Re: [Intel-gfx] [PATCH 09/10] drm/vc4: Use drm_crtc_mask()

[Eric Anholt]

Ville Syrjala  writes:

> From: Ville Syrjälä 
>
> Use drm_crtc_mask() where appropriate.

Reviewed-by: Eric Anholt 


signature.asc
Description: PGP signature
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 09/10] drm/vc4: Use drm_crtc_mask()

[Rodrigo Vivi]

On Tue, Jun 26, 2018 at 10:47:15PM +0300, Ville Syrjala wrote:
> From: Ville Syrjälä 
> 
> Use drm_crtc_mask() where appropriate.
> 
> Cc: Eric Anholt 
> Signed-off-by: Ville Syrjälä 

Reviewed-by: Rodrigo Vivi 

> ---
>  drivers/gpu/drm/vc4/vc4_crtc.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/vc4/vc4_crtc.c b/drivers/gpu/drm/vc4/vc4_crtc.c
> index dcadf793ee80..d222358fa8a7 100644
> --- a/drivers/gpu/drm/vc4/vc4_crtc.c
> +++ b/drivers/gpu/drm/vc4/vc4_crtc.c
> @@ -1081,7 +1081,7 @@ static int vc4_crtc_bind(struct device *dev, struct 
> device *master, void *data)
>   if (IS_ERR(plane))
>   continue;
>  
> - plane->possible_crtcs = 1 << drm_crtc_index(crtc);
> + plane->possible_crtcs = drm_crtc_mask(crtc);
>   }
>  
>   /* Set up the legacy cursor after overlay initialization,
> @@ -1090,7 +1090,7 @@ static int vc4_crtc_bind(struct device *dev, struct 
> device *master, void *data)
>*/
>   cursor_plane = vc4_plane_init(drm, DRM_PLANE_TYPE_CURSOR);
>   if (!IS_ERR(cursor_plane)) {
> - cursor_plane->possible_crtcs = 1 << drm_crtc_index(crtc);
> + cursor_plane->possible_crtcs = drm_crtc_mask(crtc);
>   crtc->cursor = cursor_plane;
>   }
>  
> @@ -1118,7 +1118,7 @@ static int vc4_crtc_bind(struct device *dev, struct 
> device *master, void *data)
>  err_destroy_planes:
>   list_for_each_entry_safe(destroy_plane, temp,
>>mode_config.plane_list, head) {
> - if (destroy_plane->possible_crtcs == 1 << drm_crtc_index(crtc))
> + if (destroy_plane->possible_crtcs == drm_crtc_mask(crtc))
>   destroy_plane->funcs->destroy(destroy_plane);
>   }
>  err:
> -- 
> 2.16.4
> 
> ___
> dri-devel mailing list
> dri-de...@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH 09/10] drm/vc4: Use drm_crtc_mask()

[Ville Syrjala]

From: Ville Syrjälä 

Use drm_crtc_mask() where appropriate.

Cc: Eric Anholt 
Signed-off-by: Ville Syrjälä 
---
 drivers/gpu/drm/vc4/vc4_crtc.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/vc4/vc4_crtc.c b/drivers/gpu/drm/vc4/vc4_crtc.c
index dcadf793ee80..d222358fa8a7 100644
--- a/drivers/gpu/drm/vc4/vc4_crtc.c
+++ b/drivers/gpu/drm/vc4/vc4_crtc.c
@@ -1081,7 +1081,7 @@ static int vc4_crtc_bind(struct device *dev, struct 
device *master, void *data)
if (IS_ERR(plane))
continue;
 
-   plane->possible_crtcs = 1 << drm_crtc_index(crtc);
+   plane->possible_crtcs = drm_crtc_mask(crtc);
}
 
/* Set up the legacy cursor after overlay initialization,
@@ -1090,7 +1090,7 @@ static int vc4_crtc_bind(struct device *dev, struct 
device *master, void *data)
 */
cursor_plane = vc4_plane_init(drm, DRM_PLANE_TYPE_CURSOR);
if (!IS_ERR(cursor_plane)) {
-   cursor_plane->possible_crtcs = 1 << drm_crtc_index(crtc);
+   cursor_plane->possible_crtcs = drm_crtc_mask(crtc);
crtc->cursor = cursor_plane;
}
 
@@ -1118,7 +1118,7 @@ static int vc4_crtc_bind(struct device *dev, struct 
device *master, void *data)
 err_destroy_planes:
list_for_each_entry_safe(destroy_plane, temp,
 >mode_config.plane_list, head) {
-   if (destroy_plane->possible_crtcs == 1 << drm_crtc_index(crtc))
+   if (destroy_plane->possible_crtcs == drm_crtc_mask(crtc))
destroy_plane->funcs->destroy(destroy_plane);
}
 err:
-- 
2.16.4

___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx