Re: [Intel-gfx] [PATCH 1/2] drm/i915: do runtime_get/put during display well power gate/ungate

2014-06-10 Thread Imre Deak
Hi Sagar,

On Tue, 2014-06-10 at 00:27 +0530, sagar.a.kam...@intel.com wrote:
 From: Sagar Kamble sagar.a.kam...@intel.com
 
 Display power island is on during boot, we have one count for it
 once this power gates, we do a put making sure runtime_suspend is
 called
 
 Cc: Daniel Vetter daniel.vet...@ffwll.ch (supporter:INTEL DRM DRIVERS...)
 Cc: Jani Nikula jani.nik...@linux.intel.com (supporter:INTEL DRM DRIVERS...)
 Signed-off-by: Sagar Kamble sagar.a.kam...@intel.com
 ---
  drivers/gpu/drm/i915/intel_pm.c | 6 ++
  1 file changed, 6 insertions(+)
 
 diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
 index f83d1ff..b333aae 100644
 --- a/drivers/gpu/drm/i915/intel_pm.c
 +++ b/drivers/gpu/drm/i915/intel_pm.c
 @@ -6017,6 +6017,12 @@ void __vlv_set_power_well(struct drm_i915_private 
 *dev_priv,
 state,
 vlv_punit_read(dev_priv, PUNIT_REG_PWRGT_CTRL));
  
 + if (PUNIT_POWER_WELL_DISP2D == power_well_id) {
 + if (enable)
 + intel_runtime_pm_get(dev_priv);
 + else
 + intel_runtime_pm_put(dev_priv);
 + }

The RPM refcount should already be get/put properly in
intel_display_power_get/put(), so the above doesn't seem correct to me.

With current -nightly after blanking the screen the RPM refcount does
drop to 0 for me, so I'm not sure what you're missing. One possibility
is:

# echo auto  /sys/bus/pci/devices/:00:02.0/power/control

--Imre



signature.asc
Description: This is a digitally signed message part
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx


[Intel-gfx] [PATCH 1/2] drm/i915: do runtime_get/put during display well power gate/ungate

2014-06-09 Thread sagar . a . kamble
From: Sagar Kamble sagar.a.kam...@intel.com

Display power island is on during boot, we have one count for it
once this power gates, we do a put making sure runtime_suspend is
called

Cc: Daniel Vetter daniel.vet...@ffwll.ch (supporter:INTEL DRM DRIVERS...)
Cc: Jani Nikula jani.nik...@linux.intel.com (supporter:INTEL DRM DRIVERS...)
Signed-off-by: Sagar Kamble sagar.a.kam...@intel.com
---
 drivers/gpu/drm/i915/intel_pm.c | 6 ++
 1 file changed, 6 insertions(+)

diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
index f83d1ff..b333aae 100644
--- a/drivers/gpu/drm/i915/intel_pm.c
+++ b/drivers/gpu/drm/i915/intel_pm.c
@@ -6017,6 +6017,12 @@ void __vlv_set_power_well(struct drm_i915_private 
*dev_priv,
  state,
  vlv_punit_read(dev_priv, PUNIT_REG_PWRGT_CTRL));
 
+   if (PUNIT_POWER_WELL_DISP2D == power_well_id) {
+   if (enable)
+   intel_runtime_pm_get(dev_priv);
+   else
+   intel_runtime_pm_put(dev_priv);
+   }
 #undef COND
 
 out:
-- 
1.8.5

___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx