Re: [Intel-gfx] [PATCH 1/3] drm/i915: Add ECOBITS_SNB_BIT

2013-04-09 Thread Imre Deak
On Thu, 2013-04-04 at 15:13 +0300, ville.syrj...@linux.intel.com wrote:
 From: Ville Syrjälä ville.syrj...@linux.intel.com
 
 GAC_ECO_BITS has a bit similar to GAM_ECOCHK's ECOCHK_SNB_BIT. Add
 the define, and enable it on SNB.
 
 Signed-off-by: Ville Syrjälä ville.syrj...@linux.intel.com

On the series:
Reviewed-by: Imre Deak imre.d...@intel.com

 ---
  drivers/gpu/drm/i915/i915_gem_gtt.c | 3 ++-
  drivers/gpu/drm/i915/i915_reg.h | 1 +
  2 files changed, 3 insertions(+), 1 deletion(-)
 
 diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c 
 b/drivers/gpu/drm/i915/i915_gem_gtt.c
 index 24a23b3..593137b 100644
 --- a/drivers/gpu/drm/i915/i915_gem_gtt.c
 +++ b/drivers/gpu/drm/i915/i915_gem_gtt.c
 @@ -312,7 +312,8 @@ void i915_gem_init_ppgtt(struct drm_device *dev)
   uint32_t ecochk, gab_ctl, ecobits;
  
   ecobits = I915_READ(GAC_ECO_BITS);
 - I915_WRITE(GAC_ECO_BITS, ecobits | ECOBITS_PPGTT_CACHE64B);
 + I915_WRITE(GAC_ECO_BITS, ecobits | ECOBITS_SNB_BIT |
 +  ECOBITS_PPGTT_CACHE64B);
  
   gab_ctl = I915_READ(GAB_CTL);
   I915_WRITE(GAB_CTL, gab_ctl | GAB_CTL_CONT_AFTER_PAGEFAULT);
 diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
 index 058686c..4b8fd4d 100644
 --- a/drivers/gpu/drm/i915/i915_reg.h
 +++ b/drivers/gpu/drm/i915/i915_reg.h
 @@ -127,6 +127,7 @@
  #define   ECOCHK_PPGTT_CACHE4B   (0x03)
  
  #define GAC_ECO_BITS 0x14090
 +#define   ECOBITS_SNB_BIT(113)
  #define   ECOBITS_PPGTT_CACHE64B (38)
  #define   ECOBITS_PPGTT_CACHE4B  (08)
  


___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx


[Intel-gfx] [PATCH 1/3] drm/i915: Add ECOBITS_SNB_BIT

2013-04-04 Thread ville . syrjala
From: Ville Syrjälä ville.syrj...@linux.intel.com

GAC_ECO_BITS has a bit similar to GAM_ECOCHK's ECOCHK_SNB_BIT. Add
the define, and enable it on SNB.

Signed-off-by: Ville Syrjälä ville.syrj...@linux.intel.com
---
 drivers/gpu/drm/i915/i915_gem_gtt.c | 3 ++-
 drivers/gpu/drm/i915/i915_reg.h | 1 +
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c 
b/drivers/gpu/drm/i915/i915_gem_gtt.c
index 24a23b3..593137b 100644
--- a/drivers/gpu/drm/i915/i915_gem_gtt.c
+++ b/drivers/gpu/drm/i915/i915_gem_gtt.c
@@ -312,7 +312,8 @@ void i915_gem_init_ppgtt(struct drm_device *dev)
uint32_t ecochk, gab_ctl, ecobits;
 
ecobits = I915_READ(GAC_ECO_BITS);
-   I915_WRITE(GAC_ECO_BITS, ecobits | ECOBITS_PPGTT_CACHE64B);
+   I915_WRITE(GAC_ECO_BITS, ecobits | ECOBITS_SNB_BIT |
+ECOBITS_PPGTT_CACHE64B);
 
gab_ctl = I915_READ(GAB_CTL);
I915_WRITE(GAB_CTL, gab_ctl | GAB_CTL_CONT_AFTER_PAGEFAULT);
diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
index 058686c..4b8fd4d 100644
--- a/drivers/gpu/drm/i915/i915_reg.h
+++ b/drivers/gpu/drm/i915/i915_reg.h
@@ -127,6 +127,7 @@
 #define   ECOCHK_PPGTT_CACHE4B (0x03)
 
 #define GAC_ECO_BITS   0x14090
+#define   ECOBITS_SNB_BIT  (113)
 #define   ECOBITS_PPGTT_CACHE64B   (38)
 #define   ECOBITS_PPGTT_CACHE4B(08)
 
-- 
1.8.1.5

___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx