Re: [Intel-gfx] [PATCH 1/5] drm/vmwgfx: Remove bogus crtc coords vs fb size check

[Laurent Pinchart]

Hi Ville,

Thank you for the patch.

On Wednesday, 1 November 2017 20:29:16 EET Ville Syrjala wrote:
> From: Ville Syrjälä 
> 
> Throw away the bugs crtc coords vs. fb size check. Crtc coords don't
> define the viewport inside the fb, that's a job for the src coords,
> which have been checked by the core already.
> 
> Cc: VMware Graphics 
> Cc: Sinclair Yeh 
> Cc: Thomas Hellstrom 
> Signed-off-by: Ville Syrjälä 

Reviewed-by: Laurent Pinchart 

> ---
>  drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 6 --
>  1 file changed, 6 deletions(-)
> 
> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c
> b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c index 0545740b3724..a4b56699679a
> 100644
> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c
> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c
> @@ -476,12 +476,6 @@ int vmw_du_primary_plane_atomic_check(struct drm_plane
> *plane,
> 
>   vcs = vmw_connector_state_to_vcs(du->connector.state);
> 
> - if ((dest.x2 > new_fb->width ||
> -  dest.y2 > new_fb->height)) {
> - DRM_ERROR("CRTC area outside of framebuffer\n");
> - return -EINVAL;
> - }
> -
>   /* Only one active implicit framebuffer at a time. */
>   mutex_lock(_priv->global_kms_state_mutex);
>   if (vcs->is_implicit && dev_priv->implicit_fb &&


-- 
Regards,

Laurent Pinchart

___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 1/5] drm/vmwgfx: Remove bogus crtc coords vs fb size check

[Daniel Vetter]

On Wed, Nov 01, 2017 at 08:29:16PM +0200, Ville Syrjala wrote:
> From: Ville Syrjälä 
> 
> Throw away the bugs crtc coords vs. fb size check. Crtc coords don't
> define the viewport inside the fb, that's a job for the src coords,
> which have been checked by the core already.
> 
> Cc: VMware Graphics 
> Cc: Sinclair Yeh 
> Cc: Thomas Hellstrom 
> Signed-off-by: Ville Syrjälä 

Reviewed-by: Daniel Vetter 

> ---
>  drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 6 --
>  1 file changed, 6 deletions(-)
> 
> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c 
> b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c
> index 0545740b3724..a4b56699679a 100644
> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c
> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c
> @@ -476,12 +476,6 @@ int vmw_du_primary_plane_atomic_check(struct drm_plane 
> *plane,
>  
>   vcs = vmw_connector_state_to_vcs(du->connector.state);
>  
> - if ((dest.x2 > new_fb->width ||
> -  dest.y2 > new_fb->height)) {
> - DRM_ERROR("CRTC area outside of framebuffer\n");
> - return -EINVAL;
> - }
> -
>   /* Only one active implicit framebuffer at a time. */
>   mutex_lock(_priv->global_kms_state_mutex);
>   if (vcs->is_implicit && dev_priv->implicit_fb &&
> -- 
> 2.13.6
> 
> ___
> dri-devel mailing list
> dri-de...@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH 1/5] drm/vmwgfx: Remove bogus crtc coords vs fb size check

[Ville Syrjala]

From: Ville Syrjälä 

Throw away the bugs crtc coords vs. fb size check. Crtc coords don't
define the viewport inside the fb, that's a job for the src coords,
which have been checked by the core already.

Cc: VMware Graphics 
Cc: Sinclair Yeh 
Cc: Thomas Hellstrom 
Signed-off-by: Ville Syrjälä 
---
 drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 6 --
 1 file changed, 6 deletions(-)

diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c 
b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c
index 0545740b3724..a4b56699679a 100644
--- a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c
+++ b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c
@@ -476,12 +476,6 @@ int vmw_du_primary_plane_atomic_check(struct drm_plane 
*plane,
 
vcs = vmw_connector_state_to_vcs(du->connector.state);
 
-   if ((dest.x2 > new_fb->width ||
-dest.y2 > new_fb->height)) {
-   DRM_ERROR("CRTC area outside of framebuffer\n");
-   return -EINVAL;
-   }
-
/* Only one active implicit framebuffer at a time. */
mutex_lock(_priv->global_kms_state_mutex);
if (vcs->is_implicit && dev_priv->implicit_fb &&
-- 
2.13.6

___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx