Re: [Intel-gfx] [PATCH 2/2] drm/i915/ddi: Add missing wait-for-active for HDMI aligning with bspec updates

[Imre Deak]

On Sun, Nov 27, 2022 at 10:52:32AM +0530, Ankit Nautiyal wrote:
> After enabling DDI_BUF_CTL, wait for DDI_BUF_CTL to be active.
> Bspec:4232,53339,49191,54145
> 
> Signed-off-by: Ankit Nautiyal 

Looks ok to me. On the series:

Reviewed-by: Imre Deak 

> ---
>  drivers/gpu/drm/i915/display/intel_ddi.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c 
> b/drivers/gpu/drm/i915/display/intel_ddi.c
> index 9e16db920bf2..13bf0142627b 100644
> --- a/drivers/gpu/drm/i915/display/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/display/intel_ddi.c
> @@ -2944,6 +2944,8 @@ static void intel_enable_ddi_hdmi(struct 
> intel_atomic_state *state,
>   }
>   intel_de_write(dev_priv, DDI_BUF_CTL(port), buf_ctl);
>  
> + intel_wait_ddi_buf_active(dev_priv, port);
> +
>   intel_audio_codec_enable(encoder, crtc_state, conn_state);
>  }
>  
> -- 
> 2.25.1
> 

[Intel-gfx] [PATCH 2/2] drm/i915/ddi: Add missing wait-for-active for HDMI aligning with bspec updates

[Ankit Nautiyal]

After enabling DDI_BUF_CTL, wait for DDI_BUF_CTL to be active.
Bspec:4232,53339,49191,54145

Signed-off-by: Ankit Nautiyal 
---
 drivers/gpu/drm/i915/display/intel_ddi.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c 
b/drivers/gpu/drm/i915/display/intel_ddi.c
index 9e16db920bf2..13bf0142627b 100644
--- a/drivers/gpu/drm/i915/display/intel_ddi.c
+++ b/drivers/gpu/drm/i915/display/intel_ddi.c
@@ -2944,6 +2944,8 @@ static void intel_enable_ddi_hdmi(struct 
intel_atomic_state *state,
}
intel_de_write(dev_priv, DDI_BUF_CTL(port), buf_ctl);
 
+   intel_wait_ddi_buf_active(dev_priv, port);
+
intel_audio_codec_enable(encoder, crtc_state, conn_state);
 }
 
-- 
2.25.1