Re: [Intel-gfx] [PATCH 2/2] drm/i915: re-enable rc6 by default
On Mon, Nov 14, 2011 at 21:39, Eugeni Dodonov eugeni.dodo...@intel.com wrote: Most of the rc6-related hangs and major issues were addressed for the past months. Let's re-enable it by default to provide a more wider testing, and catch the remaining problems. According to tests, enablement of rc6 results in up to +50% improvements in power usage and battery life, so it certainly would be a nice feature to have enabled by default. Also, most of the issues related to rc6 seem to came from VTd, so if you are experiencing any problems with it, try disabling VTd in bios or using intel_iommu=off kernel parameter to investigate whether it solves the issue. Acked-by: Keith Packard kei...@keithp.com CC: Daniel Vetter daniel.vet...@ffwll.ch CC: Jesse Barnes jbar...@virtuousgeek.org Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=38567 Signed-off-by: Eugeni Dodonov eugeni.dodo...@intel.com Iirc the same applies to rc6 as to semaphores. We have bug reports that it causes hard-hangs in combination with DMAR. I haven't yet gotten around to poking the relevant reporters whether ppgtt changes anything, because internet access here at the Intel Poland site sucks. So again I think we need to disable this on snb when DMAR is on. -Daniel -- Daniel Vetter daniel.vet...@ffwll.ch - +41 (0) 79 365 57 48 - http://blog.ffwll.ch ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH 2/2] drm/i915: re-enable rc6 by default
On Wed, Nov 16, 2011 at 16:59, Andrew Lutomirski a...@luto.us wrote: On Nov 16, 2011 7:54 AM, Daniel Vetter daniel.vet...@ffwll.ch wrote: On Mon, Nov 14, 2011 at 21:39, Eugeni Dodonov eugeni.dodo...@intel.com wrote: Most of the rc6-related hangs and major issues were addressed for the past months. Let's re-enable it by default to provide a more wider testing, and catch the remaining problems. According to tests, enablement of rc6 results in up to +50% improvements in power usage and battery life, so it certainly would be a nice feature to have enabled by default. Also, most of the issues related to rc6 seem to came from VTd, so if you are experiencing any problems with it, try disabling VTd in bios or using intel_iommu=off kernel parameter to investigate whether it solves the issue. Acked-by: Keith Packard kei...@keithp.com CC: Daniel Vetter daniel.vet...@ffwll.ch CC: Jesse Barnes jbar...@virtuousgeek.org Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=38567 Signed-off-by: Eugeni Dodonov eugeni.dodo...@intel.com Iirc the same applies to rc6 as to semaphores. We have bug reports that it causes hard-hangs in combination with DMAR. I haven't yet gotten around to poking the relevant reporters whether ppgtt changes anything, because internet access here at the Intel Poland site sucks. So again I think we need to disable this on snb when DMAR is on. I can reproduce the semaphore hang easily. Where are the ppgtt patches/settings to play with? FWIW, rc6 is a *huge* win on my SNB laptop, and the laptop has always been rock-solid with any set of options. Maybe this is only an issue on desktop parts, and the 5W difference is a bigger deal on laptops anyway. Grab the ppgtt branch from my fdo repo: http://cgit.freedesktop.org/~danvet/drm/ Note that this branch will only work on snb/ivb and that resume is broken. Also, after the first gpu reset ppgtt will get disabled and hence your machine might die rather quickly. So perhaps boot with i915.reset=0 to prevent that. Testing feedback highly welcome. Yours, Daniel -- Daniel Vetter daniel.vet...@ffwll.ch - +41 (0) 79 365 57 48 - http://blog.ffwll.ch ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH 2/2] drm/i915: re-enable rc6 by default
On Mon, 14 Nov 2011 18:39:15 -0200 Eugeni Dodonov eugeni.dodo...@intel.com wrote: Most of the rc6-related hangs and major issues were addressed for the past months. Let's re-enable it by default to provide a more wider testing, and catch the remaining problems. According to tests, enablement of rc6 results in up to +50% improvements in power usage and battery life, so it certainly would be a nice feature to have enabled by default. Also, most of the issues related to rc6 seem to came from VTd, so if you are experiencing any problems with it, try disabling VTd in bios or using intel_iommu=off kernel parameter to investigate whether it solves the issue. Yes please. Acked-by: Jesse Barnes jbar...@virtuousgeek.org -- Jesse Barnes, Intel Open Source Technology Center signature.asc Description: PGP signature ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH 2/2] drm/i915: re-enable rc6 by default
Hi, On Mon, Nov 14, 2011 at 06:39:15PM -0200, Eugeni Dodonov wrote: Most of the rc6-related hangs and major issues were addressed for the past months. which commits should I try to check whether rc6 issue is gone? As of 3.1 kernel, I'm still getting huge screen corruption. -- Lukáš Hejtmánek ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH 2/2] drm/i915: re-enable rc6 by default
2011/11/14 Lukas Hejtmanek xhejt...@ics.muni.cz Hi, On Mon, Nov 14, 2011 at 06:39:15PM -0200, Eugeni Dodonov wrote: Most of the rc6-related hangs and major issues were addressed for the past months. which commits should I try to check whether rc6 issue is gone? As of 3.1 kernel, I'm still getting huge screen corruption. The rc6 issue which are gone are the ones which was causing hard system hangs and gpu hangs. Corruptions are still out there, if they don't go away when using intel_iommu=off then we'll have to investigate them more in-depth. I am unable to reproduce any rc6-related corruptions on my machine(s) though. So it looks like this is yet another case in which we'll need to use Sherlock Holmes methods to get to them... -- Eugeni Dodonov http://eugeni.dodonov.net/ ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH 2/2] drm/i915: re-enable rc6 by default
2011/11/14 Lukas Hejtmanek xhejt...@ics.muni.cz I am unable to reproduce any rc6-related corruptions on my machine(s) though. So it looks like this is yet another case in which we'll need to use Sherlock Holmes methods to get to them... are you using SNA? I do on my SNB system. Are the issues SNA-specific, or they happen with UXA as well? I do use both SNA and UXA actually (thanks to http://cgit.freedesktop.org/~eugeni/xf86-video-intel/ :)). -- Eugeni Dodonov http://eugeni.dodonov.net/ ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH 2/2] drm/i915: re-enable rc6 by default
On Mon, Nov 14, 2011 at 09:04:37PM -0200, Eugeni Dodonov wrote: The rc6 issue which are gone are the ones which was causing hard system hangs and gpu hangs. Corruptions are still out there, if they don't go away when using intel_iommu=off then we'll have to investigate them more in-depth. I disabled iommu in BIOS, so I guess it is not an issue here. I am unable to reproduce any rc6-related corruptions on my machine(s) though. So it looks like this is yet another case in which we'll need to use Sherlock Holmes methods to get to them... are you using SNA? I do on my SNB system. -- Lukáš Hejtmánek ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH 2/2] drm/i915: re-enable rc6 by default
On Mon, Nov 14, 2011 at 09:17:39PM -0200, Eugeni Dodonov wrote: Are the issues SNA-specific, or they happen with UXA as well? I do use both SNA and UXA actually (thanks to http://cgit.freedesktop.org/~eugeni/xf86-video-intel/ :)). I believe they happen with both but with SNA I got regular corruption while with UXA I got accidental corruption. I.e., with SNA I got corrupted window in few minutes, with UXA maybe one corruption per few hours. But I did not try those Eric's gating patches with UXA. I got also X server segfaults related to XV video (moving window, resing window with video crashes the X server randomly). Didn't investigate this (getting core file, e.g.) I have X server 1.10, I think there are some fixes around 1.12. -- Lukáš Hejtmánek ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
