Re: [Intel-gfx] [PATCH 2/7] drm/tegra: allow compile test on !ARM

2023-03-16 Thread kernel test robot
Hi Christian,

I love your patch! Yet something to improve:

[auto build test ERROR on drm-misc/drm-misc-next]
[cannot apply to drm-tip/drm-tip]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:
https://github.com/intel-lab-lkp/linux/commits/Christian-K-nig/drm-tegra-allow-compile-test-on-ARM/20230316-172205
base:   git://anongit.freedesktop.org/drm/drm-misc drm-misc-next
patch link:
https://lore.kernel.org/r/20230316082035.567520-3-christian.koenig%40amd.com
patch subject: [Intel-gfx] [PATCH 2/7] drm/tegra: allow compile test on !ARM
config: mips-allmodconfig 
(https://download.01.org/0day-ci/archive/20230317/202303170635.a2rsq1wu-...@intel.com/config)
compiler: mips-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
wget 
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O 
~/bin/make.cross
chmod +x ~/bin/make.cross
# 
https://github.com/intel-lab-lkp/linux/commit/8a2dbd34b0290b78a1ac2252d451abbcbcd50666
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review 
Christian-K-nig/drm-tegra-allow-compile-test-on-ARM/20230316-172205
git checkout 8a2dbd34b0290b78a1ac2252d451abbcbcd50666
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 
O=build_dir ARCH=mips olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 
O=build_dir ARCH=mips SHELL=/bin/bash drivers/gpu/drm/tegra/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot 
| Link: 
https://lore.kernel.org/oe-kbuild-all/202303170635.a2rsq1wu-...@intel.com/

All errors (new ones prefixed by >>):

   drivers/gpu/drm/tegra/gem.c: In function 'tegra_bo_mmap':
>> drivers/gpu/drm/tegra/gem.c:188:24: error: implicit declaration of function 
>> 'vmap'; did you mean 'kmap'? [-Werror=implicit-function-declaration]
 188 | return vmap(obj->pages, obj->num_pages, VM_MAP,
 |^~~~
 |kmap
>> drivers/gpu/drm/tegra/gem.c:188:57: error: 'VM_MAP' undeclared (first use in 
>> this function); did you mean 'VM_MTE'?
 188 | return vmap(obj->pages, obj->num_pages, VM_MAP,
 | ^~
 | VM_MTE
   drivers/gpu/drm/tegra/gem.c:188:57: note: each undeclared identifier is 
reported only once for each function it appears in
   drivers/gpu/drm/tegra/gem.c: In function 'tegra_bo_munmap':
>> drivers/gpu/drm/tegra/gem.c:203:17: error: implicit declaration of function 
>> 'vunmap'; did you mean 'kunmap'? [-Werror=implicit-function-declaration]
 203 | vunmap(addr);
 | ^~
 | kunmap
   drivers/gpu/drm/tegra/gem.c: In function 'tegra_bo_mmap':
   drivers/gpu/drm/tegra/gem.c:191:1: error: control reaches end of non-void 
function [-Werror=return-type]
 191 | }
 | ^
   cc1: some warnings being treated as errors
--
   drivers/gpu/drm/tegra/fb.c: In function 'tegra_fbdev_probe':
>> drivers/gpu/drm/tegra/fb.c:276:29: error: implicit declaration of function 
>> 'vmap'; did you mean 'kmap'? [-Werror=implicit-function-declaration]
 276 | bo->vaddr = vmap(bo->pages, bo->num_pages, VM_MAP,
 | ^~~~
 | kmap
>> drivers/gpu/drm/tegra/fb.c:276:60: error: 'VM_MAP' undeclared (first use in 
>> this function); did you mean 'VM_MTE'?
 276 | bo->vaddr = vmap(bo->pages, bo->num_pages, VM_MAP,
 |^~
 |VM_MTE
   drivers/gpu/drm/tegra/fb.c:276:60: note: each undeclared identifier is 
reported only once for each function it appears in
   drivers/gpu/drm/tegra/fb.c: In function 'tegra_fbdev_exit':
>> drivers/gpu/drm/tegra/fb.c:359:25: error: implicit declaration of function 
>> 'vunmap'; did you mean 'kunmap'? [-Werror=implicit-function-declaration]
 359 | vunmap(bo->vaddr);
 | ^~
 | kunmap
   cc1: some warnings being treated as errors


vim +188 drivers/gpu/drm/tegra/gem.c

de2ba664c30fcdb drivers/gpu/h

[Intel-gfx] [PATCH 2/7] drm/tegra: allow compile test on !ARM

2023-03-16 Thread Christian König
This compile tests on x86 just perfectly fine.

Signed-off-by: Christian König 
CC: Thierry Reding 
CC: Jonathan Hunter 
CC: linux-te...@vger.kernel.org
---
 drivers/gpu/drm/tegra/Kconfig | 2 +-
 drivers/gpu/host1x/Kconfig| 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/tegra/Kconfig b/drivers/gpu/drm/tegra/Kconfig
index c36323f1c7e6..56453ca277c2 100644
--- a/drivers/gpu/drm/tegra/Kconfig
+++ b/drivers/gpu/drm/tegra/Kconfig
@@ -1,7 +1,7 @@
 # SPDX-License-Identifier: GPL-2.0-only
 config DRM_TEGRA
tristate "NVIDIA Tegra DRM"
-   depends on ARCH_TEGRA || (ARM && COMPILE_TEST)
+   depends on ARCH_TEGRA || COMPILE_TEST
depends on COMMON_CLK
depends on DRM
depends on OF
diff --git a/drivers/gpu/host1x/Kconfig b/drivers/gpu/host1x/Kconfig
index 1861a8180d3f..e6c78ae2003a 100644
--- a/drivers/gpu/host1x/Kconfig
+++ b/drivers/gpu/host1x/Kconfig
@@ -5,7 +5,7 @@ config TEGRA_HOST1X_CONTEXT_BUS
 
 config TEGRA_HOST1X
tristate "NVIDIA Tegra host1x driver"
-   depends on ARCH_TEGRA || (ARM && COMPILE_TEST)
+   depends on ARCH_TEGRA || COMPILE_TEST
select DMA_SHARED_BUFFER
select TEGRA_HOST1X_CONTEXT_BUS
select IOMMU_IOVA
-- 
2.34.1