Re: [Intel-gfx] [PATCH 3/3] drm/i915/gvt: Return -EIO if host GuC submission is enabled when loading GVT-g

2017-05-26 Thread Chris Wilson
On Fri, May 26, 2017 at 11:04:19AM +0800, Chuanxiao Dong wrote:
> Currently GVT-g cannot work properly when host GuC submission is
> enabled, so make i915 driver loading failed in this case.
> 
> Suggested-by: Joonas Lahtinen 
> Suggested-by: Chris Wilson 
> Cc: Joonas Lahtinen 
> Cc: Chris Wilson 
> Cc: Zhenyu Wang 
> Signed-off-by: Chuanxiao Dong 
> ---
>  drivers/gpu/drm/i915/intel_gvt.c | 5 +
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/intel_gvt.c 
> b/drivers/gpu/drm/i915/intel_gvt.c
> index c90d476..63bff89 100644
> --- a/drivers/gpu/drm/i915/intel_gvt.c
> +++ b/drivers/gpu/drm/i915/intel_gvt.c
> @@ -100,6 +100,11 @@ int intel_gvt_init(struct drm_i915_private *dev_priv)
>   return -EIO;
>   }
>  
> + if (i915.enable_guc_submission) {
> + DRM_INFO("Graphics virtualization is not yet supported with GuC 
> submission");
> + return -EIO;
> + }

Again, this is an actual DRM_ERROR as it is fatal.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx


[Intel-gfx] [PATCH 3/3] drm/i915/gvt: Return -EIO if host GuC submission is enabled when loading GVT-g

2017-05-25 Thread Chuanxiao Dong
Currently GVT-g cannot work properly when host GuC submission is
enabled, so make i915 driver loading failed in this case.

Suggested-by: Joonas Lahtinen 
Suggested-by: Chris Wilson 
Cc: Joonas Lahtinen 
Cc: Chris Wilson 
Cc: Zhenyu Wang 
Signed-off-by: Chuanxiao Dong 
---
 drivers/gpu/drm/i915/intel_gvt.c | 5 +
 1 file changed, 5 insertions(+)

diff --git a/drivers/gpu/drm/i915/intel_gvt.c b/drivers/gpu/drm/i915/intel_gvt.c
index c90d476..63bff89 100644
--- a/drivers/gpu/drm/i915/intel_gvt.c
+++ b/drivers/gpu/drm/i915/intel_gvt.c
@@ -100,6 +100,11 @@ int intel_gvt_init(struct drm_i915_private *dev_priv)
return -EIO;
}
 
+   if (i915.enable_guc_submission) {
+   DRM_INFO("Graphics virtualization is not yet supported with GuC 
submission");
+   return -EIO;
+   }
+
/*
 * We're not in host or fail to find a MPT module, disable GVT-g
 */
-- 
2.7.4

___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx