Re: [Intel-gfx] [PATCH 3/3] drm/i915: Add max DOT clock frequency to debugfs

[Mika Kahola]

On Thu, 2015-09-24 at 23:49 +0300, Ville Syrjälä wrote:
> On Thu, Sep 24, 2015 at 02:28:41PM +0300, Mika Kahola wrote:
> > Information on maximum supported pixel clock frequency to
> > i915_frequency_info.
> > 
> > Signed-off-by: Mika Kahola 
> > ---
> >  drivers/gpu/drm/i915/i915_debugfs.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/gpu/drm/i915/i915_debugfs.c 
> > b/drivers/gpu/drm/i915/i915_debugfs.c
> > index 6882455..b418d9b 100644
> > --- a/drivers/gpu/drm/i915/i915_debugfs.c
> > +++ b/drivers/gpu/drm/i915/i915_debugfs.c
> > @@ -1311,6 +1311,7 @@ static int i915_frequency_info(struct seq_file *m, 
> > void *unused)
> >  
> > seq_printf(m, "Current CD clock freq: %dkHz\n", dev_priv->cdclk_freq);
> > seq_printf(m, "Max CD clock freq: %dkHz\n", dev_priv->max_cdclk_freq);
> > +   seq_printf(m, "Max pixel clock freq: %dkHz\n", 
> > dev_priv->max_dotclk_freq);
> 
> I would put a space between the number and units.
> 
> The rest of the stuff in there is about the gt stuff, so not sure if
> this is the best place for it. But if no one else objects, I won't either.
> 
> Could probably squash all three patches into just one, since they're all
> doing the same thing anyway.
> 
> With that these are:
> Reviewed-by: Ville Syrjälä 
> 
Thanks! These patches are leftovers from the CD clock and mode validity
patch series. I'll combine all these three patches to one patch.

-Mika-

> >  
> >  out:
> > intel_runtime_pm_put(dev_priv);
> > -- 
> > 1.9.1
> > 
> > ___
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/intel-gfx
> 


___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH 3/3] drm/i915: Add max DOT clock frequency to debugfs

[Mika Kahola]

Information on maximum supported pixel clock frequency to
i915_frequency_info.

Signed-off-by: Mika Kahola 
---
 drivers/gpu/drm/i915/i915_debugfs.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/i915/i915_debugfs.c 
b/drivers/gpu/drm/i915/i915_debugfs.c
index 6882455..b418d9b 100644
--- a/drivers/gpu/drm/i915/i915_debugfs.c
+++ b/drivers/gpu/drm/i915/i915_debugfs.c
@@ -1311,6 +1311,7 @@ static int i915_frequency_info(struct seq_file *m, void 
*unused)
 
seq_printf(m, "Current CD clock freq: %dkHz\n", dev_priv->cdclk_freq);
seq_printf(m, "Max CD clock freq: %dkHz\n", dev_priv->max_cdclk_freq);
+   seq_printf(m, "Max pixel clock freq: %dkHz\n", 
dev_priv->max_dotclk_freq);
 
 out:
intel_runtime_pm_put(dev_priv);
-- 
1.9.1

___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Add max DOT clock frequency to debugfs

[Ville Syrjälä]

On Thu, Sep 24, 2015 at 02:28:41PM +0300, Mika Kahola wrote:
> Information on maximum supported pixel clock frequency to
> i915_frequency_info.
> 
> Signed-off-by: Mika Kahola 
> ---
>  drivers/gpu/drm/i915/i915_debugfs.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/i915/i915_debugfs.c 
> b/drivers/gpu/drm/i915/i915_debugfs.c
> index 6882455..b418d9b 100644
> --- a/drivers/gpu/drm/i915/i915_debugfs.c
> +++ b/drivers/gpu/drm/i915/i915_debugfs.c
> @@ -1311,6 +1311,7 @@ static int i915_frequency_info(struct seq_file *m, void 
> *unused)
>  
>   seq_printf(m, "Current CD clock freq: %dkHz\n", dev_priv->cdclk_freq);
>   seq_printf(m, "Max CD clock freq: %dkHz\n", dev_priv->max_cdclk_freq);
> + seq_printf(m, "Max pixel clock freq: %dkHz\n", 
> dev_priv->max_dotclk_freq);

I would put a space between the number and units.

The rest of the stuff in there is about the gt stuff, so not sure if
this is the best place for it. But if no one else objects, I won't either.

Could probably squash all three patches into just one, since they're all
doing the same thing anyway.

With that these are:
Reviewed-by: Ville Syrjälä 

>  
>  out:
>   intel_runtime_pm_put(dev_priv);
> -- 
> 1.9.1
> 
> ___
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Ville Syrjälä
Intel OTC
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx