Re: [Intel-gfx] [PATCH 3/4] drm/i915: drop runtime PM get/put pair around DP detect

2014-07-14 Thread Paulo Zanoni
2014-06-20 13:29 GMT-03:00 Jesse Barnes jbar...@virtuousgeek.org:
 We're taking the right power well refs now, so this shouldn't be needed.

 Reported-by: Imre Deak imre.d...@intel.com
 Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org

I submitted the exact same patch back in April, and got a review
comment: http://patchwork.freedesktop.org/patch/24645/

Then I sent a new version with the review comment applied:
http://patchwork.freedesktop.org/patch/24769/

It even has a R-B tag, it's just waiting to be merged :)

 ---
  drivers/gpu/drm/i915/intel_dp.c | 4 
  1 file changed, 4 deletions(-)

 diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
 index 912e9c4..ed6f00c 100644
 --- a/drivers/gpu/drm/i915/intel_dp.c
 +++ b/drivers/gpu/drm/i915/intel_dp.c
 @@ -3596,8 +3596,6 @@ intel_dp_detect(struct drm_connector *connector, bool 
 force)
 enum intel_display_power_domain power_domain;
 struct edid *edid = NULL;

 -   intel_runtime_pm_get(dev_priv);
 -
 power_domain = intel_display_port_power_domain(intel_encoder);
 intel_display_power_get(dev_priv, power_domain);

 @@ -3633,8 +3631,6 @@ intel_dp_detect(struct drm_connector *connector, bool 
 force)
  out:
 intel_display_power_put(dev_priv, power_domain);

 -   intel_runtime_pm_put(dev_priv);
 -
 return status;
  }

 --
 1.8.3.2

 ___
 Intel-gfx mailing list
 Intel-gfx@lists.freedesktop.org
 http://lists.freedesktop.org/mailman/listinfo/intel-gfx



-- 
Paulo Zanoni
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx


[Intel-gfx] [PATCH 3/4] drm/i915: drop runtime PM get/put pair around DP detect

2014-06-20 Thread Jesse Barnes
We're taking the right power well refs now, so this shouldn't be needed.

Reported-by: Imre Deak imre.d...@intel.com
Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org
---
 drivers/gpu/drm/i915/intel_dp.c | 4 
 1 file changed, 4 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
index 912e9c4..ed6f00c 100644
--- a/drivers/gpu/drm/i915/intel_dp.c
+++ b/drivers/gpu/drm/i915/intel_dp.c
@@ -3596,8 +3596,6 @@ intel_dp_detect(struct drm_connector *connector, bool 
force)
enum intel_display_power_domain power_domain;
struct edid *edid = NULL;
 
-   intel_runtime_pm_get(dev_priv);
-
power_domain = intel_display_port_power_domain(intel_encoder);
intel_display_power_get(dev_priv, power_domain);
 
@@ -3633,8 +3631,6 @@ intel_dp_detect(struct drm_connector *connector, bool 
force)
 out:
intel_display_power_put(dev_priv, power_domain);
 
-   intel_runtime_pm_put(dev_priv);
-
return status;
 }
 
-- 
1.8.3.2

___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx