Re: [Intel-gfx] [PATCH 3/5] drm/i915/fixed: simplify FP_16_16_MAX definition

2018-11-20 Thread Jani Nikula 
On Fri, 16 Nov 2018, Chris Wilson  wrote:
> Quoting Jani Nikula (2018-11-15 12:01:24)
>> No need to use a compound statement enclosed in parenthesis where a C99
>> compound literal will do. No functional changes.
>> 
>> Signed-off-by: Jani Nikula 
>> ---
>>  drivers/gpu/drm/i915/i915_fixed.h | 6 +-
>>  1 file changed, 1 insertion(+), 5 deletions(-)
>> 
>> diff --git a/drivers/gpu/drm/i915/i915_fixed.h 
>> b/drivers/gpu/drm/i915/i915_fixed.h
>> index 08316e50167a..927c59395569 100644
>> --- a/drivers/gpu/drm/i915/i915_fixed.h
>> +++ b/drivers/gpu/drm/i915/i915_fixed.h
>> @@ -7,11 +7,7 @@ typedef struct {
>> u32 val;
>>  } uint_fixed_16_16_t;
>>  
>> -#define FP_16_16_MAX ({ \
>> -   uint_fixed_16_16_t fp; \
>> -   fp.val = UINT_MAX; \
>> -   fp; \
>> -})
>> +#define FP_16_16_MAX ((uint_fixed_16_16_t){ .val = UINT_MAX })
>
> Following the standard set by pgprot_t
>
> #define u16_16(x) ((u16_16_t){ .val = (x) })
> #define U16_16_MAX u16_16(U32_MAX)

I left that for follow-up, and pushed v2 of the series.

I think the uint_fixed_16_16_t type name is a bit unwieldy, should we
rename that while at it...

BR,
Jani.


-- 
Jani Nikula, Intel Open Source Graphics Center
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 3/5] drm/i915/fixed: simplify FP_16_16_MAX definition

2018-11-16 Thread Jani Nikula 
On Fri, 16 Nov 2018, Joonas Lahtinen  wrote:
> Quoting Jani Nikula (2018-11-15 14:01:24)
>> No need to use a compound statement enclosed in parenthesis where a C99
>> compound literal will do. No functional changes.
>> 
>> Signed-off-by: Jani Nikula 
>
> Out of curiosity, did this have an effect on asm generation?
> Presumably not.

For some reason it caused tons of label etc. changes so it was hard to
check, but I didn't spot any functional asm changes.

BR,
Jani.



>
> Reviewed-by: Joonas Lahtinen 
>
> Regards, Joonas

-- 
Jani Nikula, Intel Open Source Graphics Center
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 3/5] drm/i915/fixed: simplify FP_16_16_MAX definition

2018-11-16 Thread Chris Wilson 
Quoting Jani Nikula (2018-11-15 12:01:24)
> No need to use a compound statement enclosed in parenthesis where a C99
> compound literal will do. No functional changes.
> 
> Signed-off-by: Jani Nikula 
> ---
>  drivers/gpu/drm/i915/i915_fixed.h | 6 +-
>  1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_fixed.h 
> b/drivers/gpu/drm/i915/i915_fixed.h
> index 08316e50167a..927c59395569 100644
> --- a/drivers/gpu/drm/i915/i915_fixed.h
> +++ b/drivers/gpu/drm/i915/i915_fixed.h
> @@ -7,11 +7,7 @@ typedef struct {
> u32 val;
>  } uint_fixed_16_16_t;
>  
> -#define FP_16_16_MAX ({ \
> -   uint_fixed_16_16_t fp; \
> -   fp.val = UINT_MAX; \
> -   fp; \
> -})
> +#define FP_16_16_MAX ((uint_fixed_16_16_t){ .val = UINT_MAX })

Following the standard set by pgprot_t

#define u16_16(x) ((u16_16_t){ .val = (x) })
#define U16_16_MAX u16_16(U32_MAX)
-Chris
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 3/5] drm/i915/fixed: simplify FP_16_16_MAX definition

2018-11-16 Thread Joonas Lahtinen 
Quoting Jani Nikula (2018-11-15 14:01:24)
> No need to use a compound statement enclosed in parenthesis where a C99
> compound literal will do. No functional changes.
> 
> Signed-off-by: Jani Nikula 

Out of curiosity, did this have an effect on asm generation?
Presumably not.

Reviewed-by: Joonas Lahtinen 

Regards, Joonas
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH 3/5] drm/i915/fixed: simplify FP_16_16_MAX definition

2018-11-15 Thread Jani Nikula 
No need to use a compound statement enclosed in parenthesis where a C99
compound literal will do. No functional changes.

Signed-off-by: Jani Nikula 
---
 drivers/gpu/drm/i915/i915_fixed.h | 6 +-
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/i915/i915_fixed.h 
b/drivers/gpu/drm/i915/i915_fixed.h
index 08316e50167a..927c59395569 100644
--- a/drivers/gpu/drm/i915/i915_fixed.h
+++ b/drivers/gpu/drm/i915/i915_fixed.h
@@ -7,11 +7,7 @@ typedef struct {
u32 val;
 } uint_fixed_16_16_t;
 
-#define FP_16_16_MAX ({ \
-   uint_fixed_16_16_t fp; \
-   fp.val = UINT_MAX; \
-   fp; \
-})
+#define FP_16_16_MAX ((uint_fixed_16_16_t){ .val = UINT_MAX })
 
 static inline bool is_fixed16_zero(uint_fixed_16_16_t val)
 {
-- 
2.11.0

___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx