Re: [Intel-gfx] [PATCH 4/7] drm/i915: Helper function to determine GGTT view from plane state

2015-03-23 Thread Joonas Lahtinen 
On ma, 2015-03-23 at 11:10 +, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin 
> 
> For now only default implementation defaulting to normal view.
> 
> v2: Some code review cleanups. (Joonas Lahtinen)
> 
> Signed-off-by: Tvrtko Ursulin 
Reviewed-by: Joonas Lahtinen  (v2)
> ---
>  drivers/gpu/drm/i915/intel_display.c | 25 ++---
>  1 file changed, 22 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_display.c 
> b/drivers/gpu/drm/i915/intel_display.c
> index 4d8a397..d3fa09b 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -2288,6 +2288,15 @@ intel_fb_align_height(struct drm_device *dev, unsigned 
> int height,
>  fb_format_modifier));
>  }
>  
> +static int
> +intel_fill_fb_ggtt_view(struct i915_ggtt_view *view, struct drm_framebuffer 
> *fb,
> + const struct drm_plane_state *plane_state)
> +{
> + *view = i915_ggtt_view_normal;
> +
> + return 0;
> +}
> +
>  int
>  intel_pin_and_fence_fb_obj(struct drm_plane *plane,
>  struct drm_framebuffer *fb,
> @@ -2297,6 +2306,7 @@ intel_pin_and_fence_fb_obj(struct drm_plane *plane,
>   struct drm_device *dev = fb->dev;
>   struct drm_i915_private *dev_priv = dev->dev_private;
>   struct drm_i915_gem_object *obj = intel_fb_obj(fb);
> + struct i915_ggtt_view view;
>   u32 alignment;
>   int ret;
>  
> @@ -2333,6 +2343,10 @@ intel_pin_and_fence_fb_obj(struct drm_plane *plane,
>   return -EINVAL;
>   }
>  
> + ret = intel_fill_fb_ggtt_view(&view, fb, plane_state);
> + if (ret)
> + return ret;
> +
>   /* Note that the w/a also requires 64 PTE of padding following the
>* bo. We currently fill all unused PTE with the shadow page and so
>* we should always have valid PTE following the scanout preventing
> @@ -2352,7 +2366,7 @@ intel_pin_and_fence_fb_obj(struct drm_plane *plane,
>  
>   dev_priv->mm.interruptible = false;
>   ret = i915_gem_object_pin_to_display_plane(obj, alignment, pipelined,
> -&i915_ggtt_view_normal);
> +&view);
>   if (ret)
>   goto err_interruptible;
>  
> @@ -2372,7 +2386,7 @@ intel_pin_and_fence_fb_obj(struct drm_plane *plane,
>   return 0;
>  
>  err_unpin:
> - i915_gem_object_unpin_from_display_plane(obj, &i915_ggtt_view_normal);
> + i915_gem_object_unpin_from_display_plane(obj, &view);
>  err_interruptible:
>   dev_priv->mm.interruptible = true;
>   intel_runtime_pm_put(dev_priv);
> @@ -2383,11 +2397,16 @@ static void intel_unpin_fb_obj(struct drm_framebuffer 
> *fb,
>  const struct drm_plane_state *plane_state)
>  {
>   struct drm_i915_gem_object *obj = intel_fb_obj(fb);
> + struct i915_ggtt_view view;
> + int ret;
>  
>   WARN_ON(!mutex_is_locked(&obj->base.dev->struct_mutex));
>  
> + ret = intel_fill_fb_ggtt_view(&view, fb, plane_state);
> + WARN_ONCE(ret, "Couldn't get view from plane state!");
> +
>   i915_gem_object_unpin_fence(obj);
> - i915_gem_object_unpin_from_display_plane(obj, &i915_ggtt_view_normal);
> + i915_gem_object_unpin_from_display_plane(obj, &view);
>  }
>  
>  /* Computes the linear offset to the base tile and adjusts x, y. bytes per 
> pixel


___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH 4/7] drm/i915: Helper function to determine GGTT view from plane state

2015-03-23 Thread Tvrtko Ursulin 
From: Tvrtko Ursulin 

For now only default implementation defaulting to normal view.

v2: Some code review cleanups. (Joonas Lahtinen)

Signed-off-by: Tvrtko Ursulin 
---
 drivers/gpu/drm/i915/intel_display.c | 25 ++---
 1 file changed, 22 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_display.c 
b/drivers/gpu/drm/i915/intel_display.c
index 4d8a397..d3fa09b 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -2288,6 +2288,15 @@ intel_fb_align_height(struct drm_device *dev, unsigned 
int height,
   fb_format_modifier));
 }
 
+static int
+intel_fill_fb_ggtt_view(struct i915_ggtt_view *view, struct drm_framebuffer 
*fb,
+   const struct drm_plane_state *plane_state)
+{
+   *view = i915_ggtt_view_normal;
+
+   return 0;
+}
+
 int
 intel_pin_and_fence_fb_obj(struct drm_plane *plane,
   struct drm_framebuffer *fb,
@@ -2297,6 +2306,7 @@ intel_pin_and_fence_fb_obj(struct drm_plane *plane,
struct drm_device *dev = fb->dev;
struct drm_i915_private *dev_priv = dev->dev_private;
struct drm_i915_gem_object *obj = intel_fb_obj(fb);
+   struct i915_ggtt_view view;
u32 alignment;
int ret;
 
@@ -2333,6 +2343,10 @@ intel_pin_and_fence_fb_obj(struct drm_plane *plane,
return -EINVAL;
}
 
+   ret = intel_fill_fb_ggtt_view(&view, fb, plane_state);
+   if (ret)
+   return ret;
+
/* Note that the w/a also requires 64 PTE of padding following the
 * bo. We currently fill all unused PTE with the shadow page and so
 * we should always have valid PTE following the scanout preventing
@@ -2352,7 +2366,7 @@ intel_pin_and_fence_fb_obj(struct drm_plane *plane,
 
dev_priv->mm.interruptible = false;
ret = i915_gem_object_pin_to_display_plane(obj, alignment, pipelined,
-  &i915_ggtt_view_normal);
+  &view);
if (ret)
goto err_interruptible;
 
@@ -2372,7 +2386,7 @@ intel_pin_and_fence_fb_obj(struct drm_plane *plane,
return 0;
 
 err_unpin:
-   i915_gem_object_unpin_from_display_plane(obj, &i915_ggtt_view_normal);
+   i915_gem_object_unpin_from_display_plane(obj, &view);
 err_interruptible:
dev_priv->mm.interruptible = true;
intel_runtime_pm_put(dev_priv);
@@ -2383,11 +2397,16 @@ static void intel_unpin_fb_obj(struct drm_framebuffer 
*fb,
   const struct drm_plane_state *plane_state)
 {
struct drm_i915_gem_object *obj = intel_fb_obj(fb);
+   struct i915_ggtt_view view;
+   int ret;
 
WARN_ON(!mutex_is_locked(&obj->base.dev->struct_mutex));
 
+   ret = intel_fill_fb_ggtt_view(&view, fb, plane_state);
+   WARN_ONCE(ret, "Couldn't get view from plane state!");
+
i915_gem_object_unpin_fence(obj);
-   i915_gem_object_unpin_from_display_plane(obj, &i915_ggtt_view_normal);
+   i915_gem_object_unpin_from_display_plane(obj, &view);
 }
 
 /* Computes the linear offset to the base tile and adjusts x, y. bytes per 
pixel
-- 
2.3.2

___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 4/7] drm/i915: Helper function to determine GGTT view from plane state

2015-03-18 Thread Joonas Lahtinen 
I'd fix the below code style corrections, the functionality is ok.

On ti, 2015-03-17 at 15:45 +, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin 
> 
> For now only default implementation defaulting to normal view.
> 
> Signed-off-by: Tvrtko Ursulin 
> ---
>  drivers/gpu/drm/i915/intel_display.c | 26 +++---
>  1 file changed, 23 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_display.c 
> b/drivers/gpu/drm/i915/intel_display.c
> index 862aa46..fe11e99 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -2249,6 +2249,16 @@ intel_fb_align_height(struct drm_device *dev, unsigned 
> int height,
>  fb_format_modifier));
>  }
>  
> +static
> +int intel_fill_fb_ggtt_view(struct i915_ggtt_view *view,

Rather make this as it's elsewhere (static and return type on the same
line):
+static int
+intel_fill_fb_ggtt_view(struct i915_ggtt_view *view,

> + struct drm_framebuffer *fb,
> + const struct drm_plane_state *plane_state)
> +{
> + *view = i915_ggtt_view_normal;
> +
> + return 0;
> +}
> +
>  int
>  intel_pin_and_fence_fb_obj(struct drm_plane *plane,
>  struct drm_framebuffer *fb,
> @@ -2258,6 +2268,7 @@ intel_pin_and_fence_fb_obj(struct drm_plane *plane,
>   struct drm_device *dev = fb->dev;
>   struct drm_i915_private *dev_priv = dev->dev_private;
>   struct drm_i915_gem_object *obj = intel_fb_obj(fb);
> + struct i915_ggtt_view view;
>   u32 alignment;
>   int ret;
>  
> @@ -2294,6 +2305,10 @@ intel_pin_and_fence_fb_obj(struct drm_plane *plane,
>   return -EINVAL;
>   }
>  
> + ret = intel_fill_fb_ggtt_view(&view, fb, plane_state);
> + if (ret < 0)

Why not just "if (ret)" for consistency?

> + return ret;
> +
>   /* Note that the w/a also requires 64 PTE of padding following the
>* bo. We currently fill all unused PTE with the shadow page and so
>* we should always have valid PTE following the scanout preventing
> @@ -2313,7 +2328,7 @@ intel_pin_and_fence_fb_obj(struct drm_plane *plane,
>  
>   dev_priv->mm.interruptible = false;
>   ret = i915_gem_object_pin_to_display_plane(obj, alignment, pipelined,
> -&i915_ggtt_view_normal);
> +&view);
>   if (ret)
>   goto err_interruptible;
>  
> @@ -2333,7 +2348,7 @@ intel_pin_and_fence_fb_obj(struct drm_plane *plane,
>   return 0;
>  
>  err_unpin:
> - i915_gem_object_unpin_from_display_plane(obj, &i915_ggtt_view_normal);
> + i915_gem_object_unpin_from_display_plane(obj, &view);
>  err_interruptible:
>   dev_priv->mm.interruptible = true;
>   intel_runtime_pm_put(dev_priv);
> @@ -2344,11 +2359,16 @@ static void intel_unpin_fb_obj(struct drm_framebuffer 
> *fb,
>  const struct drm_plane_state *plane_state)
>  {
>   struct drm_i915_gem_object *obj = intel_fb_obj(fb);
> + struct i915_ggtt_view view;
> + int ret;
>  
>   WARN_ON(!mutex_is_locked(&obj->base.dev->struct_mutex));
>  
> + ret = intel_fill_fb_ggtt_view(&view, fb, plane_state);
> + WARN_ONCE(ret < 0, "Couldn't get view from plane state!");

Again, just WARN_ONCE(ret, ...) as the function doesn't have need to
return any positive integer result.

> +
>   i915_gem_object_unpin_fence(obj);
> - i915_gem_object_unpin_from_display_plane(obj, &i915_ggtt_view_normal);
> + i915_gem_object_unpin_from_display_plane(obj, &view);
>  }
>  
>  /* Computes the linear offset to the base tile and adjusts x, y. bytes per 
> pixel


___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH 4/7] drm/i915: Helper function to determine GGTT view from plane state

2015-03-17 Thread Tvrtko Ursulin 
From: Tvrtko Ursulin 

For now only default implementation defaulting to normal view.

Signed-off-by: Tvrtko Ursulin 
---
 drivers/gpu/drm/i915/intel_display.c | 26 +++---
 1 file changed, 23 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_display.c 
b/drivers/gpu/drm/i915/intel_display.c
index 862aa46..fe11e99 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -2249,6 +2249,16 @@ intel_fb_align_height(struct drm_device *dev, unsigned 
int height,
   fb_format_modifier));
 }
 
+static
+int intel_fill_fb_ggtt_view(struct i915_ggtt_view *view,
+   struct drm_framebuffer *fb,
+   const struct drm_plane_state *plane_state)
+{
+   *view = i915_ggtt_view_normal;
+
+   return 0;
+}
+
 int
 intel_pin_and_fence_fb_obj(struct drm_plane *plane,
   struct drm_framebuffer *fb,
@@ -2258,6 +2268,7 @@ intel_pin_and_fence_fb_obj(struct drm_plane *plane,
struct drm_device *dev = fb->dev;
struct drm_i915_private *dev_priv = dev->dev_private;
struct drm_i915_gem_object *obj = intel_fb_obj(fb);
+   struct i915_ggtt_view view;
u32 alignment;
int ret;
 
@@ -2294,6 +2305,10 @@ intel_pin_and_fence_fb_obj(struct drm_plane *plane,
return -EINVAL;
}
 
+   ret = intel_fill_fb_ggtt_view(&view, fb, plane_state);
+   if (ret < 0)
+   return ret;
+
/* Note that the w/a also requires 64 PTE of padding following the
 * bo. We currently fill all unused PTE with the shadow page and so
 * we should always have valid PTE following the scanout preventing
@@ -2313,7 +2328,7 @@ intel_pin_and_fence_fb_obj(struct drm_plane *plane,
 
dev_priv->mm.interruptible = false;
ret = i915_gem_object_pin_to_display_plane(obj, alignment, pipelined,
-  &i915_ggtt_view_normal);
+  &view);
if (ret)
goto err_interruptible;
 
@@ -2333,7 +2348,7 @@ intel_pin_and_fence_fb_obj(struct drm_plane *plane,
return 0;
 
 err_unpin:
-   i915_gem_object_unpin_from_display_plane(obj, &i915_ggtt_view_normal);
+   i915_gem_object_unpin_from_display_plane(obj, &view);
 err_interruptible:
dev_priv->mm.interruptible = true;
intel_runtime_pm_put(dev_priv);
@@ -2344,11 +2359,16 @@ static void intel_unpin_fb_obj(struct drm_framebuffer 
*fb,
   const struct drm_plane_state *plane_state)
 {
struct drm_i915_gem_object *obj = intel_fb_obj(fb);
+   struct i915_ggtt_view view;
+   int ret;
 
WARN_ON(!mutex_is_locked(&obj->base.dev->struct_mutex));
 
+   ret = intel_fill_fb_ggtt_view(&view, fb, plane_state);
+   WARN_ONCE(ret < 0, "Couldn't get view from plane state!");
+
i915_gem_object_unpin_fence(obj);
-   i915_gem_object_unpin_from_display_plane(obj, &i915_ggtt_view_normal);
+   i915_gem_object_unpin_from_display_plane(obj, &view);
 }
 
 /* Computes the linear offset to the base tile and adjusts x, y. bytes per 
pixel
-- 
2.3.2

___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH 4/7] drm/i915: Helper function to determine GGTT view from plane state

2015-03-05 Thread Tvrtko Ursulin 
From: Tvrtko Ursulin 

For now only default implementation defaulting to normal view.

Signed-off-by: Tvrtko Ursulin 
---
 drivers/gpu/drm/i915/intel_display.c | 26 +++---
 1 file changed, 23 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_display.c 
b/drivers/gpu/drm/i915/intel_display.c
index 81072c4..8157999 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -2244,6 +2244,16 @@ intel_fb_align_height(struct drm_device *dev, unsigned 
int height,
   fb_format_modifier));
 }
 
+static
+int intel_fill_fb_ggtt_view(struct i915_ggtt_view *view,
+   struct drm_framebuffer *fb,
+   const struct drm_plane_state *plane_state)
+{
+   *view = i915_ggtt_view_normal;
+
+   return 0;
+}
+
 int
 intel_pin_and_fence_fb_obj(struct drm_plane *plane,
   struct drm_framebuffer *fb,
@@ -2253,6 +2263,7 @@ intel_pin_and_fence_fb_obj(struct drm_plane *plane,
struct drm_device *dev = fb->dev;
struct drm_i915_private *dev_priv = dev->dev_private;
struct drm_i915_gem_object *obj = intel_fb_obj(fb);
+   struct i915_ggtt_view view;
u32 alignment;
int ret;
 
@@ -2289,6 +2300,10 @@ intel_pin_and_fence_fb_obj(struct drm_plane *plane,
return -EINVAL;
}
 
+   ret = intel_fill_fb_ggtt_view(&view, fb, plane_state);
+   if (ret < 0)
+   return ret;
+
/* Note that the w/a also requires 64 PTE of padding following the
 * bo. We currently fill all unused PTE with the shadow page and so
 * we should always have valid PTE following the scanout preventing
@@ -2308,7 +2323,7 @@ intel_pin_and_fence_fb_obj(struct drm_plane *plane,
 
dev_priv->mm.interruptible = false;
ret = i915_gem_object_pin_to_display_plane(obj, alignment, pipelined,
-  &i915_ggtt_view_normal);
+  &view);
if (ret)
goto err_interruptible;
 
@@ -2328,7 +2343,7 @@ intel_pin_and_fence_fb_obj(struct drm_plane *plane,
return 0;
 
 err_unpin:
-   i915_gem_object_unpin_from_display_plane(obj, &i915_ggtt_view_normal);
+   i915_gem_object_unpin_from_display_plane(obj, &view);
 err_interruptible:
dev_priv->mm.interruptible = true;
intel_runtime_pm_put(dev_priv);
@@ -2339,11 +2354,16 @@ static void intel_unpin_fb_obj(struct drm_framebuffer 
*fb,
   const struct drm_plane_state *plane_state)
 {
struct drm_i915_gem_object *obj = intel_fb_obj(fb);
+   struct i915_ggtt_view view;
+   int ret;
 
WARN_ON(!mutex_is_locked(&obj->base.dev->struct_mutex));
 
+   ret = intel_fill_fb_ggtt_view(&view, fb, plane_state);
+   WARN_ONCE(ret < 0, "Couldn't get view from plane state!");
+
i915_gem_object_unpin_fence(obj);
-   i915_gem_object_unpin_from_display_plane(obj, &i915_ggtt_view_normal);
+   i915_gem_object_unpin_from_display_plane(obj, &view);
 }
 
 /* Computes the linear offset to the base tile and adjusts x, y. bytes per 
pixel
-- 
2.3.0

___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx