Re: [Intel-gfx] [PATCH 5/5] drm/i915: Add support for new aspect ratios

2016-04-22 Thread Daniel Vetter 
On Fri, Apr 22, 2016 at 10:58:34AM +0530, Sharma, Shashank wrote:
> Thanks for the review Daniel.
> My comments inline.
> 
> Regards
> Shashank
> On 4/21/2016 8:34 PM, Daniel Vetter wrote:
> >On Fri, Mar 25, 2016 at 01:47:35PM +0530, Shashank Sharma wrote:
> >>HDMI 2.0/CEA-861-F introduces two new aspect ratios:
> >>- 64:27
> >>- 256:135
> >>
> >>This patch adds support for these aspect ratios in
> >>I915 driver, at various places.
> >>
> >>Signed-off-by: Shashank Sharma 
> >
> >Ok, we discussed this a bit internally and I had some questions. Reading
> >this series patches make sense up to this one, but here I have a few
> >questions/comments.
> >
> >>---
> >>  drivers/gpu/drm/drm_modes.c   | 12 
> >>  drivers/gpu/drm/i915/intel_hdmi.c |  6 ++
> >>  drivers/gpu/drm/i915/intel_sdvo.c |  6 ++
> >>  3 files changed, 24 insertions(+)
> >>
> >>diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/gpu/drm/drm_modes.c
> >>index 6e66136..11f219a 100644
> >>--- a/drivers/gpu/drm/drm_modes.c
> >>+++ b/drivers/gpu/drm/drm_modes.c
> >>@@ -1482,6 +1482,12 @@ void drm_mode_convert_to_umode(struct 
> >>drm_mode_modeinfo *out,
> >>case HDMI_PICTURE_ASPECT_16_9:
> >>out->flags |= DRM_MODE_FLAG_PAR16_9;
> >>break;
> >>+   case HDMI_PICTURE_ASPECT_64_27:
> >>+   out->flags |= DRM_MODE_FLAG_PAR64_27;
> >>+   break;
> >>+   case DRM_MODE_PICTURE_ASPECT_256_135:
> >>+   out->flags |= DRM_MODE_FLAG_PAR256_135;
> >>+   break;
> >>case HDMI_PICTURE_ASPECT_NONE:
> >>case HDMI_PICTURE_ASPECT_RESERVED:
> >>default:
> >>@@ -1544,6 +1550,12 @@ int drm_mode_convert_umode(struct drm_display_mode 
> >>*out,
> >>case DRM_MODE_FLAG_PAR16_9:
> >>out->picture_aspect_ratio |= HDMI_PICTURE_ASPECT_16_9;
> >>break;
> >>+   case DRM_MODE_FLAG_PAR64_27:
> >>+   out->picture_aspect_ratio |= HDMI_PICTURE_ASPECT_64_27;
> >>+   break;
> >>+   case DRM_MODE_FLAG_PAR256_135:
> >>+   out->picture_aspect_ratio |= HDMI_PICTURE_ASPECT_256_135;
> >>+   break;
> >>default:
> >>out->picture_aspect_ratio = HDMI_PICTURE_ASPECT_NONE;
> >>}
> >
> >Above two parts is core enabling, I guess those should be squashed into
> >the preceeding patch?
> >
> Sure, we can do this.
> The idea was to create a separate patch for new aspect ratio, so that one
> can segregate HDMI 2.0 patches and HDMI 1.4 patches. If you still recommend
> this, I can move this part in next patch.

Definitely a good idea, and you have that separate patch already in "drm:
Add flags for new aspect ratios". I just think that the above 2 hunks
belong into the core patch, not the i915 enabling patch.

> >>diff --git a/drivers/gpu/drm/i915/intel_hdmi.c 
> >>b/drivers/gpu/drm/i915/intel_hdmi.c
> >>index e2dab48..bc8e2c8 100644
> >>--- a/drivers/gpu/drm/i915/intel_hdmi.c
> >>+++ b/drivers/gpu/drm/i915/intel_hdmi.c
> >>@@ -1545,6 +1545,12 @@ intel_hdmi_set_property(struct drm_connector 
> >>*connector,
> >>case DRM_MODE_PICTURE_ASPECT_16_9:
> >>intel_hdmi->aspect_ratio = HDMI_PICTURE_ASPECT_16_9;
> >>break;
> >>+   case DRM_MODE_PICTURE_ASPECT_64_27:
> >>+   intel_hdmi->aspect_ratio = HDMI_PICTURE_ASPECT_64_27;
> >>+   break;
> >>+   case DRM_MODE_PICTURE_ASPECT_256_135:
> >>+   intel_hdmi->aspect_ratio = HDMI_PICTURE_ASPECT_256_135;
> >>+   break;
> >>default:
> >>return -EINVAL;
> >>}
> >>diff --git a/drivers/gpu/drm/i915/intel_sdvo.c 
> >>b/drivers/gpu/drm/i915/intel_sdvo.c
> >>index fae64bc..370e4f9 100644
> >>--- a/drivers/gpu/drm/i915/intel_sdvo.c
> >>+++ b/drivers/gpu/drm/i915/intel_sdvo.c
> >>@@ -2071,6 +2071,12 @@ intel_sdvo_set_property(struct drm_connector 
> >>*connector,
> >>case DRM_MODE_PICTURE_ASPECT_16_9:
> >>intel_sdvo->aspect_ratio = HDMI_PICTURE_ASPECT_16_9;
> >>break;
> >>+   case DRM_MODE_PICTURE_ASPECT_64_27:
> >>+   intel_sdvo->aspect_ratio = HDMI_PICTURE_ASPECT_64_27;
> >>+   break;
> >>+   case DRM_MODE_PICTURE_ASPECT_256_135:
> >>+   intel_sdvo->aspect_ratio = HDMI_PICTURE_ASPECT_256_135;
> >>+   break;
> >>default:
> >>return -EINVAL;
> >>}
> >
> >The trouble with the aspect_ratio prop as currently implemented is that we
> >currently unconditionally overwrite adjusted_mode->picture_aspect_ratio
> >with it.
> >
> >But your patches here move the aspect ratio handling into
> >drm_mode_modeinfo (uabi) and drm_display_mode (kernel-internal), where it
> >imo belongs. But we need to figure out how to the interaction with the
> >property correctly. What's probably needed is a new value in the
> >aspect_ratio enum called "default", which selects

Re: [Intel-gfx] [PATCH 5/5] drm/i915: Add support for new aspect ratios

2016-04-21 Thread Sharma, Shashank 

Thanks for the review Daniel.
My comments inline.

Regards
Shashank
On 4/21/2016 8:34 PM, Daniel Vetter wrote:

On Fri, Mar 25, 2016 at 01:47:35PM +0530, Shashank Sharma wrote:

HDMI 2.0/CEA-861-F introduces two new aspect ratios:
- 64:27
- 256:135

This patch adds support for these aspect ratios in
I915 driver, at various places.

Signed-off-by: Shashank Sharma 


Ok, we discussed this a bit internally and I had some questions. Reading
this series patches make sense up to this one, but here I have a few
questions/comments.


---
  drivers/gpu/drm/drm_modes.c   | 12 
  drivers/gpu/drm/i915/intel_hdmi.c |  6 ++
  drivers/gpu/drm/i915/intel_sdvo.c |  6 ++
  3 files changed, 24 insertions(+)

diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/gpu/drm/drm_modes.c
index 6e66136..11f219a 100644
--- a/drivers/gpu/drm/drm_modes.c
+++ b/drivers/gpu/drm/drm_modes.c
@@ -1482,6 +1482,12 @@ void drm_mode_convert_to_umode(struct drm_mode_modeinfo 
*out,
case HDMI_PICTURE_ASPECT_16_9:
out->flags |= DRM_MODE_FLAG_PAR16_9;
break;
+   case HDMI_PICTURE_ASPECT_64_27:
+   out->flags |= DRM_MODE_FLAG_PAR64_27;
+   break;
+   case DRM_MODE_PICTURE_ASPECT_256_135:
+   out->flags |= DRM_MODE_FLAG_PAR256_135;
+   break;
case HDMI_PICTURE_ASPECT_NONE:
case HDMI_PICTURE_ASPECT_RESERVED:
default:
@@ -1544,6 +1550,12 @@ int drm_mode_convert_umode(struct drm_display_mode *out,
case DRM_MODE_FLAG_PAR16_9:
out->picture_aspect_ratio |= HDMI_PICTURE_ASPECT_16_9;
break;
+   case DRM_MODE_FLAG_PAR64_27:
+   out->picture_aspect_ratio |= HDMI_PICTURE_ASPECT_64_27;
+   break;
+   case DRM_MODE_FLAG_PAR256_135:
+   out->picture_aspect_ratio |= HDMI_PICTURE_ASPECT_256_135;
+   break;
default:
out->picture_aspect_ratio = HDMI_PICTURE_ASPECT_NONE;
}


Above two parts is core enabling, I guess those should be squashed into
the preceeding patch?


Sure, we can do this.
The idea was to create a separate patch for new aspect ratio, so that 
one can segregate HDMI 2.0 patches and HDMI 1.4 patches. If you still 
recommend this, I can move this part in next patch.

diff --git a/drivers/gpu/drm/i915/intel_hdmi.c 
b/drivers/gpu/drm/i915/intel_hdmi.c
index e2dab48..bc8e2c8 100644
--- a/drivers/gpu/drm/i915/intel_hdmi.c
+++ b/drivers/gpu/drm/i915/intel_hdmi.c
@@ -1545,6 +1545,12 @@ intel_hdmi_set_property(struct drm_connector *connector,
case DRM_MODE_PICTURE_ASPECT_16_9:
intel_hdmi->aspect_ratio = HDMI_PICTURE_ASPECT_16_9;
break;
+   case DRM_MODE_PICTURE_ASPECT_64_27:
+   intel_hdmi->aspect_ratio = HDMI_PICTURE_ASPECT_64_27;
+   break;
+   case DRM_MODE_PICTURE_ASPECT_256_135:
+   intel_hdmi->aspect_ratio = HDMI_PICTURE_ASPECT_256_135;
+   break;
default:
return -EINVAL;
}
diff --git a/drivers/gpu/drm/i915/intel_sdvo.c 
b/drivers/gpu/drm/i915/intel_sdvo.c
index fae64bc..370e4f9 100644
--- a/drivers/gpu/drm/i915/intel_sdvo.c
+++ b/drivers/gpu/drm/i915/intel_sdvo.c
@@ -2071,6 +2071,12 @@ intel_sdvo_set_property(struct drm_connector *connector,
case DRM_MODE_PICTURE_ASPECT_16_9:
intel_sdvo->aspect_ratio = HDMI_PICTURE_ASPECT_16_9;
break;
+   case DRM_MODE_PICTURE_ASPECT_64_27:
+   intel_sdvo->aspect_ratio = HDMI_PICTURE_ASPECT_64_27;
+   break;
+   case DRM_MODE_PICTURE_ASPECT_256_135:
+   intel_sdvo->aspect_ratio = HDMI_PICTURE_ASPECT_256_135;
+   break;
default:
return -EINVAL;
}


The trouble with the aspect_ratio prop as currently implemented is that we
currently unconditionally overwrite adjusted_mode->picture_aspect_ratio
with it.

But your patches here move the aspect ratio handling into
drm_mode_modeinfo (uabi) and drm_display_mode (kernel-internal), where it
imo belongs. But we need to figure out how to the interaction with the
property correctly. What's probably needed is a new value in the
aspect_ratio enum called "default", which selects the aspect_ratio from
the mode. Only when userspace overrides (NONE, or one of the CEA aspect
ratios) would we obey the aspect_ratio of the property. Otherwise the
aspect ratio stored in the mode would be lost.
This is exactly how we have handled this in Android branch(with NONE as 
default), thanks for the suggestion. I will incorporate this in next 
patch set.


The other bit that I can't find in this series is making sure we compute
the VIC correctly for the new modes. Or does

Re: [Intel-gfx] [PATCH 5/5] drm/i915: Add support for new aspect ratios

2016-04-21 Thread Daniel Vetter 
On Fri, Mar 25, 2016 at 01:47:35PM +0530, Shashank Sharma wrote:
> HDMI 2.0/CEA-861-F introduces two new aspect ratios:
> - 64:27
> - 256:135
> 
> This patch adds support for these aspect ratios in
> I915 driver, at various places.
> 
> Signed-off-by: Shashank Sharma 

Ok, we discussed this a bit internally and I had some questions. Reading
this series patches make sense up to this one, but here I have a few
questions/comments.

> ---
>  drivers/gpu/drm/drm_modes.c   | 12 
>  drivers/gpu/drm/i915/intel_hdmi.c |  6 ++
>  drivers/gpu/drm/i915/intel_sdvo.c |  6 ++
>  3 files changed, 24 insertions(+)
> 
> diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/gpu/drm/drm_modes.c
> index 6e66136..11f219a 100644
> --- a/drivers/gpu/drm/drm_modes.c
> +++ b/drivers/gpu/drm/drm_modes.c
> @@ -1482,6 +1482,12 @@ void drm_mode_convert_to_umode(struct 
> drm_mode_modeinfo *out,
>   case HDMI_PICTURE_ASPECT_16_9:
>   out->flags |= DRM_MODE_FLAG_PAR16_9;
>   break;
> + case HDMI_PICTURE_ASPECT_64_27:
> + out->flags |= DRM_MODE_FLAG_PAR64_27;
> + break;
> + case DRM_MODE_PICTURE_ASPECT_256_135:
> + out->flags |= DRM_MODE_FLAG_PAR256_135;
> + break;
>   case HDMI_PICTURE_ASPECT_NONE:
>   case HDMI_PICTURE_ASPECT_RESERVED:
>   default:
> @@ -1544,6 +1550,12 @@ int drm_mode_convert_umode(struct drm_display_mode 
> *out,
>   case DRM_MODE_FLAG_PAR16_9:
>   out->picture_aspect_ratio |= HDMI_PICTURE_ASPECT_16_9;
>   break;
> + case DRM_MODE_FLAG_PAR64_27:
> + out->picture_aspect_ratio |= HDMI_PICTURE_ASPECT_64_27;
> + break;
> + case DRM_MODE_FLAG_PAR256_135:
> + out->picture_aspect_ratio |= HDMI_PICTURE_ASPECT_256_135;
> + break;
>   default:
>   out->picture_aspect_ratio = HDMI_PICTURE_ASPECT_NONE;
>   }

Above two parts is core enabling, I guess those should be squashed into
the preceeding patch?

> diff --git a/drivers/gpu/drm/i915/intel_hdmi.c 
> b/drivers/gpu/drm/i915/intel_hdmi.c
> index e2dab48..bc8e2c8 100644
> --- a/drivers/gpu/drm/i915/intel_hdmi.c
> +++ b/drivers/gpu/drm/i915/intel_hdmi.c
> @@ -1545,6 +1545,12 @@ intel_hdmi_set_property(struct drm_connector 
> *connector,
>   case DRM_MODE_PICTURE_ASPECT_16_9:
>   intel_hdmi->aspect_ratio = HDMI_PICTURE_ASPECT_16_9;
>   break;
> + case DRM_MODE_PICTURE_ASPECT_64_27:
> + intel_hdmi->aspect_ratio = HDMI_PICTURE_ASPECT_64_27;
> + break;
> + case DRM_MODE_PICTURE_ASPECT_256_135:
> + intel_hdmi->aspect_ratio = HDMI_PICTURE_ASPECT_256_135;
> + break;
>   default:
>   return -EINVAL;
>   }
> diff --git a/drivers/gpu/drm/i915/intel_sdvo.c 
> b/drivers/gpu/drm/i915/intel_sdvo.c
> index fae64bc..370e4f9 100644
> --- a/drivers/gpu/drm/i915/intel_sdvo.c
> +++ b/drivers/gpu/drm/i915/intel_sdvo.c
> @@ -2071,6 +2071,12 @@ intel_sdvo_set_property(struct drm_connector 
> *connector,
>   case DRM_MODE_PICTURE_ASPECT_16_9:
>   intel_sdvo->aspect_ratio = HDMI_PICTURE_ASPECT_16_9;
>   break;
> + case DRM_MODE_PICTURE_ASPECT_64_27:
> + intel_sdvo->aspect_ratio = HDMI_PICTURE_ASPECT_64_27;
> + break;
> + case DRM_MODE_PICTURE_ASPECT_256_135:
> + intel_sdvo->aspect_ratio = HDMI_PICTURE_ASPECT_256_135;
> + break;
>   default:
>   return -EINVAL;
>   }

The trouble with the aspect_ratio prop as currently implemented is that we
currently unconditionally overwrite adjusted_mode->picture_aspect_ratio
with it.

But your patches here move the aspect ratio handling into
drm_mode_modeinfo (uabi) and drm_display_mode (kernel-internal), where it
imo belongs. But we need to figure out how to the interaction with the
property correctly. What's probably needed is a new value in the
aspect_ratio enum called "default", which selects the aspect_ratio from
the mode. Only when userspace overrides (NONE, or one of the CEA aspect
ratios) would we obey the aspect_ratio of the property. Otherwise the
aspect ratio stored in the mode would be lost.

The other bit that I can't find in this series is making sure we compute
the VIC correctly for the new modes. Or does that magically work correctly
since we compare the full mode when selecting VICs?

Thanks, Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH 5/5] drm/i915: Add support for new aspect ratios

2016-03-25 Thread Shashank Sharma 
HDMI 2.0/CEA-861-F introduces two new aspect ratios:
- 64:27
- 256:135

This patch adds support for these aspect ratios in
I915 driver, at various places.

Signed-off-by: Shashank Sharma 
---
 drivers/gpu/drm/drm_modes.c   | 12 
 drivers/gpu/drm/i915/intel_hdmi.c |  6 ++
 drivers/gpu/drm/i915/intel_sdvo.c |  6 ++
 3 files changed, 24 insertions(+)

diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/gpu/drm/drm_modes.c
index 6e66136..11f219a 100644
--- a/drivers/gpu/drm/drm_modes.c
+++ b/drivers/gpu/drm/drm_modes.c
@@ -1482,6 +1482,12 @@ void drm_mode_convert_to_umode(struct drm_mode_modeinfo 
*out,
case HDMI_PICTURE_ASPECT_16_9:
out->flags |= DRM_MODE_FLAG_PAR16_9;
break;
+   case HDMI_PICTURE_ASPECT_64_27:
+   out->flags |= DRM_MODE_FLAG_PAR64_27;
+   break;
+   case DRM_MODE_PICTURE_ASPECT_256_135:
+   out->flags |= DRM_MODE_FLAG_PAR256_135;
+   break;
case HDMI_PICTURE_ASPECT_NONE:
case HDMI_PICTURE_ASPECT_RESERVED:
default:
@@ -1544,6 +1550,12 @@ int drm_mode_convert_umode(struct drm_display_mode *out,
case DRM_MODE_FLAG_PAR16_9:
out->picture_aspect_ratio |= HDMI_PICTURE_ASPECT_16_9;
break;
+   case DRM_MODE_FLAG_PAR64_27:
+   out->picture_aspect_ratio |= HDMI_PICTURE_ASPECT_64_27;
+   break;
+   case DRM_MODE_FLAG_PAR256_135:
+   out->picture_aspect_ratio |= HDMI_PICTURE_ASPECT_256_135;
+   break;
default:
out->picture_aspect_ratio = HDMI_PICTURE_ASPECT_NONE;
}
diff --git a/drivers/gpu/drm/i915/intel_hdmi.c 
b/drivers/gpu/drm/i915/intel_hdmi.c
index e2dab48..bc8e2c8 100644
--- a/drivers/gpu/drm/i915/intel_hdmi.c
+++ b/drivers/gpu/drm/i915/intel_hdmi.c
@@ -1545,6 +1545,12 @@ intel_hdmi_set_property(struct drm_connector *connector,
case DRM_MODE_PICTURE_ASPECT_16_9:
intel_hdmi->aspect_ratio = HDMI_PICTURE_ASPECT_16_9;
break;
+   case DRM_MODE_PICTURE_ASPECT_64_27:
+   intel_hdmi->aspect_ratio = HDMI_PICTURE_ASPECT_64_27;
+   break;
+   case DRM_MODE_PICTURE_ASPECT_256_135:
+   intel_hdmi->aspect_ratio = HDMI_PICTURE_ASPECT_256_135;
+   break;
default:
return -EINVAL;
}
diff --git a/drivers/gpu/drm/i915/intel_sdvo.c 
b/drivers/gpu/drm/i915/intel_sdvo.c
index fae64bc..370e4f9 100644
--- a/drivers/gpu/drm/i915/intel_sdvo.c
+++ b/drivers/gpu/drm/i915/intel_sdvo.c
@@ -2071,6 +2071,12 @@ intel_sdvo_set_property(struct drm_connector *connector,
case DRM_MODE_PICTURE_ASPECT_16_9:
intel_sdvo->aspect_ratio = HDMI_PICTURE_ASPECT_16_9;
break;
+   case DRM_MODE_PICTURE_ASPECT_64_27:
+   intel_sdvo->aspect_ratio = HDMI_PICTURE_ASPECT_64_27;
+   break;
+   case DRM_MODE_PICTURE_ASPECT_256_135:
+   intel_sdvo->aspect_ratio = HDMI_PICTURE_ASPECT_256_135;
+   break;
default:
return -EINVAL;
}
-- 
1.9.1

___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH 5/5] drm/i915: Add support for new aspect ratios

2015-12-17 Thread Shashank Sharma 
HDMI 2.0/CEA-861-F introduces two new aspect ratios:
- 64:27
- 256:135

This patch adds support for these aspect ratios in
I915 driver, at various places.

Signed-off-by: Shashank Sharma 
---
 drivers/gpu/drm/drm_modes.c   | 12 
 drivers/gpu/drm/i915/intel_hdmi.c |  6 ++
 drivers/gpu/drm/i915/intel_sdvo.c |  6 ++
 3 files changed, 24 insertions(+)

diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/gpu/drm/drm_modes.c
index 7824a63..7e27854 100644
--- a/drivers/gpu/drm/drm_modes.c
+++ b/drivers/gpu/drm/drm_modes.c
@@ -1483,6 +1483,12 @@ void drm_mode_convert_to_umode(struct drm_mode_modeinfo 
*out,
case HDMI_PICTURE_ASPECT_16_9:
out->flags |= DRM_MODE_FLAG_PAR16_9;
break;
+   case HDMI_PICTURE_ASPECT_64_27:
+   out->flags |= DRM_MODE_FLAG_PAR64_27;
+   break;
+   case DRM_MODE_PICTURE_ASPECT_256_135:
+   out->flags |= DRM_MODE_FLAG_PAR256_135;
+   break;
case HDMI_PICTURE_ASPECT_NONE:
case HDMI_PICTURE_ASPECT_RESERVED:
default:
@@ -1545,6 +1551,12 @@ int drm_mode_convert_umode(struct drm_display_mode *out,
case DRM_MODE_FLAG_PAR16_9:
out->picture_aspect_ratio |= HDMI_PICTURE_ASPECT_16_9;
break;
+   case DRM_MODE_FLAG_PAR64_27:
+   out->picture_aspect_ratio |= HDMI_PICTURE_ASPECT_64_27;
+   break;
+   case DRM_MODE_FLAG_PAR256_135:
+   out->picture_aspect_ratio |= HDMI_PICTURE_ASPECT_256_135;
+   break;
default:
out->picture_aspect_ratio = HDMI_PICTURE_ASPECT_NONE;
}
diff --git a/drivers/gpu/drm/i915/intel_hdmi.c 
b/drivers/gpu/drm/i915/intel_hdmi.c
index 6825543..6d5c3ad 100644
--- a/drivers/gpu/drm/i915/intel_hdmi.c
+++ b/drivers/gpu/drm/i915/intel_hdmi.c
@@ -1533,6 +1533,12 @@ intel_hdmi_set_property(struct drm_connector *connector,
case DRM_MODE_PICTURE_ASPECT_16_9:
intel_hdmi->aspect_ratio = HDMI_PICTURE_ASPECT_16_9;
break;
+   case DRM_MODE_PICTURE_ASPECT_64_27:
+   intel_hdmi->aspect_ratio = HDMI_PICTURE_ASPECT_64_27;
+   break;
+   case DRM_MODE_PICTURE_ASPECT_256_135:
+   intel_hdmi->aspect_ratio = HDMI_PICTURE_ASPECT_256_135;
+   break;
default:
return -EINVAL;
}
diff --git a/drivers/gpu/drm/i915/intel_sdvo.c 
b/drivers/gpu/drm/i915/intel_sdvo.c
index 2e1da06..83f30d6 100644
--- a/drivers/gpu/drm/i915/intel_sdvo.c
+++ b/drivers/gpu/drm/i915/intel_sdvo.c
@@ -2069,6 +2069,12 @@ intel_sdvo_set_property(struct drm_connector *connector,
case DRM_MODE_PICTURE_ASPECT_16_9:
intel_sdvo->aspect_ratio = HDMI_PICTURE_ASPECT_16_9;
break;
+   case DRM_MODE_PICTURE_ASPECT_64_27:
+   intel_sdvo->aspect_ratio = HDMI_PICTURE_ASPECT_64_27;
+   break;
+   case DRM_MODE_PICTURE_ASPECT_256_135:
+   intel_sdvo->aspect_ratio = HDMI_PICTURE_ASPECT_256_135;
+   break;
default:
return -EINVAL;
}
-- 
1.9.1

___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx