Re: [Intel-gfx] [PATCH 6/8] drm/i915/tgl: Add note to Wa_1607297627

2020-02-24 Thread Matt Roper
On Fri, Feb 21, 2020 at 06:08:13PM -0800, José Roberto de Souza wrote:
> Add note about the confliting information in BSpec about this WA.
> 
> BSpec: 52890
> Signed-off-by: José Roberto de Souza 

Acked-by: Matt Roper 

> ---
>  drivers/gpu/drm/i915/gt/intel_workarounds.c | 10 +++---
>  1 file changed, 7 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c 
> b/drivers/gpu/drm/i915/gt/intel_workarounds.c
> index 978a5b051ce9..bc5025c81c4f 100644
> --- a/drivers/gpu/drm/i915/gt/intel_workarounds.c
> +++ b/drivers/gpu/drm/i915/gt/intel_workarounds.c
> @@ -1344,9 +1344,13 @@ rcs_engine_wa_init(struct intel_engine_cs *engine, 
> struct i915_wa_list *wal)
>   GEN9_CTX_PREEMPT_REG,
>   GEN12_DISABLE_POSH_BUSY_FF_DOP_CG);
>  
> - /* Wa_1607030317:tgl */
> - /* Wa_1607186500:tgl */
> - /* Wa_1607297627:tgl */
> + /*
> +  * Wa_1607030317:tgl
> +  * Wa_1607186500:tgl
> +  * Wa_1607297627:tgl there is 3 entries for this WA on BSpec, 2
> +  * of then says it is fixed on B0 the other one says it is
> +  * permanent
> +  */
>   wa_masked_en(wal,
>GEN6_RC_SLEEP_PSMI_CONTROL,
>GEN12_WAIT_FOR_EVENT_POWER_DOWN_DISABLE |
> -- 
> 2.25.1
> 
> ___
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Matt Roper
Graphics Software Engineer
VTT-OSGC Platform Enablement
Intel Corporation
(916) 356-2795
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx


[Intel-gfx] [PATCH 6/8] drm/i915/tgl: Add note to Wa_1607297627

2020-02-21 Thread José Roberto de Souza
Add note about the confliting information in BSpec about this WA.

BSpec: 52890
Signed-off-by: José Roberto de Souza 
---
 drivers/gpu/drm/i915/gt/intel_workarounds.c | 10 +++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c 
b/drivers/gpu/drm/i915/gt/intel_workarounds.c
index 978a5b051ce9..bc5025c81c4f 100644
--- a/drivers/gpu/drm/i915/gt/intel_workarounds.c
+++ b/drivers/gpu/drm/i915/gt/intel_workarounds.c
@@ -1344,9 +1344,13 @@ rcs_engine_wa_init(struct intel_engine_cs *engine, 
struct i915_wa_list *wal)
GEN9_CTX_PREEMPT_REG,
GEN12_DISABLE_POSH_BUSY_FF_DOP_CG);
 
-   /* Wa_1607030317:tgl */
-   /* Wa_1607186500:tgl */
-   /* Wa_1607297627:tgl */
+   /*
+* Wa_1607030317:tgl
+* Wa_1607186500:tgl
+* Wa_1607297627:tgl there is 3 entries for this WA on BSpec, 2
+* of then says it is fixed on B0 the other one says it is
+* permanent
+*/
wa_masked_en(wal,
 GEN6_RC_SLEEP_PSMI_CONTROL,
 GEN12_WAIT_FOR_EVENT_POWER_DOWN_DISABLE |
-- 
2.25.1

___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx