Re: [Intel-gfx] [PATCH i-g-t] igt_core: Fix logging to display extended line

[Daniel Vetter]

On Wed, Dec 23, 2015 at 03:34:48PM +, Derek Morton wrote:
> line[strlen(line)] will always evaluate to NULL so line_continuation
> was always true. That prevented the program name, pid and log level
> ever being printed.
> Changed to [strlen(line) - 1] so the last character before the null
> terminator is compared with '\n' to determine line_continuation.
> 
> Signed-off-by: Derek Morton 

Ooops. Applied, thanks for the patch.
-Daniel

> ---
>  lib/igt_core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/igt_core.c b/lib/igt_core.c
> index 84cf8d2..221ed7e 100644
> --- a/lib/igt_core.c
> +++ b/lib/igt_core.c
> @@ -1748,7 +1748,7 @@ void igt_vlog(const char *domain, enum igt_log_level 
> level, const char *format,
>   goto out;
>   }
>  
> - line_continuation = line[strlen(line)] != '\n';
> + line_continuation = line[strlen(line) - 1] != '\n';
>  
>   /* append log buffer */
>   _igt_log_buffer_append(formatted_line);
> -- 
> 1.9.1
> 
> ___
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH i-g-t] igt_core: Fix logging to display extended line

[Derek Morton]

line[strlen(line)] will always evaluate to NULL so line_continuation
was always true. That prevented the program name, pid and log level
ever being printed.
Changed to [strlen(line) - 1] so the last character before the null
terminator is compared with '\n' to determine line_continuation.

Signed-off-by: Derek Morton 
---
 lib/igt_core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/igt_core.c b/lib/igt_core.c
index 84cf8d2..221ed7e 100644
--- a/lib/igt_core.c
+++ b/lib/igt_core.c
@@ -1748,7 +1748,7 @@ void igt_vlog(const char *domain, enum igt_log_level 
level, const char *format,
goto out;
}
 
-   line_continuation = line[strlen(line)] != '\n';
+   line_continuation = line[strlen(line) - 1] != '\n';
 
/* append log buffer */
_igt_log_buffer_append(formatted_line);
-- 
1.9.1

___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx