Re: [Intel-gfx] [PATCH i-g-t] igt_kms: Use const parameters for igt_assert_crc_equal

[Robert Foss]

Looks good to me.

Added t-b and pushed upstream.


Rob.

On 2016-12-16 03:35 PM, Lyude wrote:

Since we're not modifying these anywhere, let's make them const so as to
not break code doing comparisons against compile-time CRCs.

Signed-off-by: Lyude 

___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH i-g-t] igt_kms: Use const parameters for igt_assert_crc_equal

[Lyude]

Since we're not modifying these anywhere, let's make them const so as to
not break code doing comparisons against compile-time CRCs.

Signed-off-by: Lyude 
---
 lib/igt_debugfs.c | 2 +-
 lib/igt_debugfs.h | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/igt_debugfs.c b/lib/igt_debugfs.c
index 3d92c6a..f8c8727 100644
--- a/lib/igt_debugfs.c
+++ b/lib/igt_debugfs.c
@@ -270,7 +270,7 @@ bool igt_debugfs_search(const char *filename, const char 
*substring)
  * be random testcase failures when different screen contents end up with the
  * same CRC by chance.
  */
-void igt_assert_crc_equal(igt_crc_t *a, igt_crc_t *b)
+void igt_assert_crc_equal(const igt_crc_t *a, const igt_crc_t *b)
 {
int i;
 
diff --git a/lib/igt_debugfs.h b/lib/igt_debugfs.h
index 4c6572c..86c25dd 100644
--- a/lib/igt_debugfs.h
+++ b/lib/igt_debugfs.h
@@ -113,7 +113,7 @@ enum intel_pipe_crc_source {
 INTEL_PIPE_CRC_SOURCE_MAX,
 };
 
-void igt_assert_crc_equal(igt_crc_t *a, igt_crc_t *b);
+void igt_assert_crc_equal(const igt_crc_t *a, const igt_crc_t *b);
 char *igt_crc_to_string(igt_crc_t *crc);
 
 void igt_require_pipe_crc(void);
-- 
2.9.3

___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx