Re: [Intel-gfx] [PATCH i-g-t 0/5] Import drm UAPI headers.
On Mon, Nov 20, 2017 at 12:06:50PM -0800, Eric Anholt wrote: > Petri Latvalawrites: > > > On Sat, Nov 11, 2017 at 12:27:15AM +, Lionel Landwerlin wrote: > >> Hey Eric, > >> > >> Like it did for Mesa I think this makes developers' lives easier. > >> Not having to update libdrm and then compile against the right version just > >> for the kernel headers you need is a win (in my opinion). > > > > Yes indeed. Would be nice to be able to build IGT on Debian stable > > again. > > > > Series is > > > > Acked-by: Petri Latvala > > > > Some more acks (or objections, if any) for the overall idea would be > > nice to have, after that we can merge this and start cleaning up the > > LOCAL_* crud. > > Is there anyone else who is likely to give feedback on this? I pinged Arek, but I think it's good to go otherwise. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH i-g-t 0/5] Import drm UAPI headers.
Petri Latvalawrites: > On Sat, Nov 11, 2017 at 12:27:15AM +, Lionel Landwerlin wrote: >> Hey Eric, >> >> Like it did for Mesa I think this makes developers' lives easier. >> Not having to update libdrm and then compile against the right version just >> for the kernel headers you need is a win (in my opinion). > > Yes indeed. Would be nice to be able to build IGT on Debian stable > again. > > Series is > > Acked-by: Petri Latvala > > Some more acks (or objections, if any) for the overall idea would be > nice to have, after that we can merge this and start cleaning up the > LOCAL_* crud. Is there anyone else who is likely to give feedback on this? signature.asc Description: PGP signature ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH i-g-t 0/5] Import drm UAPI headers.
On Mon, Nov 13, 2017 at 01:40:22PM +0200, Petri Latvala wrote: > On Sat, Nov 11, 2017 at 12:27:15AM +, Lionel Landwerlin wrote: > > Hey Eric, > > > > Like it did for Mesa I think this makes developers' lives easier. > > Not having to update libdrm and then compile against the right version just > > for the kernel headers you need is a win (in my opinion). > > Yes indeed. Would be nice to be able to build IGT on Debian stable > again. > > Series is > > Acked-by: Petri Latvala> > Some more acks (or objections, if any) for the overall idea would be > nice to have, after that we can merge this and start cleaning up the > LOCAL_* crud. fwiw I like the idea of just importing the headers, avoids all the need for _local versions. Of course we need to make sure we don't add stuff that isn't upstream, usually uapi merging rules apply (i.e. merge kernel, then merge userspace, how to CI tbh). Acked-by: Daniel Vetter -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH i-g-t 0/5] Import drm UAPI headers.
On Sat, Nov 11, 2017 at 12:27:15AM +, Lionel Landwerlin wrote: > Hey Eric, > > Like it did for Mesa I think this makes developers' lives easier. > Not having to update libdrm and then compile against the right version just > for the kernel headers you need is a win (in my opinion). Yes indeed. Would be nice to be able to build IGT on Debian stable again. Series is Acked-by: Petri LatvalaSome more acks (or objections, if any) for the overall idea would be nice to have, after that we can merge this and start cleaning up the LOCAL_* crud. -- Petri Latvala ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH i-g-t 0/5] Import drm UAPI headers.
Hey Eric, Like it did for Mesa I think this makes developers' lives easier. Not having to update libdrm and then compile against the right version just for the kernel headers you need is a win (in my opinion). Looking forward to get this merged! If most developers agree with the overall goal, patch 1 is : Reviewed-by: Lionel Landwerlin- Lionel On 10/11/17 21:26, Eric Anholt wrote: This series imports the UAPI headers from Linux, like we've been doing in Mesa for vc4 and i965. The advantage is that it lets you build new kernel UAPI and testcases together, without needing libdrm releases, and has a simple rule for producing header updates (avoiding the need for the LOCAL_* define hacks that have been proliferating in the tree) I started on converting i915 to not use LOCAL_*, but it's more than I'm willing to complete. Eric Anholt (5): headers: Import drm-next uapi headers. tests: Convert to using the imported drm-uapi headers. tests: Remove libdrm_vc4 dependency. lib: Use the imported uapi's addfb2 defines. lib: Use drm-uapi/i915_drm.h instead of local defines. README |8 + benchmarks/Makefile.am |6 +- benchmarks/gem_wsim.c |6 +- configure.ac | 12 +- include/drm-uapi/amdgpu_drm.h | 930 include/drm-uapi/armada_drm.h | 55 ++ include/drm-uapi/drm.h | 988 + include/drm-uapi/drm_fourcc.h | 410 +++ include/drm-uapi/drm_mode.h| 855 ++ include/drm-uapi/drm_sarea.h | 92 +++ include/drm-uapi/etnaviv_drm.h | 282 include/drm-uapi/exynos_drm.h | 373 ++ include/drm-uapi/i810_drm.h| 291 include/drm-uapi/i915_drm.h| 1542 include/drm-uapi/mga_drm.h | 427 +++ include/drm-uapi/msm_drm.h | 306 include/drm-uapi/nouveau_drm.h | 152 include/drm-uapi/omap_drm.h| 125 include/drm-uapi/qxl_drm.h | 158 include/drm-uapi/r128_drm.h| 336 + include/drm-uapi/radeon_drm.h | 1078 include/drm-uapi/savage_drm.h | 220 ++ include/drm-uapi/sis_drm.h | 77 ++ include/drm-uapi/tegra_drm.h | 209 ++ include/drm-uapi/vc4_drm.h | 359 ++ include/drm-uapi/vgem_drm.h| 62 ++ include/drm-uapi/via_drm.h | 282 include/drm-uapi/virtgpu_drm.h | 174 + include/drm-uapi/vmwgfx_drm.h | 1128 + lib/Makefile.am|7 +- lib/i915/gem_context.c | 46 +- lib/i915/gem_context.h | 19 +- lib/igt_gt.c | 38 +- lib/ioctl_wrappers.c | 71 +- lib/meson.build|6 +- meson.build|3 +- tests/Makefile.am | 16 +- tests/gem_ctx_param.c | 38 +- tests/meson.build | 16 +- 39 files changed, 11032 insertions(+), 171 deletions(-) create mode 100644 include/drm-uapi/amdgpu_drm.h create mode 100644 include/drm-uapi/armada_drm.h create mode 100644 include/drm-uapi/drm.h create mode 100644 include/drm-uapi/drm_fourcc.h create mode 100644 include/drm-uapi/drm_mode.h create mode 100644 include/drm-uapi/drm_sarea.h create mode 100644 include/drm-uapi/etnaviv_drm.h create mode 100644 include/drm-uapi/exynos_drm.h create mode 100644 include/drm-uapi/i810_drm.h create mode 100644 include/drm-uapi/i915_drm.h create mode 100644 include/drm-uapi/mga_drm.h create mode 100644 include/drm-uapi/msm_drm.h create mode 100644 include/drm-uapi/nouveau_drm.h create mode 100644 include/drm-uapi/omap_drm.h create mode 100644 include/drm-uapi/qxl_drm.h create mode 100644 include/drm-uapi/r128_drm.h create mode 100644 include/drm-uapi/radeon_drm.h create mode 100644 include/drm-uapi/savage_drm.h create mode 100644 include/drm-uapi/sis_drm.h create mode 100644 include/drm-uapi/tegra_drm.h create mode 100644 include/drm-uapi/vc4_drm.h create mode 100644 include/drm-uapi/vgem_drm.h create mode 100644 include/drm-uapi/via_drm.h create mode 100644 include/drm-uapi/virtgpu_drm.h create mode 100644 include/drm-uapi/vmwgfx_drm.h ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] [PATCH i-g-t 0/5] Import drm UAPI headers.
This series imports the UAPI headers from Linux, like we've been doing in Mesa for vc4 and i965. The advantage is that it lets you build new kernel UAPI and testcases together, without needing libdrm releases, and has a simple rule for producing header updates (avoiding the need for the LOCAL_* define hacks that have been proliferating in the tree) I started on converting i915 to not use LOCAL_*, but it's more than I'm willing to complete. Eric Anholt (5): headers: Import drm-next uapi headers. tests: Convert to using the imported drm-uapi headers. tests: Remove libdrm_vc4 dependency. lib: Use the imported uapi's addfb2 defines. lib: Use drm-uapi/i915_drm.h instead of local defines. README |8 + benchmarks/Makefile.am |6 +- benchmarks/gem_wsim.c |6 +- configure.ac | 12 +- include/drm-uapi/amdgpu_drm.h | 930 include/drm-uapi/armada_drm.h | 55 ++ include/drm-uapi/drm.h | 988 + include/drm-uapi/drm_fourcc.h | 410 +++ include/drm-uapi/drm_mode.h| 855 ++ include/drm-uapi/drm_sarea.h | 92 +++ include/drm-uapi/etnaviv_drm.h | 282 include/drm-uapi/exynos_drm.h | 373 ++ include/drm-uapi/i810_drm.h| 291 include/drm-uapi/i915_drm.h| 1542 include/drm-uapi/mga_drm.h | 427 +++ include/drm-uapi/msm_drm.h | 306 include/drm-uapi/nouveau_drm.h | 152 include/drm-uapi/omap_drm.h| 125 include/drm-uapi/qxl_drm.h | 158 include/drm-uapi/r128_drm.h| 336 + include/drm-uapi/radeon_drm.h | 1078 include/drm-uapi/savage_drm.h | 220 ++ include/drm-uapi/sis_drm.h | 77 ++ include/drm-uapi/tegra_drm.h | 209 ++ include/drm-uapi/vc4_drm.h | 359 ++ include/drm-uapi/vgem_drm.h| 62 ++ include/drm-uapi/via_drm.h | 282 include/drm-uapi/virtgpu_drm.h | 174 + include/drm-uapi/vmwgfx_drm.h | 1128 + lib/Makefile.am|7 +- lib/i915/gem_context.c | 46 +- lib/i915/gem_context.h | 19 +- lib/igt_gt.c | 38 +- lib/ioctl_wrappers.c | 71 +- lib/meson.build|6 +- meson.build|3 +- tests/Makefile.am | 16 +- tests/gem_ctx_param.c | 38 +- tests/meson.build | 16 +- 39 files changed, 11032 insertions(+), 171 deletions(-) create mode 100644 include/drm-uapi/amdgpu_drm.h create mode 100644 include/drm-uapi/armada_drm.h create mode 100644 include/drm-uapi/drm.h create mode 100644 include/drm-uapi/drm_fourcc.h create mode 100644 include/drm-uapi/drm_mode.h create mode 100644 include/drm-uapi/drm_sarea.h create mode 100644 include/drm-uapi/etnaviv_drm.h create mode 100644 include/drm-uapi/exynos_drm.h create mode 100644 include/drm-uapi/i810_drm.h create mode 100644 include/drm-uapi/i915_drm.h create mode 100644 include/drm-uapi/mga_drm.h create mode 100644 include/drm-uapi/msm_drm.h create mode 100644 include/drm-uapi/nouveau_drm.h create mode 100644 include/drm-uapi/omap_drm.h create mode 100644 include/drm-uapi/qxl_drm.h create mode 100644 include/drm-uapi/r128_drm.h create mode 100644 include/drm-uapi/radeon_drm.h create mode 100644 include/drm-uapi/savage_drm.h create mode 100644 include/drm-uapi/sis_drm.h create mode 100644 include/drm-uapi/tegra_drm.h create mode 100644 include/drm-uapi/vc4_drm.h create mode 100644 include/drm-uapi/vgem_drm.h create mode 100644 include/drm-uapi/via_drm.h create mode 100644 include/drm-uapi/virtgpu_drm.h create mode 100644 include/drm-uapi/vmwgfx_drm.h -- 2.15.0 ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx