Re: [Intel-gfx] [PATCH i-g-t 1/2] tests/debugfs_test: Try to light all outputs to increase chances of finding fails.

2017-10-25 Thread Maarten Lankhorst 
Op 25-10-17 om 03:36 schreef Pandiyan, Dhinakaran:
> On Wed, 2017-10-11 at 12:28 +0200, Maarten Lankhorst wrote:
>> Op 10-10-17 om 22:12 schreef Chris Wilson:
>>> Quoting Maarten Lankhorst (2017-10-10 17:04:27)
 Make sure read_all_entries has all outputs possible enabled, but also
 add a test that runs with all outputs disabled.

 This will maximize coverage of debugfs reading, and allows the test not
 to be dependent on fbcon for setup.

 Signed-off-by: Maarten Lankhorst 
>>> My only argument, but this is just one special case out of many, isn't
>>> really an argument but an endorsement.
>>>
>>> Reviewed-by: Chris Wilson 
>>> -Chris
>> This test seems to cause a failure in igt..
>>
>> https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_315/fi-glk-1/igt@debugfs_test@read_all_entries.html
>>
>> Dhinakaran, any idea about the DP crc failure?
>>
>> ~Maarten
>>
> I accidentally reproduced this by reading the CRC debugfs when eDP was
> off (pipe was active as per i915_display_info). Wonder if this is an
> indication that the panel did not really light up in your case. It'd be
> good to see what's happening on the screen if you have physical access
> to the machine.

Never mind, I've tracked it down to the enable sequence, when I enable
the connector butnot the primary plane I get this warning. Once I also
enabled the primary plane in the next version I was able to read a CRC. :)

thanks for the help,
Maarten

___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH i-g-t 1/2] tests/debugfs_test: Try to light all outputs to increase chances of finding fails.

2017-10-24 Thread Pandiyan, Dhinakaran 
On Wed, 2017-10-11 at 12:28 +0200, Maarten Lankhorst wrote:
> Op 10-10-17 om 22:12 schreef Chris Wilson:
> > Quoting Maarten Lankhorst (2017-10-10 17:04:27)
> >> Make sure read_all_entries has all outputs possible enabled, but also
> >> add a test that runs with all outputs disabled.
> >>
> >> This will maximize coverage of debugfs reading, and allows the test not
> >> to be dependent on fbcon for setup.
> >>
> >> Signed-off-by: Maarten Lankhorst 
> > My only argument, but this is just one special case out of many, isn't
> > really an argument but an endorsement.
> >
> > Reviewed-by: Chris Wilson 
> > -Chris
> 
> This test seems to cause a failure in igt..
> 
> https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_315/fi-glk-1/igt@debugfs_test@read_all_entries.html
> 
> Dhinakaran, any idea about the DP crc failure?
> 
> ~Maarten
> 

I accidentally reproduced this by reading the CRC debugfs when eDP was
off (pipe was active as per i915_display_info). Wonder if this is an
indication that the panel did not really light up in your case. It'd be
good to see what's happening on the screen if you have physical access
to the machine.
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH i-g-t 1/2] tests/debugfs_test: Try to light all outputs to increase chances of finding fails.

2017-10-11 Thread Maarten Lankhorst 
Op 10-10-17 om 22:12 schreef Chris Wilson:
> Quoting Maarten Lankhorst (2017-10-10 17:04:27)
>> Make sure read_all_entries has all outputs possible enabled, but also
>> add a test that runs with all outputs disabled.
>>
>> This will maximize coverage of debugfs reading, and allows the test not
>> to be dependent on fbcon for setup.
>>
>> Signed-off-by: Maarten Lankhorst 
> My only argument, but this is just one special case out of many, isn't
> really an argument but an endorsement.
>
> Reviewed-by: Chris Wilson 
> -Chris

This test seems to cause a failure in igt..

https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_315/fi-glk-1/igt@debugfs_test@read_all_entries.html

Dhinakaran, any idea about the DP crc failure?

~Maarten

___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH i-g-t 1/2] tests/debugfs_test: Try to light all outputs to increase chances of finding fails.

2017-10-10 Thread Chris Wilson 
Quoting Maarten Lankhorst (2017-10-10 17:04:27)
> Make sure read_all_entries has all outputs possible enabled, but also
> add a test that runs with all outputs disabled.
> 
> This will maximize coverage of debugfs reading, and allows the test not
> to be dependent on fbcon for setup.
> 
> Signed-off-by: Maarten Lankhorst 

My only argument, but this is just one special case out of many, isn't
really an argument but an endorsement.

Reviewed-by: Chris Wilson 
-Chris
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH i-g-t 1/2] tests/debugfs_test: Try to light all outputs to increase chances of finding fails.

2017-10-10 Thread Maarten Lankhorst 
Make sure read_all_entries has all outputs possible enabled, but also
add a test that runs with all outputs disabled.

This will maximize coverage of debugfs reading, and allows the test not
to be dependent on fbcon for setup.

Signed-off-by: Maarten Lankhorst 
---
 tests/debugfs_test.c | 34 ++
 1 file changed, 34 insertions(+)

diff --git a/tests/debugfs_test.c b/tests/debugfs_test.c
index 5e7805e1559e..bf1c5a1b5390 100644
--- a/tests/debugfs_test.c
+++ b/tests/debugfs_test.c
@@ -78,15 +78,48 @@ static void read_and_discard_sysfs_entries(int path_fd)
 igt_main
 {
int fd = -1, debugfs;
+   igt_display_t display;
+
igt_skip_on_simulation();
 
igt_fixture {
fd = drm_open_driver_master(DRIVER_INTEL);
igt_require_gem(fd);
debugfs = igt_debugfs_dir(fd);
+
+   kmstest_set_vt_graphics_mode();
+   igt_display_init(, fd);
}
 
igt_subtest("read_all_entries") {
+   enum pipe pipe;
+
+   /* try to light all pipes */
+   for_each_pipe(, pipe) {
+   igt_output_t *output;
+
+   for_each_valid_output_on_pipe(, pipe, output) {
+   if (output->pending_pipe != PIPE_NONE)
+   continue;
+
+   igt_output_set_pipe(output, pipe);
+   break;
+   }
+   }
+
+   igt_display_commit2(, display.is_atomic ? COMMIT_ATOMIC 
: COMMIT_LEGACY);
+
+   read_and_discard_sysfs_entries(debugfs);
+   }
+
+   igt_subtest("read_all_entries_display_off") {
+   igt_output_t *output;
+
+   for_each_connected_output(, output)
+   igt_output_set_pipe(output, PIPE_NONE);
+
+   igt_display_commit2(, display.is_atomic ? COMMIT_ATOMIC 
: COMMIT_LEGACY);
+
read_and_discard_sysfs_entries(debugfs);
}
 
@@ -112,6 +145,7 @@ igt_main
}
 
igt_fixture {
+   igt_display_fini();
close(debugfs);
close(fd);
}
-- 
2.14.1

___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx