Re: [Intel-gfx] [PATCH igt 2/2] tests/gem_exec_suspend: Add basic s4-devices subtest

[Imre Deak]

On ke, 2016-10-05 at 10:22 +0100, Chris Wilson wrote:
> On Wed, Oct 05, 2016 at 12:04:53PM +0300, Imre Deak wrote:
> > Add a new subtest that performs suspend-to-disk, but instead of
> > doing
> > the full sequence it suspends/resumes only devices. A failed s4
> > subtest
> > and a successful s4-devices subtest would indicate a kernel core or
> > BIOS
> > problem as opposed to some issue in the driver.
> 
> Worth doing for suspend as well? Same argument for easier diagnosis
> of
> any problem.

Yes, can add that. Btw, these pm_test cycles complete faster (for
instance 7 sec for s3-devices vs. 20 sec s3).

> > Signed-off-by: Imre Deak 
> 
> Looks sensible to me.
> -Chris
> 
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH igt 2/2] tests/gem_exec_suspend: Add basic s4-devices subtest

[Chris Wilson]

On Wed, Oct 05, 2016 at 12:04:53PM +0300, Imre Deak wrote:
> Add a new subtest that performs suspend-to-disk, but instead of doing
> the full sequence it suspends/resumes only devices. A failed s4 subtest
> and a successful s4-devices subtest would indicate a kernel core or BIOS
> problem as opposed to some issue in the driver.

Worth doing for suspend as well? Same argument for easier diagnosis of
any problem.
 
> Signed-off-by: Imre Deak 

Looks sensible to me.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH igt 2/2] tests/gem_exec_suspend: Add basic s4-devices subtest

[Imre Deak]

Add a new subtest that performs suspend-to-disk, but instead of doing
the full sequence it suspends/resumes only devices. A failed s4 subtest
and a successful s4-devices subtest would indicate a kernel core or BIOS
problem as opposed to some issue in the driver.

Signed-off-by: Imre Deak 
---
 tests/gem_exec_suspend.c | 10 +-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/tests/gem_exec_suspend.c b/tests/gem_exec_suspend.c
index b953afb..e85d877 100644
--- a/tests/gem_exec_suspend.c
+++ b/tests/gem_exec_suspend.c
@@ -32,7 +32,8 @@
 
 #define NOSLEEP 0
 #define SUSPEND 1
-#define HIBERNATE 2
+#define HIBERNATE_DEVICES 3
+#define HIBERNATE 4
 #define mode(x) ((x) & 0xff)
 
 #define LOCAL_I915_EXEC_BSD_SHIFT  (13)
@@ -210,6 +211,11 @@ static void run_test(int fd, unsigned engine, unsigned 
flags)
  SUSPEND_TEST_NONE);
break;
 
+   case HIBERNATE_DEVICES:
+   igt_system_suspend_autoresume(SUSPEND_STATE_DISK,
+ SUSPEND_TEST_DEVICES);
+   break;
+
case HIBERNATE:
igt_system_suspend_autoresume(SUSPEND_STATE_DISK,
  SUSPEND_TEST_NONE);
@@ -250,6 +256,8 @@ igt_main
run_test(fd, -1, NOSLEEP);
igt_subtest("basic-S3")
run_test(fd, -1, SUSPEND);
+   igt_subtest("basic-S4-devices")
+   run_test(fd, -1, HIBERNATE_DEVICES);
igt_subtest("basic-S4")
run_test(fd, -1, HIBERNATE);
 
-- 
2.5.0

___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx