Re: [Intel-gfx] [PATCH igt v3 05/11] igt/gem_exec_parse: req. v < 9 for oacontrol tracking test

[Matthew Auld]

On 9 November 2016 at 16:15, Robert Bragg  wrote:
> This limits testing the oacontrol tracking (required pairing of oa
> enable/disable per batch buffer) to version <= 8 of the command parser.
>
> Version 9 of the command parser removes all special handling for
> OACONTROL which is now going to be managed by i915-perf and not
> programmed from userspace.
>
> Signed-off-by: Robert Bragg 
Fancy cleaning up the open coded parser_version get param business in
the fixture, and also make it so we do it only once ?

Reviewed-by: Matthew Auld 
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH igt v3 05/11] igt/gem_exec_parse: req. v < 9 for oacontrol tracking test

[Robert Bragg]

This limits testing the oacontrol tracking (required pairing of oa
enable/disable per batch buffer) to version <= 8 of the command parser.

Version 9 of the command parser removes all special handling for
OACONTROL which is now going to be managed by i915-perf and not
programmed from userspace.

Signed-off-by: Robert Bragg 
---
 tests/gem_exec_parse.c | 6 +-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/tests/gem_exec_parse.c b/tests/gem_exec_parse.c
index 2fea060..368f30b 100644
--- a/tests/gem_exec_parse.c
+++ b/tests/gem_exec_parse.c
@@ -349,8 +349,9 @@ static int fd;
 
 igt_main
 {
+   int parser_version = 0;
+
igt_fixture {
-   int parser_version = 0;
 drm_i915_getparam_t gp;
int rc;
 
@@ -521,6 +522,9 @@ igt_main
0x31337000,
MI_BATCH_BUFFER_END,
};
+
+   igt_require(parser_version < 9);
+
exec_batch(fd, handle,
   lri_ok, sizeof(lri_ok),
   I915_EXEC_RENDER,
-- 
2.10.1

___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx