Re: [Intel-gfx] [PATCH v2 4/4] Documentation: drm: describing plane alpha and color blending property

2014-03-26 Thread David Herrmann
Hi

On Tue, Mar 25, 2014 at 3:32 PM,   wrote:
> From: Sagar Kamble 
>
> v2: Added description for "src-color" and "constant-alpha" property.
>
> Cc: Rob Landley 
> Cc: Dave Airlie 
> Cc: Daniel Vetter 
> Cc: Laurent Pinchart 
> Cc: David Herrmann 
> Cc: Alex Deucher 
> Cc: "Ville Syrjälä" 
> Cc: Sagar Kamble 
> Cc: "Purushothaman, Vijay A" 
> Cc: linux-doc at vger.kernel.org
> Cc: dri-devel at lists.freedesktop.org
> Signed-off-by: Sagar Kamble 
> ---
>  Documentation/DocBook/drm.tmpl | 23 ++-
>  1 file changed, 22 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/DocBook/drm.tmpl b/Documentation/DocBook/drm.tmpl
> index 104402a..77a45fb 100644
> --- a/Documentation/DocBook/drm.tmpl
> +++ b/Documentation/DocBook/drm.tmpl
> @@ -2253,6 +2253,14 @@ void intel_crt_init(struct drm_device *dev)
>  enumerated bits defined by the property.
>  
>  
> +  DRM_MODE_PROP_32BIT_PAIR
> +  This flag restricts Bitmask properties restricts 
> all
> +   enumerated values to the 0..31 range.
> +During get operation instance values combine one or more of the
> +enumerated bits defined by the property. During get user can 
> specify
> +   {type, value} pair.

Please rewrite that, lots of typos in there. Furthermore, if you use
verbs as nouns, you should emphasize them. So in your text, please
somehow emphasize/quote 'get'.

Thanks
David

> +
> +
>DRM_MODE_PROP_BLOB
>Blob properties store a binary blob without any 
> format
>  restriction. The binary blobs are created as KMS standalone 
> objects,
> @@ -2336,7 +2344,7 @@ void intel_crt_init(struct drm_device *dev)
> 
> 
> DRM
> -   Generic
> +   Generic
> "EDID"
> BLOB | IMMUTABLE
> 0
> @@ -2351,6 +2359,19 @@ void intel_crt_init(struct drm_device *dev)
> Contains DPMS operation mode value.
> 
> 
> +   "blend"
> +   BITMASK | 32BIT_PAIR
> +   { {0, "zero"}, {1, "one"}, {2, "src-color"}, {3, 
> "one-minus-src-color"}
> +   , {4, "dst-color"}, {5, "one-minus-dst-color"}, {6, "src-alpha"}, {7, 
> "one-minus-src-alpha"}, {8, "dst-alpha"}
> +   , {9, "one-minus-dst-alpha"}, {10, "constant-color"}, {11, 
> "one-minus-constant-color"}, {12, "constant-alpha"}
> +   , {13, "one-minus-constant-alpha"}, {14, "alpha-saturate"} }
> +   Plane
> +   Contains plane alpha/color blending operation 
> values. These are modeled after glBlendFunc API
> +   in OpenGL. Currently only "src-color" and "constant-alpha" are 
> supported. "src-color" will consider supplied fb
> +   with plane's pixel format as input without any additional color/alpha 
> changes."constant-alpha" will apply constant
> +   transparency to all pixels in addition to source color.
> +   
> +   
> DVI-I
> "subconnector"
> ENUM
> --
> 1.8.5
>
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx


[Intel-gfx] [PATCH v2 4/4] Documentation: drm: describing plane alpha and color blending property

2014-03-25 Thread sagar . a . kamble
From: Sagar Kamble 

v2: Added description for "src-color" and "constant-alpha" property.

Cc: Rob Landley 
Cc: Dave Airlie 
Cc: Daniel Vetter 
Cc: Laurent Pinchart 
Cc: David Herrmann 
Cc: Alex Deucher 
Cc: "Ville Syrjälä" 
Cc: Sagar Kamble 
Cc: "Purushothaman, Vijay A" 
Cc: linux-doc at vger.kernel.org
Cc: dri-devel at lists.freedesktop.org
Signed-off-by: Sagar Kamble 
---
 Documentation/DocBook/drm.tmpl | 23 ++-
 1 file changed, 22 insertions(+), 1 deletion(-)

diff --git a/Documentation/DocBook/drm.tmpl b/Documentation/DocBook/drm.tmpl
index 104402a..77a45fb 100644
--- a/Documentation/DocBook/drm.tmpl
+++ b/Documentation/DocBook/drm.tmpl
@@ -2253,6 +2253,14 @@ void intel_crt_init(struct drm_device *dev)
 enumerated bits defined by the property.
 
 
+  DRM_MODE_PROP_32BIT_PAIR
+  This flag restricts Bitmask properties restricts all
+   enumerated values to the 0..31 range.
+During get operation instance values combine one or more of the
+enumerated bits defined by the property. During get user can 
specify
+   {type, value} pair.
+
+
   DRM_MODE_PROP_BLOB
   Blob properties store a binary blob without any 
format
 restriction. The binary blobs are created as KMS standalone 
objects,
@@ -2336,7 +2344,7 @@ void intel_crt_init(struct drm_device *dev)


DRM
-   Generic
+   Generic
“EDID”
BLOB | IMMUTABLE
0
@@ -2351,6 +2359,19 @@ void intel_crt_init(struct drm_device *dev)
Contains DPMS operation mode value.


+   “blend”
+   BITMASK | 32BIT_PAIR
+   { {0, "zero"}, {1, "one"}, {2, "src-color"}, {3, 
"one-minus-src-color"}
+   , {4, "dst-color"}, {5, "one-minus-dst-color"}, {6, "src-alpha"}, {7, 
"one-minus-src-alpha"}, {8, "dst-alpha"}
+   , {9, "one-minus-dst-alpha"}, {10, "constant-color"}, {11, 
"one-minus-constant-color"}, {12, "constant-alpha"}
+   , {13, "one-minus-constant-alpha"}, {14, "alpha-saturate"} }
+   Plane
+   Contains plane alpha/color blending operation values. 
These are modeled after glBlendFunc API
+   in OpenGL. Currently only "src-color" and "constant-alpha" are 
supported. "src-color" will consider supplied fb
+   with plane's pixel format as input without any additional color/alpha 
changes."constant-alpha" will apply constant
+   transparency to all pixels in addition to source color.
+   
+   
DVI-I
“subconnector”
ENUM
-- 
1.8.5

___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx