On Wed, Sep 06, 2023 at 01:02:19PM -0600, Jim Cromie wrote:
> By at least strong convention, a print-buffer's trailing newline says
> "message complete, send it". The exception (no TNL, followed by a call
> to pr_cont) proves the general rule.
>
> Most DRM.debug calls already comport with this: 207 DRM_DEV_DEBUG,
> 1288 drm_dbg. Clean up the remainders, in maintainer sized chunks.
>
> No functional changes.
>
> Signed-off-by: Jim Cromie
> ---
> drivers/gpu/drm/drm_connector.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connector.c
> index f28725736237..14020585bdc0 100644
> --- a/drivers/gpu/drm/drm_connector.c
> +++ b/drivers/gpu/drm/drm_connector.c
> @@ -2925,7 +2925,9 @@ int drm_mode_getconnector(struct drm_device *dev, void
> *data,
>dev->mode_config.max_width,
>
> dev->mode_config.max_height);
> else
> - drm_dbg_kms(dev, "User-space requested a forced probe
> on [CONNECTOR:%d:%s] but is not the DRM master, demoting to read-only probe",
> + drm_dbg_kms(dev,
> + "User-space requested a forced probe on
> [CONNECTOR:%d:%s] "
> + "but is not the DRM master, demoting to
> read-only probe\n",
> connector->base.id, connector->name);
I'm fine with the general idea behind this patch, but we shouldn't break
the message itself.
See
https://www.kernel.org/doc/html/latest/process/coding-style.html#breaking-long-lines-and-strings
Maxime
signature.asc
Description: PGP signature
