Re: [Intel-gfx] [PATCH v9 22/24] drm/i915/fec: Set FEC_READY in FEC_CONFIGURATION
On Mon, Nov 19, 2018 at 10:19:42PM +0200, Ville Syrjälä wrote: > On Tue, Nov 13, 2018 at 05:52:30PM -0800, Manasi Navare wrote: > > From: Anusha Srivatsa > > > > If the panel supports FEC, the driver has to > > set the FEC_READY bit in the dpcd register: > > FEC_CONFIGURATION. > > > > This has to happen before link training. > > > > v2: s/intel_dp_set_fec_ready/intel_dp_sink_set_fec_ready > >- change commit message. (Gaurav) > > > > v3: rebased. (r-b Manasi) > > > > v4: Use fec crtc state, before setting FEC_READY > > bit. (Anusha) > > > > v5: Move to intel_ddi.c > > - Make the function static (Anusha) > > > > v6: Dont pass state as a separate argument (Ville) > > > > Cc: dri-de...@lists.freedesktop.org > > Cc: Gaurav K Singh > > Cc: Jani Nikula > > Cc: Ville Syrjala > > Cc: Manasi Navare > > Signed-off-by: Anusha Srivatsa > > Reviewed-by: Manasi Navare > > --- > > drivers/gpu/drm/i915/intel_ddi.c | 11 +++ > > 1 file changed, 11 insertions(+) > > > > diff --git a/drivers/gpu/drm/i915/intel_ddi.c > > b/drivers/gpu/drm/i915/intel_ddi.c > > index 0638fd2febfb..2d15520f13c5 100644 > > --- a/drivers/gpu/drm/i915/intel_ddi.c > > +++ b/drivers/gpu/drm/i915/intel_ddi.c > > @@ -3102,6 +3102,16 @@ static void icl_program_mg_dp_mode(struct > > intel_digital_port *intel_dig_port) > > I915_WRITE(MG_DP_MODE(port, 1), ln1); > > } > > > > +static void intel_dp_sink_set_fec_ready(struct intel_dp *intel_dp, > > + const struct intel_crtc_state > > *crtc_state) > > +{ > > + if (!crtc_state->fec_enable) > > + return; > > + > > + if (drm_dp_dpcd_writeb(_dp->aux, DP_FEC_CONFIGURATION, > > DP_FEC_READY) <= 0) > > + DRM_DEBUG_KMS("Failed to get FEC enabled in sink\n"); > > The debug message is still bonkers. Should I get rid of the debug message here? Manasi > > > +} > > + > > static void intel_ddi_pre_enable_dp(struct intel_encoder *encoder, > > const struct intel_crtc_state *crtc_state, > > const struct drm_connector_state > > *conn_state) > > @@ -3142,6 +3152,7 @@ static void intel_ddi_pre_enable_dp(struct > > intel_encoder *encoder, > > intel_dp_sink_dpms(intel_dp, DRM_MODE_DPMS_ON); > > intel_dp_sink_set_decompression_state(intel_dp, crtc_state, > > true); > > + intel_dp_sink_set_fec_ready(intel_dp, crtc_state); > > intel_dp_start_link_train(intel_dp); > > if (port != PORT_A || INTEL_GEN(dev_priv) >= 9) > > intel_dp_stop_link_train(intel_dp); > > -- > > 2.19.1 > > -- > Ville Syrjälä > Intel > ___ > dri-devel mailing list > dri-de...@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH v9 22/24] drm/i915/fec: Set FEC_READY in FEC_CONFIGURATION
On Mon, Nov 19, 2018 at 10:19:42PM +0200, Ville Syrjälä wrote: > On Tue, Nov 13, 2018 at 05:52:30PM -0800, Manasi Navare wrote: > > From: Anusha Srivatsa > > > > If the panel supports FEC, the driver has to > > set the FEC_READY bit in the dpcd register: > > FEC_CONFIGURATION. > > > > This has to happen before link training. > > > > v2: s/intel_dp_set_fec_ready/intel_dp_sink_set_fec_ready > >- change commit message. (Gaurav) > > > > v3: rebased. (r-b Manasi) > > > > v4: Use fec crtc state, before setting FEC_READY > > bit. (Anusha) > > > > v5: Move to intel_ddi.c > > - Make the function static (Anusha) > > > > v6: Dont pass state as a separate argument (Ville) > > > > Cc: dri-de...@lists.freedesktop.org > > Cc: Gaurav K Singh > > Cc: Jani Nikula > > Cc: Ville Syrjala > > Cc: Manasi Navare > > Signed-off-by: Anusha Srivatsa > > Reviewed-by: Manasi Navare > > --- > > drivers/gpu/drm/i915/intel_ddi.c | 11 +++ > > 1 file changed, 11 insertions(+) > > > > diff --git a/drivers/gpu/drm/i915/intel_ddi.c > > b/drivers/gpu/drm/i915/intel_ddi.c > > index 0638fd2febfb..2d15520f13c5 100644 > > --- a/drivers/gpu/drm/i915/intel_ddi.c > > +++ b/drivers/gpu/drm/i915/intel_ddi.c > > @@ -3102,6 +3102,16 @@ static void icl_program_mg_dp_mode(struct > > intel_digital_port *intel_dig_port) > > I915_WRITE(MG_DP_MODE(port, 1), ln1); > > } > > > > +static void intel_dp_sink_set_fec_ready(struct intel_dp *intel_dp, > > + const struct intel_crtc_state > > *crtc_state) > > +{ > > + if (!crtc_state->fec_enable) > > + return; > > + > > + if (drm_dp_dpcd_writeb(_dp->aux, DP_FEC_CONFIGURATION, > > DP_FEC_READY) <= 0) > > + DRM_DEBUG_KMS("Failed to get FEC enabled in sink\n"); > > The debug message is still bonkers. Havent we always had a debug print on drm_dp_dpcd_write() calls? Manasi > > > +} > > + > > static void intel_ddi_pre_enable_dp(struct intel_encoder *encoder, > > const struct intel_crtc_state *crtc_state, > > const struct drm_connector_state > > *conn_state) > > @@ -3142,6 +3152,7 @@ static void intel_ddi_pre_enable_dp(struct > > intel_encoder *encoder, > > intel_dp_sink_dpms(intel_dp, DRM_MODE_DPMS_ON); > > intel_dp_sink_set_decompression_state(intel_dp, crtc_state, > > true); > > + intel_dp_sink_set_fec_ready(intel_dp, crtc_state); > > intel_dp_start_link_train(intel_dp); > > if (port != PORT_A || INTEL_GEN(dev_priv) >= 9) > > intel_dp_stop_link_train(intel_dp); > > -- > > 2.19.1 > > -- > Ville Syrjälä > Intel > ___ > dri-devel mailing list > dri-de...@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH v9 22/24] drm/i915/fec: Set FEC_READY in FEC_CONFIGURATION
On Tue, Nov 13, 2018 at 05:52:30PM -0800, Manasi Navare wrote: > From: Anusha Srivatsa > > If the panel supports FEC, the driver has to > set the FEC_READY bit in the dpcd register: > FEC_CONFIGURATION. > > This has to happen before link training. > > v2: s/intel_dp_set_fec_ready/intel_dp_sink_set_fec_ready >- change commit message. (Gaurav) > > v3: rebased. (r-b Manasi) > > v4: Use fec crtc state, before setting FEC_READY > bit. (Anusha) > > v5: Move to intel_ddi.c > - Make the function static (Anusha) > > v6: Dont pass state as a separate argument (Ville) > > Cc: dri-de...@lists.freedesktop.org > Cc: Gaurav K Singh > Cc: Jani Nikula > Cc: Ville Syrjala > Cc: Manasi Navare > Signed-off-by: Anusha Srivatsa > Reviewed-by: Manasi Navare > --- > drivers/gpu/drm/i915/intel_ddi.c | 11 +++ > 1 file changed, 11 insertions(+) > > diff --git a/drivers/gpu/drm/i915/intel_ddi.c > b/drivers/gpu/drm/i915/intel_ddi.c > index 0638fd2febfb..2d15520f13c5 100644 > --- a/drivers/gpu/drm/i915/intel_ddi.c > +++ b/drivers/gpu/drm/i915/intel_ddi.c > @@ -3102,6 +3102,16 @@ static void icl_program_mg_dp_mode(struct > intel_digital_port *intel_dig_port) > I915_WRITE(MG_DP_MODE(port, 1), ln1); > } > > +static void intel_dp_sink_set_fec_ready(struct intel_dp *intel_dp, > + const struct intel_crtc_state > *crtc_state) > +{ > + if (!crtc_state->fec_enable) > + return; > + > + if (drm_dp_dpcd_writeb(_dp->aux, DP_FEC_CONFIGURATION, > DP_FEC_READY) <= 0) > + DRM_DEBUG_KMS("Failed to get FEC enabled in sink\n"); The debug message is still bonkers. > +} > + > static void intel_ddi_pre_enable_dp(struct intel_encoder *encoder, > const struct intel_crtc_state *crtc_state, > const struct drm_connector_state > *conn_state) > @@ -3142,6 +3152,7 @@ static void intel_ddi_pre_enable_dp(struct > intel_encoder *encoder, > intel_dp_sink_dpms(intel_dp, DRM_MODE_DPMS_ON); > intel_dp_sink_set_decompression_state(intel_dp, crtc_state, > true); > + intel_dp_sink_set_fec_ready(intel_dp, crtc_state); > intel_dp_start_link_train(intel_dp); > if (port != PORT_A || INTEL_GEN(dev_priv) >= 9) > intel_dp_stop_link_train(intel_dp); > -- > 2.19.1 -- Ville Syrjälä Intel ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] [PATCH v9 22/24] drm/i915/fec: Set FEC_READY in FEC_CONFIGURATION
From: Anusha Srivatsa If the panel supports FEC, the driver has to set the FEC_READY bit in the dpcd register: FEC_CONFIGURATION. This has to happen before link training. v2: s/intel_dp_set_fec_ready/intel_dp_sink_set_fec_ready - change commit message. (Gaurav) v3: rebased. (r-b Manasi) v4: Use fec crtc state, before setting FEC_READY bit. (Anusha) v5: Move to intel_ddi.c - Make the function static (Anusha) v6: Dont pass state as a separate argument (Ville) Cc: dri-de...@lists.freedesktop.org Cc: Gaurav K Singh Cc: Jani Nikula Cc: Ville Syrjala Cc: Manasi Navare Signed-off-by: Anusha Srivatsa Reviewed-by: Manasi Navare --- drivers/gpu/drm/i915/intel_ddi.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c index 0638fd2febfb..2d15520f13c5 100644 --- a/drivers/gpu/drm/i915/intel_ddi.c +++ b/drivers/gpu/drm/i915/intel_ddi.c @@ -3102,6 +3102,16 @@ static void icl_program_mg_dp_mode(struct intel_digital_port *intel_dig_port) I915_WRITE(MG_DP_MODE(port, 1), ln1); } +static void intel_dp_sink_set_fec_ready(struct intel_dp *intel_dp, + const struct intel_crtc_state *crtc_state) +{ + if (!crtc_state->fec_enable) + return; + + if (drm_dp_dpcd_writeb(_dp->aux, DP_FEC_CONFIGURATION, DP_FEC_READY) <= 0) + DRM_DEBUG_KMS("Failed to get FEC enabled in sink\n"); +} + static void intel_ddi_pre_enable_dp(struct intel_encoder *encoder, const struct intel_crtc_state *crtc_state, const struct drm_connector_state *conn_state) @@ -3142,6 +3152,7 @@ static void intel_ddi_pre_enable_dp(struct intel_encoder *encoder, intel_dp_sink_dpms(intel_dp, DRM_MODE_DPMS_ON); intel_dp_sink_set_decompression_state(intel_dp, crtc_state, true); + intel_dp_sink_set_fec_ready(intel_dp, crtc_state); intel_dp_start_link_train(intel_dp); if (port != PORT_A || INTEL_GEN(dev_priv) >= 9) intel_dp_stop_link_train(intel_dp); -- 2.19.1 ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx