Re: [Intel-gfx] [PATCHv3] drm/i915: Support Async Flip on Linear buffers
> -Original Message- > From: Lisovskiy, Stanislav > Sent: Monday, March 13, 2023 3:01 PM > To: Murthy, Arun R > Cc: intel-gfx@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCHv3] drm/i915: Support Async Flip on Linear > buffers > > On Tue, Sep 06, 2022 at 09:48:06AM +0530, Arun R Murthy wrote: > > Starting from Gen12 Async Flip is supported on linear buffers. > > This patch enables support for async on linear buffer. > > > > UseCase: In Hybrid graphics, for hardware unsupported pixel formats it > > will be converted to linear memory and then composed. > > > > v2: Added use case > > v3: Added FIXME for ICL indicating the restrictions > > > > Signed-off-by: Arun R Murthy > > Reviewed-by: Stanislav Lisovskiy > Thanks for the review! Can this patch be merged now? Thanks and Regards, Arun R Murthy
Re: [Intel-gfx] [PATCHv3] drm/i915: Support Async Flip on Linear buffers
On Tue, Sep 06, 2022 at 09:48:06AM +0530, Arun R Murthy wrote:
> Starting from Gen12 Async Flip is supported on linear buffers.
> This patch enables support for async on linear buffer.
>
> UseCase: In Hybrid graphics, for hardware unsupported pixel formats it
> will be converted to linear memory and then composed.
>
> v2: Added use case
> v3: Added FIXME for ICL indicating the restrictions
>
> Signed-off-by: Arun R Murthy
Reviewed-by: Stanislav Lisovskiy
> ---
> drivers/gpu/drm/i915/display/intel_display.c | 14 ++
> 1 file changed, 14 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display.c
> b/drivers/gpu/drm/i915/display/intel_display.c
> index be7cff722196..f0d2c3cb3bd5 100644
> --- a/drivers/gpu/drm/i915/display/intel_display.c
> +++ b/drivers/gpu/drm/i915/display/intel_display.c
> @@ -6610,6 +6610,20 @@ static int intel_async_flip_check_hw(struct
> intel_atomic_state *state, struct in
>* this selectively if required.
>*/
> switch (new_plane_state->hw.fb->modifier) {
> + case DRM_FORMAT_MOD_LINEAR:
> + /*
> + * FIXME: Async on Linear buffer is supported on ICL as
> + * but with additional alignment and fbc restrictions
> + * need to be taken care of. These aren't applicable for
> + * gen12+.
> + */
> + if (DISPLAY_VER(i915) < 12) {
> + drm_dbg_kms(>drm,
> + "[PLANE:%d:%s] Modifier does not
> support async flips\n",
> + plane->base.base.id,
> plane->base.name);
> + return -EINVAL;
> + }
> +
> case I915_FORMAT_MOD_X_TILED:
> case I915_FORMAT_MOD_Y_TILED:
> case I915_FORMAT_MOD_Yf_TILED:
> --
> 2.25.1
>
Re: [Intel-gfx] [PATCHv3] drm/i915: Support Async Flip on Linear buffers
> -Original Message- > From: Murthy, Arun R > Sent: Thursday, February 2, 2023 4:59 PM > To: Ville Syrjälä > Cc: intel-gfx@lists.freedesktop.org; Syrjala, Ville > Subject: RE: [Intel-gfx] [PATCHv3] drm/i915: Support Async Flip on Linear > buffers > > > -Original Message- > > From: Ville Syrjälä > > Sent: Thursday, February 2, 2023 2:54 PM > > To: Murthy, Arun R > > Cc: intel-gfx@lists.freedesktop.org; Syrjala, Ville > > > > Subject: Re: [Intel-gfx] [PATCHv3] drm/i915: Support Async Flip on > > Linear buffers > > > > On Thu, Feb 02, 2023 at 06:51:49AM +, Murthy, Arun R wrote: > > > Gentle Reminder! > > > The patch is pending since a long time. > > > > Please review the igt changes here: > > https://patchwork.freedesktop.org/series/113525/ > > then we can actually test this (and any other new modifier in the future). > > > Done! > This patch is to add support for linear buffer in the driver and shouldn't > conflict with the IGT patch series > https://patchwork.freedesktop.org/series/113525/ > Since this patch doesn't conflict with the IGT series https://patchwork.freedesktop.org/series/113525/ Can this patch be reviewed and merged? Thanks and Regards, Arun R Murthy > Thanks and Regards, > Arun R Murthy > > > > > > > > Thanks and Regards, > > > Arun R Murthy > > > --- > > > > > > > -Original Message----- > > > > From: Murthy, Arun R > > > > Sent: Monday, January 23, 2023 12:14 PM > > > > To: 'Ville Syrjälä' > > > > Cc: 'intel-gfx@lists.freedesktop.org' > > > > ; > > > > Syrjala, Ville > > > > Subject: RE: [Intel-gfx] [PATCHv3] drm/i915: Support Async Flip on > > > > Linear buffers > > > > > > > > Any review comments on this. Gentle Reminder! > > > > > > > > Thanks and Regards, > > > > Arun R Murthy > > > > > > > > > > > > > -Original Message- > > > > > From: Murthy, Arun R > > > > > Sent: Tuesday, January 17, 2023 2:09 PM > > > > > To: 'Ville Syrjälä' > > > > > Cc: 'intel-gfx@lists.freedesktop.org' > > > > > ; > > > > > Syrjala, Ville > > > > > Subject: RE: [Intel-gfx] [PATCHv3] drm/i915: Support Async Flip > > > > > on Linear buffers > > > > > > > > > > Gentle Reminder! > > > > > > > > > > Thanks and Regards, > > > > > Arun R Murthy > > > > > --- > > > > > > > > > > > -Original Message- > > > > > > From: Murthy, Arun R > > > > > > Sent: Friday, January 13, 2023 12:57 PM > > > > > > To: Ville Syrjälä > > > > > > Cc: intel-gfx@lists.freedesktop.org; Syrjala, Ville > > > > > > > > > > > > Subject: RE: [Intel-gfx] [PATCHv3] drm/i915: Support Async > > > > > > Flip on Linear buffers > > > > > > > > > > > > > On Fri, Oct 28, 2022 at 03:23:02AM +, Murthy, Arun R wrote: > > > > > > > > Gentle Reminder! > > > > > > > > > > > > > > Is the igt stuff merged, and did this pass the test? > > > > > > > > > > > > > With IGT alone the tests will fail without the kernel patch. > > > > > > The > > > > > > tests(https://intel-gfx-ci.01.org/tree/drm-tip/Trybot_112722v2 > > > > > > /s > > > > > > hard > > > > > > s- > > > > > > all.html?testfilter=kms_async_flips) are passing with IGT and > > > > > > kernel > > > > patch. > > > > > > > > > > > > Thanks and Regards, > > > > > > Arun R Murthy > > > > > > > > > > > > > > > > > > > > > > > -Original Message- > > > > > > > > > From: Murthy, Arun R > > > > > > > > > Sent: Monday, October 10, 2022 1:24 PM > > > > > > > > > To: 'intel-gfx@lists.freedesktop.org' > > > > > > > > > > > > > > > > > > Cc: Syrjala, Ville > > > > > > > > >
Re: [Intel-gfx] [PATCHv3] drm/i915: Support Async Flip on Linear buffers
> -Original Message- > From: Ville Syrjälä > Sent: Thursday, February 2, 2023 2:54 PM > To: Murthy, Arun R > Cc: intel-gfx@lists.freedesktop.org; Syrjala, Ville > Subject: Re: [Intel-gfx] [PATCHv3] drm/i915: Support Async Flip on Linear > buffers > > On Thu, Feb 02, 2023 at 06:51:49AM +, Murthy, Arun R wrote: > > Gentle Reminder! > > The patch is pending since a long time. > > Please review the igt changes here: > https://patchwork.freedesktop.org/series/113525/ > then we can actually test this (and any other new modifier in the future). > Done! This patch is to add support for linear buffer in the driver and shouldn't conflict with the IGT patch series https://patchwork.freedesktop.org/series/113525/ Thanks and Regards, Arun R Murthy > > > > Thanks and Regards, > > Arun R Murthy > > --- > > > > > -Original Message- > > > From: Murthy, Arun R > > > Sent: Monday, January 23, 2023 12:14 PM > > > To: 'Ville Syrjälä' > > > Cc: 'intel-gfx@lists.freedesktop.org' > > > ; > > > Syrjala, Ville > > > Subject: RE: [Intel-gfx] [PATCHv3] drm/i915: Support Async Flip on > > > Linear buffers > > > > > > Any review comments on this. Gentle Reminder! > > > > > > Thanks and Regards, > > > Arun R Murthy > > > > > > > > > > -----Original Message----- > > > > From: Murthy, Arun R > > > > Sent: Tuesday, January 17, 2023 2:09 PM > > > > To: 'Ville Syrjälä' > > > > Cc: 'intel-gfx@lists.freedesktop.org' > > > > ; > > > > Syrjala, Ville > > > > Subject: RE: [Intel-gfx] [PATCHv3] drm/i915: Support Async Flip on > > > > Linear buffers > > > > > > > > Gentle Reminder! > > > > > > > > Thanks and Regards, > > > > Arun R Murthy > > > > --- > > > > > > > > > -Original Message- > > > > > From: Murthy, Arun R > > > > > Sent: Friday, January 13, 2023 12:57 PM > > > > > To: Ville Syrjälä > > > > > Cc: intel-gfx@lists.freedesktop.org; Syrjala, Ville > > > > > > > > > > Subject: RE: [Intel-gfx] [PATCHv3] drm/i915: Support Async Flip > > > > > on Linear buffers > > > > > > > > > > > On Fri, Oct 28, 2022 at 03:23:02AM +, Murthy, Arun R wrote: > > > > > > > Gentle Reminder! > > > > > > > > > > > > Is the igt stuff merged, and did this pass the test? > > > > > > > > > > > With IGT alone the tests will fail without the kernel patch. > > > > > The > > > > > tests(https://intel-gfx-ci.01.org/tree/drm-tip/Trybot_112722v2/s > > > > > hard > > > > > s- > > > > > all.html?testfilter=kms_async_flips) are passing with IGT and > > > > > kernel > > > patch. > > > > > > > > > > Thanks and Regards, > > > > > Arun R Murthy > > > > > > > > > > > > > > > > > > > > -Original Message- > > > > > > > > From: Murthy, Arun R > > > > > > > > Sent: Monday, October 10, 2022 1:24 PM > > > > > > > > To: 'intel-gfx@lists.freedesktop.org' > > > > > > > > > > > > > > > > Cc: Syrjala, Ville > > > > > > > > Subject: RE: [PATCHv3] drm/i915: Support Async Flip on > > > > > > > > Linear buffers > > > > > > > > > > > > > > > > Ville, > > > > > > > > Gentle reminder! > > > > > > > > > > > > > > > > Thanks and Regards, > > > > > > > > Arun R Murthy > > > > > > > > > > > > > > > > > > > > > > > > > -Original Message- > > > > > > > > > From: Murthy, Arun R > > > > > > > > > Sent: Monday, September 19, 2022 10:38 AM > > > > > > > > > To: 'intel-gfx@lists.freedesktop.org' > > > > > > > > > > > > > > > > > > Cc: Syrjala, Ville > > > > > > > > > Subject: RE: [PATCHv3] drm/i915: Support Async
Re: [Intel-gfx] [PATCHv3] drm/i915: Support Async Flip on Linear buffers
On Thu, Feb 02, 2023 at 06:51:49AM +, Murthy, Arun R wrote: > Gentle Reminder! > The patch is pending since a long time. Please review the igt changes here: https://patchwork.freedesktop.org/series/113525/ then we can actually test this (and any other new modifier in the future). > > Thanks and Regards, > Arun R Murthy > --- > > > -Original Message- > > From: Murthy, Arun R > > Sent: Monday, January 23, 2023 12:14 PM > > To: 'Ville Syrjälä' > > Cc: 'intel-gfx@lists.freedesktop.org' ; > > Syrjala, Ville > > Subject: RE: [Intel-gfx] [PATCHv3] drm/i915: Support Async Flip on Linear > > buffers > > > > Any review comments on this. Gentle Reminder! > > > > Thanks and Regards, > > Arun R Murthy > > > > > > > -Original Message- > > > From: Murthy, Arun R > > > Sent: Tuesday, January 17, 2023 2:09 PM > > > To: 'Ville Syrjälä' > > > Cc: 'intel-gfx@lists.freedesktop.org' > > > ; > > > Syrjala, Ville > > > Subject: RE: [Intel-gfx] [PATCHv3] drm/i915: Support Async Flip on > > > Linear buffers > > > > > > Gentle Reminder! > > > > > > Thanks and Regards, > > > Arun R Murthy > > > ------- > > > > > > > -Original Message----- > > > > From: Murthy, Arun R > > > > Sent: Friday, January 13, 2023 12:57 PM > > > > To: Ville Syrjälä > > > > Cc: intel-gfx@lists.freedesktop.org; Syrjala, Ville > > > > > > > > Subject: RE: [Intel-gfx] [PATCHv3] drm/i915: Support Async Flip on > > > > Linear buffers > > > > > > > > > On Fri, Oct 28, 2022 at 03:23:02AM +, Murthy, Arun R wrote: > > > > > > Gentle Reminder! > > > > > > > > > > Is the igt stuff merged, and did this pass the test? > > > > > > > > > With IGT alone the tests will fail without the kernel patch. > > > > The > > > > tests(https://intel-gfx-ci.01.org/tree/drm-tip/Trybot_112722v2/shard > > > > s- > > > > all.html?testfilter=kms_async_flips) are passing with IGT and kernel > > patch. > > > > > > > > Thanks and Regards, > > > > Arun R Murthy > > > > > > > > > > > > > > > > > -Original Message- > > > > > > > From: Murthy, Arun R > > > > > > > Sent: Monday, October 10, 2022 1:24 PM > > > > > > > To: 'intel-gfx@lists.freedesktop.org' > > > > > > > > > > > > > > Cc: Syrjala, Ville > > > > > > > Subject: RE: [PATCHv3] drm/i915: Support Async Flip on Linear > > > > > > > buffers > > > > > > > > > > > > > > Ville, > > > > > > > Gentle reminder! > > > > > > > > > > > > > > Thanks and Regards, > > > > > > > Arun R Murthy > > > > > > > > > > > > > > > > > > > > > > -Original Message- > > > > > > > > From: Murthy, Arun R > > > > > > > > Sent: Monday, September 19, 2022 10:38 AM > > > > > > > > To: 'intel-gfx@lists.freedesktop.org' > > > > > > > > > > > > > > > > Cc: Syrjala, Ville > > > > > > > > Subject: RE: [PATCHv3] drm/i915: Support Async Flip on > > > > > > > > Linear buffers > > > > > > > > > > > > > > > > If no comments, can anyone merge the patch! > > > > > > > > > > > > > > > > Thanks and Regards, > > > > > > > > Arun R Murthy > > > > > > > > > > > > > > > > > > > > > > > > > -Original Message- > > > > > > > > > From: Murthy, Arun R > > > > > > > > > Sent: Wednesday, September 14, 2022 4:21 PM > > > > > > > > > To: Murthy, Arun R ; intel- > > > > > > > > > g...@lists.freedesktop.org > > > > > > > > > Cc: Syrjala, Ville > > > > > > > > > Subject: RE: [PATCHv3] drm/i915: Support Async Flip on > > > > > > > > > Linear buffers > > &
Re: [Intel-gfx] [PATCHv3] drm/i915: Support Async Flip on Linear buffers
Gentle Reminder! The patch is pending since a long time. Thanks and Regards, Arun R Murthy --- > -Original Message- > From: Murthy, Arun R > Sent: Monday, January 23, 2023 12:14 PM > To: 'Ville Syrjälä' > Cc: 'intel-gfx@lists.freedesktop.org' ; > Syrjala, Ville > Subject: RE: [Intel-gfx] [PATCHv3] drm/i915: Support Async Flip on Linear > buffers > > Any review comments on this. Gentle Reminder! > > Thanks and Regards, > Arun R Murthy > > > > -Original Message- > > From: Murthy, Arun R > > Sent: Tuesday, January 17, 2023 2:09 PM > > To: 'Ville Syrjälä' > > Cc: 'intel-gfx@lists.freedesktop.org' > > ; > > Syrjala, Ville > > Subject: RE: [Intel-gfx] [PATCHv3] drm/i915: Support Async Flip on > > Linear buffers > > > > Gentle Reminder! > > > > Thanks and Regards, > > Arun R Murthy > > --- > > > > > -Original Message- > > > From: Murthy, Arun R > > > Sent: Friday, January 13, 2023 12:57 PM > > > To: Ville Syrjälä > > > Cc: intel-gfx@lists.freedesktop.org; Syrjala, Ville > > > > > > Subject: RE: [Intel-gfx] [PATCHv3] drm/i915: Support Async Flip on > > > Linear buffers > > > > > > > On Fri, Oct 28, 2022 at 03:23:02AM +, Murthy, Arun R wrote: > > > > > Gentle Reminder! > > > > > > > > Is the igt stuff merged, and did this pass the test? > > > > > > > With IGT alone the tests will fail without the kernel patch. > > > The > > > tests(https://intel-gfx-ci.01.org/tree/drm-tip/Trybot_112722v2/shard > > > s- > > > all.html?testfilter=kms_async_flips) are passing with IGT and kernel > patch. > > > > > > Thanks and Regards, > > > Arun R Murthy > > > > > > > > > > > > > > -Original Message- > > > > > > From: Murthy, Arun R > > > > > > Sent: Monday, October 10, 2022 1:24 PM > > > > > > To: 'intel-gfx@lists.freedesktop.org' > > > > > > > > > > > > Cc: Syrjala, Ville > > > > > > Subject: RE: [PATCHv3] drm/i915: Support Async Flip on Linear > > > > > > buffers > > > > > > > > > > > > Ville, > > > > > > Gentle reminder! > > > > > > > > > > > > Thanks and Regards, > > > > > > Arun R Murthy > > > > > > > > > > > > > > > > > > > -Original Message- > > > > > > > From: Murthy, Arun R > > > > > > > Sent: Monday, September 19, 2022 10:38 AM > > > > > > > To: 'intel-gfx@lists.freedesktop.org' > > > > > > > > > > > > > > Cc: Syrjala, Ville > > > > > > > Subject: RE: [PATCHv3] drm/i915: Support Async Flip on > > > > > > > Linear buffers > > > > > > > > > > > > > > If no comments, can anyone merge the patch! > > > > > > > > > > > > > > Thanks and Regards, > > > > > > > Arun R Murthy > > > > > > > -------- > > > > > > > > > > > > > > > -Original Message- > > > > > > > > From: Murthy, Arun R > > > > > > > > Sent: Wednesday, September 14, 2022 4:21 PM > > > > > > > > To: Murthy, Arun R ; intel- > > > > > > > > g...@lists.freedesktop.org > > > > > > > > Cc: Syrjala, Ville > > > > > > > > Subject: RE: [PATCHv3] drm/i915: Support Async Flip on > > > > > > > > Linear buffers > > > > > > > > > > > > > > > > Gentle Reminder! > > > > > > > > Any comments? > > > > > > > > > > > > > > > > Thanks and Regards, > > > > > > > > Arun R Murthy > > > > > > > > > > > > > > > > > > > > > > > > > -Original Message- > > > > > > > > > From: Intel-gfx > > > > > > > > > > > > > > > > > > On Behalf Of Murthy, Arun R > > > > > > > > > Sent: Fri
Re: [Intel-gfx] [PATCHv3] drm/i915: Support Async Flip on Linear buffers
Any review comments on this. Gentle Reminder! Thanks and Regards, Arun R Murthy > -Original Message- > From: Murthy, Arun R > Sent: Tuesday, January 17, 2023 2:09 PM > To: 'Ville Syrjälä' > Cc: 'intel-gfx@lists.freedesktop.org' ; > Syrjala, Ville > Subject: RE: [Intel-gfx] [PATCHv3] drm/i915: Support Async Flip on Linear > buffers > > Gentle Reminder! > > Thanks and Regards, > Arun R Murthy > --- > > > -Original Message- > > From: Murthy, Arun R > > Sent: Friday, January 13, 2023 12:57 PM > > To: Ville Syrjälä > > Cc: intel-gfx@lists.freedesktop.org; Syrjala, Ville > > > > Subject: RE: [Intel-gfx] [PATCHv3] drm/i915: Support Async Flip on > > Linear buffers > > > > > On Fri, Oct 28, 2022 at 03:23:02AM +, Murthy, Arun R wrote: > > > > Gentle Reminder! > > > > > > Is the igt stuff merged, and did this pass the test? > > > > > With IGT alone the tests will fail without the kernel patch. > > The > > tests(https://intel-gfx-ci.01.org/tree/drm-tip/Trybot_112722v2/shards- > > all.html?testfilter=kms_async_flips) are passing with IGT and kernel patch. > > > > Thanks and Regards, > > Arun R Murthy > > > > > > > > > > > -Original Message- > > > > > From: Murthy, Arun R > > > > > Sent: Monday, October 10, 2022 1:24 PM > > > > > To: 'intel-gfx@lists.freedesktop.org' > > > > > > > > > > Cc: Syrjala, Ville > > > > > Subject: RE: [PATCHv3] drm/i915: Support Async Flip on Linear > > > > > buffers > > > > > > > > > > Ville, > > > > > Gentle reminder! > > > > > > > > > > Thanks and Regards, > > > > > Arun R Murthy > > > > > > > > > > > > > > > > -Original Message- > > > > > > From: Murthy, Arun R > > > > > > Sent: Monday, September 19, 2022 10:38 AM > > > > > > To: 'intel-gfx@lists.freedesktop.org' > > > > > > > > > > > > Cc: Syrjala, Ville > > > > > > Subject: RE: [PATCHv3] drm/i915: Support Async Flip on Linear > > > > > > buffers > > > > > > > > > > > > If no comments, can anyone merge the patch! > > > > > > > > > > > > Thanks and Regards, > > > > > > Arun R Murthy > > > > > > > > > > > > > > > > > > > -Original Message- > > > > > > > From: Murthy, Arun R > > > > > > > Sent: Wednesday, September 14, 2022 4:21 PM > > > > > > > To: Murthy, Arun R ; intel- > > > > > > > g...@lists.freedesktop.org > > > > > > > Cc: Syrjala, Ville > > > > > > > Subject: RE: [PATCHv3] drm/i915: Support Async Flip on > > > > > > > Linear buffers > > > > > > > > > > > > > > Gentle Reminder! > > > > > > > Any comments? > > > > > > > > > > > > > > Thanks and Regards, > > > > > > > Arun R Murthy > > > > > > > > > > > > > > > > > > > > > > -Original Message- > > > > > > > > From: Intel-gfx > > > > > > > > On Behalf Of Murthy, Arun R > > > > > > > > Sent: Friday, September 9, 2022 9:17 AM > > > > > > > > To: intel-gfx@lists.freedesktop.org > > > > > > > > Cc: Syrjala, Ville > > > > > > > > Subject: Re: [Intel-gfx] [PATCHv3] drm/i915: Support Async > > > > > > > > Flip on Linear buffers > > > > > > > > > > > > > > > > Gentle Reminder! > > > > > > > > > > > > > > > > > -Original Message- > > > > > > > > > From: Murthy, Arun R > > > > > > > > > Sent: Tuesday, September 6, 2022 9:18 AM > > > > > > > > > To: intel-gfx@lists.freedesktop.org > > > > > > > > > Cc: ville.syrj...@linux.intel.com; Murthy, Arun R > > > > > > > > > > > > > > > > > > Subject: [PATCHv3] drm/i915:
Re: [Intel-gfx] [PATCHv3] drm/i915: Support Async Flip on Linear buffers
Gentle Reminder! Thanks and Regards, Arun R Murthy --- > -Original Message- > From: Murthy, Arun R > Sent: Friday, January 13, 2023 12:57 PM > To: Ville Syrjälä > Cc: intel-gfx@lists.freedesktop.org; Syrjala, Ville > Subject: RE: [Intel-gfx] [PATCHv3] drm/i915: Support Async Flip on Linear > buffers > > > On Fri, Oct 28, 2022 at 03:23:02AM +, Murthy, Arun R wrote: > > > Gentle Reminder! > > > > Is the igt stuff merged, and did this pass the test? > > > With IGT alone the tests will fail without the kernel patch. > The tests(https://intel-gfx-ci.01.org/tree/drm-tip/Trybot_112722v2/shards- > all.html?testfilter=kms_async_flips) are passing with IGT and kernel patch. > > Thanks and Regards, > Arun R Murthy > > > > > > > > -Original Message- > > > > From: Murthy, Arun R > > > > Sent: Monday, October 10, 2022 1:24 PM > > > > To: 'intel-gfx@lists.freedesktop.org' > > > > > > > > Cc: Syrjala, Ville > > > > Subject: RE: [PATCHv3] drm/i915: Support Async Flip on Linear > > > > buffers > > > > > > > > Ville, > > > > Gentle reminder! > > > > > > > > Thanks and Regards, > > > > Arun R Murthy > > > > > > > > > > > > > -Original Message- > > > > > From: Murthy, Arun R > > > > > Sent: Monday, September 19, 2022 10:38 AM > > > > > To: 'intel-gfx@lists.freedesktop.org' > > > > > > > > > > Cc: Syrjala, Ville > > > > > Subject: RE: [PATCHv3] drm/i915: Support Async Flip on Linear > > > > > buffers > > > > > > > > > > If no comments, can anyone merge the patch! > > > > > > > > > > Thanks and Regards, > > > > > Arun R Murthy > > > > > > > > > > > > > > > > -Original Message- > > > > > > From: Murthy, Arun R > > > > > > Sent: Wednesday, September 14, 2022 4:21 PM > > > > > > To: Murthy, Arun R ; intel- > > > > > > g...@lists.freedesktop.org > > > > > > Cc: Syrjala, Ville > > > > > > Subject: RE: [PATCHv3] drm/i915: Support Async Flip on Linear > > > > > > buffers > > > > > > > > > > > > Gentle Reminder! > > > > > > Any comments? > > > > > > > > > > > > Thanks and Regards, > > > > > > Arun R Murthy > > > > > > > > > > > > > > > > > > > -Original Message- > > > > > > > From: Intel-gfx On > > > > > > > Behalf Of Murthy, Arun R > > > > > > > Sent: Friday, September 9, 2022 9:17 AM > > > > > > > To: intel-gfx@lists.freedesktop.org > > > > > > > Cc: Syrjala, Ville > > > > > > > Subject: Re: [Intel-gfx] [PATCHv3] drm/i915: Support Async > > > > > > > Flip on Linear buffers > > > > > > > > > > > > > > Gentle Reminder! > > > > > > > > > > > > > > > -Original Message- > > > > > > > > From: Murthy, Arun R > > > > > > > > Sent: Tuesday, September 6, 2022 9:18 AM > > > > > > > > To: intel-gfx@lists.freedesktop.org > > > > > > > > Cc: ville.syrj...@linux.intel.com; Murthy, Arun R > > > > > > > > > > > > > > > > Subject: [PATCHv3] drm/i915: Support Async Flip on Linear > > > > > > > > buffers > > > > > > > > > > > > > > > > Starting from Gen12 Async Flip is supported on linear buffers. > > > > > > > > This patch enables support for async on linear buffer. > > > > > > > > > > > > > > > > UseCase: In Hybrid graphics, for hardware unsupported > > > > > > > > pixel formats it will be converted to linear memory and then > composed. > > > > > > > > > > > > > > > > v2: Added use case > > > > > > > > v3: Added FIXME for ICL indicating the restrictions > > > > > > > > > > > > > > > > Signed-off-by: Arun R Murthy >
Re: [Intel-gfx] [PATCHv3] drm/i915: Support Async Flip on Linear buffers
> On Fri, Oct 28, 2022 at 03:23:02AM +, Murthy, Arun R wrote:
> > Gentle Reminder!
>
> Is the igt stuff merged, and did this pass the test?
>
With IGT alone the tests will fail without the kernel patch.
The
tests(https://intel-gfx-ci.01.org/tree/drm-tip/Trybot_112722v2/shards-all.html?testfilter=kms_async_flips)
are passing with IGT and kernel patch.
Thanks and Regards,
Arun R Murthy
> >
> > > -Original Message-
> > > From: Murthy, Arun R
> > > Sent: Monday, October 10, 2022 1:24 PM
> > > To: 'intel-gfx@lists.freedesktop.org'
> > >
> > > Cc: Syrjala, Ville
> > > Subject: RE: [PATCHv3] drm/i915: Support Async Flip on Linear
> > > buffers
> > >
> > > Ville,
> > > Gentle reminder!
> > >
> > > Thanks and Regards,
> > > Arun R Murthy
> > >
> > >
> > > > -Original Message-
> > > > From: Murthy, Arun R
> > > > Sent: Monday, September 19, 2022 10:38 AM
> > > > To: 'intel-gfx@lists.freedesktop.org'
> > > >
> > > > Cc: Syrjala, Ville
> > > > Subject: RE: [PATCHv3] drm/i915: Support Async Flip on Linear
> > > > buffers
> > > >
> > > > If no comments, can anyone merge the patch!
> > > >
> > > > Thanks and Regards,
> > > > Arun R Murthy
> > > >
> > > >
> > > > > -Original Message-
> > > > > From: Murthy, Arun R
> > > > > Sent: Wednesday, September 14, 2022 4:21 PM
> > > > > To: Murthy, Arun R ; intel-
> > > > > g...@lists.freedesktop.org
> > > > > Cc: Syrjala, Ville
> > > > > Subject: RE: [PATCHv3] drm/i915: Support Async Flip on Linear
> > > > > buffers
> > > > >
> > > > > Gentle Reminder!
> > > > > Any comments?
> > > > >
> > > > > Thanks and Regards,
> > > > > Arun R Murthy
> > > > >
> > > > >
> > > > > > -Original Message-
> > > > > > From: Intel-gfx On
> > > > > > Behalf Of Murthy, Arun R
> > > > > > Sent: Friday, September 9, 2022 9:17 AM
> > > > > > To: intel-gfx@lists.freedesktop.org
> > > > > > Cc: Syrjala, Ville
> > > > > > Subject: Re: [Intel-gfx] [PATCHv3] drm/i915: Support Async
> > > > > > Flip on Linear buffers
> > > > > >
> > > > > > Gentle Reminder!
> > > > > >
> > > > > > > -Original Message-
> > > > > > > From: Murthy, Arun R
> > > > > > > Sent: Tuesday, September 6, 2022 9:18 AM
> > > > > > > To: intel-gfx@lists.freedesktop.org
> > > > > > > Cc: ville.syrj...@linux.intel.com; Murthy, Arun R
> > > > > > >
> > > > > > > Subject: [PATCHv3] drm/i915: Support Async Flip on Linear
> > > > > > > buffers
> > > > > > >
> > > > > > > Starting from Gen12 Async Flip is supported on linear buffers.
> > > > > > > This patch enables support for async on linear buffer.
> > > > > > >
> > > > > > > UseCase: In Hybrid graphics, for hardware unsupported pixel
> > > > > > > formats it will be converted to linear memory and then composed.
> > > > > > >
> > > > > > > v2: Added use case
> > > > > > > v3: Added FIXME for ICL indicating the restrictions
> > > > > > >
> > > > > > > Signed-off-by: Arun R Murthy
> > > > > > > ---
> > > > > > > drivers/gpu/drm/i915/display/intel_display.c | 14
> > > > > > > ++
> > > > > > > 1 file changed, 14 insertions(+)
> > > > > > >
> > > > > > > diff --git a/drivers/gpu/drm/i915/display/intel_display.c
> > > > > > > b/drivers/gpu/drm/i915/display/intel_display.c
> > > > > > > index be7cff722196..1880cfe70a7d 100644
> > > > > > > --- a/drivers/gpu/drm/i915/display/intel_display.c
> > > > > > > +++ b/drivers/gpu/drm/i915/display/intel_display.c
> > > > > > > @@ -6610,6 +6610,20 @@ static int
> > > > > > > intel_async_flip_check_hw(struct intel_atomic_state *state, struct
> in
> > > > > > >* this selectively if required.
> > > > > > >*/
> > > > > > > switch (new_plane_state->hw.fb->modifier) {
> > > > > > > + case DRM_FORMAT_MOD_LINEAR:
> > > > > > > + /*
> > > > > > > + * FIXME: Async on Linear buffer is supported
> > > on ICL
> > > > > > > as
> > > > > > > + * but with additional alignment and fbc
> > > restrictions
> > > > > > > + * need to be taken care of. These aren't
> > > applicable
> > > > > > > for
> > > > > > > + * gen12+.
> > > > > > > + */
> > > > > > > + if (DISPLAY_VER(i915) < 12) {
> > > > > > > + drm_dbg_kms(>drm,
> > > > > > > + "[PLANE:%d:%s] Modifier
> > > does not
> > > > > > > support async flips\n",
> > > > > > > + plane->base.base.id, plane-
> > > > > > > >base.name);
> > > > > > > + return -EINVAL;
> > > > > > > + }
> > > > > > > +
> > > > > > > case I915_FORMAT_MOD_X_TILED:
> > > > > > > case I915_FORMAT_MOD_Y_TILED:
> > > > > > > case I915_FORMAT_MOD_Yf_TILED:
> > > > > > > --
> > > > > > > 2.25.1
>
> --
> Ville Syrjälä
> Intel
Re: [Intel-gfx] [PATCHv3] drm/i915: Support Async Flip on Linear buffers
> -Original Message- > From: Ville Syrjälä > Sent: Friday, October 28, 2022 12:01 PM > To: Murthy, Arun R > Cc: intel-gfx@lists.freedesktop.org; Syrjala, Ville > Subject: Re: [Intel-gfx] [PATCHv3] drm/i915: Support Async Flip on Linear > buffers > > On Fri, Oct 28, 2022 at 03:23:02AM +, Murthy, Arun R wrote: > > Gentle Reminder! > > Is the igt stuff merged, and did this pass the test? > IGT patches are waiting for kernel to be merged. Test results can be located @ https://intel-gfx-ci.01.org/tree/drm-tip/Trybot_109443v7/index.html Thanks and Regards, Arun R Murthy > > > > > -Original Message- > > > From: Murthy, Arun R > > > Sent: Monday, October 10, 2022 1:24 PM > > > To: 'intel-gfx@lists.freedesktop.org' > > > > > > Cc: Syrjala, Ville > > > Subject: RE: [PATCHv3] drm/i915: Support Async Flip on Linear > > > buffers > > > > > > Ville, > > > Gentle reminder! > > > > > > Thanks and Regards, > > > Arun R Murthy > > > > > > > > > > -Original Message- > > > > From: Murthy, Arun R > > > > Sent: Monday, September 19, 2022 10:38 AM > > > > To: 'intel-gfx@lists.freedesktop.org' > > > > > > > > Cc: Syrjala, Ville > > > > Subject: RE: [PATCHv3] drm/i915: Support Async Flip on Linear > > > > buffers > > > > > > > > If no comments, can anyone merge the patch! > > > > > > > > Thanks and Regards, > > > > Arun R Murthy > > > > > > > > > > > > > -Original Message- > > > > > From: Murthy, Arun R > > > > > Sent: Wednesday, September 14, 2022 4:21 PM > > > > > To: Murthy, Arun R ; intel- > > > > > g...@lists.freedesktop.org > > > > > Cc: Syrjala, Ville > > > > > Subject: RE: [PATCHv3] drm/i915: Support Async Flip on Linear > > > > > buffers > > > > > > > > > > Gentle Reminder! > > > > > Any comments? > > > > > > > > > > Thanks and Regards, > > > > > Arun R Murthy > > > > > > > > > > > > > > > > -Original Message- > > > > > > From: Intel-gfx On > > > > > > Behalf Of Murthy, Arun R > > > > > > Sent: Friday, September 9, 2022 9:17 AM > > > > > > To: intel-gfx@lists.freedesktop.org > > > > > > Cc: Syrjala, Ville > > > > > > Subject: Re: [Intel-gfx] [PATCHv3] drm/i915: Support Async > > > > > > Flip on Linear buffers > > > > > > > > > > > > Gentle Reminder! > > > > > > > > > > > > > -Original Message- > > > > > > > From: Murthy, Arun R > > > > > > > Sent: Tuesday, September 6, 2022 9:18 AM > > > > > > > To: intel-gfx@lists.freedesktop.org > > > > > > > Cc: ville.syrj...@linux.intel.com; Murthy, Arun R > > > > > > > > > > > > > > Subject: [PATCHv3] drm/i915: Support Async Flip on Linear > > > > > > > buffers > > > > > > > > > > > > > > Starting from Gen12 Async Flip is supported on linear buffers. > > > > > > > This patch enables support for async on linear buffer. > > > > > > > > > > > > > > UseCase: In Hybrid graphics, for hardware unsupported pixel > > > > > > > formats it will be converted to linear memory and then composed. > > > > > > > > > > > > > > v2: Added use case > > > > > > > v3: Added FIXME for ICL indicating the restrictions > > > > > > > > > > > > > > Signed-off-by: Arun R Murthy > > > > > > > --- > > > > > > > drivers/gpu/drm/i915/display/intel_display.c | 14 > > > > > > > ++ > > > > > > > 1 file changed, 14 insertions(+) > > > > > > > > > > > > > > diff --git a/drivers/gpu/drm/i915/display/intel_display.c > > > > > > > b/drivers/gpu/drm/i915/display/intel_display.c > > > > > > > index be7cff722196..1880cfe70a7d 100644 > > > > > > > --- a/drivers/gpu/drm/i915/display/intel
Re: [Intel-gfx] [PATCHv3] drm/i915: Support Async Flip on Linear buffers
On Fri, Oct 28, 2022 at 03:23:02AM +, Murthy, Arun R wrote:
> Gentle Reminder!
Is the igt stuff merged, and did this pass the test?
>
> > -Original Message-
> > From: Murthy, Arun R
> > Sent: Monday, October 10, 2022 1:24 PM
> > To: 'intel-gfx@lists.freedesktop.org'
> > Cc: Syrjala, Ville
> > Subject: RE: [PATCHv3] drm/i915: Support Async Flip on Linear buffers
> >
> > Ville,
> > Gentle reminder!
> >
> > Thanks and Regards,
> > Arun R Murthy
> >
> >
> > > -Original Message-
> > > From: Murthy, Arun R
> > > Sent: Monday, September 19, 2022 10:38 AM
> > > To: 'intel-gfx@lists.freedesktop.org'
> > >
> > > Cc: Syrjala, Ville
> > > Subject: RE: [PATCHv3] drm/i915: Support Async Flip on Linear buffers
> > >
> > > If no comments, can anyone merge the patch!
> > >
> > > Thanks and Regards,
> > > Arun R Murthy
> > >
> > >
> > > > -Original Message-
> > > > From: Murthy, Arun R
> > > > Sent: Wednesday, September 14, 2022 4:21 PM
> > > > To: Murthy, Arun R ; intel-
> > > > g...@lists.freedesktop.org
> > > > Cc: Syrjala, Ville
> > > > Subject: RE: [PATCHv3] drm/i915: Support Async Flip on Linear
> > > > buffers
> > > >
> > > > Gentle Reminder!
> > > > Any comments?
> > > >
> > > > Thanks and Regards,
> > > > Arun R Murthy
> > > >
> > > >
> > > > > -Original Message-
> > > > > From: Intel-gfx On
> > > > > Behalf Of Murthy, Arun R
> > > > > Sent: Friday, September 9, 2022 9:17 AM
> > > > > To: intel-gfx@lists.freedesktop.org
> > > > > Cc: Syrjala, Ville
> > > > > Subject: Re: [Intel-gfx] [PATCHv3] drm/i915: Support Async Flip on
> > > > > Linear buffers
> > > > >
> > > > > Gentle Reminder!
> > > > >
> > > > > > -Original Message-
> > > > > > From: Murthy, Arun R
> > > > > > Sent: Tuesday, September 6, 2022 9:18 AM
> > > > > > To: intel-gfx@lists.freedesktop.org
> > > > > > Cc: ville.syrj...@linux.intel.com; Murthy, Arun R
> > > > > >
> > > > > > Subject: [PATCHv3] drm/i915: Support Async Flip on Linear
> > > > > > buffers
> > > > > >
> > > > > > Starting from Gen12 Async Flip is supported on linear buffers.
> > > > > > This patch enables support for async on linear buffer.
> > > > > >
> > > > > > UseCase: In Hybrid graphics, for hardware unsupported pixel
> > > > > > formats it will be converted to linear memory and then composed.
> > > > > >
> > > > > > v2: Added use case
> > > > > > v3: Added FIXME for ICL indicating the restrictions
> > > > > >
> > > > > > Signed-off-by: Arun R Murthy
> > > > > > ---
> > > > > > drivers/gpu/drm/i915/display/intel_display.c | 14
> > > > > > ++
> > > > > > 1 file changed, 14 insertions(+)
> > > > > >
> > > > > > diff --git a/drivers/gpu/drm/i915/display/intel_display.c
> > > > > > b/drivers/gpu/drm/i915/display/intel_display.c
> > > > > > index be7cff722196..1880cfe70a7d 100644
> > > > > > --- a/drivers/gpu/drm/i915/display/intel_display.c
> > > > > > +++ b/drivers/gpu/drm/i915/display/intel_display.c
> > > > > > @@ -6610,6 +6610,20 @@ static int
> > > > > > intel_async_flip_check_hw(struct intel_atomic_state *state, struct
> > > > > > in
> > > > > > * this selectively if required.
> > > > > > */
> > > > > > switch (new_plane_state->hw.fb->modifier) {
> > > > > > + case DRM_FORMAT_MOD_LINEAR:
> > > > > > + /*
> > > > > > +* FIXME: Async on Linear buffer is supported
> > on ICL
> > > > > > as
> > > > > > +* but with additional alignment and fbc
> > restrictions
> > > > > > +* need to be taken care of. These aren't
> > applicable
> > > > > > for
> > > > > > +* gen12+.
> > > > > > +*/
> > > > > > + if (DISPLAY_VER(i915) < 12) {
> > > > > > + drm_dbg_kms(>drm,
> > > > > > + "[PLANE:%d:%s] Modifier
> > does not
> > > > > > support async flips\n",
> > > > > > + plane->base.base.id, plane-
> > > > > > >base.name);
> > > > > > + return -EINVAL;
> > > > > > + }
> > > > > > +
> > > > > > case I915_FORMAT_MOD_X_TILED:
> > > > > > case I915_FORMAT_MOD_Y_TILED:
> > > > > > case I915_FORMAT_MOD_Yf_TILED:
> > > > > > --
> > > > > > 2.25.1
--
Ville Syrjälä
Intel
Re: [Intel-gfx] [PATCHv3] drm/i915: Support Async Flip on Linear buffers
Gentle Reminder!
> -Original Message-
> From: Murthy, Arun R
> Sent: Monday, October 10, 2022 1:24 PM
> To: 'intel-gfx@lists.freedesktop.org'
> Cc: Syrjala, Ville
> Subject: RE: [PATCHv3] drm/i915: Support Async Flip on Linear buffers
>
> Ville,
> Gentle reminder!
>
> Thanks and Regards,
> Arun R Murthy
>
>
> > -Original Message-
> > From: Murthy, Arun R
> > Sent: Monday, September 19, 2022 10:38 AM
> > To: 'intel-gfx@lists.freedesktop.org'
> >
> > Cc: Syrjala, Ville
> > Subject: RE: [PATCHv3] drm/i915: Support Async Flip on Linear buffers
> >
> > If no comments, can anyone merge the patch!
> >
> > Thanks and Regards,
> > Arun R Murthy
> >
> >
> > > -Original Message-
> > > From: Murthy, Arun R
> > > Sent: Wednesday, September 14, 2022 4:21 PM
> > > To: Murthy, Arun R ; intel-
> > > g...@lists.freedesktop.org
> > > Cc: Syrjala, Ville
> > > Subject: RE: [PATCHv3] drm/i915: Support Async Flip on Linear
> > > buffers
> > >
> > > Gentle Reminder!
> > > Any comments?
> > >
> > > Thanks and Regards,
> > > Arun R Murthy
> > > --------
> > >
> > > > -Original Message-----
> > > > From: Intel-gfx On
> > > > Behalf Of Murthy, Arun R
> > > > Sent: Friday, September 9, 2022 9:17 AM
> > > > To: intel-gfx@lists.freedesktop.org
> > > > Cc: Syrjala, Ville
> > > > Subject: Re: [Intel-gfx] [PATCHv3] drm/i915: Support Async Flip on
> > > > Linear buffers
> > > >
> > > > Gentle Reminder!
> > > >
> > > > > -Original Message-
> > > > > From: Murthy, Arun R
> > > > > Sent: Tuesday, September 6, 2022 9:18 AM
> > > > > To: intel-gfx@lists.freedesktop.org
> > > > > Cc: ville.syrj...@linux.intel.com; Murthy, Arun R
> > > > >
> > > > > Subject: [PATCHv3] drm/i915: Support Async Flip on Linear
> > > > > buffers
> > > > >
> > > > > Starting from Gen12 Async Flip is supported on linear buffers.
> > > > > This patch enables support for async on linear buffer.
> > > > >
> > > > > UseCase: In Hybrid graphics, for hardware unsupported pixel
> > > > > formats it will be converted to linear memory and then composed.
> > > > >
> > > > > v2: Added use case
> > > > > v3: Added FIXME for ICL indicating the restrictions
> > > > >
> > > > > Signed-off-by: Arun R Murthy
> > > > > ---
> > > > > drivers/gpu/drm/i915/display/intel_display.c | 14
> > > > > ++
> > > > > 1 file changed, 14 insertions(+)
> > > > >
> > > > > diff --git a/drivers/gpu/drm/i915/display/intel_display.c
> > > > > b/drivers/gpu/drm/i915/display/intel_display.c
> > > > > index be7cff722196..1880cfe70a7d 100644
> > > > > --- a/drivers/gpu/drm/i915/display/intel_display.c
> > > > > +++ b/drivers/gpu/drm/i915/display/intel_display.c
> > > > > @@ -6610,6 +6610,20 @@ static int
> > > > > intel_async_flip_check_hw(struct intel_atomic_state *state, struct in
> > > > >* this selectively if required.
> > > > >*/
> > > > > switch (new_plane_state->hw.fb->modifier) {
> > > > > + case DRM_FORMAT_MOD_LINEAR:
> > > > > + /*
> > > > > + * FIXME: Async on Linear buffer is supported
> on ICL
> > > > > as
> > > > > + * but with additional alignment and fbc
> restrictions
> > > > > + * need to be taken care of. These aren't
> applicable
> > > > > for
> > > > > + * gen12+.
> > > > > + */
> > > > > + if (DISPLAY_VER(i915) < 12) {
> > > > > + drm_dbg_kms(>drm,
> > > > > + "[PLANE:%d:%s] Modifier
> does not
> > > > > support async flips\n",
> > > > > + plane->base.base.id, plane-
> > > > > >base.name);
> > > > > + return -EINVAL;
> > > > > + }
> > > > > +
> > > > > case I915_FORMAT_MOD_X_TILED:
> > > > > case I915_FORMAT_MOD_Y_TILED:
> > > > > case I915_FORMAT_MOD_Yf_TILED:
> > > > > --
> > > > > 2.25.1
Re: [Intel-gfx] [PATCHv3] drm/i915: Support Async Flip on Linear buffers
Ville,
Gentle reminder!
Thanks and Regards,
Arun R Murthy
> -Original Message-
> From: Murthy, Arun R
> Sent: Monday, September 19, 2022 10:38 AM
> To: 'intel-gfx@lists.freedesktop.org'
> Cc: Syrjala, Ville
> Subject: RE: [PATCHv3] drm/i915: Support Async Flip on Linear buffers
>
> If no comments, can anyone merge the patch!
>
> Thanks and Regards,
> Arun R Murthy
>
>
> > -Original Message-
> > From: Murthy, Arun R
> > Sent: Wednesday, September 14, 2022 4:21 PM
> > To: Murthy, Arun R ; intel-
> > g...@lists.freedesktop.org
> > Cc: Syrjala, Ville
> > Subject: RE: [PATCHv3] drm/i915: Support Async Flip on Linear buffers
> >
> > Gentle Reminder!
> > Any comments?
> >
> > Thanks and Regards,
> > Arun R Murthy
> >
> >
> > > -Original Message-
> > > From: Intel-gfx On Behalf
> > > Of Murthy, Arun R
> > > Sent: Friday, September 9, 2022 9:17 AM
> > > To: intel-gfx@lists.freedesktop.org
> > > Cc: Syrjala, Ville
> > > Subject: Re: [Intel-gfx] [PATCHv3] drm/i915: Support Async Flip on
> > > Linear buffers
> > >
> > > Gentle Reminder!
> > >
> > > > -Original Message-
> > > > From: Murthy, Arun R
> > > > Sent: Tuesday, September 6, 2022 9:18 AM
> > > > To: intel-gfx@lists.freedesktop.org
> > > > Cc: ville.syrj...@linux.intel.com; Murthy, Arun R
> > > >
> > > > Subject: [PATCHv3] drm/i915: Support Async Flip on Linear buffers
> > > >
> > > > Starting from Gen12 Async Flip is supported on linear buffers.
> > > > This patch enables support for async on linear buffer.
> > > >
> > > > UseCase: In Hybrid graphics, for hardware unsupported pixel
> > > > formats it will be converted to linear memory and then composed.
> > > >
> > > > v2: Added use case
> > > > v3: Added FIXME for ICL indicating the restrictions
> > > >
> > > > Signed-off-by: Arun R Murthy
> > > > ---
> > > > drivers/gpu/drm/i915/display/intel_display.c | 14 ++
> > > > 1 file changed, 14 insertions(+)
> > > >
> > > > diff --git a/drivers/gpu/drm/i915/display/intel_display.c
> > > > b/drivers/gpu/drm/i915/display/intel_display.c
> > > > index be7cff722196..1880cfe70a7d 100644
> > > > --- a/drivers/gpu/drm/i915/display/intel_display.c
> > > > +++ b/drivers/gpu/drm/i915/display/intel_display.c
> > > > @@ -6610,6 +6610,20 @@ static int intel_async_flip_check_hw(struct
> > > > intel_atomic_state *state, struct in
> > > > * this selectively if required.
> > > > */
> > > > switch (new_plane_state->hw.fb->modifier) {
> > > > + case DRM_FORMAT_MOD_LINEAR:
> > > > + /*
> > > > +* FIXME: Async on Linear buffer is supported
> > > > on ICL
> > > > as
> > > > +* but with additional alignment and fbc
> > > > restrictions
> > > > +* need to be taken care of. These aren't
> > > > applicable
> > > > for
> > > > +* gen12+.
> > > > +*/
> > > > + if (DISPLAY_VER(i915) < 12) {
> > > > + drm_dbg_kms(>drm,
> > > > + "[PLANE:%d:%s] Modifier does not
> > > > support async flips\n",
> > > > + plane->base.base.id, plane-
> > > > >base.name);
> > > > + return -EINVAL;
> > > > + }
> > > > +
> > > > case I915_FORMAT_MOD_X_TILED:
> > > > case I915_FORMAT_MOD_Y_TILED:
> > > > case I915_FORMAT_MOD_Yf_TILED:
> > > > --
> > > > 2.25.1
Re: [Intel-gfx] [PATCHv3] drm/i915: Support Async Flip on Linear buffers
If no comments, can anyone merge the patch!
Thanks and Regards,
Arun R Murthy
> -Original Message-
> From: Murthy, Arun R
> Sent: Wednesday, September 14, 2022 4:21 PM
> To: Murthy, Arun R ; intel-
> g...@lists.freedesktop.org
> Cc: Syrjala, Ville
> Subject: RE: [PATCHv3] drm/i915: Support Async Flip on Linear buffers
>
> Gentle Reminder!
> Any comments?
>
> Thanks and Regards,
> Arun R Murthy
>
>
> > -Original Message-
> > From: Intel-gfx On Behalf Of
> > Murthy, Arun R
> > Sent: Friday, September 9, 2022 9:17 AM
> > To: intel-gfx@lists.freedesktop.org
> > Cc: Syrjala, Ville
> > Subject: Re: [Intel-gfx] [PATCHv3] drm/i915: Support Async Flip on
> > Linear buffers
> >
> > Gentle Reminder!
> >
> > > -Original Message-
> > > From: Murthy, Arun R
> > > Sent: Tuesday, September 6, 2022 9:18 AM
> > > To: intel-gfx@lists.freedesktop.org
> > > Cc: ville.syrj...@linux.intel.com; Murthy, Arun R
> > >
> > > Subject: [PATCHv3] drm/i915: Support Async Flip on Linear buffers
> > >
> > > Starting from Gen12 Async Flip is supported on linear buffers.
> > > This patch enables support for async on linear buffer.
> > >
> > > UseCase: In Hybrid graphics, for hardware unsupported pixel formats
> > > it will be converted to linear memory and then composed.
> > >
> > > v2: Added use case
> > > v3: Added FIXME for ICL indicating the restrictions
> > >
> > > Signed-off-by: Arun R Murthy
> > > ---
> > > drivers/gpu/drm/i915/display/intel_display.c | 14 ++
> > > 1 file changed, 14 insertions(+)
> > >
> > > diff --git a/drivers/gpu/drm/i915/display/intel_display.c
> > > b/drivers/gpu/drm/i915/display/intel_display.c
> > > index be7cff722196..1880cfe70a7d 100644
> > > --- a/drivers/gpu/drm/i915/display/intel_display.c
> > > +++ b/drivers/gpu/drm/i915/display/intel_display.c
> > > @@ -6610,6 +6610,20 @@ static int intel_async_flip_check_hw(struct
> > > intel_atomic_state *state, struct in
> > >* this selectively if required.
> > >*/
> > > switch (new_plane_state->hw.fb->modifier) {
> > > + case DRM_FORMAT_MOD_LINEAR:
> > > + /*
> > > + * FIXME: Async on Linear buffer is supported on ICL
> > > as
> > > + * but with additional alignment and fbc restrictions
> > > + * need to be taken care of. These aren't applicable
> > > for
> > > + * gen12+.
> > > + */
> > > + if (DISPLAY_VER(i915) < 12) {
> > > + drm_dbg_kms(>drm,
> > > + "[PLANE:%d:%s] Modifier does not
> > > support async flips\n",
> > > + plane->base.base.id, plane-
> > > >base.name);
> > > + return -EINVAL;
> > > + }
> > > +
> > > case I915_FORMAT_MOD_X_TILED:
> > > case I915_FORMAT_MOD_Y_TILED:
> > > case I915_FORMAT_MOD_Yf_TILED:
> > > --
> > > 2.25.1
Re: [Intel-gfx] [PATCHv3] drm/i915: Support Async Flip on Linear buffers
Gentle Reminder!
Any comments?
Thanks and Regards,
Arun R Murthy
> -Original Message-
> From: Intel-gfx On Behalf Of
> Murthy, Arun R
> Sent: Friday, September 9, 2022 9:17 AM
> To: intel-gfx@lists.freedesktop.org
> Cc: Syrjala, Ville
> Subject: Re: [Intel-gfx] [PATCHv3] drm/i915: Support Async Flip on Linear
> buffers
>
> Gentle Reminder!
>
> > -Original Message-
> > From: Murthy, Arun R
> > Sent: Tuesday, September 6, 2022 9:18 AM
> > To: intel-gfx@lists.freedesktop.org
> > Cc: ville.syrj...@linux.intel.com; Murthy, Arun R
> >
> > Subject: [PATCHv3] drm/i915: Support Async Flip on Linear buffers
> >
> > Starting from Gen12 Async Flip is supported on linear buffers.
> > This patch enables support for async on linear buffer.
> >
> > UseCase: In Hybrid graphics, for hardware unsupported pixel formats it
> > will be converted to linear memory and then composed.
> >
> > v2: Added use case
> > v3: Added FIXME for ICL indicating the restrictions
> >
> > Signed-off-by: Arun R Murthy
> > ---
> > drivers/gpu/drm/i915/display/intel_display.c | 14 ++
> > 1 file changed, 14 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/i915/display/intel_display.c
> > b/drivers/gpu/drm/i915/display/intel_display.c
> > index be7cff722196..1880cfe70a7d 100644
> > --- a/drivers/gpu/drm/i915/display/intel_display.c
> > +++ b/drivers/gpu/drm/i915/display/intel_display.c
> > @@ -6610,6 +6610,20 @@ static int intel_async_flip_check_hw(struct
> > intel_atomic_state *state, struct in
> > * this selectively if required.
> > */
> > switch (new_plane_state->hw.fb->modifier) {
> > + case DRM_FORMAT_MOD_LINEAR:
> > + /*
> > +* FIXME: Async on Linear buffer is supported on ICL
> > as
> > +* but with additional alignment and fbc restrictions
> > +* need to be taken care of. These aren't applicable
> > for
> > +* gen12+.
> > +*/
> > + if (DISPLAY_VER(i915) < 12) {
> > + drm_dbg_kms(>drm,
> > + "[PLANE:%d:%s] Modifier does not
> > support async flips\n",
> > + plane->base.base.id, plane-
> > >base.name);
> > + return -EINVAL;
> > + }
> > +
> > case I915_FORMAT_MOD_X_TILED:
> > case I915_FORMAT_MOD_Y_TILED:
> > case I915_FORMAT_MOD_Yf_TILED:
> > --
> > 2.25.1
Re: [Intel-gfx] [PATCHv3] drm/i915: Support Async Flip on Linear buffers
Gentle Reminder!
> -Original Message-
> From: Murthy, Arun R
> Sent: Tuesday, September 6, 2022 9:18 AM
> To: intel-gfx@lists.freedesktop.org
> Cc: ville.syrj...@linux.intel.com; Murthy, Arun R
> Subject: [PATCHv3] drm/i915: Support Async Flip on Linear buffers
>
> Starting from Gen12 Async Flip is supported on linear buffers.
> This patch enables support for async on linear buffer.
>
> UseCase: In Hybrid graphics, for hardware unsupported pixel formats it will
> be converted to linear memory and then composed.
>
> v2: Added use case
> v3: Added FIXME for ICL indicating the restrictions
>
> Signed-off-by: Arun R Murthy
> ---
> drivers/gpu/drm/i915/display/intel_display.c | 14 ++
> 1 file changed, 14 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display.c
> b/drivers/gpu/drm/i915/display/intel_display.c
> index be7cff722196..1880cfe70a7d 100644
> --- a/drivers/gpu/drm/i915/display/intel_display.c
> +++ b/drivers/gpu/drm/i915/display/intel_display.c
> @@ -6610,6 +6610,20 @@ static int intel_async_flip_check_hw(struct
> intel_atomic_state *state, struct in
>* this selectively if required.
>*/
> switch (new_plane_state->hw.fb->modifier) {
> + case DRM_FORMAT_MOD_LINEAR:
> + /*
> + * FIXME: Async on Linear buffer is supported on ICL
> as
> + * but with additional alignment and fbc restrictions
> + * need to be taken care of. These aren't applicable
> for
> + * gen12+.
> + */
> + if (DISPLAY_VER(i915) < 12) {
> + drm_dbg_kms(>drm,
> + "[PLANE:%d:%s] Modifier does not
> support async flips\n",
> + plane->base.base.id, plane-
> >base.name);
> + return -EINVAL;
> + }
> +
> case I915_FORMAT_MOD_X_TILED:
> case I915_FORMAT_MOD_Y_TILED:
> case I915_FORMAT_MOD_Yf_TILED:
> --
> 2.25.1
[Intel-gfx] [PATCHv3] drm/i915: Support Async Flip on Linear buffers
Starting from Gen12 Async Flip is supported on linear buffers.
This patch enables support for async on linear buffer.
UseCase: In Hybrid graphics, for hardware unsupported pixel formats it
will be converted to linear memory and then composed.
v2: Added use case
v3: Added FIXME for ICL indicating the restrictions
Signed-off-by: Arun R Murthy
---
drivers/gpu/drm/i915/display/intel_display.c | 14 ++
1 file changed, 14 insertions(+)
diff --git a/drivers/gpu/drm/i915/display/intel_display.c
b/drivers/gpu/drm/i915/display/intel_display.c
index be7cff722196..f0d2c3cb3bd5 100644
--- a/drivers/gpu/drm/i915/display/intel_display.c
+++ b/drivers/gpu/drm/i915/display/intel_display.c
@@ -6610,6 +6610,20 @@ static int intel_async_flip_check_hw(struct
intel_atomic_state *state, struct in
* this selectively if required.
*/
switch (new_plane_state->hw.fb->modifier) {
+ case DRM_FORMAT_MOD_LINEAR:
+ /*
+* FIXME: Async on Linear buffer is supported on ICL as
+* but with additional alignment and fbc restrictions
+* need to be taken care of. These aren't applicable for
+* gen12+.
+*/
+ if (DISPLAY_VER(i915) < 12) {
+ drm_dbg_kms(>drm,
+ "[PLANE:%d:%s] Modifier does not
support async flips\n",
+ plane->base.base.id,
plane->base.name);
+ return -EINVAL;
+ }
+
case I915_FORMAT_MOD_X_TILED:
case I915_FORMAT_MOD_Y_TILED:
case I915_FORMAT_MOD_Yf_TILED:
--
2.25.1
[Intel-gfx] [PATCHv3] drm/i915: Support Async Flip on Linear buffers
Starting from Gen12 Async Flip is supported on linear buffers.
This patch enables support for async on linear buffer.
UseCase: In Hybrid graphics, for hardware unsupported pixel formats it
will be converted to linear memory and then composed.
v2: Added use case
v3: Added FIXME for ICL indicating the restrictions
Signed-off-by: Arun R Murthy
---
drivers/gpu/drm/i915/display/intel_display.c | 14 ++
1 file changed, 14 insertions(+)
diff --git a/drivers/gpu/drm/i915/display/intel_display.c
b/drivers/gpu/drm/i915/display/intel_display.c
index be7cff722196..1880cfe70a7d 100644
--- a/drivers/gpu/drm/i915/display/intel_display.c
+++ b/drivers/gpu/drm/i915/display/intel_display.c
@@ -6610,6 +6610,20 @@ static int intel_async_flip_check_hw(struct
intel_atomic_state *state, struct in
* this selectively if required.
*/
switch (new_plane_state->hw.fb->modifier) {
+ case DRM_FORMAT_MOD_LINEAR:
+ /*
+* FIXME: Async on Linear buffer is supported on ICL as
+* but with additional alignment and fbc restrictions
+* need to be taken care of. These aren't applicable for
+* gen12+.
+*/
+ if (DISPLAY_VER(i915) < 12) {
+ drm_dbg_kms(>drm,
+ "[PLANE:%d:%s] Modifier does not
support async flips\n",
+ plane->base.base.id, plane->base.name);
+ return -EINVAL;
+ }
+
case I915_FORMAT_MOD_X_TILED:
case I915_FORMAT_MOD_Y_TILED:
case I915_FORMAT_MOD_Yf_TILED:
--
2.25.1
Re: [Intel-gfx] [PATCHv3] drm/i915: Support Async Flip on Linear buffers
On Tue, Aug 30, 2022 at 07:57:15AM +, Murthy, Arun R wrote: > > > > > > > Intel Gen do support Async Flip is supported on linear buffers. > > > > > > > Since we didn't had a use case, it was not enabled. Now that > > > > > > > as part of hybrid graphics for unsupported hardware pixel > > > > > > > formats, its being converted to linear memory and then flipped, > > hence enabling! > > > > > > > This patch enables support for async on linear buffer. > > > > > > > > > > > > > > v2: added use case > > > > > > > v3: enabled async on linear for pre Gen 12 as well > > > > > > > > > > > > I didn't think it went all the way back to gen9? > > > > > > > > > > > It's the same as other buffers. I have just added support for > > > > > linear buffer in > > > > the present async flip path, so the platforms on which the async > > > > flip is supported will support linear buffer as well. > > > > > > > > I know what the patch does. But I don't think bspec agrees with it. > > > > > > > I initially had this async on linear buffer support from Gen12 onwards. > > > Will > > add that check back. > > > > We're just going in circles here. What I've asked repeatedly is actual > > justification for whatever gen check or no gen check there is. Ie. please > > *read* the bspec and include the appropriate information in the patch. > > Otherwise there is no point in me even looking at these patches anymore. > > > Per the BSpec async on Linear is not supported on Pre Gen 12. Where in bspec does it say that? > > > > > > > > > > > > > > > Also we still don't seem to have any tests for this stuff... > > > > > > > > > > There is an IGT patch in queue, once this patch is merged, the IGT > > > > > patch will > > > > be floated. > > > > > > > > Do the igt stuff first. Then you can at least get some CI results for > > > > this > > stuff. > > > > > > > IGT has be floated. https://patchwork.freedesktop.org/series/107871/ > > > > > Thanks and Regards, > Arun R Murthy > -- Ville Syrjälä Intel
Re: [Intel-gfx] [PATCHv3] drm/i915: Support Async Flip on Linear buffers
> > > > > > Intel Gen do support Async Flip is supported on linear buffers. > > > > > > Since we didn't had a use case, it was not enabled. Now that > > > > > > as part of hybrid graphics for unsupported hardware pixel > > > > > > formats, its being converted to linear memory and then flipped, > hence enabling! > > > > > > This patch enables support for async on linear buffer. > > > > > > > > > > > > v2: added use case > > > > > > v3: enabled async on linear for pre Gen 12 as well > > > > > > > > > > I didn't think it went all the way back to gen9? > > > > > > > > > It's the same as other buffers. I have just added support for > > > > linear buffer in > > > the present async flip path, so the platforms on which the async > > > flip is supported will support linear buffer as well. > > > > > > I know what the patch does. But I don't think bspec agrees with it. > > > > > I initially had this async on linear buffer support from Gen12 onwards. Will > add that check back. > > We're just going in circles here. What I've asked repeatedly is actual > justification for whatever gen check or no gen check there is. Ie. please > *read* the bspec and include the appropriate information in the patch. > Otherwise there is no point in me even looking at these patches anymore. > Per the BSpec async on Linear is not supported on Pre Gen 12. > > > > > > > > > > > Also we still don't seem to have any tests for this stuff... > > > > > > > > There is an IGT patch in queue, once this patch is merged, the IGT > > > > patch will > > > be floated. > > > > > > Do the igt stuff first. Then you can at least get some CI results for this > stuff. > > > > > IGT has be floated. https://patchwork.freedesktop.org/series/107871/ > > Thanks and Regards, Arun R Murthy
Re: [Intel-gfx] [PATCHv3] drm/i915: Support Async Flip on Linear buffers
On Tue, Aug 30, 2022 at 06:15:44AM +, Murthy, Arun R wrote: > > -Original Message- > > From: Ville Syrjälä > > Sent: Wednesday, August 24, 2022 5:48 PM > > To: Murthy, Arun R > > Cc: intel-gfx@lists.freedesktop.org; Shankar, Uma > > Subject: Re: [PATCHv3] drm/i915: Support Async Flip on Linear buffers > > > > On Wed, Aug 24, 2022 at 03:02:33AM +, Murthy, Arun R wrote: > > > > -Original Message- > > > > From: Ville Syrjälä > > > > Sent: Tuesday, August 23, 2022 6:27 PM > > > > To: Murthy, Arun R > > > > Cc: intel-gfx@lists.freedesktop.org; Shankar, Uma > > > > > > > > Subject: Re: [PATCHv3] drm/i915: Support Async Flip on Linear > > > > buffers > > > > > > > > On Mon, Jul 04, 2022 at 09:45:48PM +0530, Arun R Murthy wrote: > > > > > Intel Gen do support Async Flip is supported on linear buffers. > > > > > Since we didn't had a use case, it was not enabled. Now that as > > > > > part of hybrid graphics for unsupported hardware pixel formats, > > > > > its being converted to linear memory and then flipped, hence enabling! > > > > > This patch enables support for async on linear buffer. > > > > > > > > > > v2: added use case > > > > > v3: enabled async on linear for pre Gen 12 as well > > > > > > > > I didn't think it went all the way back to gen9? > > > > > > > It's the same as other buffers. I have just added support for linear > > > buffer in > > the present async flip path, so the platforms on which the async flip is > > supported will support linear buffer as well. > > > > I know what the patch does. But I don't think bspec agrees with it. > > > I initially had this async on linear buffer support from Gen12 onwards. Will > add that check back. We're just going in circles here. What I've asked repeatedly is actual justification for whatever gen check or no gen check there is. Ie. please *read* the bspec and include the appropriate information in the patch. Otherwise there is no point in me even looking at these patches anymore. > > > > > > > > Also we still don't seem to have any tests for this stuff... > > > > > > There is an IGT patch in queue, once this patch is merged, the IGT patch > > > will > > be floated. > > > > Do the igt stuff first. Then you can at least get some CI results for this > > stuff. > > > IGT has be floated. https://patchwork.freedesktop.org/series/107871/ > > Thanks and Regards, > Arun R Murthy > -- Ville Syrjälä Intel
Re: [Intel-gfx] [PATCHv3] drm/i915: Support Async Flip on Linear buffers
> -Original Message- > From: Ville Syrjälä > Sent: Wednesday, August 24, 2022 5:48 PM > To: Murthy, Arun R > Cc: intel-gfx@lists.freedesktop.org; Shankar, Uma > Subject: Re: [PATCHv3] drm/i915: Support Async Flip on Linear buffers > > On Wed, Aug 24, 2022 at 03:02:33AM +, Murthy, Arun R wrote: > > > -Original Message- > > > From: Ville Syrjälä > > > Sent: Tuesday, August 23, 2022 6:27 PM > > > To: Murthy, Arun R > > > Cc: intel-gfx@lists.freedesktop.org; Shankar, Uma > > > > > > Subject: Re: [PATCHv3] drm/i915: Support Async Flip on Linear > > > buffers > > > > > > On Mon, Jul 04, 2022 at 09:45:48PM +0530, Arun R Murthy wrote: > > > > Intel Gen do support Async Flip is supported on linear buffers. > > > > Since we didn't had a use case, it was not enabled. Now that as > > > > part of hybrid graphics for unsupported hardware pixel formats, > > > > its being converted to linear memory and then flipped, hence enabling! > > > > This patch enables support for async on linear buffer. > > > > > > > > v2: added use case > > > > v3: enabled async on linear for pre Gen 12 as well > > > > > > I didn't think it went all the way back to gen9? > > > > > It's the same as other buffers. I have just added support for linear buffer > > in > the present async flip path, so the platforms on which the async flip is > supported will support linear buffer as well. > > I know what the patch does. But I don't think bspec agrees with it. > I initially had this async on linear buffer support from Gen12 onwards. Will add that check back. > > > > > Also we still don't seem to have any tests for this stuff... > > > > There is an IGT patch in queue, once this patch is merged, the IGT patch > > will > be floated. > > Do the igt stuff first. Then you can at least get some CI results for this > stuff. > IGT has be floated. https://patchwork.freedesktop.org/series/107871/ Thanks and Regards, Arun R Murthy
Re: [Intel-gfx] [PATCHv3] drm/i915: Support Async Flip on Linear buffers
On Wed, Aug 24, 2022 at 03:02:33AM +, Murthy, Arun R wrote: > > -Original Message- > > From: Ville Syrjälä > > Sent: Tuesday, August 23, 2022 6:27 PM > > To: Murthy, Arun R > > Cc: intel-gfx@lists.freedesktop.org; Shankar, Uma > > Subject: Re: [PATCHv3] drm/i915: Support Async Flip on Linear buffers > > > > On Mon, Jul 04, 2022 at 09:45:48PM +0530, Arun R Murthy wrote: > > > Intel Gen do support Async Flip is supported on linear buffers. Since > > > we didn't had a use case, it was not enabled. Now that as part of > > > hybrid graphics for unsupported hardware pixel formats, its being > > > converted to linear memory and then flipped, hence enabling! > > > This patch enables support for async on linear buffer. > > > > > > v2: added use case > > > v3: enabled async on linear for pre Gen 12 as well > > > > I didn't think it went all the way back to gen9? > > > It's the same as other buffers. I have just added support for linear buffer > in the present async flip path, so the platforms on which the async flip is > supported will support linear buffer as well. I know what the patch does. But I don't think bspec agrees with it. > > > Also we still don't seem to have any tests for this stuff... > > There is an IGT patch in queue, once this patch is merged, the IGT patch will > be floated. Do the igt stuff first. Then you can at least get some CI results for this stuff. -- Ville Syrjälä Intel
Re: [Intel-gfx] [PATCHv3] drm/i915: Support Async Flip on Linear buffers
> -Original Message- > From: Ville Syrjälä > Sent: Tuesday, August 23, 2022 6:27 PM > To: Murthy, Arun R > Cc: intel-gfx@lists.freedesktop.org; Shankar, Uma > Subject: Re: [PATCHv3] drm/i915: Support Async Flip on Linear buffers > > On Mon, Jul 04, 2022 at 09:45:48PM +0530, Arun R Murthy wrote: > > Intel Gen do support Async Flip is supported on linear buffers. Since > > we didn't had a use case, it was not enabled. Now that as part of > > hybrid graphics for unsupported hardware pixel formats, its being > > converted to linear memory and then flipped, hence enabling! > > This patch enables support for async on linear buffer. > > > > v2: added use case > > v3: enabled async on linear for pre Gen 12 as well > > I didn't think it went all the way back to gen9? > It's the same as other buffers. I have just added support for linear buffer in the present async flip path, so the platforms on which the async flip is supported will support linear buffer as well. > Also we still don't seem to have any tests for this stuff... There is an IGT patch in queue, once this patch is merged, the IGT patch will be floated. Thanks and Regards, Arun R Murthy
Re: [Intel-gfx] [PATCHv3] drm/i915: Support Async Flip on Linear buffers
On Mon, Jul 04, 2022 at 09:45:48PM +0530, Arun R Murthy wrote:
> Intel Gen do support Async Flip is supported on linear buffers. Since we
> didn't had a use case, it was not enabled. Now that as part of hybrid
> graphics for unsupported hardware pixel formats, its being converted to
> linear memory and then flipped, hence enabling!
> This patch enables support for async on linear buffer.
>
> v2: added use case
> v3: enabled async on linear for pre Gen 12 as well
I didn't think it went all the way back to gen9?
Also we still don't seem to have any tests for this stuff...
>
> Signed-off-by: Arun R Murthy
> ---
> drivers/gpu/drm/i915/display/intel_display.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display.c
> b/drivers/gpu/drm/i915/display/intel_display.c
> index a0f84cbe974f..99ad67af74e3 100644
> --- a/drivers/gpu/drm/i915/display/intel_display.c
> +++ b/drivers/gpu/drm/i915/display/intel_display.c
> @@ -6614,6 +6614,7 @@ static int intel_async_flip_check_hw(struct
> intel_atomic_state *state, struct in
>* this selectively if required.
>*/
> switch (new_plane_state->hw.fb->modifier) {
> + case DRM_FORMAT_MOD_LINEAR:
> case I915_FORMAT_MOD_X_TILED:
> case I915_FORMAT_MOD_Y_TILED:
> case I915_FORMAT_MOD_Yf_TILED:
> --
> 2.25.1
--
Ville Syrjälä
Intel
Re: [Intel-gfx] [PATCHv3] drm/i915: Support Async Flip on Linear buffers
Gentle Reminder!
Thanks and Regards,
Arun R Murthy
> -Original Message-
> From: Murthy, Arun R
> Sent: Monday, July 4, 2022 9:46 PM
> To: intel-gfx@lists.freedesktop.org
> Cc: ville.syrj...@linux.intel.com; Shankar, Uma ;
> Murthy, Arun R
> Subject: [PATCHv3] drm/i915: Support Async Flip on Linear buffers
>
> Intel Gen do support Async Flip is supported on linear buffers. Since we
> didn't had a use case, it was not enabled. Now that as part of hybrid graphics
> for unsupported hardware pixel formats, its being converted to linear
> memory and then flipped, hence enabling!
> This patch enables support for async on linear buffer.
>
> v2: added use case
> v3: enabled async on linear for pre Gen 12 as well
>
> Signed-off-by: Arun R Murthy
> ---
> drivers/gpu/drm/i915/display/intel_display.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display.c
> b/drivers/gpu/drm/i915/display/intel_display.c
> index a0f84cbe974f..99ad67af74e3 100644
> --- a/drivers/gpu/drm/i915/display/intel_display.c
> +++ b/drivers/gpu/drm/i915/display/intel_display.c
> @@ -6614,6 +6614,7 @@ static int intel_async_flip_check_hw(struct
> intel_atomic_state *state, struct in
>* this selectively if required.
>*/
> switch (new_plane_state->hw.fb->modifier) {
> + case DRM_FORMAT_MOD_LINEAR:
> case I915_FORMAT_MOD_X_TILED:
> case I915_FORMAT_MOD_Y_TILED:
> case I915_FORMAT_MOD_Yf_TILED:
> --
> 2.25.1
[Intel-gfx] [PATCHv3] drm/i915: Support Async Flip on Linear buffers
Intel Gen do support Async Flip is supported on linear buffers. Since we
didn't had a use case, it was not enabled. Now that as part of hybrid
graphics for unsupported hardware pixel formats, its being converted to
linear memory and then flipped, hence enabling!
This patch enables support for async on linear buffer.
v2: added use case
v3: enabled async on linear for pre Gen 12 as well
Signed-off-by: Arun R Murthy
---
drivers/gpu/drm/i915/display/intel_display.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/i915/display/intel_display.c
b/drivers/gpu/drm/i915/display/intel_display.c
index a0f84cbe974f..99ad67af74e3 100644
--- a/drivers/gpu/drm/i915/display/intel_display.c
+++ b/drivers/gpu/drm/i915/display/intel_display.c
@@ -6614,6 +6614,7 @@ static int intel_async_flip_check_hw(struct
intel_atomic_state *state, struct in
* this selectively if required.
*/
switch (new_plane_state->hw.fb->modifier) {
+ case DRM_FORMAT_MOD_LINEAR:
case I915_FORMAT_MOD_X_TILED:
case I915_FORMAT_MOD_Y_TILED:
case I915_FORMAT_MOD_Yf_TILED:
--
2.25.1
