Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm: drm_plane_helper_check_state() related stuff
On Wed, Nov 01, 2017 at 07:46:18PM -, Patchwork wrote: > == Series Details == > > Series: drm: drm_plane_helper_check_state() related stuff > URL : https://patchwork.freedesktop.org/series/33002/ > State : failure > > == Summary == > > Series 33002v1 drm: drm_plane_helper_check_state() related stuff > https://patchwork.freedesktop.org/api/1.0/series/33002/revisions/1/mbox/ > > Test chamelium: > Subgroup dp-edid-read: > pass -> DMESG-WARN (fi-kbl-7500u) fdo#102672 > Subgroup dp-crc-fast: > pass -> DMESG-WARN (fi-kbl-7500u) fdo#102514 > Subgroup hdmi-edid-read: > pass -> DMESG-WARN (fi-skl-6700k) > Subgroup hdmi-crc-fast: > pass -> DMESG-WARN (fi-skl-6700k) > Subgroup common-hpd-after-suspend: > pass -> DMESG-WARN (fi-skl-6700k) Thinko in my WARNs. I guess it needs to be something like: - WARN_ON(!crtc_state != !plane_state->crtc); - WARN_ON(crtc_state && crtc_state->crtc != plane_state->crtc); + WARN_ON(plane_state->crtc && plane_state->crtc != crtc_state->crtc); since we grab the crtc from the old plane state if the new plane state doesn't have one. And thus the crtc state we pass around may refer to the old crtc, not the new one (well, there won't be a new one in those cases). Although I'm not sure how sensible it is to use the crtc state of the old crtc for state computation/checks in general. Feels a bit iffy at least. -- Ville Syrjälä Intel OTC ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] ✗ Fi.CI.BAT: failure for drm: drm_plane_helper_check_state() related stuff
== Series Details == Series: drm: drm_plane_helper_check_state() related stuff URL : https://patchwork.freedesktop.org/series/33002/ State : failure == Summary == Series 33002v1 drm: drm_plane_helper_check_state() related stuff https://patchwork.freedesktop.org/api/1.0/series/33002/revisions/1/mbox/ Test chamelium: Subgroup dp-edid-read: pass -> DMESG-WARN (fi-kbl-7500u) fdo#102672 Subgroup dp-crc-fast: pass -> DMESG-WARN (fi-kbl-7500u) fdo#102514 Subgroup hdmi-edid-read: pass -> DMESG-WARN (fi-skl-6700k) Subgroup hdmi-crc-fast: pass -> DMESG-WARN (fi-skl-6700k) Subgroup common-hpd-after-suspend: pass -> DMESG-WARN (fi-skl-6700k) Test debugfs_test: Subgroup read_all_entries: pass -> DMESG-WARN (fi-gdg-551) pass -> DMESG-WARN (fi-blb-e6850) pass -> DMESG-WARN (fi-pnv-d510) pass -> DMESG-WARN (fi-bwr-2160) pass -> DMESG-WARN (fi-elk-e7500) pass -> DMESG-WARN (fi-ilk-650) pass -> DMESG-WARN (fi-snb-2520m) pass -> DMESG-WARN (fi-snb-2600) pass -> DMESG-WARN (fi-ivb-3520m) pass -> DMESG-WARN (fi-ivb-3770) pass -> DMESG-WARN (fi-byt-j1900) pass -> DMESG-WARN (fi-byt-n2820) pass -> DMESG-WARN (fi-hsw-4770) pass -> DMESG-WARN (fi-hsw-4770r) pass -> DMESG-WARN (fi-bdw-5557u) pass -> DMESG-WARN (fi-bdw-gvtdvm) pass -> DMESG-WARN (fi-bsw-n3050) pass -> DMESG-WARN (fi-skl-6260u) pass -> DMESG-WARN (fi-skl-6600u) pass -> DMESG-WARN (fi-skl-6700hq) pass -> DMESG-WARN (fi-skl-6700k) pass -> DMESG-WARN (fi-skl-6770hq) pass -> DMESG-WARN (fi-skl-gvtdvm) pass -> DMESG-WARN (fi-bxt-dsi) pass -> DMESG-WARN (fi-bxt-j4205) pass -> DMESG-WARN (fi-kbl-7500u) fdo#103285 pass -> DMESG-WARN (fi-kbl-7560u) pass -> DMESG-WARN (fi-kbl-7567u) pass -> DMESG-WARN (fi-kbl-r) pass -> DMESG-WARN (fi-glk-1) pass -> DMESG-WARN (fi-glk-dsi) pass -> DMESG-WARN (fi-cfl-s) fdo#103186 pass -> DMESG-WARN (fi-cnl-y) Test drv_hangman: Subgroup error-state-basic: pass -> DMESG-WARN (fi-gdg-551) pass -> DMESG-WARN (fi-blb-e6850) pass -> DMESG-WARN (fi-pnv-d510) pass -> DMESG-WARN (fi-bwr-2160) Test gem_busy: Subgroup basic-hang-default: pass -> DMESG-WARN (fi-blb-e6850) pass -> DMESG-WARN (fi-pnv-d510) Test gem_exec_fence: Subgroup await-hang-default: pass -> DMESG-WARN (fi-blb-e6850) pass -> DMESG-WARN (fi-pnv-d510) Test gem_exec_suspend: Subgroup basic-s3: pass -> DMESG-WARN (fi-blb-e6850) pass -> DMESG-WARN (fi-pnv-d510) pass -> DMESG-WARN (fi-elk-e7500) pass -> DMESG-WARN (fi-ilk-650) pass -> DMESG-WARN (fi-snb-2520m) pass -> DMESG-WARN (fi-snb-2600) fdo#102365 pass -> DMESG-WARN (fi-ivb-3520m) pass -> DMESG-WARN (fi-ivb-3770) pass -> DMESG-WARN (fi-byt-j1900) pass -> DMESG-WARN (fi-byt-n2820) pass -> DMESG-WARN (fi-hsw-4770) pass -> DMESG-WARN (fi-hsw-4770r) pass -> DMESG-WARN (fi-bdw-5557u) pass -> DMESG-WARN (fi-bdw-gvtdvm) pass -> DMESG-WARN (fi-bsw-n3050) pass -> DMESG-WARN (fi-skl-6260u) pass -> DMESG-WARN (fi-skl-6600u) pass -> DMESG-WARN (fi-skl-6700hq) pass -> DMESG-WARN (fi-skl-6700k) pass -> DMESG-WARN (fi-skl-6770hq) pass -> DMESG-WARN (fi-skl-gvtdvm) pass -> DMESG-WARN (fi-bxt-dsi) pass -> DMESG-WARN (fi-bxt-j4205) pass -> DMESG-WARN (fi-kbl-7500u) pass -> DMESG-FAIL (fi-kbl-7560u) fdo#103039 pass -> DMESG-WARN (fi-kbl-7567u) fdo#102846 +11 pass -> DMESG-WARN (fi-glk-1) pass -> DMESG-WARN (fi-glk-dsi) pass -> DMESG-WARN (fi-cnl-y)
