[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Reword warning for missing cases (rev2)
== Series Details == Series: drm/i915: Reword warning for missing cases (rev2) URL : https://patchwork.freedesktop.org/series/39821/ State : warning == Summary == $ dim checkpatch origin/drm-tip 82628817d5f1 drm/i915: Reword warning for missing cases -:41: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'x' - possible side-effects? #41: FILE: drivers/gpu/drm/i915/i915_utils.h:43: +#define MISSING_CASE(x) WARN(1, "Missing case (%s == %ld)\n", \ +__stringify(x), (long)(x)) total: 0 errors, 0 warnings, 1 checks, 10 lines checked ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Reword warning for missing cases (rev2)
CCing checkpatch maintainers
On Mon, Mar 19, 2018 at 06:36:16PM +, Patchwork wrote:
> == Series Details ==
>
> Series: drm/i915: Reword warning for missing cases (rev2)
> URL : https://patchwork.freedesktop.org/series/39821/
> State : warning
>
> == Summary ==
>
> $ dim checkpatch origin/drm-tip
> 7cb94d2c3c47 drm/i915: Reword warning for missing cases
> -:40: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'x' - possible side-effects?
> #40: FILE: drivers/gpu/drm/i915/i915_utils.h:43:
> +#define MISSING_CASE(x) WARN(1, "Missing case (%s == %ld)\n", \
> + __stringify(x), (long)(x))
checkpatch seems wrong here since __stringify() doesn't evaluate x. And
it looks similar to the one fixed by
e942e2c3f7e0 ("checkpatch: fix stringification macro defect")
Lucas De Marchi
>
> total: 0 errors, 0 warnings, 1 checks, 10 lines checked
>
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Reword warning for missing cases (rev2)
== Series Details == Series: drm/i915: Reword warning for missing cases (rev2) URL : https://patchwork.freedesktop.org/series/39821/ State : warning == Summary == $ dim checkpatch origin/drm-tip 7cb94d2c3c47 drm/i915: Reword warning for missing cases -:40: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'x' - possible side-effects? #40: FILE: drivers/gpu/drm/i915/i915_utils.h:43: +#define MISSING_CASE(x) WARN(1, "Missing case (%s == %ld)\n", \ +__stringify(x), (long)(x)) total: 0 errors, 0 warnings, 1 checks, 10 lines checked ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
