[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Adding NV12 support (rev10)
== Series Details ==
Series: Adding NV12 support (rev10)
URL : https://patchwork.freedesktop.org/series/28103/
State : warning
== Summary ==
$ dim sparse origin/drm-tip
Commit: drm/i915/skl+: rename skl_wm_values struct to skl_ddb_values
Okay!
Commit: drm/i915/skl+: refactor WM calculation for NV12
-drivers/gpu/drm/i915/gvt/mmio.c:256:23: warning: memcpy with byte count of
279040
-drivers/gpu/drm/i915/gvt/mmio.c:257:23: warning: memcpy with byte count of
279040
+ ^~
+^~
-drivers/gpu/drm/i915/i915_perf.c:1366:15: warning: memset with byte count of
16777216
-drivers/gpu/drm/i915/i915_perf.c:1424:15: warning: memset with byte count of
16777216
+drivers/gpu/drm/i915/intel_pm.c:4656:19: error: no member 'is_nv12' in struct
skl_plane_wm
+drivers/gpu/drm/i915/intel_pm.c:4656:19: warning: generating address of
non-lvalue (8)
+drivers/gpu/drm/i915/intel_pm.c:4656:5: error: ‘struct skl_plane_wm’ has no
member named ‘is_nv12’
+drivers/gpu/drm/i915/intel_pm.c:4834:15: error: no member 'is_nv12' in struct
skl_plane_wm
+drivers/gpu/drm/i915/intel_pm.c:4834:15: warning: unknown expression (8 46)
+drivers/gpu/drm/i915/intel_pm.c:4834:8: error: ‘const struct skl_plane_wm’ has
no member named ‘is_nv12’
+drivers/gpu/drm/i915/intel_pm.c: In function ‘skl_compute_wm_levels’:
+drivers/gpu/drm/i915/intel_pm.c: In function ‘skl_write_plane_wm’:
+ if (wm->is_nv12) {
+make[1]: *** [drivers/gpu/drm/i915] Error 2
+make[2]: *** [drivers/gpu/drm/i915/intel_pm.o] Error 1
+make[2]: *** Waiting for unfinished jobs
+make[2]: *** wait: No child processes. Stop.
+make: *** [drivers/gpu/drm/] Error 2
+ wm->is_nv12 = true;
Commit: drm/i915/skl+: add NV12 in skl_format_to_fourcc
-drivers/gpu/drm/i915/gvt/mmio.c:256:23: warning: memcpy with byte count of
279040
-drivers/gpu/drm/i915/gvt/mmio.c:257:23: warning: memcpy with byte count of
279040
-drivers/gpu/drm/i915/i915_perf.c:1366:15: warning: memset with byte count of
16777216
-drivers/gpu/drm/i915/i915_perf.c:1424:15: warning: memset with byte count of
16777216
Commit: drm/i915/skl+: support verification of DDB HW state for NV12
Okay!
Commit: drm/i915/skl+: NV12 related changes for WM
- ^~
-^~
+drivers/gpu/drm/i915/gvt/mmio.c:256:23: warning: memcpy with byte count of
279040
+drivers/gpu/drm/i915/gvt/mmio.c:257:23: warning: memcpy with byte count of
279040
+drivers/gpu/drm/i915/i915_perf.c:1366:15: warning: memset with byte count of
16777216
+drivers/gpu/drm/i915/i915_perf.c:1424:15: warning: memset with byte count of
16777216
-O:drivers/gpu/drm/i915/intel_pm.c:4687:19: error: no member 'is_nv12' in
struct skl_plane_wm
-O:drivers/gpu/drm/i915/intel_pm.c:4687:19: warning: generating address of
non-lvalue (8)
-O:drivers/gpu/drm/i915/intel_pm.c:4687:5: error: ‘struct skl_plane_wm’ has no
member named ‘is_nv12’
-O:drivers/gpu/drm/i915/intel_pm.c:4865:15: error: no member 'is_nv12' in
struct skl_plane_wm
-O:drivers/gpu/drm/i915/intel_pm.c:4865:15: warning: unknown expression (8 46)
-O:drivers/gpu/drm/i915/intel_pm.c:4865:8: error: ‘const struct skl_plane_wm’
has no member named ‘is_nv12’
-drivers/gpu/drm/i915/intel_pm.c: In function ‘skl_compute_wm_levels’:
-drivers/gpu/drm/i915/intel_pm.c: In function ‘skl_write_plane_wm’:
- if (wm->is_nv12) {
-make[1]: *** [drivers/gpu/drm/i915] Error 2
-make[2]: *** [drivers/gpu/drm/i915/intel_pm.o] Error 1
-make[2]: *** Waiting for unfinished jobs
-make[2]: *** wait: No child processes. Stop.
-make: *** [drivers/gpu/drm/] Error 2
- wm->is_nv12 = true;
Commit: drm/i915/skl+: pass skl_wm_level struct to wm compute func
Okay!
Commit: drm/i915/skl+: make sure higher latency level has higher wm value
Okay!
Commit: drm/i915/skl+: nv12 workaround disable WM level 1-7
Okay!
Commit: drm/i915/skl: split skl_compute_ddb function
Okay!
Commit: drm/i915: Set scaler mode for NV12
Okay!
Commit: drm/i915: Update format_is_yuv() to include NV12
Okay!
Commit: drm/i915: Upscale scaler max scale for NV12
Okay!
Commit: drm/i915: Add NV12 as supported format for primary plane
Okay!
Commit: drm/i915: Add NV12 as supported format for sprite plane
Okay!
Commit: drm/i915: Add NV12 support to intel_framebuffer_init
Okay!
Commit: drm/i915: Enable YUV to RGB for Gen10 in Plane Ctrl Reg
Okay!
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] ✗ Fi.CI.SPARSE: warning for Adding NV12 support (rev10)
On Wed, Feb 14, 2018 at 02:07:49PM +0100, Maarten Lankhorst wrote:
> Op 14-02-18 om 13:37 schreef Patchwork:
> > == Series Details ==
> >
> > Series: Adding NV12 support (rev10)
> > URL : https://patchwork.freedesktop.org/series/28103/
> > State : warning
> >
> > == Summary ==
> >
> > $ dim sparse origin/drm-tip
> > Commit: drm/i915/skl+: rename skl_wm_values struct to skl_ddb_values
> > Okay!
> >
> > Commit: drm/i915/skl+: refactor WM calculation for NV12
> > -drivers/gpu/drm/i915/gvt/mmio.c:256:23: warning: memcpy with byte count of
> > 279040
> > -drivers/gpu/drm/i915/gvt/mmio.c:257:23: warning: memcpy with byte count of
> > 279040
> > + ^~
> > +^~
> > -drivers/gpu/drm/i915/i915_perf.c:1366:15: warning: memset with byte count
> > of 16777216
> > -drivers/gpu/drm/i915/i915_perf.c:1424:15: warning: memset with byte count
> > of 16777216
> > +drivers/gpu/drm/i915/intel_pm.c:4656:19: error: no member 'is_nv12' in
> > struct skl_plane_wm
> > +drivers/gpu/drm/i915/intel_pm.c:4656:19: warning: generating address of
> > non-lvalue (8)
> > +drivers/gpu/drm/i915/intel_pm.c:4656:5: error: ‘struct skl_plane_wm’ has
> > no member named ‘is_nv12’
> > +drivers/gpu/drm/i915/intel_pm.c:4834:15: error: no member 'is_nv12' in
> > struct skl_plane_wm
> > +drivers/gpu/drm/i915/intel_pm.c:4834:15: warning: unknown expression (8 46)
> > +drivers/gpu/drm/i915/intel_pm.c:4834:8: error: ‘const struct skl_plane_wm’
> > has no member named ‘is_nv12’
> > +drivers/gpu/drm/i915/intel_pm.c: In function ‘skl_compute_wm_levels’:
> > +drivers/gpu/drm/i915/intel_pm.c: In function ‘skl_write_plane_wm’:
> > + if (wm->is_nv12) {
> > +make[1]: *** [drivers/gpu/drm/i915] Error 2
> > +make[2]: *** [drivers/gpu/drm/i915/intel_pm.o] Error 1
> > +make[2]: *** Waiting for unfinished jobs
> > +make[2]: *** wait: No child processes. Stop.
> > +make: *** [drivers/gpu/drm/] Error 2
> > + wm->is_nv12 = true;
> >
> > Commit: drm/i915/skl+: add NV12 in skl_format_to_fourcc
> > -drivers/gpu/drm/i915/i915_perf.c:1366:15: warning: memset with byte count
> > of 16777216
> > -drivers/gpu/drm/i915/i915_perf.c:1424:15: warning: memset with byte count
> > of 16777216
> > +drivers/gpu/drm/i915/gvt/mmio.c:256:23: warning: memcpy with byte count of
> > 279040
> > +drivers/gpu/drm/i915/gvt/mmio.c:257:23: warning: memcpy with byte count of
> > 279040
> >
> > Commit: drm/i915/skl+: support verification of DDB HW state for NV12
> > -make[2]: *** wait: No child processes. Stop.
> >
> > Commit: drm/i915/skl+: NV12 related changes for WM
> > - ^~
> > -^~
> > +drivers/gpu/drm/i915/gvt/mmio.c:256:23: warning: memcpy with byte count of
> > 279040
> > +drivers/gpu/drm/i915/gvt/mmio.c:257:23: warning: memcpy with byte count of
> > 279040
> > +drivers/gpu/drm/i915/i915_perf.c:1366:15: warning: memset with byte count
> > of 16777216
> > +drivers/gpu/drm/i915/i915_perf.c:1424:15: warning: memset with byte count
> > of 16777216
> > -O:drivers/gpu/drm/i915/intel_pm.c:4687:19: error: no member 'is_nv12' in
> > struct skl_plane_wm
> > -O:drivers/gpu/drm/i915/intel_pm.c:4687:19: warning: generating address of
> > non-lvalue (8)
> > -O:drivers/gpu/drm/i915/intel_pm.c:4687:5: error: ‘struct skl_plane_wm’ has
> > no member named ‘is_nv12’
> > -O:drivers/gpu/drm/i915/intel_pm.c:4865:15: error: no member 'is_nv12' in
> > struct skl_plane_wm
> > -O:drivers/gpu/drm/i915/intel_pm.c:4865:15: warning: unknown expression (8
> > 46)
> > -O:drivers/gpu/drm/i915/intel_pm.c:4865:8: error: ‘const struct
> > skl_plane_wm’ has no member named ‘is_nv12’
> > -drivers/gpu/drm/i915/intel_pm.c: In function ‘skl_compute_wm_levels’:
> > -drivers/gpu/drm/i915/intel_pm.c: In function ‘skl_write_plane_wm’:
> > - if (wm->is_nv12) {
> > -make[1]: *** [drivers/gpu/drm/i915] Error 2
> > -make[2]: *** [drivers/gpu/drm/i915/intel_pm.o] Error 1
> > -make[2]: *** Waiting for unfinished jobs
> > -make[2]: *** wait: No child processes. Stop.
> > -make: *** [drivers/gpu/drm/] Error 2
> > - wm->is_nv12 = true;
> Looks like not all commits compile on their own?
> ~Maarten
Yep. That is exactly the case. We run sparse build incrementally, i.e.
applying one patch after another, building and looking for any
difference in what is reported.
Patch
> Commit: drm/i915/skl+: rename skl_wm_values struct to skl_ddb_values
breaks compilation.
Please fix that. You can check your series locally with something like:
git rebase HEAD~12 --exec make
--
Cheers,
Arek
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] ✗ Fi.CI.SPARSE: warning for Adding NV12 support (rev10)
Op 14-02-18 om 13:37 schreef Patchwork:
> == Series Details ==
>
> Series: Adding NV12 support (rev10)
> URL : https://patchwork.freedesktop.org/series/28103/
> State : warning
>
> == Summary ==
>
> $ dim sparse origin/drm-tip
> Commit: drm/i915/skl+: rename skl_wm_values struct to skl_ddb_values
> Okay!
>
> Commit: drm/i915/skl+: refactor WM calculation for NV12
> -drivers/gpu/drm/i915/gvt/mmio.c:256:23: warning: memcpy with byte count of
> 279040
> -drivers/gpu/drm/i915/gvt/mmio.c:257:23: warning: memcpy with byte count of
> 279040
> + ^~
> +^~
> -drivers/gpu/drm/i915/i915_perf.c:1366:15: warning: memset with byte count of
> 16777216
> -drivers/gpu/drm/i915/i915_perf.c:1424:15: warning: memset with byte count of
> 16777216
> +drivers/gpu/drm/i915/intel_pm.c:4656:19: error: no member 'is_nv12' in
> struct skl_plane_wm
> +drivers/gpu/drm/i915/intel_pm.c:4656:19: warning: generating address of
> non-lvalue (8)
> +drivers/gpu/drm/i915/intel_pm.c:4656:5: error: ‘struct skl_plane_wm’ has no
> member named ‘is_nv12’
> +drivers/gpu/drm/i915/intel_pm.c:4834:15: error: no member 'is_nv12' in
> struct skl_plane_wm
> +drivers/gpu/drm/i915/intel_pm.c:4834:15: warning: unknown expression (8 46)
> +drivers/gpu/drm/i915/intel_pm.c:4834:8: error: ‘const struct skl_plane_wm’
> has no member named ‘is_nv12’
> +drivers/gpu/drm/i915/intel_pm.c: In function ‘skl_compute_wm_levels’:
> +drivers/gpu/drm/i915/intel_pm.c: In function ‘skl_write_plane_wm’:
> + if (wm->is_nv12) {
> +make[1]: *** [drivers/gpu/drm/i915] Error 2
> +make[2]: *** [drivers/gpu/drm/i915/intel_pm.o] Error 1
> +make[2]: *** Waiting for unfinished jobs
> +make[2]: *** wait: No child processes. Stop.
> +make: *** [drivers/gpu/drm/] Error 2
> + wm->is_nv12 = true;
>
> Commit: drm/i915/skl+: add NV12 in skl_format_to_fourcc
> -drivers/gpu/drm/i915/i915_perf.c:1366:15: warning: memset with byte count of
> 16777216
> -drivers/gpu/drm/i915/i915_perf.c:1424:15: warning: memset with byte count of
> 16777216
> +drivers/gpu/drm/i915/gvt/mmio.c:256:23: warning: memcpy with byte count of
> 279040
> +drivers/gpu/drm/i915/gvt/mmio.c:257:23: warning: memcpy with byte count of
> 279040
>
> Commit: drm/i915/skl+: support verification of DDB HW state for NV12
> -make[2]: *** wait: No child processes. Stop.
>
> Commit: drm/i915/skl+: NV12 related changes for WM
> - ^~
> -^~
> +drivers/gpu/drm/i915/gvt/mmio.c:256:23: warning: memcpy with byte count of
> 279040
> +drivers/gpu/drm/i915/gvt/mmio.c:257:23: warning: memcpy with byte count of
> 279040
> +drivers/gpu/drm/i915/i915_perf.c:1366:15: warning: memset with byte count of
> 16777216
> +drivers/gpu/drm/i915/i915_perf.c:1424:15: warning: memset with byte count of
> 16777216
> -O:drivers/gpu/drm/i915/intel_pm.c:4687:19: error: no member 'is_nv12' in
> struct skl_plane_wm
> -O:drivers/gpu/drm/i915/intel_pm.c:4687:19: warning: generating address of
> non-lvalue (8)
> -O:drivers/gpu/drm/i915/intel_pm.c:4687:5: error: ‘struct skl_plane_wm’ has
> no member named ‘is_nv12’
> -O:drivers/gpu/drm/i915/intel_pm.c:4865:15: error: no member 'is_nv12' in
> struct skl_plane_wm
> -O:drivers/gpu/drm/i915/intel_pm.c:4865:15: warning: unknown expression (8 46)
> -O:drivers/gpu/drm/i915/intel_pm.c:4865:8: error: ‘const struct skl_plane_wm’
> has no member named ‘is_nv12’
> -drivers/gpu/drm/i915/intel_pm.c: In function ‘skl_compute_wm_levels’:
> -drivers/gpu/drm/i915/intel_pm.c: In function ‘skl_write_plane_wm’:
> - if (wm->is_nv12) {
> -make[1]: *** [drivers/gpu/drm/i915] Error 2
> -make[2]: *** [drivers/gpu/drm/i915/intel_pm.o] Error 1
> -make[2]: *** Waiting for unfinished jobs
> -make[2]: *** wait: No child processes. Stop.
> -make: *** [drivers/gpu/drm/] Error 2
> - wm->is_nv12 = true;
Looks like not all commits compile on their own?
~Maarten
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Adding NV12 support (rev10)
== Series Details ==
Series: Adding NV12 support (rev10)
URL : https://patchwork.freedesktop.org/series/28103/
State : warning
== Summary ==
$ dim sparse origin/drm-tip
Commit: drm/i915/skl+: rename skl_wm_values struct to skl_ddb_values
Okay!
Commit: drm/i915/skl+: refactor WM calculation for NV12
-drivers/gpu/drm/i915/gvt/mmio.c:256:23: warning: memcpy with byte count of
279040
-drivers/gpu/drm/i915/gvt/mmio.c:257:23: warning: memcpy with byte count of
279040
+ ^~
+^~
-drivers/gpu/drm/i915/i915_perf.c:1366:15: warning: memset with byte count of
16777216
-drivers/gpu/drm/i915/i915_perf.c:1424:15: warning: memset with byte count of
16777216
+drivers/gpu/drm/i915/intel_pm.c:4656:19: error: no member 'is_nv12' in struct
skl_plane_wm
+drivers/gpu/drm/i915/intel_pm.c:4656:19: warning: generating address of
non-lvalue (8)
+drivers/gpu/drm/i915/intel_pm.c:4656:5: error: ‘struct skl_plane_wm’ has no
member named ‘is_nv12’
+drivers/gpu/drm/i915/intel_pm.c:4834:15: error: no member 'is_nv12' in struct
skl_plane_wm
+drivers/gpu/drm/i915/intel_pm.c:4834:15: warning: unknown expression (8 46)
+drivers/gpu/drm/i915/intel_pm.c:4834:8: error: ‘const struct skl_plane_wm’ has
no member named ‘is_nv12’
+drivers/gpu/drm/i915/intel_pm.c: In function ‘skl_compute_wm_levels’:
+drivers/gpu/drm/i915/intel_pm.c: In function ‘skl_write_plane_wm’:
+ if (wm->is_nv12) {
+make[1]: *** [drivers/gpu/drm/i915] Error 2
+make[2]: *** [drivers/gpu/drm/i915/intel_pm.o] Error 1
+make[2]: *** Waiting for unfinished jobs
+make[2]: *** wait: No child processes. Stop.
+make: *** [drivers/gpu/drm/] Error 2
+ wm->is_nv12 = true;
Commit: drm/i915/skl+: add NV12 in skl_format_to_fourcc
-drivers/gpu/drm/i915/i915_perf.c:1366:15: warning: memset with byte count of
16777216
-drivers/gpu/drm/i915/i915_perf.c:1424:15: warning: memset with byte count of
16777216
+drivers/gpu/drm/i915/gvt/mmio.c:256:23: warning: memcpy with byte count of
279040
+drivers/gpu/drm/i915/gvt/mmio.c:257:23: warning: memcpy with byte count of
279040
Commit: drm/i915/skl+: support verification of DDB HW state for NV12
-make[2]: *** wait: No child processes. Stop.
Commit: drm/i915/skl+: NV12 related changes for WM
- ^~
-^~
+drivers/gpu/drm/i915/gvt/mmio.c:256:23: warning: memcpy with byte count of
279040
+drivers/gpu/drm/i915/gvt/mmio.c:257:23: warning: memcpy with byte count of
279040
+drivers/gpu/drm/i915/i915_perf.c:1366:15: warning: memset with byte count of
16777216
+drivers/gpu/drm/i915/i915_perf.c:1424:15: warning: memset with byte count of
16777216
-O:drivers/gpu/drm/i915/intel_pm.c:4687:19: error: no member 'is_nv12' in
struct skl_plane_wm
-O:drivers/gpu/drm/i915/intel_pm.c:4687:19: warning: generating address of
non-lvalue (8)
-O:drivers/gpu/drm/i915/intel_pm.c:4687:5: error: ‘struct skl_plane_wm’ has no
member named ‘is_nv12’
-O:drivers/gpu/drm/i915/intel_pm.c:4865:15: error: no member 'is_nv12' in
struct skl_plane_wm
-O:drivers/gpu/drm/i915/intel_pm.c:4865:15: warning: unknown expression (8 46)
-O:drivers/gpu/drm/i915/intel_pm.c:4865:8: error: ‘const struct skl_plane_wm’
has no member named ‘is_nv12’
-drivers/gpu/drm/i915/intel_pm.c: In function ‘skl_compute_wm_levels’:
-drivers/gpu/drm/i915/intel_pm.c: In function ‘skl_write_plane_wm’:
- if (wm->is_nv12) {
-make[1]: *** [drivers/gpu/drm/i915] Error 2
-make[2]: *** [drivers/gpu/drm/i915/intel_pm.o] Error 1
-make[2]: *** Waiting for unfinished jobs
-make[2]: *** wait: No child processes. Stop.
-make: *** [drivers/gpu/drm/] Error 2
- wm->is_nv12 = true;
Commit: drm/i915/skl+: pass skl_wm_level struct to wm compute func
Okay!
Commit: drm/i915/skl+: make sure higher latency level has higher wm value
Okay!
Commit: drm/i915/skl+: nv12 workaround disable WM level 1-7
Okay!
Commit: drm/i915/skl: split skl_compute_ddb function
Okay!
Commit: drm/i915: Set scaler mode for NV12
Okay!
Commit: drm/i915: Update format_is_yuv() to include NV12
Okay!
Commit: drm/i915: Upscale scaler max scale for NV12
Okay!
Commit: drm/i915: Add NV12 as supported format for primary plane
Okay!
Commit: drm/i915: Add NV12 as supported format for sprite plane
Okay!
Commit: drm/i915: Add NV12 support to intel_framebuffer_init
Okay!
Commit: drm/i915: Enable YUV to RGB for Gen10 in Plane Ctrl Reg
Okay!
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
