Re: [Intel-gfx] Guc parameter Handling
On Thu, Dec 15, 2016 at 10:36:40PM +, Srivatsa, Anusha wrote: > Hi All, > > I was wondering if we intend to keep -1 and 2 for the > enable_guc_submission parameter. Since now we are gating guc loads if > either guc_submission or enable_huc parameter is set, why have a > -1(platform default) and 2(forcefully load) option? We anyway do not > have any special default set per platform. For now the default is 0 on > all platforms. Moving forward if GuC gets more stable and we want to > set a default to a certain platform, we can add -1 then. > > Also, why have a 2? We can use enable_guc_submission=1 in order to > make sure the guc is loaded and guc_submission is enabled and set > enable_guc_submission=0 to make sure guc submission is not used. I've asked around on IRC yesterday for the exact same thing, and it seems that no one realy does remembery why the "2" was introduced in the first place. We not simplifying it, if we do not have real use case for having 1 and 2 separate? > Any thought on this? > Cheers, > Anusha -- Cheers, Arek ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] Guc parameter Handling
On 2016.12.15 22:36:40 +, Srivatsa, Anusha wrote: > Hi All, > > > > I was wondering if we intend to keep -1 and 2 for the enable_guc_submission > parameter. Since now we are gating guc loads if either guc_submission or > enable_huc parameter is set, why have a -1(platform default) and 2(forcefully > load) option? We anyway do not have any special default set per platform. For > now the default is 0 on all platforms. Moving forward if GuC gets more stable > and we want to set a default to a certain platform, we can add -1 then. > > > > Also, why have a 2? We can use enable_guc_submission=1 in order to make sure > the guc is loaded and guc_submission is enabled and set > enable_guc_submission=0 > to make sure guc submission is not used. > > > > Any thought on this? > > For gvt, we need to disable guc submission in guest on current hw. I just want to send one using current enable_guc_loading but if changed to guc_submission/enable_huc later, I'll hold till that settle down. To support HuC for guest, we will need to add extra pvinfo, so won't allow guest kernel to load huc firmware but tell guest driver that HuC is ready for use. thanks -- Open Source Technology Center, Intel ltd. $gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827 signature.asc Description: PGP signature ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] Guc parameter Handling
Hi All, I was wondering if we intend to keep -1 and 2 for the enable_guc_submission parameter. Since now we are gating guc loads if either guc_submission or enable_huc parameter is set, why have a -1(platform default) and 2(forcefully load) option? We anyway do not have any special default set per platform. For now the default is 0 on all platforms. Moving forward if GuC gets more stable and we want to set a default to a certain platform, we can add -1 then. Also, why have a 2? We can use enable_guc_submission=1 in order to make sure the guc is loaded and guc_submission is enabled and set enable_guc_submission=0 to make sure guc submission is not used. Any thought on this? Cheers, Anusha ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
