Re: [PATCH 1/5] drm/i915/irq: use DISPLAY_VER instead of GRAPHICS_VER

2024-01-05 Thread Jani Nikula 
On Thu, 04 Jan 2024, Matt Roper  wrote:
> On Thu, Jan 04, 2024 at 07:43:46PM +0200, Jani Nikula wrote:
>> Display code should not care about graphics version.
>> 
>> Signed-off-by: Jani Nikula 
>
> For the series:
>
> Reviewed-by: Matt Roper 

Thanks, pushed to drm-intel-next, with the tabs in commit message for
2/5 fixed.

BR,
Jani.

>
>> ---
>>  drivers/gpu/drm/i915/display/intel_display_irq.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/drivers/gpu/drm/i915/display/intel_display_irq.c 
>> b/drivers/gpu/drm/i915/display/intel_display_irq.c
>> index 6964f4b95865..99843883cef7 100644
>> --- a/drivers/gpu/drm/i915/display/intel_display_irq.c
>> +++ b/drivers/gpu/drm/i915/display/intel_display_irq.c
>> @@ -1587,7 +1587,7 @@ void ilk_de_irq_postinstall(struct drm_i915_private 
>> *i915)
>>  struct intel_uncore *uncore = &i915->uncore;
>>  u32 display_mask, extra_mask;
>>  
>> -if (GRAPHICS_VER(i915) >= 7) {
>> +if (DISPLAY_VER(i915) >= 7) {
>>  display_mask = (DE_MASTER_IRQ_CONTROL | DE_GSE_IVB |
>>  DE_PCH_EVENT_IVB | DE_AUX_CHANNEL_A_IVB);
>>  extra_mask = (DE_PIPEC_VBLANK_IVB | DE_PIPEB_VBLANK_IVB |
>> -- 
>> 2.39.2
>> 

-- 
Jani Nikula, Intel

Re: [PATCH 1/5] drm/i915/irq: use DISPLAY_VER instead of GRAPHICS_VER

2024-01-04 Thread Matt Roper 
On Thu, Jan 04, 2024 at 07:43:46PM +0200, Jani Nikula wrote:
> Display code should not care about graphics version.
> 
> Signed-off-by: Jani Nikula 

For the series:

Reviewed-by: Matt Roper 

> ---
>  drivers/gpu/drm/i915/display/intel_display_irq.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_display_irq.c 
> b/drivers/gpu/drm/i915/display/intel_display_irq.c
> index 6964f4b95865..99843883cef7 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_irq.c
> +++ b/drivers/gpu/drm/i915/display/intel_display_irq.c
> @@ -1587,7 +1587,7 @@ void ilk_de_irq_postinstall(struct drm_i915_private 
> *i915)
>   struct intel_uncore *uncore = &i915->uncore;
>   u32 display_mask, extra_mask;
>  
> - if (GRAPHICS_VER(i915) >= 7) {
> + if (DISPLAY_VER(i915) >= 7) {
>   display_mask = (DE_MASTER_IRQ_CONTROL | DE_GSE_IVB |
>   DE_PCH_EVENT_IVB | DE_AUX_CHANNEL_A_IVB);
>   extra_mask = (DE_PIPEC_VBLANK_IVB | DE_PIPEB_VBLANK_IVB |
> -- 
> 2.39.2
> 

-- 
Matt Roper
Graphics Software Engineer
Linux GPU Platform Enablement
Intel Corporation

[PATCH 1/5] drm/i915/irq: use DISPLAY_VER instead of GRAPHICS_VER

2024-01-04 Thread Jani Nikula 
Display code should not care about graphics version.

Signed-off-by: Jani Nikula 
---
 drivers/gpu/drm/i915/display/intel_display_irq.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/display/intel_display_irq.c 
b/drivers/gpu/drm/i915/display/intel_display_irq.c
index 6964f4b95865..99843883cef7 100644
--- a/drivers/gpu/drm/i915/display/intel_display_irq.c
+++ b/drivers/gpu/drm/i915/display/intel_display_irq.c
@@ -1587,7 +1587,7 @@ void ilk_de_irq_postinstall(struct drm_i915_private *i915)
struct intel_uncore *uncore = &i915->uncore;
u32 display_mask, extra_mask;
 
-   if (GRAPHICS_VER(i915) >= 7) {
+   if (DISPLAY_VER(i915) >= 7) {
display_mask = (DE_MASTER_IRQ_CONTROL | DE_GSE_IVB |
DE_PCH_EVENT_IVB | DE_AUX_CHANNEL_A_IVB);
extra_mask = (DE_PIPEC_VBLANK_IVB | DE_PIPEB_VBLANK_IVB |
-- 
2.39.2