Re: [PATCH 3/9] drm/i915: Drop 'uses_fence' parameter from intel_pin_fb_obj_dpt()

[Jani Nikula]

On Mon, 06 May 2024, Ville Syrjala  wrote:
> From: Ville Syrjälä 
>
> Fence regions are only relevant for GGTT, not DPT. Drop the
> pointless 'uses_fence' argument from intel_pin_fb_obj_dpt().
>
> Signed-off-by: Ville Syrjälä 

Reviewed-by: Jani Nikula 

> ---
>  drivers/gpu/drm/i915/display/intel_fb_pin.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_fb_pin.c 
> b/drivers/gpu/drm/i915/display/intel_fb_pin.c
> index be095cc696ba..2b50c1946c63 100644
> --- a/drivers/gpu/drm/i915/display/intel_fb_pin.c
> +++ b/drivers/gpu/drm/i915/display/intel_fb_pin.c
> @@ -20,7 +20,6 @@ static struct i915_vma *
>  intel_pin_fb_obj_dpt(struct drm_framebuffer *fb,
>const struct i915_gtt_view *view,
>unsigned int alignment,
> -  bool uses_fence,
>unsigned long *out_flags,
>struct i915_address_space *vm)
>  {
> @@ -274,8 +273,8 @@ int intel_plane_pin_fb(struct intel_plane_state 
> *plane_state)
>   plane_state->ggtt_vma = vma;
>  
>   vma = intel_pin_fb_obj_dpt(fb, _state->view.gtt,
> -alignment, false,
> -_state->flags, 
> intel_fb->dpt_vm);
> +alignment, _state->flags,
> +intel_fb->dpt_vm);
>   if (IS_ERR(vma)) {
>   intel_dpt_unpin(intel_fb->dpt_vm);
>   plane_state->ggtt_vma = NULL;

-- 
Jani Nikula, Intel

[PATCH 3/9] drm/i915: Drop 'uses_fence' parameter from intel_pin_fb_obj_dpt()

[Ville Syrjala]

From: Ville Syrjälä 

Fence regions are only relevant for GGTT, not DPT. Drop the
pointless 'uses_fence' argument from intel_pin_fb_obj_dpt().

Signed-off-by: Ville Syrjälä 
---
 drivers/gpu/drm/i915/display/intel_fb_pin.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_fb_pin.c 
b/drivers/gpu/drm/i915/display/intel_fb_pin.c
index be095cc696ba..2b50c1946c63 100644
--- a/drivers/gpu/drm/i915/display/intel_fb_pin.c
+++ b/drivers/gpu/drm/i915/display/intel_fb_pin.c
@@ -20,7 +20,6 @@ static struct i915_vma *
 intel_pin_fb_obj_dpt(struct drm_framebuffer *fb,
 const struct i915_gtt_view *view,
 unsigned int alignment,
-bool uses_fence,
 unsigned long *out_flags,
 struct i915_address_space *vm)
 {
@@ -274,8 +273,8 @@ int intel_plane_pin_fb(struct intel_plane_state 
*plane_state)
plane_state->ggtt_vma = vma;
 
vma = intel_pin_fb_obj_dpt(fb, _state->view.gtt,
-  alignment, false,
-  _state->flags, 
intel_fb->dpt_vm);
+  alignment, _state->flags,
+  intel_fb->dpt_vm);
if (IS_ERR(vma)) {
intel_dpt_unpin(intel_fb->dpt_vm);
plane_state->ggtt_vma = NULL;
-- 
2.43.2