Re: [PATCH v3 4/5] ASoC: codecs: hda: Cleanup error messages

[Mark Brown]

On Mon, Feb 26, 2024 at 01:44:31PM +0100, Cezary Rojewski wrote:
> Be cohesive and use same pattern in each error message.

Acked-by: Mark Brown 


signature.asc
Description: PGP signature

[PATCH v3 4/5] ASoC: codecs: hda: Cleanup error messages

[Cezary Rojewski]

Be cohesive and use same pattern in each error message.

Signed-off-by: Cezary Rojewski 
---
 sound/soc/codecs/hda.c | 10 +-
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/sound/soc/codecs/hda.c b/sound/soc/codecs/hda.c
index 7c6bedeceaa2..5a58723dc0e9 100644
--- a/sound/soc/codecs/hda.c
+++ b/sound/soc/codecs/hda.c
@@ -198,19 +198,19 @@ static int hda_codec_probe(struct snd_soc_component 
*component)
ret = snd_hda_codec_device_new(codec->bus, component->card->snd_card, 
hdev->addr, codec,
   false);
if (ret < 0) {
-   dev_err(>dev, "create hda codec failed: %d\n", ret);
+   dev_err(>dev, "codec create failed: %d\n", ret);
goto device_new_err;
}
 
ret = snd_hda_codec_set_name(codec, codec->preset->name);
if (ret < 0) {
-   dev_err(>dev, "name failed %s\n", codec->preset->name);
+   dev_err(>dev, "set name: %s failed: %d\n", 
codec->preset->name, ret);
goto err;
}
 
ret = snd_hdac_regmap_init(>core);
if (ret < 0) {
-   dev_err(>dev, "regmap init failed\n");
+   dev_err(>dev, "regmap init failed: %d\n", ret);
goto err;
}
 
@@ -223,13 +223,13 @@ static int hda_codec_probe(struct snd_soc_component 
*component)
 
ret = patch(codec);
if (ret < 0) {
-   dev_err(>dev, "patch failed %d\n", ret);
+   dev_err(>dev, "codec init failed: %d\n", ret);
goto err;
}
 
ret = snd_hda_codec_parse_pcms(codec);
if (ret < 0) {
-   dev_err(>dev, "unable to map pcms to dai %d\n", ret);
+   dev_err(>dev, "unable to map pcms to dai: %d\n", ret);
goto parse_pcms_err;
}
 
-- 
2.25.1