Re: [Intel-gfx] [PATCH 00/21] drm/i915: the great header refactoring, part two

2019-04-30 Thread Jani Nikula
On Tue, 30 Apr 2019, Chris Wilson  wrote:
> Quoting Jani Nikula (2019-04-29 13:29:18)
>> Continue the header refactoring started in part one [1].
>> 
>> BR,
>> Jani.
>> 
>> [1] https://patchwork.freedesktop.org/series/59022/
>> 
>> 
>> Jani Nikula (21):
>>   drm/i915: ensure more headers remain self-contained
>>   drm/i915: make intel_bios.h self-contained
>>   drm/i915/dvo: rename dvo.h to intel_dvo_dev.h and make self-contained
>>   drm/i915: make intel_dpll_mgr.h self-contained
>>   drm/i915: move dsi init functions to intel_dsi.h
>>   drm/i915: extract intel_fifo_underrun.h from intel_drv.h
>>   drm/i915: extract intel_dp_link_training.h from intel_drv.h
>>   drm/i915: extract intel_dp_aux_backlight.h from intel_drv.h
>>   drm/i915: extract i915_irq.h from intel_drv.h and i915_drv.h
>>   drm/i915: extract intel_hotplug.h from intel_drv.h and i915_drv.h
>>   drm/i915: extract intel_bios.h functions from i915_drv.h
>>   drm/i915: extract intel_quirks.h from intel_drv.h
>>   drm/i915: extract intel_overlay.h from intel_drv.h and i915_drv.h
>>   drm/i915: extract intel_vdsc.h from intel_drv.h and i915_drv.h
>>   drm/i915: extract intel_dp_mst.h from intel_drv.h
>>   drm/i915: extract intel_dsi_dcs_backlight.h from intel_drv.h
>>   drm/i915: extract intel_atomic.h from intel_drv.h
>>   drm/i915: extract intel_runtime_pm.h from intel_drv.h
>>   drm/i915: move some leftovers to intel_pm.h from i915_drv.h
>>   drm/i915: extract intel_combo_phy.h from i915_drv.h
>>   drm/i915: add single combo phy init/unit functions
>
> I read them all and they look sane. I trust the HDRTEST infrastructure
> to spot any typos, so
>
> Reviewed-by: Chris Wilson 

Thanks, pushed everything except the last one which conflicts. Will post
a rebased version.

I don't think any of these could cause the reported CI incompletes.

BR,
Jani.


-- 
Jani Nikula, Intel Open Source Graphics Center
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 00/21] drm/i915: the great header refactoring, part two

2019-04-30 Thread Chris Wilson
Quoting Jani Nikula (2019-04-29 13:29:18)
> Continue the header refactoring started in part one [1].
> 
> BR,
> Jani.
> 
> [1] https://patchwork.freedesktop.org/series/59022/
> 
> 
> Jani Nikula (21):
>   drm/i915: ensure more headers remain self-contained
>   drm/i915: make intel_bios.h self-contained
>   drm/i915/dvo: rename dvo.h to intel_dvo_dev.h and make self-contained
>   drm/i915: make intel_dpll_mgr.h self-contained
>   drm/i915: move dsi init functions to intel_dsi.h
>   drm/i915: extract intel_fifo_underrun.h from intel_drv.h
>   drm/i915: extract intel_dp_link_training.h from intel_drv.h
>   drm/i915: extract intel_dp_aux_backlight.h from intel_drv.h
>   drm/i915: extract i915_irq.h from intel_drv.h and i915_drv.h
>   drm/i915: extract intel_hotplug.h from intel_drv.h and i915_drv.h
>   drm/i915: extract intel_bios.h functions from i915_drv.h
>   drm/i915: extract intel_quirks.h from intel_drv.h
>   drm/i915: extract intel_overlay.h from intel_drv.h and i915_drv.h
>   drm/i915: extract intel_vdsc.h from intel_drv.h and i915_drv.h
>   drm/i915: extract intel_dp_mst.h from intel_drv.h
>   drm/i915: extract intel_dsi_dcs_backlight.h from intel_drv.h
>   drm/i915: extract intel_atomic.h from intel_drv.h
>   drm/i915: extract intel_runtime_pm.h from intel_drv.h
>   drm/i915: move some leftovers to intel_pm.h from i915_drv.h
>   drm/i915: extract intel_combo_phy.h from i915_drv.h
>   drm/i915: add single combo phy init/unit functions

I read them all and they look sane. I trust the HDRTEST infrastructure
to spot any typos, so

Reviewed-by: Chris Wilson 
-Chris
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx