Re: [Intel-gfx] [PATCH 41/43] drm/i915/bdw: Enable Logical Ring Contexts (hence, Execlists)

2014-08-18 Thread Jani Nikula
On Thu, 24 Jul 2014, Thomas Daniel thomas.dan...@intel.com wrote:
 From: Oscar Mateo oscar.ma...@intel.com

 The time has come, the Walrus said, to talk of many things.

FYI this causes https://bugs.freedesktop.org/show_bug.cgi?id=82740

 Signed-off-by: Oscar Mateo oscar.ma...@intel.com
 ---
  drivers/gpu/drm/i915/i915_drv.h |2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

 diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
 index b7cf0ec..1ce51d6 100644
 --- a/drivers/gpu/drm/i915/i915_drv.h
 +++ b/drivers/gpu/drm/i915/i915_drv.h
 @@ -2061,7 +2061,7 @@ struct drm_i915_cmd_table {
  #define I915_NEED_GFX_HWS(dev)   (INTEL_INFO(dev)-need_gfx_hws)
  
  #define HAS_HW_CONTEXTS(dev) (INTEL_INFO(dev)-gen = 6)
 -#define HAS_LOGICAL_RING_CONTEXTS(dev)   0
 +#define HAS_LOGICAL_RING_CONTEXTS(dev)   (INTEL_INFO(dev)-gen = 8)
  #define HAS_ALIASING_PPGTT(dev)  (INTEL_INFO(dev)-gen = 6)
  #define HAS_PPGTT(dev)   (INTEL_INFO(dev)-gen = 7  
 !IS_GEN8(dev))
  #define USES_PPGTT(dev)  intel_enable_ppgtt(dev, false)
 -- 
 1.7.9.5

 ___
 Intel-gfx mailing list
 Intel-gfx@lists.freedesktop.org
 http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Jani Nikula, Intel Open Source Technology Center
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx


Re: [Intel-gfx] [PATCH 41/43] drm/i915/bdw: Enable Logical Ring Contexts (hence, Execlists)

2014-08-18 Thread Daniel, Thomas


 -Original Message-
 From: Jani Nikula [mailto:jani.nik...@linux.intel.com]
 Sent: Monday, August 18, 2014 9:33 AM
 To: Daniel, Thomas; intel-gfx@lists.freedesktop.org
 Subject: Re: [Intel-gfx] [PATCH 41/43] drm/i915/bdw: Enable Logical Ring
 Contexts (hence, Execlists)
 
 On Thu, 24 Jul 2014, Thomas Daniel thomas.dan...@intel.com wrote:
  From: Oscar Mateo oscar.ma...@intel.com
 
  The time has come, the Walrus said, to talk of many things.
 
 FYI this causes https://bugs.freedesktop.org/show_bug.cgi?id=82740
Hmm, this seems to be an interaction between execlists and PPGTT
patches, specifically:
http://patchwork.freedesktop.org/patch/31150/
which breaks aliasing PPGTT when execlists are enabled, resulting
in this oops on boot.

I will post a patch which avoids this but I don't know if the intention
is to drop aliasing PPGTT support when execlists are enabled.

Thomas.

  Signed-off-by: Oscar Mateo oscar.ma...@intel.com
  ---
   drivers/gpu/drm/i915/i915_drv.h |2 +-
   1 file changed, 1 insertion(+), 1 deletion(-)
 
  diff --git a/drivers/gpu/drm/i915/i915_drv.h
  b/drivers/gpu/drm/i915/i915_drv.h index b7cf0ec..1ce51d6 100644
  --- a/drivers/gpu/drm/i915/i915_drv.h
  +++ b/drivers/gpu/drm/i915/i915_drv.h
  @@ -2061,7 +2061,7 @@ struct drm_i915_cmd_table {
   #define I915_NEED_GFX_HWS(dev) (INTEL_INFO(dev)-need_gfx_hws)
 
   #define HAS_HW_CONTEXTS(dev)   (INTEL_INFO(dev)-gen = 6)
  -#define HAS_LOGICAL_RING_CONTEXTS(dev) 0
  +#define HAS_LOGICAL_RING_CONTEXTS(dev) (INTEL_INFO(dev)-
 gen = 8)
   #define HAS_ALIASING_PPGTT(dev)(INTEL_INFO(dev)-gen = 6)
   #define HAS_PPGTT(dev) (INTEL_INFO(dev)-gen = 7 
 !IS_GEN8(dev))
   #define USES_PPGTT(dev)intel_enable_ppgtt(dev, false)
  --
  1.7.9.5
 
  ___
  Intel-gfx mailing list
  Intel-gfx@lists.freedesktop.org
  http://lists.freedesktop.org/mailman/listinfo/intel-gfx
 
 --
 Jani Nikula, Intel Open Source Technology Center
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx