Re: [Intel-gfx] [PATCH v2 RESEND] drm/i915: prefer INTEL_GEN() over INTEL_INFO()->gen

[Jani Nikula]

On Thu, 26 Apr 2018, Tvrtko Ursulin  wrote:
> On 26/04/2018 12:35, Jani Nikula wrote:
>> Prefer INTEL_GEN() over INTEL_INFO()->gen except in special
>> circumstances.
>> 
>> v2: don't change device info dump (Chris)
>> 
>> Cc: Tvrtko Ursulin 
>> Cc: Mika Kuoppala 
>> Signed-off-by: Jani Nikula 
>> ---
>>   drivers/gpu/drm/i915/intel_device_info.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/drivers/gpu/drm/i915/intel_device_info.c 
>> b/drivers/gpu/drm/i915/intel_device_info.c
>> index a32ba72c514e..0fd13df424cf 100644
>> --- a/drivers/gpu/drm/i915/intel_device_info.c
>> +++ b/drivers/gpu/drm/i915/intel_device_info.c
>> @@ -848,7 +848,7 @@ void intel_device_info_runtime_init(struct 
>> intel_device_info *info)
>>  gen9_sseu_info_init(dev_priv);
>>  else if (INTEL_GEN(dev_priv) == 10)
>>  gen10_sseu_info_init(dev_priv);
>> -else if (INTEL_INFO(dev_priv)->gen >= 11)
>> +else if (INTEL_GEN(dev_priv) >= 11)
>>  gen11_sseu_info_init(dev_priv);
>>   
>>  /* Initialize command stream timestamp frequency */
>> 
>
> Reviewed-by: Tvrtko Ursulin 

Thanks, pushed to dinq.

I'm having second thoughts on the ->gen to ->__gen change. There were
after all some legit users of it.

BR,
Jani.

>
> Regards,
>
> Tvrtko
> ___
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Jani Nikula, Intel Open Source Technology Center
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH v2 RESEND] drm/i915: prefer INTEL_GEN() over INTEL_INFO()->gen

[Tvrtko Ursulin]

On 26/04/2018 12:35, Jani Nikula wrote:

Prefer INTEL_GEN() over INTEL_INFO()->gen except in special
circumstances.

v2: don't change device info dump (Chris)

Cc: Tvrtko Ursulin 
Cc: Mika Kuoppala 
Signed-off-by: Jani Nikula 
---
  drivers/gpu/drm/i915/intel_device_info.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/intel_device_info.c 
b/drivers/gpu/drm/i915/intel_device_info.c
index a32ba72c514e..0fd13df424cf 100644
--- a/drivers/gpu/drm/i915/intel_device_info.c
+++ b/drivers/gpu/drm/i915/intel_device_info.c
@@ -848,7 +848,7 @@ void intel_device_info_runtime_init(struct 
intel_device_info *info)
gen9_sseu_info_init(dev_priv);
else if (INTEL_GEN(dev_priv) == 10)
gen10_sseu_info_init(dev_priv);
-   else if (INTEL_INFO(dev_priv)->gen >= 11)
+   else if (INTEL_GEN(dev_priv) >= 11)
gen11_sseu_info_init(dev_priv);
  
  	/* Initialize command stream timestamp frequency */




Reviewed-by: Tvrtko Ursulin 

Regards,

Tvrtko
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx