Re: [Intel-gfx] [PATCH v7 0/8] GEN-9 Arbitrated Bandwidth WM WA's & IPC
On Thu, Dec 08, 2016 at 04:12:37PM +, Zanoni, Paulo R wrote: > Em Qui, 2016-12-08 às 17:00 +0100, Daniel Vetter escreveu: > > On Wed, Dec 07, 2016 at 05:35:09PM -0200, Paulo Zanoni wrote: > > > > > > Em Qui, 2016-12-01 às 21:19 +0530, Mahesh Kumar escreveu: > > > > > > > > This series implements following set of functionality > > > > Implement IPC WA's for Broxton/KBL > > > > Enable IPC in supported platforms > > > > Convert WM calculation to fixed point calculation > > > > Calculation of System memory Bandwidth for SKL/KBL/BXT > > > > Implementation of Arbitrated memory Bandwidth related WM WA's > > > > > > Pushed patches 1, 2, 3, 5 and 6, with small bikesheds applied. > > > Thanks > > > for the patches! > > > > > > (actually I had a little problem with dim, so right now only dinq > > > has > > > the patches, drm-tip doesn't, soon they will appear) > > > > Hm, what did go boom with dim? > > This was my first commit/push since the change. I had followed the > instructions on your email (including the dim setup stage), and then > when I did "dim push-queued" it complained that I didn't have the audio > remotes in my tree. After the error message I was not sure what was the > correct way to proceed. > > I suppose we could change dim setup so that it really adds every single > remote that's needed? Also, why doesn't it just add the remotes itself? dim doesn't require that you have a separate kernel repo for it, so for creating somewhat invasive stuff like naming remotes it defers to the user. It should print the exact git cmdline you need to run, only thing to fill in would be the name you want to give that remote. I guess we could switch over to just auto-creating remotes. If you want to do that, the function you need to change is url_to_remote. Instead of the error output simply create the remote, and then set the local remote variable to the remote name. I'd be happy to ack such a patch for dim, since you're not the only one who got confused by this. Seems better to just create the remote ... > > If the pushing worked, then you can re-run > > just the drm-tip rebuilding with > > > > $ dim rebuild-tip > > Good to know, thanks for that. > > > > > Might also be worth it to upgrade to latest dim, we've dropped a few > > bugfixes in the branch push/pull logic in a few places since the big > > conversion, you might hit them. > > I always upgrade to the latest version before using it. > > > > > If all this doesn't help, pls ping me on irc with a pastebin of > > what's > > going on. For testing you can always run > > I sent you an email yesterday with the error message pasted... Maybe > you'll find it soon :). I random walk through my various inboxes ;-) -Daniel > > > > > > $ dim pq > > > > To repush dinq - dim will complain if you'll do a non-ff push and > > abort, > > so it's safe. > > -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH v7 0/8] GEN-9 Arbitrated Bandwidth WM WA's & IPC
Em Qui, 2016-12-08 às 17:00 +0100, Daniel Vetter escreveu: > On Wed, Dec 07, 2016 at 05:35:09PM -0200, Paulo Zanoni wrote: > > > > Em Qui, 2016-12-01 às 21:19 +0530, Mahesh Kumar escreveu: > > > > > > This series implements following set of functionality > > > Implement IPC WA's for Broxton/KBL > > > Enable IPC in supported platforms > > > Convert WM calculation to fixed point calculation > > > Calculation of System memory Bandwidth for SKL/KBL/BXT > > > Implementation of Arbitrated memory Bandwidth related WM WA's > > > > Pushed patches 1, 2, 3, 5 and 6, with small bikesheds applied. > > Thanks > > for the patches! > > > > (actually I had a little problem with dim, so right now only dinq > > has > > the patches, drm-tip doesn't, soon they will appear) > > Hm, what did go boom with dim? This was my first commit/push since the change. I had followed the instructions on your email (including the dim setup stage), and then when I did "dim push-queued" it complained that I didn't have the audio remotes in my tree. After the error message I was not sure what was the correct way to proceed. I suppose we could change dim setup so that it really adds every single remote that's needed? Also, why doesn't it just add the remotes itself? > If the pushing worked, then you can re-run > just the drm-tip rebuilding with > > $ dim rebuild-tip Good to know, thanks for that. > > Might also be worth it to upgrade to latest dim, we've dropped a few > bugfixes in the branch push/pull logic in a few places since the big > conversion, you might hit them. I always upgrade to the latest version before using it. > > If all this doesn't help, pls ping me on irc with a pastebin of > what's > going on. For testing you can always run I sent you an email yesterday with the error message pasted... Maybe you'll find it soon :). > > $ dim pq > > To repush dinq - dim will complain if you'll do a non-ff push and > abort, > so it's safe. > -Daniel ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH v7 0/8] GEN-9 Arbitrated Bandwidth WM WA's & IPC
On Wed, Dec 07, 2016 at 05:35:09PM -0200, Paulo Zanoni wrote: > Em Qui, 2016-12-01 às 21:19 +0530, Mahesh Kumar escreveu: > > This series implements following set of functionality > > Implement IPC WA's for Broxton/KBL > > Enable IPC in supported platforms > > Convert WM calculation to fixed point calculation > > Calculation of System memory Bandwidth for SKL/KBL/BXT > > Implementation of Arbitrated memory Bandwidth related WM WA's > > Pushed patches 1, 2, 3, 5 and 6, with small bikesheds applied. Thanks > for the patches! > > (actually I had a little problem with dim, so right now only dinq has > the patches, drm-tip doesn't, soon they will appear) Hm, what did go boom with dim? If the pushing worked, then you can re-run just the drm-tip rebuilding with $ dim rebuild-tip Might also be worth it to upgrade to latest dim, we've dropped a few bugfixes in the branch push/pull logic in a few places since the big conversion, you might hit them. If all this doesn't help, pls ping me on irc with a pastebin of what's going on. For testing you can always run $ dim pq To repush dinq - dim will complain if you'll do a non-ff push and abort, so it's safe. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH v7 0/8] GEN-9 Arbitrated Bandwidth WM WA's & IPC
Em Qui, 2016-12-01 às 21:19 +0530, Mahesh Kumar escreveu: > This series implements following set of functionality > Implement IPC WA's for Broxton/KBL > Enable IPC in supported platforms > Convert WM calculation to fixed point calculation > Calculation of System memory Bandwidth for SKL/KBL/BXT > Implementation of Arbitrated memory Bandwidth related WM WA's Pushed patches 1, 2, 3, 5 and 6, with small bikesheds applied. Thanks for the patches! (actually I had a little problem with dim, so right now only dinq has the patches, drm-tip doesn't, soon they will appear) Let's resume the discussion on the remaining patches. For a possible next series, make sure to rebase and send only what's not applied. > > > Mahesh Kumar (8): > drm/i915/skl: Add variables to check x_tile and y_tile > drm/i915/bxt: IPC WA for Broxton > drm/i915/kbl: IPC workaround for kabylake > drm/i915/bxt: Enable IPC support > drm/i915/skl+: change WM calc to fixed point 16.16 > drm/i915: Add intel_atomic_get_existing_crtc_state function > drm/i915: Decode system memory bandwidth > drm/i915/gen9: WM memory bandwidth related workaround > > drivers/gpu/drm/i915/i915_drv.c | 175 ++ > drivers/gpu/drm/i915/i915_drv.h | 109 ++ > drivers/gpu/drm/i915/i915_reg.h | 38 + > drivers/gpu/drm/i915/intel_display.c | 24 > drivers/gpu/drm/i915/intel_drv.h | 15 ++ > drivers/gpu/drm/i915/intel_pm.c | 272 > +-- > 6 files changed, 586 insertions(+), 47 deletions(-) > ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
