Re: [Intel-gfx] [REGRESSION BISECTED] backlight control stops workin with 3.14 and later

2014-08-25 Thread Jani Nikula
On Sat, 23 Aug 2014, Hans de Goede hdego...@redhat.com wrote:
 Hi,

 On 08/22/2014 08:48 AM, Jani Nikula wrote:
 On Fri, 22 Aug 2014, Bertrik Sikken bert...@sikken.nl wrote:
 On 19-8-2014 3:29, Jani Nikula wrote:
 On Tue, 19 Aug 2014, Bertrik Sikken bert...@sikken.nl wrote:
 On Sun, 17 Aug 2014, Bertrik Sikken bert...@sikken.nl wrote:
 On 15-8-2014 3:43, Jani Nikula wrote:
 On Thu, 14 Aug 2014, Bertrik Sikken bert...@sikken.nl wrote:

 Attached is dmesg output from booting kernel 3.14-2 (debian unstable)
 with drm.debug=0xe and the samsung_laptop module enabled, from my
 Samsung N150plus netbook.

 Have you tried 3.15?

 I've built the v3.15 kernel (using the .config file from debian
 unstable and doing make oldconfig).

 The backlight is at maximum brightness after boot and I can't control
 it using the backlight buttons, nor by writing to
 /sys/class/backlight/samsung/brightness
 (say half the value or 1/10th of max_brightness)

 Backlight does work when writing
 /sys/class/backlight/intel_backlight/brightness

 How about disabling samsung backlight module with 3.15?

 I'm not sure what you mean by that.

 As I understand it, there are three ways to control the backlight on this
 netbook: using intel_backlight, samsung_laptop (using a sabi interface)
 and acpi_video.
 Backlight control using the samsung_laptop driver no longer seems to work
 after the change. If I disable it (e.g. by blacklisting it), I expect it
 to no longer work at all obviously.

 What do you want me to test exactly?

 If the intel_backlight interface works in 3.15, I presume the problem is
 that you have a non-functional samsung backlight interface that is
 preferred over intel_backlight by your userspace.

 I tested the intel_backlight interface in linux v3.15 with the samsung
 backlight module blacklisted. The intel_backlight interface still works.
 
 I read that as, I no longer have problems with backlight.

 No, just NO. This thread has REGRESSION in the subject for a reason,
 userspace will prefer a firmware backlight interface over a raw backlight
 interface, so the only way to get userspace to use the intel backlight
 driver is to blacklist the samsung_laptop and acpi_video (Bertrik can you
 confirm that acpi_video also is broken?) so that the intel one is the only
 remaining.

Fair enough.

I'm going to need a bunch of attached files that will be awkward on the
mailing list, so please file a new bug against DRM/Intel at [1]. Refer
this mail thread, and attach the output of intel_reg_dumper (from
intel-gpu-tools [2]) on a working and a non-working kernel. Also attach
/sys/kernel/debug/dri/0/i915_opregion

On the broken kernel, does the samsung backlight interface work *before*
you've loaded i915.ko?

Thanks,
Jani.


[1] https://bugs.freedesktop.org/enter_bug.cgi?product=DRI
[2] http://cgit.freedesktop.org/xorg/app/intel-gpu-tools/

-- 
Jani Nikula, Intel Open Source Technology Center
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx


Re: [Intel-gfx] [REGRESSION BISECTED] backlight control stops workin with 3.14 and later

2014-08-23 Thread Hans de Goede
Hi,

On 08/22/2014 08:48 AM, Jani Nikula wrote:
 On Fri, 22 Aug 2014, Bertrik Sikken bert...@sikken.nl wrote:
 On 19-8-2014 3:29, Jani Nikula wrote:
 On Tue, 19 Aug 2014, Bertrik Sikken bert...@sikken.nl wrote:
 On Sun, 17 Aug 2014, Bertrik Sikken bert...@sikken.nl wrote:
 On 15-8-2014 3:43, Jani Nikula wrote:
 On Thu, 14 Aug 2014, Bertrik Sikken bert...@sikken.nl wrote:

 Attached is dmesg output from booting kernel 3.14-2 (debian unstable)
 with drm.debug=0xe and the samsung_laptop module enabled, from my
 Samsung N150plus netbook.

 Have you tried 3.15?

 I've built the v3.15 kernel (using the .config file from debian
 unstable and doing make oldconfig).

 The backlight is at maximum brightness after boot and I can't control
 it using the backlight buttons, nor by writing to
 /sys/class/backlight/samsung/brightness
 (say half the value or 1/10th of max_brightness)

 Backlight does work when writing
 /sys/class/backlight/intel_backlight/brightness

 How about disabling samsung backlight module with 3.15?

 I'm not sure what you mean by that.

 As I understand it, there are three ways to control the backlight on this
 netbook: using intel_backlight, samsung_laptop (using a sabi interface)
 and acpi_video.
 Backlight control using the samsung_laptop driver no longer seems to work
 after the change. If I disable it (e.g. by blacklisting it), I expect it
 to no longer work at all obviously.

 What do you want me to test exactly?

 If the intel_backlight interface works in 3.15, I presume the problem is
 that you have a non-functional samsung backlight interface that is
 preferred over intel_backlight by your userspace.

 I tested the intel_backlight interface in linux v3.15 with the samsung
 backlight module blacklisted. The intel_backlight interface still works.
 
 I read that as, I no longer have problems with backlight.

No, just NO. This thread has REGRESSION in the subject for a reason,
userspace will prefer a firmware backlight interface over a raw backlight
interface, so the only way to get userspace to use the intel backlight
driver is to blacklist the samsung_laptop and acpi_video (Bertrik can you
confirm that acpi_video also is broken?) so that the intel one is the only
remaining.

Now in some cases that is the right answer, it is actually what we do for
all laptops with win8 ready BIOS-es as the firmware interfaces tend to
be broken there, but that is not the case here.

The samsung_laptop backlight interface used to work, and at a minimum we
need to figure out exactly _why_ it stopped working.

We could possibly fix things for Bertrik by a dmi based quirk, but this
problem will likely apply to all samsung netbook devices from the same
era and there are a  _lot_ of different models from those, and the problem
may also apply to other vendor laptops too. Doing a dmi string based quirk is
just papering over the problem, and thus is unacceptable IMHO.

Regards,

Hans






 
 Jani.
 
 

 Regards,
 Bertrik
 
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx


Re: [Intel-gfx] [REGRESSION BISECTED] backlight control stops workin with 3.14 and later

2014-08-22 Thread Jani Nikula
On Fri, 22 Aug 2014, Bertrik Sikken bert...@sikken.nl wrote:
 On 19-8-2014 3:29, Jani Nikula wrote:
 On Tue, 19 Aug 2014, Bertrik Sikken bert...@sikken.nl wrote:
 On Sun, 17 Aug 2014, Bertrik Sikken bert...@sikken.nl wrote:
 On 15-8-2014 3:43, Jani Nikula wrote:
 On Thu, 14 Aug 2014, Bertrik Sikken bert...@sikken.nl wrote:

 Attached is dmesg output from booting kernel 3.14-2 (debian unstable)
 with drm.debug=0xe and the samsung_laptop module enabled, from my
 Samsung N150plus netbook.

 Have you tried 3.15?

 I've built the v3.15 kernel (using the .config file from debian
 unstable and doing make oldconfig).

 The backlight is at maximum brightness after boot and I can't control
 it using the backlight buttons, nor by writing to
 /sys/class/backlight/samsung/brightness
 (say half the value or 1/10th of max_brightness)

 Backlight does work when writing
 /sys/class/backlight/intel_backlight/brightness

 How about disabling samsung backlight module with 3.15?

 I'm not sure what you mean by that.

 As I understand it, there are three ways to control the backlight on this
 netbook: using intel_backlight, samsung_laptop (using a sabi interface)
 and acpi_video.
 Backlight control using the samsung_laptop driver no longer seems to work
 after the change. If I disable it (e.g. by blacklisting it), I expect it
 to no longer work at all obviously.

 What do you want me to test exactly?
 
 If the intel_backlight interface works in 3.15, I presume the problem is
 that you have a non-functional samsung backlight interface that is
 preferred over intel_backlight by your userspace.

 I tested the intel_backlight interface in linux v3.15 with the samsung
 backlight module blacklisted. The intel_backlight interface still works.

I read that as, I no longer have problems with backlight.

Jani.



 Regards,
 Bertrik

-- 
Jani Nikula, Intel Open Source Technology Center
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx


Re: [Intel-gfx] [REGRESSION BISECTED] backlight control stops workin with 3.14 and later

2014-08-22 Thread Bertrik Sikken
 On Fri, 22 Aug 2014, Bertrik Sikken bert...@sikken.nl wrote:
 On 19-8-2014 3:29, Jani Nikula wrote:
 On Tue, 19 Aug 2014, Bertrik Sikken bert...@sikken.nl wrote:
 On Sun, 17 Aug 2014, Bertrik Sikken bert...@sikken.nl wrote:
 On 15-8-2014 3:43, Jani Nikula wrote:
 On Thu, 14 Aug 2014, Bertrik Sikken bert...@sikken.nl wrote:

 Attached is dmesg output from booting kernel 3.14-2 (debian
 unstable)
 with drm.debug=0xe and the samsung_laptop module enabled, from my
 Samsung N150plus netbook.

 Have you tried 3.15?

 I've built the v3.15 kernel (using the .config file from debian
 unstable and doing make oldconfig).

 The backlight is at maximum brightness after boot and I can't
 control
 it using the backlight buttons, nor by writing to
 /sys/class/backlight/samsung/brightness
 (say half the value or 1/10th of max_brightness)

 Backlight does work when writing
 /sys/class/backlight/intel_backlight/brightness

 How about disabling samsung backlight module with 3.15?

 I'm not sure what you mean by that.

 As I understand it, there are three ways to control the backlight on
 this
 netbook: using intel_backlight, samsung_laptop (using a sabi
 interface)
 and acpi_video.
 Backlight control using the samsung_laptop driver no longer seems to
 work
 after the change. If I disable it (e.g. by blacklisting it), I expect
 it
 to no longer work at all obviously.

 What do you want me to test exactly?

 If the intel_backlight interface works in 3.15, I presume the problem
 is
 that you have a non-functional samsung backlight interface that is
 preferred over intel_backlight by your userspace.

 I tested the intel_backlight interface in linux v3.15 with the samsung
 backlight module blacklisted. The intel_backlight interface still works.

 I read that as, I no longer have problems with backlight.

The problem as I see it, is that the bisected backlight change in the
intel-gfx driver caused the samsung_laptop backlight mechanism to break,
while they apparently were able to play nice with each other before.

You could consider having two drivers trying to access the same hardware
as a more general linux kernel bug. As I understand it now, the intel-gfx
driver talks directly to the hardware and the samsung_laptop driver talks
through a BIOS interface (SABI = Samsung advanced BIOS interface).

I'm not trying to put the blame on any of the two drivers, just looking
for the best solution to a practical problem.

With kind regards,
Bertrik Sikken

___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx


Re: [Intel-gfx] [REGRESSION BISECTED] backlight control stops workin with 3.14 and later

2014-08-21 Thread Bertrik Sikken
On 19-8-2014 3:29, Jani Nikula wrote:
 On Tue, 19 Aug 2014, Bertrik Sikken bert...@sikken.nl wrote:
 On Sun, 17 Aug 2014, Bertrik Sikken bert...@sikken.nl wrote:
 On 15-8-2014 3:43, Jani Nikula wrote:
 On Thu, 14 Aug 2014, Bertrik Sikken bert...@sikken.nl wrote:

 Attached is dmesg output from booting kernel 3.14-2 (debian unstable)
 with drm.debug=0xe and the samsung_laptop module enabled, from my
 Samsung N150plus netbook.

 Have you tried 3.15?

 I've built the v3.15 kernel (using the .config file from debian
 unstable and doing make oldconfig).

 The backlight is at maximum brightness after boot and I can't control
 it using the backlight buttons, nor by writing to
 /sys/class/backlight/samsung/brightness
 (say half the value or 1/10th of max_brightness)

 Backlight does work when writing
 /sys/class/backlight/intel_backlight/brightness

 How about disabling samsung backlight module with 3.15?

 I'm not sure what you mean by that.

 As I understand it, there are three ways to control the backlight on this
 netbook: using intel_backlight, samsung_laptop (using a sabi interface)
 and acpi_video.
 Backlight control using the samsung_laptop driver no longer seems to work
 after the change. If I disable it (e.g. by blacklisting it), I expect it
 to no longer work at all obviously.

 What do you want me to test exactly?
 
 If the intel_backlight interface works in 3.15, I presume the problem is
 that you have a non-functional samsung backlight interface that is
 preferred over intel_backlight by your userspace.

I tested the intel_backlight interface in linux v3.15 with the samsung
backlight module blacklisted. The intel_backlight interface still works.

Regards,
Bertrik
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx


Re: [Intel-gfx] [REGRESSION BISECTED] backlight control stops workin with 3.14 and later

2014-08-19 Thread Bertrik Sikken
 On Sun, 17 Aug 2014, Bertrik Sikken bert...@sikken.nl wrote:
 On 15-8-2014 3:43, Jani Nikula wrote:
 On Thu, 14 Aug 2014, Bertrik Sikken bert...@sikken.nl wrote:

 Attached is dmesg output from booting kernel 3.14-2 (debian unstable)
 with drm.debug=0xe and the samsung_laptop module enabled, from my
 Samsung N150plus netbook.

 Have you tried 3.15?

 I've built the v3.15 kernel (using the .config file from debian
 unstable and doing make oldconfig).

 The backlight is at maximum brightness after boot and I can't control
 it using the backlight buttons, nor by writing to
 /sys/class/backlight/samsung/brightness
 (say half the value or 1/10th of max_brightness)

 Backlight does work when writing
 /sys/class/backlight/intel_backlight/brightness

 How about disabling samsung backlight module with 3.15?

I'm not sure what you mean by that.

As I understand it, there are three ways to control the backlight on this
netbook: using intel_backlight, samsung_laptop (using a sabi interface)
and acpi_video.
Backlight control using the samsung_laptop driver no longer seems to work
after the change. If I disable it (e.g. by blacklisting it), I expect it
to no longer work at all obviously.

What do you want me to test exactly?

Kind regards,
Bertrik

___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx


Re: [Intel-gfx] [REGRESSION BISECTED] backlight control stops workin with 3.14 and later

2014-08-19 Thread Jani Nikula
On Tue, 19 Aug 2014, Bertrik Sikken bert...@sikken.nl wrote:
 On Sun, 17 Aug 2014, Bertrik Sikken bert...@sikken.nl wrote:
 On 15-8-2014 3:43, Jani Nikula wrote:
 On Thu, 14 Aug 2014, Bertrik Sikken bert...@sikken.nl wrote:

 Attached is dmesg output from booting kernel 3.14-2 (debian unstable)
 with drm.debug=0xe and the samsung_laptop module enabled, from my
 Samsung N150plus netbook.

 Have you tried 3.15?

 I've built the v3.15 kernel (using the .config file from debian
 unstable and doing make oldconfig).

 The backlight is at maximum brightness after boot and I can't control
 it using the backlight buttons, nor by writing to
 /sys/class/backlight/samsung/brightness
 (say half the value or 1/10th of max_brightness)

 Backlight does work when writing
 /sys/class/backlight/intel_backlight/brightness

 How about disabling samsung backlight module with 3.15?

 I'm not sure what you mean by that.

 As I understand it, there are three ways to control the backlight on this
 netbook: using intel_backlight, samsung_laptop (using a sabi interface)
 and acpi_video.
 Backlight control using the samsung_laptop driver no longer seems to work
 after the change. If I disable it (e.g. by blacklisting it), I expect it
 to no longer work at all obviously.

 What do you want me to test exactly?

If the intel_backlight interface works in 3.15, I presume the problem is
that you have a non-functional samsung backlight interface that is
preferred over intel_backlight by your userspace.

BR,
Jani.




 Kind regards,
 Bertrik

 ___
 Intel-gfx mailing list
 Intel-gfx@lists.freedesktop.org
 http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Jani Nikula, Intel Open Source Technology Center
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx


Re: [Intel-gfx] [REGRESSION BISECTED] backlight control stops workin with 3.14 and later

2014-08-18 Thread Jani Nikula
On Sun, 17 Aug 2014, Bertrik Sikken bert...@sikken.nl wrote:
 On 15-8-2014 3:43, Jani Nikula wrote:
 On Thu, 14 Aug 2014, Bertrik Sikken bert...@sikken.nl wrote:

 Attached is dmesg output from booting kernel 3.14-2 (debian unstable)
 with drm.debug=0xe and the samsung_laptop module enabled, from my
 Samsung N150plus netbook.
 
 Have you tried 3.15?

 I've built the v3.15 kernel (using the .config file from debian
 unstable and doing make oldconfig).

 The backlight is at maximum brightness after boot and I can't control
 it using the backlight buttons, nor by writing to
 /sys/class/backlight/samsung/brightness
 (say half the value or 1/10th of max_brightness)

 Backlight does work when writing
 /sys/class/backlight/intel_backlight/brightness

How about disabling samsung backlight module with 3.15?

BR,
Jani.



 Kind regards,
 Bertrik Sikken

-- 
Jani Nikula, Intel Open Source Technology Center
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx


Re: [Intel-gfx] [REGRESSION BISECTED] backlight control stops workin with 3.14 and later

2014-08-17 Thread Bertrik Sikken
On 15-8-2014 3:43, Jani Nikula wrote:
 On Thu, 14 Aug 2014, Bertrik Sikken bert...@sikken.nl wrote:

 Attached is dmesg output from booting kernel 3.14-2 (debian unstable)
 with drm.debug=0xe and the samsung_laptop module enabled, from my
 Samsung N150plus netbook.
 
 Have you tried 3.15?

I've built the v3.15 kernel (using the .config file from debian
unstable and doing make oldconfig).

The backlight is at maximum brightness after boot and I can't control
it using the backlight buttons, nor by writing to
/sys/class/backlight/samsung/brightness
(say half the value or 1/10th of max_brightness)

Backlight does work when writing
/sys/class/backlight/intel_backlight/brightness

Kind regards,
Bertrik Sikken
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx


Re: [Intel-gfx] [REGRESSION BISECTED] backlight control stops workin with 3.14 and later

2014-08-15 Thread Jani Nikula
On Thu, 14 Aug 2014, Bertrik Sikken bert...@sikken.nl wrote:
 Hi Jani,

 On 13-8-2014 3:43, Jani Nikula wrote:
 On Wed, 23 Jul 2014, Hans de Goede hdego...@redhat.com wrote:
 On 07/22/2014 08:52 AM, Daniel Vetter wrote:
 On Tue, Jul 22, 2014 at 8:42 AM, Hans de Goede hdego...@redhat.com wrote:

 snip

 Also please grab latest intel-gpu-tools and record a register dump
 with intel_reg_dump, again for both broken and working kernels.

 Bertrik, can you do this please (without the blacklisting or special
 kernel commandline options).
 
 Please attach dmesg with drm.debug=0xe module parameter set for some
 recent kernel.

 Attached is dmesg output from booting kernel 3.14-2 (debian unstable)
 with drm.debug=0xe and the samsung_laptop module enabled, from my
 Samsung N150plus netbook.

Have you tried 3.15?

BR,
Jani.



 If you need anything else, please let me know.
 Thanks for looking into this,

 Bertrik Sikken
 [0.00] CPU0 microcode updated early to revision 0x107, date = 
 2009-08-25
 [0.00] Initializing cgroup subsys cpuset
 [0.00] Initializing cgroup subsys cpu
 [0.00] Initializing cgroup subsys cpuacct
 [0.00] Linux version 3.14-2-amd64 (debian-ker...@lists.debian.org) 
 (gcc version 4.8.3 (Debian 4.8.3-7) ) #1 SMP Debian 3.14.15-2 (2014-08-09)
 [0.00] Command line: BOOT_IMAGE=/boot/vmlinuz-3.14-2-amd64 
 root=UUID=d72b9d1c-1e83-43c5-b5b9-e7ad03e8bd9d ro quiet init=/bin/systemd 
 drm.debug=0xe
 [0.00] e820: BIOS-provided physical RAM map:
 [0.00] BIOS-e820: [mem 0x-0x0009dbff] usable
 [0.00] BIOS-e820: [mem 0x0009dc00-0x0009] reserved
 [0.00] BIOS-e820: [mem 0x000ce000-0x000c] reserved
 [0.00] BIOS-e820: [mem 0x000dc000-0x000d] reserved
 [0.00] BIOS-e820: [mem 0x000e4000-0x000f] reserved
 [0.00] BIOS-e820: [mem 0x0010-0x7f5a] usable
 [0.00] BIOS-e820: [mem 0x7f5b-0x7f5b] ACPI 
 data
 [0.00] BIOS-e820: [mem 0x7f5c-0x7f5c2fff] ACPI NVS
 [0.00] BIOS-e820: [mem 0x7f5c3000-0x7fff] reserved
 [0.00] BIOS-e820: [mem 0xe000-0xefff] reserved
 [0.00] BIOS-e820: [mem 0xfec0-0xfec0] reserved
 [0.00] BIOS-e820: [mem 0xfee0-0xfee00fff] reserved
 [0.00] BIOS-e820: [mem 0xff00-0x] reserved
 [0.00] NX (Execute Disable) protection: active
 [0.00] SMBIOS 2.5 present.
 [0.00] DMI: SAMSUNG ELECTRONICS CO., LTD. N150P/N210P/N220P  
 /N150P/N210P/N220P  , BIOS 02KY.M021.20101217.RHU 12/17/2010
 [0.00] e820: update [mem 0x-0x0fff] usable == reserved
 [0.00] e820: remove [mem 0x000a-0x000f] usable
 [0.00] No AGP bridge found
 [0.00] e820: last_pfn = 0x7f5b0 max_arch_pfn = 0x4
 [0.00] MTRR default type: uncachable
 [0.00] MTRR fixed ranges enabled:
 [0.00]   0-9 write-back
 [0.00]   A-B uncachable
 [0.00]   C-C write-protect
 [0.00]   D-D uncachable
 [0.00]   E-F write-protect
 [0.00] MTRR variable ranges enabled:
 [0.00]   0 base 0 mask 08000 write-back
 [0.00]   1 base 07F60 mask 0FFE0 uncachable
 [0.00]   2 base 07F80 mask 0FF80 uncachable
 [0.00]   3 disabled
 [0.00]   4 disabled
 [0.00]   5 disabled
 [0.00]   6 disabled
 [0.00]   7 disabled
 [0.00] x86 PAT enabled: cpu 0, old 0x7040600070406, new 
 0x7010600070106
 [0.00] found SMP MP-table at [mem 0x000f7d40-0x000f7d4f] mapped at 
 [880f7d40]
 [0.00] Base memory trampoline at [88097000] 97000 size 24576
 [0.00] init_memory_mapping: [mem 0x-0x000f]
 [0.00]  [mem 0x-0x000f] page 4k
 [0.00] BRK [0x01aaf000, 0x01aa] PGTABLE
 [0.00] BRK [0x01ab, 0x01ab0fff] PGTABLE
 [0.00] BRK [0x01ab1000, 0x01ab1fff] PGTABLE
 [0.00] init_memory_mapping: [mem 0x7f20-0x7f3f]
 [0.00]  [mem 0x7f20-0x7f3f] page 2M
 [0.00] BRK [0x01ab2000, 0x01ab2fff] PGTABLE
 [0.00] init_memory_mapping: [mem 0x7c00-0x7f1f]
 [0.00]  [mem 0x7c00-0x7f1f] page 2M
 [0.00] init_memory_mapping: [mem 0x0010-0x7bff]
 [0.00]  [mem 0x0010-0x001f] page 4k
 [0.00]  [mem 0x0020-0x7bff] page 2M
 [0.00] init_memory_mapping: [mem 0x7f40-0x7f5a]
 [0.00]  [mem 0x7f40-0x7f5a] page 4k
 [0.00] BRK [0x01ab3000, 0x01ab3fff] PGTABLE
 [0.00] RAMDISK: [mem 0x36548000-0x3729bfff]
 [0.00] ACPI: RSDP 000f7d10 24 (v02 

Re: [Intel-gfx] [REGRESSION BISECTED] backlight control stops workin with 3.14 and later

2014-08-14 Thread Bertrik Sikken
Hi Jani,

On 13-8-2014 3:43, Jani Nikula wrote:
 On Wed, 23 Jul 2014, Hans de Goede hdego...@redhat.com wrote:
 On 07/22/2014 08:52 AM, Daniel Vetter wrote:
 On Tue, Jul 22, 2014 at 8:42 AM, Hans de Goede hdego...@redhat.com wrote:

snip

 Also please grab latest intel-gpu-tools and record a register dump
 with intel_reg_dump, again for both broken and working kernels.

 Bertrik, can you do this please (without the blacklisting or special
 kernel commandline options).
 
 Please attach dmesg with drm.debug=0xe module parameter set for some
 recent kernel.

Attached is dmesg output from booting kernel 3.14-2 (debian unstable)
with drm.debug=0xe and the samsung_laptop module enabled, from my
Samsung N150plus netbook.

If you need anything else, please let me know.
Thanks for looking into this,

Bertrik Sikken
[0.00] CPU0 microcode updated early to revision 0x107, date = 2009-08-25
[0.00] Initializing cgroup subsys cpuset
[0.00] Initializing cgroup subsys cpu
[0.00] Initializing cgroup subsys cpuacct
[0.00] Linux version 3.14-2-amd64 (debian-ker...@lists.debian.org) (gcc 
version 4.8.3 (Debian 4.8.3-7) ) #1 SMP Debian 3.14.15-2 (2014-08-09)
[0.00] Command line: BOOT_IMAGE=/boot/vmlinuz-3.14-2-amd64 
root=UUID=d72b9d1c-1e83-43c5-b5b9-e7ad03e8bd9d ro quiet init=/bin/systemd 
drm.debug=0xe
[0.00] e820: BIOS-provided physical RAM map:
[0.00] BIOS-e820: [mem 0x-0x0009dbff] usable
[0.00] BIOS-e820: [mem 0x0009dc00-0x0009] reserved
[0.00] BIOS-e820: [mem 0x000ce000-0x000c] reserved
[0.00] BIOS-e820: [mem 0x000dc000-0x000d] reserved
[0.00] BIOS-e820: [mem 0x000e4000-0x000f] reserved
[0.00] BIOS-e820: [mem 0x0010-0x7f5a] usable
[0.00] BIOS-e820: [mem 0x7f5b-0x7f5b] ACPI data
[0.00] BIOS-e820: [mem 0x7f5c-0x7f5c2fff] ACPI NVS
[0.00] BIOS-e820: [mem 0x7f5c3000-0x7fff] reserved
[0.00] BIOS-e820: [mem 0xe000-0xefff] reserved
[0.00] BIOS-e820: [mem 0xfec0-0xfec0] reserved
[0.00] BIOS-e820: [mem 0xfee0-0xfee00fff] reserved
[0.00] BIOS-e820: [mem 0xff00-0x] reserved
[0.00] NX (Execute Disable) protection: active
[0.00] SMBIOS 2.5 present.
[0.00] DMI: SAMSUNG ELECTRONICS CO., LTD. N150P/N210P/N220P  
/N150P/N210P/N220P  , BIOS 02KY.M021.20101217.RHU 12/17/2010
[0.00] e820: update [mem 0x-0x0fff] usable == reserved
[0.00] e820: remove [mem 0x000a-0x000f] usable
[0.00] No AGP bridge found
[0.00] e820: last_pfn = 0x7f5b0 max_arch_pfn = 0x4
[0.00] MTRR default type: uncachable
[0.00] MTRR fixed ranges enabled:
[0.00]   0-9 write-back
[0.00]   A-B uncachable
[0.00]   C-C write-protect
[0.00]   D-D uncachable
[0.00]   E-F write-protect
[0.00] MTRR variable ranges enabled:
[0.00]   0 base 0 mask 08000 write-back
[0.00]   1 base 07F60 mask 0FFE0 uncachable
[0.00]   2 base 07F80 mask 0FF80 uncachable
[0.00]   3 disabled
[0.00]   4 disabled
[0.00]   5 disabled
[0.00]   6 disabled
[0.00]   7 disabled
[0.00] x86 PAT enabled: cpu 0, old 0x7040600070406, new 0x7010600070106
[0.00] found SMP MP-table at [mem 0x000f7d40-0x000f7d4f] mapped at 
[880f7d40]
[0.00] Base memory trampoline at [88097000] 97000 size 24576
[0.00] init_memory_mapping: [mem 0x-0x000f]
[0.00]  [mem 0x-0x000f] page 4k
[0.00] BRK [0x01aaf000, 0x01aa] PGTABLE
[0.00] BRK [0x01ab, 0x01ab0fff] PGTABLE
[0.00] BRK [0x01ab1000, 0x01ab1fff] PGTABLE
[0.00] init_memory_mapping: [mem 0x7f20-0x7f3f]
[0.00]  [mem 0x7f20-0x7f3f] page 2M
[0.00] BRK [0x01ab2000, 0x01ab2fff] PGTABLE
[0.00] init_memory_mapping: [mem 0x7c00-0x7f1f]
[0.00]  [mem 0x7c00-0x7f1f] page 2M
[0.00] init_memory_mapping: [mem 0x0010-0x7bff]
[0.00]  [mem 0x0010-0x001f] page 4k
[0.00]  [mem 0x0020-0x7bff] page 2M
[0.00] init_memory_mapping: [mem 0x7f40-0x7f5a]
[0.00]  [mem 0x7f40-0x7f5a] page 4k
[0.00] BRK [0x01ab3000, 0x01ab3fff] PGTABLE
[0.00] RAMDISK: [mem 0x36548000-0x3729bfff]
[0.00] ACPI: RSDP 000f7d10 24 (v02 PTLTD )
[0.00] ACPI: XSDT 7f5b8d8d 6C (v01 SECCSD LH43STAR 0604 
 LTP )
[0.00] ACPI: FACP 7f5bfc92 F4 (v03 INTEL   0604 

Re: [Intel-gfx] [REGRESSION BISECTED] backlight control stops workin with 3.14 and later

2014-08-13 Thread Jani Nikula
On Wed, 23 Jul 2014, Hans de Goede hdego...@redhat.com wrote:
 Hi,

 On 07/22/2014 08:52 AM, Daniel Vetter wrote:
 On Tue, Jul 22, 2014 at 8:42 AM, Hans de Goede hdego...@redhat.com wrote:
 Hi Jani et al,

 A friend of mine Bertrik Sikken (in the Cc) his backlight control
 stopped working for him on his Samsung N150Plus netbook.

 I took a quick look, and the raw intel_backlight backlight interface
 works under 3.14, but the firmware samsung_laptop backlight interface,
 which is what most userspace apps will use by default, stops working
 in 3.14 .

 I've asked him to bisect this and the bisect points out this
 commit as the culprit:

 b35684b8fa94e04f55fd38bf672b737741d2f9e2 is the first bad commit
 commit b35684b8fa94e04f55fd38bf672b737741d2f9e2
 Author: Jani Nikula jani.nik...@intel.com
 Date:   Thu Nov 14 12:13:41 2013 +0200

 drm/i915: do full backlight setup at enable time

 We should now have all the information we need to do a full
 initialization of the backlight registers.

 v2: Keep QUIRK_NO_PCH_PWM_ENABLE for now (Imre).

 Signed-off-by: Jani Nikula jani.nik...@intel.com
 Reviewed-by: Imre Deak imre.d...@intel.com
 Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch

 Note that this laptop has an acpi_video backlight interface too,
 but that has been broken from the start and gets disabled by
 samsung-laptop based on dmi matching.
 
 How does the intel backlight fare?

 That works fine with 3.14 .

 Please test both 3.14 and 3.15 and

 We've tested with 3.14, please let us know if you also want
 Bertrik to test with 3.15.

 also test what happens when you blacklist the samsung-laptop driver
 (if that's possible without wreaking the machine).

 Then the vendor interface won't get promoted, acpi-video will load,
 and things likely will not work.

 Bertrik, can you try blacklisting the samsung-laptop module, then
 check /sys/class/backlight, the samsung_laptop dir should be gone
 replaced by an acpi_video0 (or some such) dir. Please try if that
 works. If that does not work, try booting with both the module
 blacklisted and acpi_backlight=vendor on the kernel commandline,
 then you should see only the intel-backlight under /sys/class/backlight
 and things should work.

 Also please grab latest intel-gpu-tools and record a register dump
 with intel_reg_dump, again for both broken and working kernels.

 Bertrik, can you do this please (without the blacklisting or special
 kernel commandline options).

Please attach dmesg with drm.debug=0xe module parameter set for some
recent kernel.

BR,
Jani.



 Regards,

 Hans

-- 
Jani Nikula, Intel Open Source Technology Center
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx


Re: [Intel-gfx] [REGRESSION BISECTED] backlight control stops workin with 3.14 and later

2014-07-23 Thread Hans de Goede
Hi,

On 07/22/2014 08:52 AM, Daniel Vetter wrote:
 On Tue, Jul 22, 2014 at 8:42 AM, Hans de Goede hdego...@redhat.com wrote:
 Hi Jani et al,

 A friend of mine Bertrik Sikken (in the Cc) his backlight control
 stopped working for him on his Samsung N150Plus netbook.

 I took a quick look, and the raw intel_backlight backlight interface
 works under 3.14, but the firmware samsung_laptop backlight interface,
 which is what most userspace apps will use by default, stops working
 in 3.14 .

 I've asked him to bisect this and the bisect points out this
 commit as the culprit:

 b35684b8fa94e04f55fd38bf672b737741d2f9e2 is the first bad commit
 commit b35684b8fa94e04f55fd38bf672b737741d2f9e2
 Author: Jani Nikula jani.nik...@intel.com
 Date:   Thu Nov 14 12:13:41 2013 +0200

 drm/i915: do full backlight setup at enable time

 We should now have all the information we need to do a full
 initialization of the backlight registers.

 v2: Keep QUIRK_NO_PCH_PWM_ENABLE for now (Imre).

 Signed-off-by: Jani Nikula jani.nik...@intel.com
 Reviewed-by: Imre Deak imre.d...@intel.com
 Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch

 Note that this laptop has an acpi_video backlight interface too,
 but that has been broken from the start and gets disabled by
 samsung-laptop based on dmi matching.
 
 How does the intel backlight fare?

That works fine with 3.14 .

 Please test both 3.14 and 3.15 and

We've tested with 3.14, please let us know if you also want
Bertrik to test with 3.15.

 also test what happens when you blacklist the samsung-laptop driver
 (if that's possible without wreaking the machine).

Then the vendor interface won't get promoted, acpi-video will load,
and things likely will not work.

Bertrik, can you try blacklisting the samsung-laptop module, then
check /sys/class/backlight, the samsung_laptop dir should be gone
replaced by an acpi_video0 (or some such) dir. Please try if that
works. If that does not work, try booting with both the module
blacklisted and acpi_backlight=vendor on the kernel commandline,
then you should see only the intel-backlight under /sys/class/backlight
and things should work.

 Also please grab latest intel-gpu-tools and record a register dump
 with intel_reg_dump, again for both broken and working kernels.

Bertrik, can you do this please (without the blacklisting or special
kernel commandline options).

Regards,

Hans
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx


Re: [Intel-gfx] [REGRESSION BISECTED] backlight control stops workin with 3.14 and later

2014-07-23 Thread Bertrik Sikken
 On Tue, Jul 22, 2014 at 8:42 AM, Hans de Goede hdego...@redhat.com
 Bertrik, can you try blacklisting the samsung-laptop module, then
 check /sys/class/backlight, the samsung_laptop dir should be gone
 replaced by an acpi_video0 (or some such) dir. Please try if that
 works. If that does not work, try booting with both the module
 blacklisted and acpi_backlight=vendor on the kernel commandline,
 then you should see only the intel-backlight under /sys/class/backlight
 and things should work.

With linux kernel v3.14 and the samsung_laptop module blacklisted,
I indeed see a /sys/class/backlight/acpi_video0, but changing brightness
by writing (as root) to the brightness file does not have an effect.

Additionally, with the acpi_backlight=vendor kernel command line option,
there is only an intel_backlight directory in /sys/class/backlight.
Brightness does work using brightness up and down function keys,
with 'udevadm monitor' I can see it uses the intel_backlight:

bertrik@netbook:~$ udevadm monitor
monitor will print the received events for:
UDEV - the event which udev sends out after rule processing
KERNEL - the kernel uevent

KERNEL[40.375921] change  
/devices/pci:00/:00:02.0/drm/card0/card0-LVDS-1/intel_backlight
(backlight)
UDEV  [40.503704] change  
/devices/pci:00/:00:02.0/drm/card0/card0-LVDS-1/intel_backlight
(backlight)

With kind regards,
Bertrik Sikken

___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx


Re: [Intel-gfx] [REGRESSION BISECTED] backlight control stops workin with 3.14 and later

2014-07-22 Thread Daniel Vetter
On Tue, Jul 22, 2014 at 8:42 AM, Hans de Goede hdego...@redhat.com wrote:
 Hi Jani et al,

 A friend of mine Bertrik Sikken (in the Cc) his backlight control
 stopped working for him on his Samsung N150Plus netbook.

 I took a quick look, and the raw intel_backlight backlight interface
 works under 3.14, but the firmware samsung_laptop backlight interface,
 which is what most userspace apps will use by default, stops working
 in 3.14 .

 I've asked him to bisect this and the bisect points out this
 commit as the culprit:

 b35684b8fa94e04f55fd38bf672b737741d2f9e2 is the first bad commit
 commit b35684b8fa94e04f55fd38bf672b737741d2f9e2
 Author: Jani Nikula jani.nik...@intel.com
 Date:   Thu Nov 14 12:13:41 2013 +0200

 drm/i915: do full backlight setup at enable time

 We should now have all the information we need to do a full
 initialization of the backlight registers.

 v2: Keep QUIRK_NO_PCH_PWM_ENABLE for now (Imre).

 Signed-off-by: Jani Nikula jani.nik...@intel.com
 Reviewed-by: Imre Deak imre.d...@intel.com
 Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch

 Note that this laptop has an acpi_video backlight interface too,
 but that has been broken from the start and gets disabled by
 samsung-laptop based on dmi matching.

How does the intel backlight fare? Please test both 3.14 and 3.15 and
also test what happens when you blacklist the samsung-laptop driver
(if that's possible without wreaking the machine).

Also please grab latest intel-gpu-tools and record a register dump
with intel_reg_dump, again for both broken and working kernels.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx


Re: [Intel-gfx] [REGRESSION BISECTED] backlight control stops workin with 3.14 and later

2014-07-22 Thread Chris Wilson
On Tue, Jul 22, 2014 at 08:52:48AM +0200, Daniel Vetter wrote:
 On Tue, Jul 22, 2014 at 8:42 AM, Hans de Goede hdego...@redhat.com wrote:
  Hi Jani et al,
 
  A friend of mine Bertrik Sikken (in the Cc) his backlight control
  stopped working for him on his Samsung N150Plus netbook.
 
  I took a quick look, and the raw intel_backlight backlight interface
  works under 3.14, but the firmware samsung_laptop backlight interface,
  which is what most userspace apps will use by default, stops working
  in 3.14 .
 
  I've asked him to bisect this and the bisect points out this
  commit as the culprit:
 
  b35684b8fa94e04f55fd38bf672b737741d2f9e2 is the first bad commit
  commit b35684b8fa94e04f55fd38bf672b737741d2f9e2
  Author: Jani Nikula jani.nik...@intel.com
  Date:   Thu Nov 14 12:13:41 2013 +0200
 
  drm/i915: do full backlight setup at enable time
 
  We should now have all the information we need to do a full
  initialization of the backlight registers.
 
  v2: Keep QUIRK_NO_PCH_PWM_ENABLE for now (Imre).
 
  Signed-off-by: Jani Nikula jani.nik...@intel.com
  Reviewed-by: Imre Deak imre.d...@intel.com
  Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch
 
  Note that this laptop has an acpi_video backlight interface too,
  but that has been broken from the start and gets disabled by
  samsung-laptop based on dmi matching.
 
 How does the intel backlight fare? Please test both 3.14 and 3.15 and
 also test what happens when you blacklist the samsung-laptop driver
 (if that's possible without wreaking the machine).
 
 Also please grab latest intel-gpu-tools and record a register dump
 with intel_reg_dump, again for both broken and working kernels.

What would be useful here would be dumping the regs when we takeover (and
our interpretation for ease of reading). Basically the question here is
what does the samsung backlight driver do - and the suspicion is that it
uses the combination mode and we don't set that up...
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx