Re: [Intel-gfx] [RFC 02/15] drm: i915: remove intel_hdmi variable declaration

[Pierre-Louis Bossart]

On 3/10/16 11:34 AM, Ville Syrjälä wrote:

On Fri, Mar 04, 2016 at 08:50:39PM -0600, Pierre-Louis Bossart wrote:

'intel_hdmi' variable is redeclared, use same variable declared in
function scope.

Signed-off-by: Pierre-Louis Bossart 
---
  drivers/gpu/drm/i915/intel_hdmi.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/intel_hdmi.c 
b/drivers/gpu/drm/i915/intel_hdmi.c
index d8060e6..1beb155 100644
--- a/drivers/gpu/drm/i915/intel_hdmi.c
+++ b/drivers/gpu/drm/i915/intel_hdmi.c
@@ -1418,7 +1418,7 @@ intel_hdmi_detect(struct drm_connector *connector, bool 
force)
intel_hdmi_unset_edid(connector);

if (intel_hdmi_set_edid(connector, live_status)) {
-   struct intel_hdmi *intel_hdmi = intel_attached_hdmi(connector);
+   intel_hdmi = intel_attached_hdmi(connector);


We're still going to get the same answer,
so you can just kill the assignment as well.


Thanks. I wasn't sure if the set_edid would have side effects. Will 
resend this one.


___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [RFC 02/15] drm: i915: remove intel_hdmi variable declaration

[Ville Syrjälä]

On Fri, Mar 04, 2016 at 08:50:39PM -0600, Pierre-Louis Bossart wrote:
> 'intel_hdmi' variable is redeclared, use same variable declared in
> function scope.
> 
> Signed-off-by: Pierre-Louis Bossart 
> ---
>  drivers/gpu/drm/i915/intel_hdmi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_hdmi.c 
> b/drivers/gpu/drm/i915/intel_hdmi.c
> index d8060e6..1beb155 100644
> --- a/drivers/gpu/drm/i915/intel_hdmi.c
> +++ b/drivers/gpu/drm/i915/intel_hdmi.c
> @@ -1418,7 +1418,7 @@ intel_hdmi_detect(struct drm_connector *connector, bool 
> force)
>   intel_hdmi_unset_edid(connector);
>  
>   if (intel_hdmi_set_edid(connector, live_status)) {
> - struct intel_hdmi *intel_hdmi = intel_attached_hdmi(connector);
> + intel_hdmi = intel_attached_hdmi(connector);

We're still going to get the same answer,
so you can just kill the assignment as well.

>  
>   hdmi_to_dig_port(intel_hdmi)->base.type = INTEL_OUTPUT_HDMI;
>   status = connector_status_connected;
> -- 
> 1.9.1
> 
> ___
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Ville Syrjälä
Intel OTC
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx