Re: [Intel-gfx] [igt-dev] [PATCH] test/kms_content_protection: Use generic debugfs name for HDCP caps
On 2019-09-24 at 12:54:54 +0300, Petri Latvala wrote: > On Mon, Sep 23, 2019 at 02:23:25PM -0400, Bhawanpreet Lakha wrote: > > Rename "i915_hdcp_sink_capability" to "hdcp_sink_capability" > > > > The content protection tests only start if this debugfs entry exists. > > Since the name is specific to intel driver these tests cannot be used with > > other drivers. > > > > Remove "i915" so the debugfs name is generic. > > I don't see any drivers currently using the name > "hdcp_sink_capability". Is the content of the file in other drivers > the same as i915's? > > And is there a plan to rename i915's debugfs filename to > hdcp_sink_capability? Ram? > > Agreed, for a DRIVER_ANY-using test generic names are preferrable, but > this needs some kind of a transition plan. If i915's filename is > staying as is, both names need to be tried. This IGT test change has to wait untill we have the i915_hdcp_sink_capabilities renamed, if at all we rename. Else based on drm_device we could decide the debugfs file and read it. Daniel, Considering all other debugfs are prefixed with i915, could we rename this debugfs as "hdcp_sink_capabilities" instead? -Ram > > > -- > Petri Latvala ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [igt-dev] [PATCH] test/kms_content_protection: Use generic debugfs name for HDCP caps
We have used the tests for our hdcp implementation. But because of the name we can't use it as is. Bhawan On 2019-09-24 5:54 a.m., Petri Latvala wrote: > On Mon, Sep 23, 2019 at 02:23:25PM -0400, Bhawanpreet Lakha wrote: >> Rename "i915_hdcp_sink_capability" to "hdcp_sink_capability" >> >> The content protection tests only start if this debugfs entry exists. >> Since the name is specific to intel driver these tests cannot be used with >> other drivers. >> >> Remove "i915" so the debugfs name is generic. > I don't see any drivers currently using the name > "hdcp_sink_capability". Is the content of the file in other drivers > the same as i915's? > > And is there a plan to rename i915's debugfs filename to > hdcp_sink_capability? Ram? > > Agreed, for a DRIVER_ANY-using test generic names are preferrable, but > this needs some kind of a transition plan. If i915's filename is > staying as is, both names need to be tried. > > ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [igt-dev] [PATCH] test/kms_content_protection: Use generic debugfs name for HDCP caps
On Mon, Sep 23, 2019 at 02:23:25PM -0400, Bhawanpreet Lakha wrote: > Rename "i915_hdcp_sink_capability" to "hdcp_sink_capability" > > The content protection tests only start if this debugfs entry exists. > Since the name is specific to intel driver these tests cannot be used with > other drivers. > > Remove "i915" so the debugfs name is generic. I don't see any drivers currently using the name "hdcp_sink_capability". Is the content of the file in other drivers the same as i915's? And is there a plan to rename i915's debugfs filename to hdcp_sink_capability? Ram? Agreed, for a DRIVER_ANY-using test generic names are preferrable, but this needs some kind of a transition plan. If i915's filename is staying as is, both names need to be tried. -- Petri Latvala ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
