Re: [Intel-gfx] 3.0 (or SNA?) regression: failed to train DP, aborting

2011-07-25 Thread Andrew Lutomirski 
On Mon, Jul 25, 2011 at 12:54 AM, Keith Packard kei...@keithp.com wrote:
 On Sat, 23 Jul 2011 14:40:36 -0400, Andrew Lutomirski l...@mit.edu wrote:
 I have a Q67 (DQ67SW board) attached to a Dell U2711 via DP.  In
 previous kernels, the DP link has worked flawlessly.  I just booted
 3.0-final and simultaneously enabled SNA, and now when my screen goes
 to sleep I don't get an image back until I power cycle the monitor.
 dmesg says:

 [drm:intel_dp_complete_link_train] *ERROR* failed to train DP,
 aborting

 Jesse put together a set of 7 display port patches around July 7 which
 were merged just after 3.0-rc6. If you try 3.0-rc6 and find that it
 works, you should be able to bisect that really quickly; there are only
 13 patches post-rc6 in drivers/gpu/drm/i915:

 $ git bisect start v3.0 v3.0-rc6 -- drivers/gpu/drm/i915

The offending commit appears to be:

commit 885a50147f00a8a80108904bf58a18af357717f3
Author: Jesse Barnes jbar...@virtuousgeek.org
Date:   Thu Jul 7 11:11:01 2011 -0700

drm/i915/dp: remove DPMS mode tracking from DP

We currently use this when a hot plug event is received, only checking
the link status and re-training if we had previously configured a link.
However if we want to preserve the DP configuration across both hot plug
and DPMS events (which we do for userspace apps that don't respond to
hot plug uevents), we need to unconditionally check the link and try to
bring it up on hot plug.

Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org
Reviewed-by: Keith Packard kei...@keithp.com
Signed-off-by: Keith Packard kei...@keithp.com

A debugging patch and its output are attached.

If I had to guess, though, it's a race: a hotplug event happens during
the intel_dp_dpms callback, confusing the code that's trying to train
the link.

--Andy
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] 3.0 (or SNA?) regression: failed to train DP, aborting

2011-07-25 Thread Keith Packard 
On Mon, 25 Jul 2011 11:23:17 -0400, Andrew Lutomirski l...@mit.edu wrote:

 A debugging patch and its output are attached.

I didn't get any attachment.

 If I had to guess, though, it's a race: a hotplug event happens during
 the intel_dp_dpms callback, confusing the code that's trying to train
 the link.

Interesting possibility. Please re-send the attachments and I'll take a
look.

-- 
keith.pack...@intel.com


pgpcGIfKsGI8Y.pgp
Description: PGP signature
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] 3.0 (or SNA?) regression: failed to train DP, aborting

2011-07-25 Thread Andrew Lutomirski 
On Mon, Jul 25, 2011 at 12:08 PM, Keith Packard kei...@keithp.com wrote:
 On Mon, 25 Jul 2011 11:23:17 -0400, Andrew Lutomirski l...@mit.edu wrote:

 A debugging patch and its output are attached.

 I didn't get any attachment.

 If I had to guess, though, it's a race: a hotplug event happens during
 the intel_dp_dpms callback, confusing the code that's trying to train
 the link.

 Interesting possibility. Please re-send the attachments and I'll take a
 look.

Done.

I'm pretty sure the debugging patch is barking up the wrong tree.  If
you like, I can do a different one to instrument intel_dp_dpms and
hotplug later on.


 --
 keith.pack...@intel.com

[  437.718439] [drm:intel_dp_link_down], 
[  439.250105] [drm:i915_hotplug_work_func], running encoder hotplug functions
[  439.250322] [drm:intel_dp_check_link_status], DPCD was 110A8401
[  439.250536] [drm:intel_dp_check_link_status], DPCD is now 110A8401
[  439.301732] [drm:intel_wait_for_vblank], vblank wait timed out
[  439.303716] [drm:intel_dp_complete_link_train], Training worked. 
DPCD=110A8401
[  439.303942] [drm:intel_ironlake_crt_detect_hotplug], ironlake hotplug 
adpa=0xf4, result 0
[  439.303946] [drm:intel_crt_detect], CRT not detected via hotplug
[  439.303950] [drm:output_poll_execute], [CONNECTOR:5:VGA-1] status updated 
from 2 to 2
[  439.316359] [drm:output_poll_execute], [CONNECTOR:8:HDMI-A-1] status updated 
from 2 to 2
[  439.316363] [drm:ironlake_dp_detect], DPCD was 
[  439.316878] [drm:intel_dp_aux_ch], dp_aux_ch timeout status 0x5143003e
[  439.316882] [drm:ironlake_dp_detect], Try 0: ret=-110 DPCD=
[  439.319216] [drm:intel_dp_aux_ch], dp_aux_ch timeout status 0x5143003e
[  439.319219] [drm:ironlake_dp_detect], Try 1: ret=-110 DPCD=
[  439.321217] [drm:intel_dp_aux_ch], dp_aux_ch timeout status 0x5143003e
[  439.321222] [drm:ironlake_dp_detect], Try 2: ret=-110 DPCD=
[  439.322704] [drm:ironlake_dp_detect], No link. DPCD: 
[  439.322711] [drm:output_poll_execute], [CONNECTOR:11:DP-1] status updated 
from 2 to 2
[  439.335104] [drm:output_poll_execute], [CONNECTOR:14:HDMI-A-2] status 
updated from 2 to 2
[  439.347505] [drm:output_poll_execute], [CONNECTOR:16:HDMI-A-3] status 
updated from 2 to 2
[  439.347509] [drm:ironlake_dp_detect], DPCD was 110A8401
[  439.347724] [drm:ironlake_dp_detect], Try 0: ret=4 DPCD=110A8401
[  439.347730] [drm:ironlake_dp_detect], Happy now!
[  439.347732] [drm:ironlake_dp_detect], No link. DPCD: 110a8401
[  439.348687] [drm:i2c_algo_dp_aux_xfer], dp_aux_xfer return 2
[  439.376262] [drm:i2c_algo_dp_aux_xfer], dp_aux_xfer return 2
[  439.403831] [drm:i2c_algo_dp_aux_xfer], dp_aux_xfer return 2
[  439.403835] [drm:drm_detect_monitor_audio], Monitor has basic audio support
[  439.403838] [drm:output_poll_execute], [CONNECTOR:17:DP-2] status updated 
from 1 to 1
[  439.403842] [drm:ironlake_dp_detect], DPCD was 
[  439.404357] [drm:intel_dp_aux_ch], dp_aux_ch timeout status 0x5143003e
[  439.404360] [drm:ironlake_dp_detect], Try 0: ret=-110 DPCD=
[  439.406164] [drm:intel_dp_aux_ch], dp_aux_ch timeout status 0x5143003e
[  439.406165] [drm:ironlake_dp_detect], Try 1: ret=-110 DPCD=
[  439.408167] [drm:intel_dp_aux_ch], dp_aux_ch timeout status 0x5143003e
[  439.408169] [drm:ironlake_dp_detect], Try 2: ret=-110 DPCD=
[  439.409663] [drm:ironlake_dp_detect], No link. DPCD: 
[  439.409671] [drm:output_poll_execute], [CONNECTOR:19:DP-3] status updated 
from 2 to 2
[  442.956501] [drm:ironlake_crtc_dpms], crtc 0/0 dpms on
[  443.120115] [drm:intel_dp_link_down], 
[  443.137460] [drm:ironlake_crtc_dpms], crtc 0/0 dpms off
[  443.189440] [drm:intel_wait_for_vblank], vblank wait timed out
[  443.211838] [drm:sandybridge_update_wm], FIFO watermarks For pipe A - plane 
13, cursor: 6
[  443.211845] [drm:ironlake_check_srwm], watermark 1: display plane 25, fbc 
lines 3, cursor 6
[  443.211849] [drm:ironlake_check_srwm], watermark 2: display plane 33, fbc 
lines 3, cursor 6
[  443.211854] [drm:ironlake_check_srwm], watermark 3: display plane 169, fbc 
lines 4, cursor 10
[  443.211858] [drm:intel_update_fbc], 
[  444.644607] [drm:i915_hotplug_work_func], running encoder hotplug functions
[  444.644823] [drm:intel_dp_check_link_status], DPCD was 110A8401
[  444.645037] [drm:intel_dp_check_link_status], DPCD is now 110A8401
[  444.696526] [drm:intel_wait_for_vblank], vblank wait timed out
[  444.751506] [drm:intel_wait_for_vblank], vblank wait timed out
[  444.806485] [drm:intel_wait_for_vblank], vblank wait timed out
[  444.861428] [drm:intel_wait_for_vblank], vblank wait timed out
[  444.916419] [drm:intel_wait_for_vblank], vblank wait timed out
[  444.971376] [drm:intel_wait_for_vblank], vblank wait timed out
[  445.026356] [drm:intel_wait_for_vblank], vblank wait timed out
[  445.028771] [drm:intel_dp_complete_link_train] *ERROR* failed to train DP, 
aborting
[  445.028775] [drm:intel_dp_complete_link_train], DPCD is 110A8401
[

Re: [Intel-gfx] 3.0 (or SNA?) regression: failed to train DP, aborting

2011-07-24 Thread Keith Packard 
On Sat, 23 Jul 2011 14:40:36 -0400, Andrew Lutomirski l...@mit.edu wrote:
 I have a Q67 (DQ67SW board) attached to a Dell U2711 via DP.  In
 previous kernels, the DP link has worked flawlessly.  I just booted
 3.0-final and simultaneously enabled SNA, and now when my screen goes
 to sleep I don't get an image back until I power cycle the monitor.
 dmesg says:
 
 [drm:intel_dp_complete_link_train] *ERROR* failed to train DP,
 aborting

Jesse put together a set of 7 display port patches around July 7 which
were merged just after 3.0-rc6. If you try 3.0-rc6 and find that it
works, you should be able to bisect that really quickly; there are only
13 patches post-rc6 in drivers/gpu/drm/i915:

$ git bisect start v3.0 v3.0-rc6 -- drivers/gpu/drm/i915

We tested this on as many machines as we could get our hands on, but
it's a combinatorial problem between the chipset and the monitor...

 I don't know whether this is a 3.0 regression or whether it's
 triggered by SNA, but something broke.

Yeah, as you noticed, this should have no effect. Please let us know
what you find.

-- 
keith.pack...@intel.com


pgpWKigOHeTzD.pgp
Description: PGP signature
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] 3.0 (or SNA?) regression: failed to train DP, aborting

2011-07-23 Thread Andrew Lutomirski 
On Sat, Jul 23, 2011 at 2:40 PM, Andrew Lutomirski l...@mit.edu wrote:
 I have a Q67 (DQ67SW board) attached to a Dell U2711 via DP.  In
 previous kernels, the DP link has worked flawlessly.  I just booted
 3.0-final and simultaneously enabled SNA, and now when my screen goes
 to sleep I don't get an image back until I power cycle the monitor.
 dmesg says:

 [drm:intel_dp_complete_link_train] *ERROR* failed to train DP, aborting

 I don't know whether this is a 3.0 regression or whether it's
 triggered by SNA, but something broke.

It's not SNA.  Building with --disable-sna doesn't help.


 --Andy

___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx