Re: [Intel-gfx] mmotm 2019-07-04-15-01 uploaded (gpu/drm/i915/oa/)
On Thu, 04 Jul 2019 22:22:41 -0700 Joe Perches wrote: > > So when comparing a zero-length file with a non-existent file, diff > > produces no output. > > Why use the -N option ? > > $ diff --help > [...] > -N, --new-file treat absent files as empty > > otherwise > > $ cd $(mktemp -d -p .) > $ touch x > $ diff -u x y > diff: y: No such file or directory Without -N diff fails and exits with an error. -N does what's desired as long as the non-missing file isn't empty. ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] mmotm 2019-07-04-15-01 uploaded (gpu/drm/i915/oa/)
On Thu, 2019-07-04 at 22:09 -0700, Andrew Morton wrote: > diff(1) doesn't seem to know how to handle a zero-length file. > > y:/home/akpm> mkdir foo > y:/home/akpm> cd foo > y:/home/akpm/foo> touch x > y:/home/akpm/foo> diff -uN x y > y:/home/akpm/foo> date > x > y:/home/akpm/foo> diff -uN x y > --- x 2019-07-04 21:58:37.815028211 -0700 > +++ y 1969-12-31 16:00:00.0 -0800 > @@ -1 +0,0 @@ > -Thu Jul 4 21:58:37 PDT 2019 > > So when comparing a zero-length file with a non-existent file, diff > produces no output. Why use the -N option ? $ diff --help [...] -N, --new-file treat absent files as empty otherwise $ cd $(mktemp -d -p .) $ touch x $ diff -u x y diff: y: No such file or directory ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] mmotm 2019-07-04-15-01 uploaded (gpu/drm/i915/oa/)
On Fri, 5 Jul 2019 13:14:35 +1000 Stephen Rothwell
wrote:
> > I checked next-20190704 tag.
> >
> > I see the empty file
> > drivers/gpu/drm/i915/oa/Makefile
> >
> > Did someone delete it?
>
> Commit
>
> 5ed7a0cf3394 ("drm/i915: Move OA files to separate folder")
>
> from the drm-intel tree seems to have created it as an empty file.
hrm.
diff(1) doesn't seem to know how to handle a zero-length file.
y:/home/akpm> mkdir foo
y:/home/akpm> cd foo
y:/home/akpm/foo> touch x
y:/home/akpm/foo> diff -uN x y
y:/home/akpm/foo> date > x
y:/home/akpm/foo> diff -uN x y
--- x 2019-07-04 21:58:37.815028211 -0700
+++ y 1969-12-31 16:00:00.0 -0800
@@ -1 +0,0 @@
-Thu Jul 4 21:58:37 PDT 2019
So when comparing a zero-length file with a non-existent file, diff
produces no output.
This'll make things happy. And I guess it should be done to protect
all the valuable intellectual property in that file.
--- /dev/null
+++ a/drivers/gpu/drm/i915/oa/Makefile
@@ -0,0 +1 @@
+# SPDX-License-Identifier: GPL-2.0
_
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] mmotm 2019-07-04-15-01 uploaded (gpu/drm/i915/oa/)
Hi Masahiro,
On Fri, 5 Jul 2019 12:05:49 +0900 Masahiro Yamada
wrote:
>
> On Fri, Jul 5, 2019 at 10:09 AM Randy Dunlap wrote:
> >
> > I get a lot of these but don't see/know what causes them:
> >
> > ../scripts/Makefile.build:42: ../drivers/gpu/drm/i915/oa/Makefile: No such
> > file or directory
> > make[6]: *** No rule to make target '../drivers/gpu/drm/i915/oa/Makefile'.
> > Stop.
> > ../scripts/Makefile.build:498: recipe for target 'drivers/gpu/drm/i915/oa'
> > failed
> > make[5]: *** [drivers/gpu/drm/i915/oa] Error 2
> > ../scripts/Makefile.build:498: recipe for target 'drivers/gpu/drm/i915'
> > failed
> >
>
> I checked next-20190704 tag.
>
> I see the empty file
> drivers/gpu/drm/i915/oa/Makefile
>
> Did someone delete it?
Commit
5ed7a0cf3394 ("drm/i915: Move OA files to separate folder")
from the drm-intel tree seems to have created it as an empty file.
--
Cheers,
Stephen Rothwell
pgp2PWxDEJlhM.pgp
Description: OpenPGP digital signature
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
