Re: [PULL] drm-misc-fixes
Hi, On Thu, Feb 29, 2024 at 01:54:30PM +, Matthew Auld wrote: > On 29/02/2024 13:37, Maxime Ripard wrote: > > Hi, > > > > Here's this week drm-misc fixes PR. > > > > There's two commits for files unders drivers/soc/qcom that don't have a > > maintainer Acked-by. Bjorn's Acked-by was provided on IRC, and Konrad > > provided it by mail after the facts so we're covered. > > > > Maxime > > > > drm-misc-fixes-2024-02-29: > > A reset fix for host1x, a resource leak fix and a probe fix for aux-hpd, > > a use-after-free fix and a boot fix for a pmic_glink qcom driver in > > drivers/soc, a fix for the simpledrm/tegra transition, a kunit fix for > > the TTM tests, a font handling fix for fbcon, two allocation fixes and a > > kunit test to cover them for drm/buddy > > The following changes since commit 72fa02fdf83306c52bc1eede28359e3fa32a151a: > > > >nouveau: add an ioctl to report vram usage (2024-02-23 10:20:07 +1000) > > > > are available in the Git repository at: > > > >https://anongit.freedesktop.org/git/drm/drm-misc > > tags/drm-misc-fixes-2024-02-29 > > > > for you to fetch changes up to c70703320e557ff30847915e6a7631a9abdda16b: > > > >drm/tests/drm_buddy: add alloc_range_bias test (2024-02-28 08:03:29 > > +0100) > > > > > > A reset fix for host1x, a resource leak fix and a probe fix for aux-hpd, > > a use-after-free fix and a boot fix for a pmic_glink qcom driver in > > drivers/soc, a fix for the simpledrm/tegra transition, a kunit fix for > > the TTM tests, a font handling fix for fbcon, two allocation fixes and a > > kunit test to cover them for drm/buddy > > > > > > Christian König (1): > >drm/ttm/tests: depend on UML || COMPILE_TEST > > > > Jiri Slaby (SUSE) (1): > >fbcon: always restore the old font data in fbcon_do_set_font() > > > > Johan Hovold (3): > >drm/bridge: aux-hpd: fix OF node leaks > >drm/bridge: aux-hpd: separate allocation and registration > >soc: qcom: pmic_glink_altmode: fix drm bridge use-after-free > > > > Matthew Auld (3): > >drm/buddy: fix range bias > >drm/buddy: check range allocation matches alignment > >drm/tests/drm_buddy: add alloc_range_bias test > > Note that there is a build fix needed for this one: > https://patchwork.freedesktop.org/patch/580568/?series=130552=1 It looks like that patch still hasn't been applied. What's going on? Maxime signature.asc Description: PGP signature
Re: [PULL] drm-misc-fixes
On 29/02/2024 13:37, Maxime Ripard wrote: Hi, Here's this week drm-misc fixes PR. There's two commits for files unders drivers/soc/qcom that don't have a maintainer Acked-by. Bjorn's Acked-by was provided on IRC, and Konrad provided it by mail after the facts so we're covered. Maxime drm-misc-fixes-2024-02-29: A reset fix for host1x, a resource leak fix and a probe fix for aux-hpd, a use-after-free fix and a boot fix for a pmic_glink qcom driver in drivers/soc, a fix for the simpledrm/tegra transition, a kunit fix for the TTM tests, a font handling fix for fbcon, two allocation fixes and a kunit test to cover them for drm/buddy The following changes since commit 72fa02fdf83306c52bc1eede28359e3fa32a151a: nouveau: add an ioctl to report vram usage (2024-02-23 10:20:07 +1000) are available in the Git repository at: https://anongit.freedesktop.org/git/drm/drm-misc tags/drm-misc-fixes-2024-02-29 for you to fetch changes up to c70703320e557ff30847915e6a7631a9abdda16b: drm/tests/drm_buddy: add alloc_range_bias test (2024-02-28 08:03:29 +0100) A reset fix for host1x, a resource leak fix and a probe fix for aux-hpd, a use-after-free fix and a boot fix for a pmic_glink qcom driver in drivers/soc, a fix for the simpledrm/tegra transition, a kunit fix for the TTM tests, a font handling fix for fbcon, two allocation fixes and a kunit test to cover them for drm/buddy Christian König (1): drm/ttm/tests: depend on UML || COMPILE_TEST Jiri Slaby (SUSE) (1): fbcon: always restore the old font data in fbcon_do_set_font() Johan Hovold (3): drm/bridge: aux-hpd: fix OF node leaks drm/bridge: aux-hpd: separate allocation and registration soc: qcom: pmic_glink_altmode: fix drm bridge use-after-free Matthew Auld (3): drm/buddy: fix range bias drm/buddy: check range allocation matches alignment drm/tests/drm_buddy: add alloc_range_bias test Note that there is a build fix needed for this one: https://patchwork.freedesktop.org/patch/580568/?series=130552=1 Maxime Ripard (1): Merge drm/drm-fixes into drm-misc-fixes Mikko Perttunen (1): gpu: host1x: Skip reset assert on Tegra186 Rob Clark (1): soc: qcom: pmic_glink: Fix boot when QRTR=m Thierry Reding (1): drm/tegra: Remove existing framebuffer only if we support display drivers/gpu/drm/Kconfig | 5 +- drivers/gpu/drm/bridge/aux-hpd-bridge.c | 70 +++--- drivers/gpu/drm/drm_buddy.c | 16 ++- drivers/gpu/drm/tegra/drm.c | 23 +++- drivers/gpu/drm/tests/drm_buddy_test.c | 218 drivers/gpu/host1x/dev.c| 15 ++- drivers/gpu/host1x/dev.h| 6 + drivers/soc/qcom/pmic_glink.c | 21 +-- drivers/soc/qcom/pmic_glink_altmode.c | 16 ++- drivers/video/fbdev/core/fbcon.c| 8 +- include/drm/bridge/aux-bridge.h | 15 +++ 11 files changed, 368 insertions(+), 45 deletions(-)
Re: Re: [PULL] drm-misc-fixes
Hi Maxime, Dave,
On Thu, Feb 15, 2024 at 5:45 PM Geert Uytterhoeven wrote:
> On Thu, Feb 15, 2024 at 5:09 PM Maxime Ripard wrote:
> On Thu, Feb 15, 2024 at 01:41:24PM +0100, Geert Uytterhoeven wrote:
> > > On Thu, 15 Feb 2024, Maxime Ripard wrote:
> > > > Matthew Auld (1):
> > > > drm/tests/drm_buddy: add alloc_contiguous test
> > >
> > > Please drop this one.
> > >
> > > nore...@ellerman.id.au reported a build failure on m68k (and presumably
> > > other 32-bit platforms) in next-20240215:
> > >
> > > ERROR: modpost: "__umoddi3" [drivers/gpu/drm/tests/drm_buddy_test.ko]
> > > undefined!
> > > ERROR: modpost: "__moddi3" [drivers/gpu/drm/tests/drm_buddy_test.ko]
> > > undefined!
> > >
> > > Reverting commit a64056bb5a3215bd ("drm/tests/drm_buddy: add
> > > alloc_contiguous test") fixes the issue.
> >
> > From a quick cross-compile test with arm(32), it seems to work there
> > interestingly:
> >
> > ./tools/testing/kunit/kunit.py run \
> > --kunitconfig=drivers/gpu/drm//tests \
> > --cross_compile arm-linux-gnu- --arch arm
>
> shmobile_defconfig + CONFIG_DRM_KUNIT_TEST=y + CONFIG_KUNIT=y:
>
> arm-linux-gnueabihf-ld: drivers/gpu/drm/tests/drm_buddy_test.o: in
> function `drm_test_buddy_alloc_contiguous':
> drm_buddy_test.c:(.text+0xe0): undefined reference to `__aeabi_uldivmod'
>
> > But I agree, with should wait for a fix or a revert before merging this.
>
> Great, thanks!
Unfortunately the breakage still made it upstream.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Re: Re: [PULL] drm-misc-fixes
Hi Maxime,
On Thu, Feb 15, 2024 at 5:09 PM Maxime Ripard wrote:
On Thu, Feb 15, 2024 at 01:41:24PM +0100, Geert Uytterhoeven wrote:
> > On Thu, 15 Feb 2024, Maxime Ripard wrote:
> > > Matthew Auld (1):
> > > drm/tests/drm_buddy: add alloc_contiguous test
> >
> > Please drop this one.
> >
> > nore...@ellerman.id.au reported a build failure on m68k (and presumably
> > other 32-bit platforms) in next-20240215:
> >
> > ERROR: modpost: "__umoddi3" [drivers/gpu/drm/tests/drm_buddy_test.ko]
> > undefined!
> > ERROR: modpost: "__moddi3" [drivers/gpu/drm/tests/drm_buddy_test.ko]
> > undefined!
> >
> > Reverting commit a64056bb5a3215bd ("drm/tests/drm_buddy: add
> > alloc_contiguous test") fixes the issue.
>
> From a quick cross-compile test with arm(32), it seems to work there
> interestingly:
>
> ./tools/testing/kunit/kunit.py run \
> --kunitconfig=drivers/gpu/drm//tests \
> --cross_compile arm-linux-gnu- --arch arm
shmobile_defconfig + CONFIG_DRM_KUNIT_TEST=y + CONFIG_KUNIT=y:
arm-linux-gnueabihf-ld: drivers/gpu/drm/tests/drm_buddy_test.o: in
function `drm_test_buddy_alloc_contiguous':
drm_buddy_test.c:(.text+0xe0): undefined reference to `__aeabi_uldivmod'
> But I agree, with should wait for a fix or a revert before merging this.
Great, thanks!
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Re: Re: [PULL] drm-misc-fixes
Hi,
On Thu, Feb 15, 2024 at 01:41:24PM +0100, Geert Uytterhoeven wrote:
> Hi Maxime,
>
> On Thu, 15 Feb 2024, Maxime Ripard wrote:
> > Here's this week drm-misc-fixes PR
> >
> > Maxime
> >
> > drm-misc-fixes-2024-02-15:
> > A suspend/resume error fix for ivpu, a couple of scheduler fixes for
> > nouveau, a patch to support large page arrays in prime, a uninitialized
> > variable fix in crtc, a locking fix in rockchip/vop2 and a buddy
> > allocator error reporting fix.
> > The following changes since commit 5f8408aca66772d3aa9b4831577b2ac5ec41bcd9:
> >
> > accel/ivpu: Add job status for jobs aborted by the driver (2024-02-06
> > 13:37:34 +0100)
> >
> > are available in the Git repository at:
> >
> > git://anongit.freedesktop.org/drm/drm-misc tags/drm-misc-fixes-2024-02-15
> >
> > for you to fetch changes up to a64056bb5a3215bd31c8ce17d609ba0f4d5c55ea:
> >
> > drm/tests/drm_buddy: add alloc_contiguous test (2024-02-14 15:22:21 +0100)
> >
> >
> > A suspend/resume error fix for ivpu, a couple of scheduler fixes for
> > nouveau, a patch to support large page arrays in prime, a uninitialized
> > variable fix in crtc, a locking fix in rockchip/vop2 and a buddy
> > allocator error reporting fix.
>
> > Matthew Auld (1):
> > drm/tests/drm_buddy: add alloc_contiguous test
>
> Please drop this one.
>
> nore...@ellerman.id.au reported a build failure on m68k (and presumably
> other 32-bit platforms) in next-20240215:
>
> ERROR: modpost: "__umoddi3" [drivers/gpu/drm/tests/drm_buddy_test.ko]
> undefined!
> ERROR: modpost: "__moddi3" [drivers/gpu/drm/tests/drm_buddy_test.ko]
> undefined!
>
> Reverting commit a64056bb5a3215bd ("drm/tests/drm_buddy: add
> alloc_contiguous test") fixes the issue.
From a quick cross-compile test with arm(32), it seems to work there
interestingly:
./tools/testing/kunit/kunit.py run \
--kunitconfig=drivers/gpu/drm//tests \
--cross_compile arm-linux-gnu- --arch arm
But I agree, with should wait for a fix or a revert before merging this.
Maxime
signature.asc
Description: PGP signature
Re: [PULL] drm-misc-fixes
Hi Maxime,
On Thu, 15 Feb 2024, Maxime Ripard wrote:
Here's this week drm-misc-fixes PR
Maxime
drm-misc-fixes-2024-02-15:
A suspend/resume error fix for ivpu, a couple of scheduler fixes for
nouveau, a patch to support large page arrays in prime, a uninitialized
variable fix in crtc, a locking fix in rockchip/vop2 and a buddy
allocator error reporting fix.
The following changes since commit 5f8408aca66772d3aa9b4831577b2ac5ec41bcd9:
accel/ivpu: Add job status for jobs aborted by the driver (2024-02-06 13:37:34
+0100)
are available in the Git repository at:
git://anongit.freedesktop.org/drm/drm-misc tags/drm-misc-fixes-2024-02-15
for you to fetch changes up to a64056bb5a3215bd31c8ce17d609ba0f4d5c55ea:
drm/tests/drm_buddy: add alloc_contiguous test (2024-02-14 15:22:21 +0100)
A suspend/resume error fix for ivpu, a couple of scheduler fixes for
nouveau, a patch to support large page arrays in prime, a uninitialized
variable fix in crtc, a locking fix in rockchip/vop2 and a buddy
allocator error reporting fix.
Matthew Auld (1):
drm/tests/drm_buddy: add alloc_contiguous test
Please drop this one.
nore...@ellerman.id.au reported a build failure on m68k (and presumably
other 32-bit platforms) in next-20240215:
ERROR: modpost: "__umoddi3" [drivers/gpu/drm/tests/drm_buddy_test.ko] undefined!
ERROR: modpost: "__moddi3" [drivers/gpu/drm/tests/drm_buddy_test.ko] undefined!
Reverting commit a64056bb5a3215bd ("drm/tests/drm_buddy: add
alloc_contiguous test") fixes the issue.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
