Re: [PHP-DEV] Where to send small enhancement patch for openssl module of PHP 5.2.6 ?
Hi Pierre, If you have time to look at his bug, maybe you'll also have time to look at my one-line patch also related to OpenSSL ? http://bugs.php.net/bug.php?id=46127 I really don't know if I'm being ignored or what, but every time I write something for PHP, it gets nowhere (see: bug #46073 and #46496), to the point I'm thinking of creating my own branch of PHP with my own patches. So, is that my own impression, or is it just that everybody is just too worried with choices of namespace separators (yeah I also have an opinion about this, but it's not relevant to the scope of this mail) or whatever? Mark Le dimanche 09 novembre 2008 à 01:05 +0100, Pierre Joye a écrit : hi! On Sat, Nov 8, 2008 at 11:37 PM, Nikolay Zapolnov [EMAIL PROTECTED] wrote: I do not know the patch contribution scheme of PHP project and did not find how to do this at the PHP web site. Can you please tell me where can I send my patch? Best would be to create a new report (http://bugs.php.net) with a link to the patch, examples and tests. You can reply as well to this thread with the info. I may have the time to review and test it before the next 5.3 alpha3. Cheers, -- Pierre http://blog.thepimp.net | http://www.libgd.org -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
[PHP-DEV] sybase_connect()
Hi, I'd like to add a new optional parameter to sybase_connect() for PHP 5.3. If set to TRUE it will force creation of a new link (and works just like mysql_connect()'s new_link parameter). http://sitten-polizei.de/php/sybase-connect-newlink.diff Any objections? - Timm -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] sybase_connect()
On 09.11.2008, at 13:05, Timm Friebe wrote: Hi, I'd like to add a new optional parameter to sybase_connect() for PHP 5.3. If set to TRUE it will force creation of a new link (and works just like mysql_connect()'s new_link parameter). http://sitten-polizei.de/php/sybase-connect-newlink.diff seems like a good idea to have this and i guess there is no other choice but to stick it at the end of the function parameter list. regards, Lukas Kahwe Smith [EMAIL PROTECTED] -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Where to send small enhancement patch for openssl module of PHP 5.2.6 ?
hi, On Sun, Nov 9, 2008 at 9:39 AM, M. Karpelès [EMAIL PROTECTED] wrote: Hi Pierre, If you have time to look at his bug, maybe you'll also have time to look at my one-line patch also related to OpenSSL ? http://bugs.php.net/bug.php?id=46127 I really don't know if I'm being ignored or what, but every time I write something for PHP, it gets nowhere (see: bug #46073 and #46496), to the point I'm thinking of creating my own branch of PHP with my own patches. It is more a matter of availability. I will take a look at them too. So, is that my own impression, or is it just that everybody is just too worried with choices of namespace separators (yeah I also have an opinion about this, but it's not relevant to the scope of this mail) or whatever? Namespace discussions are irrelevant in any other feature requests. -- Pierre http://blog.thepimp.net | http://www.libgd.org -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
[PHP-DEV] karma request
Hi, I'd like to request karma for ZE in order to do minor bugfixes and refactoring. I have no intention to commit any feature changes or major commits, and am perfectly happy writing patches for these to be reviewed by the big guns. Thanks, Greg -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
[PHP-DEV] alpha3 or forever hold your peace
Hi, I just wanted to ask everybody to skim over the changes for PHP 5.3 we have in CVS (especially bigger stuff like the addition/removal of an extension etc.). Please bring up any areas you are concerned about that we might have forgotten. However I am not interested in people bringing up a debate again on namespace syntax or resolution orders (I hope to have the final behavior in CVS ASAP). This is just an attempt to ensure we do not forget something. regards, Lukas Kahwe Smith [EMAIL PROTECTED] PS: I know this might sound like an invitation for a flame war, it isnt. Please keep replies as technical as possible. Thanks! -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Bug in namespaces and type hints
Hi! recent change in namespace code introduced new bug, please consider: Current code needs some change and cleanup, which will be done shortly. -- Stanislav Malyshev, Zend Software Architect [EMAIL PROTECTED] http://www.zend.com/ (408)253-8829 MSN: [EMAIL PROTECTED] -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Where to send small enhancement patch for openssl module of PHP 5.2.6 ?
Pierre Joye kirjoitti: hi, On Sun, Nov 9, 2008 at 9:39 AM, M. Karpelès [EMAIL PROTECTED] wrote: Hi Pierre, If you have time to look at his bug, maybe you'll also have time to look at my one-line patch also related to OpenSSL ? http://bugs.php.net/bug.php?id=46127 I really don't know if I'm being ignored or what, but every time I write something for PHP, it gets nowhere (see: bug #46073 and #46496), to the point I'm thinking of creating my own branch of PHP with my own patches. It is more a matter of availability. I will take a look at them too. Given your track record for keeping promises, I wouldn't hold my breath waiting. Please leave the bugs for the people who actually deliver what they promise. --Jani -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
[PHP-DEV] Bug in namespaces and type hints
Hi,
recent change in namespace code introduced new bug, please consider:
?php
namespace tests;
class t1 {
function abc(\stdClass $std = null) {
}
}
?
triggers Fatal error: Default value for parameters with a class type hint can
only be NULL where the same w/o namespace definition works as
expected (no error).
this is tested with currently newest snap: 2008.11.09 23:30 (UTC)
I haven't filed bug report for this yet i'll do it if required.
TIA for quick fix ;-)
Marcin Kurzyna
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
[PHP-DEV] where to request small enhancements?
I'm not a C++ or C programmer, however I have made an extension that exposes a complimentary function to error_get_last, error_clear_last. It's a super useful function, specially if you're trying to detect things like white pages It's a much needed function for people that write their own error reporters. Considering the last error doesn't clear until the error reporter returns true, so there could be cases where someone's custom error reporter could be reporting the same error stored in $php_errormsg many times. regardless of your usage, users should have the ability to clear the 'last error' at their will. ANYWAY where would I post something like this? I don't want to put up my code because a.)I can't find it anymore and b.)it'd probably be embarrassing to show my crap C! -James -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] [PATCH] Allow unsetting headers previously set usingheader()
Stan Vassilev | FM wrote:
I suggest header_remove('*') or simply header_remove() /no param/
removes all headers (including the one PHP sets by default), so we can
start with a clear state.
I added header_remove('Foo'). header_remove() without arguments removes
all headers (though Apache still adds some headers that you cannot remove).
I have tested with apache2handler and cgi. I had to change the signature
of SAPI header_handler function and sapi_header_struct, so the other
SAPIs should be updated for this. I am not sure how to test all these?
Creating a testing environment for all those webservers seems like a
huge task.
I am not comfortable with the size of this patch, given my understanding
of the PHP source code and my general C skills, so I am posting this
patch hoping that somebody will pick it up or help me get it into shape.
Christian
Index: ext/standard/basic_functions.c
===
RCS file: /repository/php-src/ext/standard/basic_functions.c,v
retrieving revision 1.725.2.31.2.64.2.69
diff -u -8 -p -r1.725.2.31.2.64.2.69 basic_functions.c
--- ext/standard/basic_functions.c 5 Nov 2008 21:35:02 -
1.725.2.31.2.64.2.69
+++ ext/standard/basic_functions.c 9 Nov 2008 18:37:09 -
@@ -1687,16 +1687,21 @@ ZEND_END_ARG_INFO()
static
ZEND_BEGIN_ARG_INFO_EX(arginfo_header, 0, 0, 1)
ZEND_ARG_INFO(0, header)
ZEND_ARG_INFO(0, replace)
ZEND_ARG_INFO(0, http_response_code)
ZEND_END_ARG_INFO()
static
+ZEND_BEGIN_ARG_INFO_EX(arginfo_header_remove, 0, 0, 0)
+ ZEND_ARG_INFO(0, name)
+ZEND_END_ARG_INFO()
+
+static
ZEND_BEGIN_ARG_INFO_EX(arginfo_setcookie, 0, 0, 1)
ZEND_ARG_INFO(0, name)
ZEND_ARG_INFO(0, value)
ZEND_ARG_INFO(0, expires)
ZEND_ARG_INFO(0, path)
ZEND_ARG_INFO(0, domain)
ZEND_ARG_INFO(0, secure)
ZEND_END_ARG_INFO()
@@ -3445,16 +3450,17 @@ const zend_function_entry basic_function
PHP_FE(ini_restore,
arginfo_ini_restore)
PHP_FE(get_include_path,
arginfo_get_include_path)
PHP_FE(set_include_path,
arginfo_set_include_path)
PHP_FE(restore_include_path,
arginfo_restore_include_path)
PHP_FE(setcookie,
arginfo_setcookie)
PHP_FE(setrawcookie,
arginfo_setrawcookie)
PHP_FE(header,
arginfo_header)
+ PHP_FE(header_remove,
arginfo_header_remove)
PHP_FE(headers_sent,
arginfo_headers_sent)
PHP_FE(headers_list,
arginfo_headers_list)
PHP_FE(connection_aborted,
arginfo_connection_aborted)
PHP_FE(connection_status,
arginfo_connection_status)
PHP_FE(ignore_user_abort,
arginfo_ignore_user_abort)
PHP_FE(parse_ini_file,
arginfo_parse_ini_file)
PHP_FE(parse_ini_string,
arginfo_parse_ini_string)
Index: ext/standard/head.c
===
RCS file: /repository/php-src/ext/standard/head.c,v
retrieving revision 1.84.2.1.2.7.2.5
diff -u -8 -p -r1.84.2.1.2.7.2.5 head.c
--- ext/standard/head.c 21 Oct 2008 22:08:37 - 1.84.2.1.2.7.2.5
+++ ext/standard/head.c 9 Nov 2008 18:37:09 -
@@ -45,16 +45,30 @@ PHP_FUNCTION(header)
if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, s|bl, ctr.line,
ctr.line_len, rep, ctr.response_code) ==
FAILURE)
return;
sapi_header_op(rep ? SAPI_HEADER_REPLACE:SAPI_HEADER_ADD, ctr
TSRMLS_CC);
}
/* }}} */
+/* {{{
RE: [PHP-DEV] [PATCH] Allow unsetting headers previously set usingheader()
+1
I have no problem with implementing this for NSAPI after the patch is
committed to CVS, just keep me informed about this.
-
Uwe Schindler
[EMAIL PROTECTED] - http://www.php.net
NSAPI SAPI developer
Bremen, Germany
-Original Message-
From: Arnaud LB [mailto:[EMAIL PROTECTED] On Behalf Of Arnaud Le Blanc
Sent: Sunday, November 09, 2008 10:02 PM
To: internals@lists.php.net
Cc: Christian Schmidt
Subject: Re: [PHP-DEV] [PATCH] Allow unsetting headers previously set
usingheader()
On Sunday 09 November 2008 19:51:31 Christian Schmidt wrote:
Stan Vassilev | FM wrote:
I suggest header_remove('*') or simply header_remove() /no param/
removes all headers (including the one PHP sets by default), so we can
start with a clear state.
I added header_remove('Foo'). header_remove() without arguments removes
all headers (though Apache still adds some headers that you cannot
remove).
I have tested with apache2handler and cgi. I had to change the signature
of SAPI header_handler function and sapi_header_struct, so the other
SAPIs should be updated for this. I am not sure how to test all these?
Creating a testing environment for all those webservers seems like a
huge task.
I am not comfortable with the size of this patch, given my understanding
of the PHP source code and my general C skills, so I am posting this
patch hoping that somebody will pick it up or help me get it into shape.
It looks good. The signature change is not that bad if it forces all SAPIs
to
be updated and ensures that PHP behaves the same way with all SAPIs.
It is also possible to add something like header_delete_handler() or
header_handler_ex() to sapi_module_struct if the signature change is to be
avoided.
Regards,
Arnaud
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] [PATCH] Allow unsetting headers previously set usingheader()
On Sunday 09 November 2008 19:51:31 Christian Schmidt wrote:
Stan Vassilev | FM wrote:
I suggest header_remove('*') or simply header_remove() /no param/
removes all headers (including the one PHP sets by default), so we can
start with a clear state.
I added header_remove('Foo'). header_remove() without arguments removes
all headers (though Apache still adds some headers that you cannot remove).
I have tested with apache2handler and cgi. I had to change the signature
of SAPI header_handler function and sapi_header_struct, so the other
SAPIs should be updated for this. I am not sure how to test all these?
Creating a testing environment for all those webservers seems like a
huge task.
I am not comfortable with the size of this patch, given my understanding
of the PHP source code and my general C skills, so I am posting this
patch hoping that somebody will pick it up or help me get it into shape.
It looks good. The signature change is not that bad if it forces all SAPIs to
be updated and ensures that PHP behaves the same way with all SAPIs.
It is also possible to add something like header_delete_handler() or
header_handler_ex() to sapi_module_struct if the signature change is to be
avoided.
Regards,
Arnaud
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
