Re: [PHP-DEV] [RFC] Integrating Zend Optimizer+ into the PHP distribution
On Tue, Feb 12, 2013 at 5:20 PM, Zeev Suraski z...@zend.com wrote: We're trying to do exactly that. It's taking a bit longer than expected but I'm hopeful we'll open the initial code base tomorrow. Zeev -Original Message- From: Pierre Joye [mailto:pierre@gmail.com] Sent: Tuesday, February 12, 2013 3:48 PM To: Zeev Suraski Cc: PHP internals Subject: Re: [PHP-DEV] [RFC] Integrating Zend Optimizer+ into the PHP distribution hi Zeev, On Tue, Jan 29, 2013 at 9:03 AM, Zeev Suraski z...@zend.com wrote: Any news on this front? It's becoming harder and harder to consider it in 5.5 if we have to wait longer. There are enough volunteers to help, open it now :) Cheers, Pierre -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php My weekend is reserved for testing! Regards, Thomas -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
[PHP-DEV] Status of pull request
Is it considered spamming the list to check the status of a pull request? I am going to ask any ways, hope it doesn't offend. The pull request addresses bug fix/feature request #38917 implementing native signed public key challenge support to the OpenSSL extension. Details can be found @ https://github.com/php/php-src/pull/267 (I created a new branch 'issue-38917-spkac' according to the Wiki, but does not seem to be in the list of branches anylonger) -- Jas http://phpdhcpadmin.sourceforge.net
Re: [PHP-DEV] Zend Optimizer+ Source Code now available
That's a good idea :) I'm also in On 13 February 2013 09:51, Zeev Suraski z...@zend.com wrote: As per Derick’s idea, we can arrange a webinar for those interested in better understanding how it works.
Re: [PHP-DEV] Zend Optimizer+ Source Code now available
On Wed, Feb 13, 2013 at 9:51 AM, Zeev Suraski z...@zend.com wrote: As per Derick’s idea, we can arrange a webinar for those interested in better understanding how it works. Note that this will not be a webinar for the faint of heart – opcode caches are complicated pieces of software; Attendees should have very good engine-development knowledge to have a good chance of understanding what’s going on… Stas – your help in that webinar would be very welcome J I'm interested in attending the webinar, as well, Zeev. Any general idea when it would be (e.g. - next week, March, sometime during the summer)? -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
[PHP-DEV] Github pull request management
Hi, with Felipe's help I've just added the second pull request management tool to mange pull requests. The first one is https://qa.php.net/pulls/ this allows any php.net developer to close pull requests on github, without us having to manage users on github and adding them to groups and all that stuff. I guess most of you have seen that. The new one is a simple integration of pull requests to the bug tracker. Similar to the patch feature of the bug tracker it is meant to link pull requests from bugs so one can easily use a quick search to find all bugs with code waiting for a review and having php.net users assigned to pull requests. Search for recent bugs with patch or pull request: https://bugs.php.net/search.php?boolean=0limit=30order_by=iddirection=DESCcmd=displaystatus=Openbug_age=0bug_updated=0bug_type=Allpatch=Ypull=Y Search for recent bugs with pull requests only: https://bugs.php.net/search.php?boolean=0limit=30order_by=iddirection=DESCcmd=displaystatus=Openbug_age=0bug_updated=0bug_type=Allpull=Y This is a relatively quick hack with room for improvement, some ideas anybody can pick up (I'm happy to give a hand where needed): - Add functionality from qa.php.net/pull for closing pull requests - Add a note to github when a bug is assigned to a pull request - Show more details about the pull request - Improve the usability - Improve the code - ... Happy bug fixing! johannes -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
[PHP-DEV] Regarding BC bugs fixes and XKCD
I'm sure many, if not all of you have seen this already. http://xkcd.com/1172/ It sounds awfully familiar to PHP Internal's attitude toward BC considerations for bug fixes, and perhaps offers some (albeit humorous) insight into why some things just need to be fixed.
Re: [PHP-DEV] Github pull request management
On Wed, Feb 13, 2013 at 11:03 AM, Johannes Schlüter johan...@schlueters.dewrote: Hi, with Felipe's help I've just added the second pull request management tool to mange pull requests. The first one is https://qa.php.net/pulls/ this allows any php.net developer to close pull requests on github, without us having to manage users on github and adding them to groups and all that stuff. I guess most of you have seen that. The new one is a simple integration of pull requests to the bug tracker. Similar to the patch feature of the bug tracker it is meant to link pull requests from bugs so one can easily use a quick search to find all bugs with code waiting for a review and having php.net users assigned to pull requests. Search for recent bugs with patch or pull request: https://bugs.php.net/search.php?boolean=0limit=30order_by=iddirection=DESCcmd=displaystatus=Openbug_age=0bug_updated=0bug_type=Allpatch=Ypull=Y Search for recent bugs with pull requests only: https://bugs.php.net/search.php?boolean=0limit=30order_by=iddirection=DESCcmd=displaystatus=Openbug_age=0bug_updated=0bug_type=Allpull=Y This is a relatively quick hack with room for improvement, some ideas anybody can pick up (I'm happy to give a hand where needed): - Add functionality from qa.php.net/pull for closing pull requests - Add a note to github when a bug is assigned to a pull request - Show more details about the pull request - Improve the usability - Improve the code - ... Happy bug fixing! johannes -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php Excellent stuff! I like the idea of having bugs linked to github. Most often I find a great disconnect between the bugs and github so that idea strikes me as very convenient since knowing someone is assigned in both places alleviates the need to go hunting.
Re: [PHP-DEV] Regarding BC bugs fixes and XKCD
On Wed, Feb 13, 2013 at 11:04 AM, Aaron Holmes aa...@aaronholmes.netwrote: I'm sure many, if not all of you have seen this already. http://xkcd.com/1172/ It sounds awfully familiar to PHP Internal's attitude toward BC considerations for bug fixes, and perhaps offers some (albeit humorous) insight into why some things just need to be fixed. That's an excellent attitude! I'm all for fixing broken stuff. Now if only we can find more people that actually fix stuff and less people that have time to post xkcd comics? --- Sherif, The always happy, never grumpy guy...
Re: [PHP-DEV] Regarding BC bugs fixes and XKCD
... As the number of people who might do so decrements thanks to the attitude of the person wishing for it. On Wed, Feb 13, 2013 at 11:18 AM, Sherif Ramadan theanomaly...@gmail.com wrote: On Wed, Feb 13, 2013 at 11:04 AM, Aaron Holmes aa...@aaronholmes.netwrote: I'm sure many, if not all of you have seen this already. http://xkcd.com/1172/ It sounds awfully familiar to PHP Internal's attitude toward BC considerations for bug fixes, and perhaps offers some (albeit humorous) insight into why some things just need to be fixed. That's an excellent attitude! I'm all for fixing broken stuff. Now if only we can find more people that actually fix stuff and less people that have time to post xkcd comics? --- Sherif, The always happy, never grumpy guy... -- Tom Boutell P'unk Avenue 215 755 1330 punkave.com window.punkave.com -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Status of pull request
Hi Jason, thanks for the reminder. Am 13.02.2013 um 14:03 schrieb Jason Gerfen jason.ger...@gmail.com: Is it considered spamming the list to check the status of a pull request? I am going to ask any ways, hope it doesn't offend. The pull request addresses bug fix/feature request #38917 implementing native signed public key challenge support to the OpenSSL extension. Details can be found @ https://github.com/php/php-src/pull/267 (I created a new branch 'issue-38917-spkac' according to the Wiki, but does not seem to be in the list of branches anylonger) I'm personally don't feel comfortable enough to mess around in ext/openssl. Could somebody else please have a look? cu, Lars -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Status of pull request
Thanks! It simply implements native support for creating, parsing exporting details of SPKAC strings sent from browsers using the HTML5 KeyGen element (even though the element has been around since Netscape 1 or 2). On Wed, Feb 13, 2013 at 10:34 AM, Lars Strojny l...@strojny.net wrote: Hi Jason, thanks for the reminder. Am 13.02.2013 um 14:03 schrieb Jason Gerfen jason.ger...@gmail.com: Is it considered spamming the list to check the status of a pull request? I am going to ask any ways, hope it doesn't offend. The pull request addresses bug fix/feature request #38917 implementing native signed public key challenge support to the OpenSSL extension. Details can be found @ https://github.com/php/php-src/pull/267 (I created a new branch 'issue-38917-spkac' according to the Wiki, but does not seem to be in the list of branches anylonger) I'm personally don't feel comfortable enough to mess around in ext/openssl. Could somebody else please have a look? cu, Lars -- Jason Gerfen jason.ger...@gmail.com http://www.github.com/jas- http://dev.in-my-cloud.com/pow-mia http://in-my-cloud.com http://awesomealaskaadventures.com http://phpdhcpadmin.sourceforge.net
Re: [PHP-DEV] Github pull request management
Hi Johannes, quick question: does it automatically open bug reports for each PR? Am 13.02.2013 um 17:03 schrieb Johannes Schlüter johan...@schlueters.de: Hi, with Felipe's help I've just added the second pull request management tool to mange pull requests. The first one is https://qa.php.net/pulls/ this allows any php.net developer to close pull requests on github, without us having to manage users on github and adding them to groups and all that stuff. I guess most of you have seen that. The new one is a simple integration of pull requests to the bug tracker. Similar to the patch feature of the bug tracker it is meant to link pull requests from bugs so one can easily use a quick search to find all bugs with code waiting for a review and having php.net users assigned to pull requests. Search for recent bugs with patch or pull request: https://bugs.php.net/search.php?boolean=0limit=30order_by=iddirection=DESCcmd=displaystatus=Openbug_age=0bug_updated=0bug_type=Allpatch=Ypull=Y Search for recent bugs with pull requests only: https://bugs.php.net/search.php?boolean=0limit=30order_by=iddirection=DESCcmd=displaystatus=Openbug_age=0bug_updated=0bug_type=Allpull=Y This is a relatively quick hack with room for improvement, some ideas anybody can pick up (I'm happy to give a hand where needed): - Add functionality from qa.php.net/pull for closing pull requests - Add a note to github when a bug is assigned to a pull request - Show more details about the pull request - Improve the usability - Improve the code - ... Happy bug fixing! johannes -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Zend Optimizer+ Source Code now available
Le 13/02/2013 15:51, Zeev Suraski a écrit : https://github.com/zend-dev/ZendOptimizerPlus/ Great News ! Do you know if any control panel (like the one provided with APC) already exists ? I notice accelerator_reset, accelerator_get_configuration and accelerator_get_status functions, so should be possible. Regards, Remi. P.S. RPM already available in my repo for Fedora / RHEL / CentOS users of php 5.4 and Fedora users of php 5.5. -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
[PHP-DEV] libxml bit field
Hey all, In commit http://git.php.net/?p=php-src.git;a=commitdiff;h=afe98b78 I just noticed two instances of the following: ctxt-options -= XML_PARSE_DTDLOAD; Shouldn't that be ctxt-options = ~XML_PARSE_DTDLOAD; or am I missing something? -- Ard. -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] libxml bit field
Yeah. Bit reset is better. I'll update it. Thanks. Dmitry. On Wed, Feb 13, 2013 at 9:51 PM, Ard Biesheuvel ard.biesheu...@linaro.orgwrote: Hey all, In commit http://git.php.net/?p=php-src.git;a=commitdiff;h=afe98b78 I just noticed two instances of the following: ctxt-options -= XML_PARSE_DTDLOAD; Shouldn't that be ctxt-options = ~XML_PARSE_DTDLOAD; or am I missing something? -- Ard. -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Github pull request management
On Wed, 2013-02-13 at 18:37 +0100, Lars Strojny wrote: Hi Johannes, quick question: does it automatically open bug reports for each PR? No, for two reasons: A. Github provides no good notification mechanism for that, we'd have to pull periodically and match it and so on B. Many requests are written after bugs were opened, if it would open bugs automatically we'd have quite a few duplicates and discussion in three places (initial analysis on initial report, review discussion at github, final discussion at the new bug) All this feature currently does is providing a structured (relational database model, yay) way to link from a bug report to github. I'm happy about any improvements being done, though (part of pushing this is my hope to motivate some people to think about possibilities and add better things) johannes -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] clearing up who can propose RFCs
On 01/29/2013 06:10 AM, Ferenc Kovacs wrote: On Fri, Sep 14, 2012 at 12:47 PM, Pierre Joye pierre@gmail.com wrote: hi Ferenc, Can you put that in the wiki too instead? So it can be clarified there directly if necessary. Thanks, I've put it up under https://wiki.php.net/rfc/howto feel free to extend or improve the wording/formatting. I blogged about how I have seen the RFC process working in practice: https://blogs.oracle.com/opal/entry/the_mysterious_php_rfc_process Flame away, Chris -- christopher.jo...@oracle.com http://twitter.com/ghrd Newly updated, free PHP Oracle book: http://www.oracle.com/technetwork/topics/php/underground-php-oracle-manual-098250.html -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Zend Optimizer+ Source Code now available
Hi, I tried to install the ZendOptimizer+ provided earlier today but wasn't able to make it work. I compiled it with success but when I looked at the phpinfo(); I had this : Opcode Caching Disabled Optimization Enabled Startup Failed no value I'm using the apache2handler (MPM Worker - multi-threaded), PHP Version 5.4.13-dev. Here's my configure : './configure' '--enable-debug' '--enable-bcmath' '--enable-calendar' '--enable-gd-native-ttf' '--enable-maintainer-zts' '--enable-mbstring' '--enable-soap' '--enable-sockets' '--enable-sysvsem' '--enable-sysvshm' '--enable-zip' '--with-apxs2=/usr/bin/apxs2' '--with-config-file-path=/etc/php5/PHP-5.4' '--with-config-file-scan-dir=/etc/php5/PHP-5.4/conf.d' '--with-curl' '--with-freetype-dir=/usr/lib' '--with-gd' '--with-jpeg-dir' '--with-kerberos' '--with-mcrypt' '--with-mysql-sock=/var/run/mysqld/mysqld.sock' '--with-mysql=mysqlnd' '--with-mysqli=mysqlnd' '--with-openssl' '--with-pdo-mysql=mysqlnd' '--with-png-dir' '--with-readline' '--with-xsl' '--with-zlib-dir' I only added the zend_extension line in my php.ini file. I tried to look at the log but did not found anything that could explain why the Startup Failed. I looked a little bit at the code and the accel_startup worked as expected at the apache start and ZCG(startup_ok) was equal to 1 at the end of it. I'm suspecting that my problem is related to the fact that I'm using a multi-threaded environment. Could it be because the startup_ok variable is in the zend_accel_globals structure and not in the zend_accel_shared_globals ? And that a new zend_accel_globals is created for my request where the startup_ok is not 1 ? If you have any idea of anything I could have done wrong please let me know. Also if you need more informations just ask and I'll try to provide them to you. Thanks for the help ! Pierrick On 13 February 2013 09:51, Zeev Suraski z...@zend.com wrote: For your browsing pleasure: https://github.com/zend-dev/ZendOptimizerPlus/ An initial README with some instructions is available at http://bit.ly/VSs5KC We’ve put it under the PHP license, with the same PHP Group copyright header as all files in PHP. As per Derick’s idea, we can arrange a webinar for those interested in better understanding how it works. Note that this will not be a webinar for the faint of heart – opcode caches are complicated pieces of software; Attendees should have very good engine-development knowledge to have a good chance of understanding what’s going on… Stas – your help in that webinar would be very welcome J Zeev
Re: [PHP-DEV] clearing up who can propose RFCs
Hi! I blogged about how I have seen the RFC process working in practice: https://blogs.oracle.com/opal/entry/the_mysterious_php_rfc_process Great article, thanks for writing it! -- Stanislav Malyshev, Software Architect SugarCRM: http://www.sugarcrm.com/ (408)454-6900 ext. 227 -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Zend Optimizer+ Source Code now available
hi, On Wed, Feb 13, 2013 at 3:51 PM, Zeev Suraski z...@zend.com wrote: For those willing to play with it on Windows, here are the bins for 5.5/VC11 https://twitter.com/PierreJoye/status/301946818835652608 5.3/5.4/5.5 VC9 are coming. Cheers, -- Pierre @pierrejoye -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Zend Optimizer+ Source Code now available
Hi Pierrick, We didn't use ZTS in Zend commercial products, so it wasn't tested for a long time. O+ may definitely have some ZTS related problems. Please, report an issue at https://github.com/zend-dev/ZendOptimizerPlus/issues I'll look into it later Thanks. Dmitry. On Thu, Feb 14, 2013 at 1:42 AM, Pierrick Charron pierr...@webstart.frwrote: Hi, I tried to install the ZendOptimizer+ provided earlier today but wasn't able to make it work. I compiled it with success but when I looked at the phpinfo(); I had this : Opcode Caching Disabled Optimization Enabled Startup Failed no value I'm using the apache2handler (MPM Worker - multi-threaded), PHP Version 5.4.13-dev. Here's my configure : './configure' '--enable-debug' '--enable-bcmath' '--enable-calendar' '--enable-gd-native-ttf' '--enable-maintainer-zts' '--enable-mbstring' '--enable-soap' '--enable-sockets' '--enable-sysvsem' '--enable-sysvshm' '--enable-zip' '--with-apxs2=/usr/bin/apxs2' '--with-config-file-path=/etc/php5/PHP-5.4' '--with-config-file-scan-dir=/etc/php5/PHP-5.4/conf.d' '--with-curl' '--with-freetype-dir=/usr/lib' '--with-gd' '--with-jpeg-dir' '--with-kerberos' '--with-mcrypt' '--with-mysql-sock=/var/run/mysqld/mysqld.sock' '--with-mysql=mysqlnd' '--with-mysqli=mysqlnd' '--with-openssl' '--with-pdo-mysql=mysqlnd' '--with-png-dir' '--with-readline' '--with-xsl' '--with-zlib-dir' I only added the zend_extension line in my php.ini file. I tried to look at the log but did not found anything that could explain why the Startup Failed. I looked a little bit at the code and the accel_startup worked as expected at the apache start and ZCG(startup_ok) was equal to 1 at the end of it. I'm suspecting that my problem is related to the fact that I'm using a multi-threaded environment. Could it be because the startup_ok variable is in the zend_accel_globals structure and not in the zend_accel_shared_globals ? And that a new zend_accel_globals is created for my request where the startup_ok is not 1 ? If you have any idea of anything I could have done wrong please let me know. Also if you need more informations just ask and I'll try to provide them to you. Thanks for the help ! Pierrick On 13 February 2013 09:51, Zeev Suraski z...@zend.com wrote: For your browsing pleasure: https://github.com/zend-dev/ZendOptimizerPlus/ An initial README with some instructions is available at http://bit.ly/VSs5KC We’ve put it under the PHP license, with the same PHP Group copyright header as all files in PHP. As per Derick’s idea, we can arrange a webinar for those interested in better understanding how it works. Note that this will not be a webinar for the faint of heart – opcode caches are complicated pieces of software; Attendees should have very good engine-development knowledge to have a good chance of understanding what’s going on… Stas – your help in that webinar would be very welcome J Zeev
