Re: [PHP-DEV] [RFC] Importing namespaced functions
On 20 August 2013 23:29, Igor Wiedler i...@wiedler.ch wrote: Hi Stas, Thanks for the notes. I will address these issues, hopefully during the next few days. Nay news on that? -- Regards, Mike -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] 5.4 RecursiveDirectoryIterator
Hello, Two things could be done IMO: - revert this change from 5.4 - mention it in the Upgrade Guide 5.3 - 5.4 that was a bug, that if you didn't pass SKIP_DOTS , dots should no be skipped. and this bug is also fixed in 5.3 branch. thanks Yeah i understand that it was a bug, but the bugfix was a BC break (even if small) Maybe just mention it somewhere shortly: Upgrade guide or doc of __construct() Best regards
Re: [PHP-DEV] [RFC] Importing namespaced functions
Hi, I just looked into the first issue you mentioned. The following does not produce a warning either currently: use bar as bar; As such, I would say that it would be inconsistent to produce a warning for functions. Do you agree? Regards, Igor On Aug 19, 2013, at 3:32 AM, Stas Malyshev smalys...@sugarcrm.com wrote: Hi! RFC: https://wiki.php.net/rfc/use_function Patch: https://github.com/php/php-src/pull/388 Looking at the patch: 1. use function bar as bar; does not produce any warning -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] [RFC] Importing namespaced functions
Hi! use bar as bar; Hmm... they probably should both produce a notice. But if it's hard to do, then ok to do the same thing as class does. -- Stanislav Malyshev, Software Architect SugarCRM: http://www.sugarcrm.com/ (408)454-6900 ext. 227 -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
[PHP-DEV] Pull requests report (21/8/2013)
(reporting about two weeks) Merged requests (past 7 days): #359 https://github.com/php/php-src/issues/359 PHPTests for the DOMDocument::load and DOMDocument::loadXML #360 https://github.com/php/php-src/pull/360 Bug44168 #381 https://github.com/php/php-src/issues/381 Fixed #65225: PHP_BINARY incorrectly set #395 https://github.com/php/php-src/issues/395 typofixes - code related #402 https://github.com/php/php-src/issues/402 make the bison version check a blacklist #403 https://github.com/php/php-src/issues/403 Fix #61345: fix install of CGI binary #404 https://github.com/php/php-src/issues/404 php.ini-development/production: remove php_zip.dll #405 https://github.com/php/php-src/issues/405 Fixbug: phpize --clean will delete include/*.h #410 https://github.com/php/php-src/pull/410 Fix for php bug #64802 #411 https://github.com/php/php-src/issues/411 Use pkg-config to detect iodbc #412 https://github.com/php/php-src/issues/412 Create test to the extension xmlrpc, encode array and int. Closed requests (without merge): #325 https://github.com/php/php-src/issues/325 Add schema default/fixed value support in DOM (merged in April, closed now). #329 https://github.com/php/php-src/issues/329 Allow major versions of bison (done as part of #402). New: #406 https://github.com/php/php-src/pull/406 OnEnable INI MH for opcache causing strangeness #413 https://github.com/php/php-src/pull/413 Make exception messages and error output binary safe #414 https://github.com/php/php-src/pull/414 Fix #65483: quoted-printable encode stream filter incorrectly encoding #415 https://github.com/php/php-src/pull/415 Remove duplicate calls to set filename lineno for the DTRACE_FUNCTION_ENTRY/RETURN cases #416 https://github.com/php/php-src/pull/416 New function: pcntl_daemonize pcntl_setaffinity Kaplan p.s. For those of you who want some perspective on merges done in the last month: http://liorkaplan.wordpress.com/2013/08/11/getting-patches-into-php-take-two/ On Wed, Aug 7, 2013 at 10:15 AM, Lior Kaplan lio...@zend.com wrote: Merged requests (past 7 days): #214 https://github.com/php/php-src/pull/214 First fixes for a 64bit compatible ftp extension #394 https://github.com/php/php-src/issues/394 typofixes - non living code related typo fixes #399 https://github.com/php/php-src/pull/399 Constify streams API and a few other calls down the rabbit hole. #401 https://github.com/php/php-src/pull/401 Php 5.5 strict session collision detection Thanks Stas (: Closed requests (without merge): #199 https://github.com/php/php-src/pull/199 Bug #62479 Fix bug where spaces in passwords would fail #368 https://github.com/php/php-src/issues/368 Php 5.5 strict session collision detection (in favor of #401) #400 https://github.com/php/php-src/pull/400 Bug44164 New and still open requests (past 7 days): None - everything from this week was either merged or closed - well done (: existing requests (7-21 days): #388 https://github.com/php/php-src/pull/388 Add new 'use function' sequence for importing namespaced functions #390 https://github.com/php/php-src/pull/390 Add DateInterval::add method #393 https://github.com/php/php-src/pull/393 Fix #60873: Add read_property handler for DateTime object #395 https://github.com/php/php-src/pull/395 typofixes - code related #397 https://github.com/php/php-src/pull/397 New handler for retrieving properties when object is serialized #398 https://github.com/php/php-src/pull/398 Fix #65069: GlobIterator fails to access files inside an open_basedir restricted dir Kaplan