Re: [PHP-DEV] RFC [Discussion] array_column results grouping

2021-12-05 Thread Rowan Tommins

On 05/12/2021 10:41, Mark Randall wrote:

On 04/12/2021 14:21, Marco Pivetta wrote:
Gonna vote `no` on this: please design new/dedicated functions, 
rather than

expanding optional parameters.



I would vote no for the same reason.



Since this is explicitly an open question in the current RFC draft, it 
seems a bit premature to talk about voting, rather than encouraging the 
RFC to develop in a particular direction.


For what it's worth, I agree that a new function is probably better 
here, because the argument list of array_column is already quite 
complicated. A new function also leaves the way open to add more 
functionality, such as the "reducer" callback suggested by Hendra 
Gunawan; I don't think that's needed in the first implementation, though.


In general, I like the proposal - like array_column itself, it's one of 
those things that's fairly _simple_ to do in userland, but also fairly 
_often_ done, so compacting it to a neat function call seems useful.


Regards,

--
Rowan Tommins
[IMSoP]

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: https://www.php.net/unsub.php



Re: [PHP-DEV] Fork microsoft/php-sdk-binary-tools to PHP org on GH

2021-12-05 Thread Christoph M. Becker
On 01.12.2021 at 16:58, Pierre Joye wrote:

> On Wed, Dec 1, 2021, 5:48 PM Christoph M. Becker  wrote:
>
>> since Microsoft won't support PHP 8 and beyond, it appears to be
>> reasonable to fork the microsoft/php-sdk-binary-tools[1] to the PHP org
>> account on Github.  The PHP-SDK is required to build PHP on Windows[2],
>> and at least some adaptions to newer PHP versions need to be done[3],
>> and there is a PR for building for arm64[4], which may be rejected by
>> Microsoft.
>>
>> Thoughts?  Objections?
>
> yes please.

I have forked to php/php-sdk-binary-tools, and GH support has detached
the fork, so this is now a standalone repo.  I have also updated the
AppVeyor build script and the PECL build machine to use that repo now.

> And get ride of the CLA while being  at it.

Nothing to do there.  This is apparently specific to MSFT repos on Github.

Christoph

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: https://www.php.net/unsub.php



Re: [PHP-DEV] RFC [Discussion] array_column results grouping

2021-12-05 Thread Mark Randall

On 04/12/2021 14:21, Marco Pivetta wrote:

Gonna vote `no` on this: please design new/dedicated functions, rather than
expanding optional parameters.



I would vote no for the same reason.

Mark Randall

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: https://www.php.net/unsub.php