[PHP-DEV][RFC] Multibyte for ucfirst function

2024-01-15 Thread youkidearitai
Hi, Internals

I have been create an RFC: https://wiki.php.net/rfc/mb_ucfirst
Please feel free comment.

Regards
Yuya


-- 
---
Yuya Hamada (tekimen)
- https://tekitoh-memdhoi.info
- https://github.com/youkidearitai
-

-- 
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: https://www.php.net/unsub.php



Re: [PHP-DEV] Multibyte for ucfirst function

2024-01-15 Thread youkidearitai
Hi, Internals

I'm try creating a new RFC that add mb_ucfirst and mb_lcfirst functions.
Draft is here: 
https://github.com/php/php-src/issues/13075#issuecomment-1893012382
If any wrong, please feel free comment.

Cheers
Yuya

-- 
---
Yuya Hamada (tekimen)
- https://tekitoh-memdhoi.info
- https://github.com/youkidearitai
-

-- 
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: https://www.php.net/unsub.php



Re: [PHP-DEV] [VOTE] [RFC] Final-by-default anonymous classes

2024-01-15 Thread Ilija Tovilo
Hi Daniil

On Mon, Jan 15, 2024 at 11:36 AM Daniil Gentili
 wrote:
>
> Hi all,
>
> I've opened voting for the final-by-default anonymous classes RFC:
> https://wiki.php.net/rfc/final_by_default_anonymous_classes

It seems you've edited the text of the poll. Doing so disassociates
the existing votes from the poll, so the existing votes were gone. I
reverted the change, the votes are now back.

Ilija

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: https://www.php.net/unsub.php



Re: [PHP-DEV] [VOTE] [RFC] Final-by-default anonymous classes

2024-01-15 Thread Nuno Maduro
On Mon, 15 Jan 2024 at 10:36, Daniil Gentili 
wrote:

> Hi all,
>
> I've opened voting for the final-by-default anonymous classes RFC:
> https://wiki.php.net/rfc/final_by_default_anonymous_classes
>
> Regards,
>
> Daniil Gentili.
>

Hi Daniil,

Thank you for your work on this RFC. In my opinion, this RFC should not
move forward for consistency reasons. If regular class definitions are
non-final by default, anonymous classes should be non-final too.

In addition, it would be a breaking change with very little benefit - like
a small optimization in the op-cache.


[PHP-DEV] Re: VCS Account Request: saki

2024-01-15 Thread PHP Group
VCS Account Approved: saki approved by derick \o/

-- 
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: https://www.php.net/unsub.php



[PHP-DEV] VCS Account Request: saki

2024-01-15 Thread Saki Takamachi
Perform PHP maintenance.

-- 
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: https://www.php.net/unsub.php



[PHP-DEV] Re: VCS Account Request: shivam

2024-01-15 Thread PHP Group
VCS Account Approved: shivam approved by derick \o/

-- 
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: https://www.php.net/unsub.php



[PHP-DEV] VCS Account Request: shivam

2024-01-15 Thread Shivam Mathur
Maintaining infrastructure for the PHP project.

-- 
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: https://www.php.net/unsub.php



Re: [PHP-DEV] [VOTE] [RFC] Final-by-default anonymous classes

2024-01-15 Thread Sebastian Bergmann

Am 15.01.2024 um 11:35 schrieb Daniil Gentili:
I've opened voting for the final-by-default anonymous classes RFC: 
https://wiki.php.net/rfc/final_by_default_anonymous_classes


I am confused by the voting option "Make final anonymous classes final by 
default".


You mean "Make anonymous classes final by default", right?

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: https://www.php.net/unsub.php



Re: [PHP-DEV] [RFC] [Discussion] nameof

2024-01-15 Thread Bob Weinand

> Am 14.01.2024 um 23:58 schrieb Robert Landers :
> 
> Hello Internals,
> 
> After much thought and deliberation, I've updated the nameof RFC
> (https://wiki.php.net/rfc/nameof) to reflect most of this discussion
> and refine a few edge cases regarding objects. TL;DR: there are a few
> rules regarding how properties of objects are addressed that I hope a
> few people will like (and would make it much more usable in static
> contexts, like attributes).
> 
> I'm still not fully settled on the syntax, and this is still very much
> a work in progress. So, I'd love feedback in that regard.
> 
> Robert Landers
> Software Engineer
> Utrecht NL

Hey Robert,

In line with ::class, nameof() should never prepend a leading slash.

The leading slash is a compile time concept to distinguish namespace relative 
and global addressing. At runtime everything has a canonical name, without 
leading slash.

Also prepending a slash in code, i.e. '\\'. is much easier than substr(..., 1) 
to remove, if needed.

On the name resolution of things which have a visibility, I wonder whether the 
visibility is checked or not? In e.g. C# it is.

Also, the RFC says a warning will be emitted during compilation. I assume it 
should be rather be the first time the given line is executed at runtime as PHP 
doesn't necessarily have access to all identifiers yet when the code is 
compiled (e.g. referencing something which is included at runtime).
Similarly, how often is static:: checked? On every access? Thanks to late 
static binding it may sometimes exist and sometimes not.

I think parent:: is missing in the list of left-hand allowed exceptions.

Thanks,
Bob
-- 
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: https://www.php.net/unsub.php



Re: [PHP-DEV] [VOTE] [RFC] Final-by-default anonymous classes

2024-01-15 Thread Bob Weinand

> Am 15.01.2024 um 11:57 schrieb Nicolas Grekas :
> 
> Hi Daniil,
> 
> I've opened voting for the final-by-default anonymous classes RFC:
>> https://wiki.php.net/rfc/final_by_default_anonymous_classes
>> 
> 
> I voted against the proposal because as I mentioned in the previous thread
> on the same topic, this is a backward compatibility break that lacks ground
> but will have impact.
> 
> Note that I voted even though I think the vote itself might be "illegal"
> per our policies (neither did 6 months pass, nor does the proposal make
> substantial changes to the previous one, to some definition of
> "substantial"). If the vote itself isn't allowed per this policy, then my
> vote is void of course.
> https://wiki.php.net/rfc/voting#resurrecting_rejected_proposals
> 
> Sorry for being a bit legalist on the topic but principles matter. We have
> policies and this vote is on the edge of two of them. That's a red flag for
> me.
> 
> Nicolas

Hey Nicolas,

I think having a radically different approach to this definitely qualifies as 
substantial.

The previous RFC made final opt-in. This RFC proposes final by default and an 
opt-out, which is something a lot of voters suggested.

Feel free to disagree, though I see here no grounds for disqualifying. This 
rule is here to not have repeated votes with cosmetic changes, to force a vote 
through.

Bob

Re: [PHP-DEV] [VOTE] [RFC] Final-by-default anonymous classes

2024-01-15 Thread Nicolas Grekas
Hi Daniil,

I've opened voting for the final-by-default anonymous classes RFC:
> https://wiki.php.net/rfc/final_by_default_anonymous_classes
>

I voted against the proposal because as I mentioned in the previous thread
on the same topic, this is a backward compatibility break that lacks ground
but will have impact.

Note that I voted even though I think the vote itself might be "illegal"
per our policies (neither did 6 months pass, nor does the proposal make
substantial changes to the previous one, to some definition of
"substantial"). If the vote itself isn't allowed per this policy, then my
vote is void of course.
https://wiki.php.net/rfc/voting#resurrecting_rejected_proposals

Sorry for being a bit legalist on the topic but principles matter. We have
policies and this vote is on the edge of two of them. That's a red flag for
me.

Nicolas


[PHP-DEV] [VOTE] [RFC] Final-by-default anonymous classes

2024-01-15 Thread Daniil Gentili

Hi all,

I've opened voting for the final-by-default anonymous classes RFC: 
https://wiki.php.net/rfc/final_by_default_anonymous_classes


Regards,

Daniil Gentili.