[PHP-DEV] Re: Issuing CVEs for PHP

[Lior Kaplan]

On Mon, Apr 29, 2019 at 6:51 AM Stanislav Malyshev 
wrote:

> Hi!
>
> I have set up PHP as CNA (CVE Identifiers authority) with MITRE. That
> means that we will be assigning our own CVEs from now on. The process in
> broad strokes works like this:
>
> 1. We request a block of numbers
> 2. When we have security bug, we use one of the numbers in the block
> 3. We create CVE descriptions and commit them to the cvelist repo
>
> Much more detailed documentation on how it is done is here:
> https://wiki.php.net/cve
>
> Me please (:

Re: [PHP-DEV] pdo_dblib pull requests

[Lior Kaplan]

Hi Adam,

First, thanks for contributing.

I think the best way would be to try and provide tests (part of the PR) and 
test environment for this change.

If the latter can't be provided, maybe instructions how to create one (as you 
guys probably have far more experience then us).

Kaplan


From: Adam Baratz 
Sent: Friday, February 5, 2016 8:04 PM
To: internals@lists.php.net
Subject: [PHP-DEV] pdo_dblib pull requests

Hi,

I work for the rare company that uses Linux PHP servers with MSSQL. We rely
quite a bit on this extension and have invested a little in some feature
improvements. I'd like to get them pushed upstream, but given the
relatively low usage of this extension, it seems like PRs easily get stuck
in limbo because of the difficulty in testing/verifying them (e.g.,
https://github.com/php/php-src/pull/1122). What process would people
recommend for sharing our work?

Thanks,
Adam
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-DEV] Re: compiling php 5.6.# fails with sun CC 12.3 sparc sol 10, no problem 5.5 or 5.3

[Lior Kaplan]

Please try the sources available from the website (e.g. 5.6.17), these are 
already have some files pre-generated.

Regradless, which versions of re2c/bison do you have on that system?

Kaplan


From: Ross, Christine 
Sent: Saturday, January 23, 2016 11:29 PM
To: internals@lists.php.net
Cc: christine.s.r...@gmail.com
Subject: [PHP-DEV] compiling php 5.6.# fails with sun CC 12.3 sparc sol 10, no 
problem 5.5 or 5.3

Hello.

It was suggested I email this to this address.  I hope someone can help. I had 
no problems compiling php 5.3.# and 5.5.# on Sparc solaris 10 with Sun CC 12.3, 
but 5.6.# fails with the error below. GCC works but my whole application and 
environment is built with Sun CC. This is where it fails. I even tried adding 
/usr/sfw to the paths but no change.  I have received responses from others 
with the same issue.
Any help would be appreciated.



Lots of white space character errors before it fails on line 70. I saw 
something about flex and re2c so I installed re2c, and it didn't help. I tried 
without opcache, no help.

"Zend/zend_language_scanner.l", line 66: warning: invalid white space character 
in directive
"Zend/zend_language_scanner.l", line 67: warning: invalid white space character 
in directive
"Zend/zend_language_scanner.l", line 68: warning: invalid white space character 
in directive
"Zend/zend_language_scanner.l", line 69: warning: invalid white space character 
in directive
"Zend/zend_language_scanner.l", line 70: warning: function prototype parameters 
must have types
"Zend/zend_language_scanner.l", line 70: warning: old-style declaration or 
incorrect type for: SCNG
"Zend/zend_language_scanner.l", line 70: cannot initialize function: SCNG
"Zend/zend_language_scanner.l", line 70: undefined symbol: x

#!/bin/sh
#
# Configure PHP
#
PATH=/usr/bin:/usr/local/bin:/usr/ccs/bin:/opt/SUNWspro/bin:/usr/sbin:/usr/dt/bin;
 export PATH
LD_LIBRARY_PATH=/lib:/usr/lib:/usr/local/lib:/usr/local/ssl/lib; export 
LD_LIBRARY_PATH
LD_RUN_PATH=/usr/local/ssl/lib:/usr/local/lib; export LD_RUN_PATH
#
env CC=cc CXX=CC \
../configure \
--with-apxs2=/usr/local/apache2/bin/apxs \
--with-mysql=mysqlnd \
--with-pear \
--with-libxml-dir=/usr \
--with-mysqli=mysqlnd \
--with-pdo-mysql=mysqlnd \
--enable-mbstring \
--with-curl \
--with-gd \
--with-jpeg-dir=/usr/lib \
--enable-soap \
--with-openssl=/usr/local/ssl \
--enable-zip \
--with-iconv=/opt/local \
--enable-opcache

#!/end
#

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] mcrypt extermination plan

[Lior Kaplan]

On Jan 7, 2016 6:59 PM, "Remi Collet"  wrote:
>
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA1
>
> Le 07/01/2016 17:54, Scott Arciszewski a écrit :
> > All,
> >
> > I propose the following timeline to give ext/mcrypt the viking
> > funeral it deserves:
> >
> > PHP 7.1 - all mcrypt functions raise E_DEPRECATED PHP 8.0 - remove
> > ext/mcrypt, only make it available through PECL
>
> Big +1.
>
> We need to solve this chicken and eggs issue.
> People use it because it exists.
> It still exists because people still use it.

Why not move it to pecl as part on 7.1 ?

Kaplan

Re: [PHP-DEV] Push Litespeed SAPI 6.9 to PHP 7.0.1

[Lior Kaplan]

On Thu, Dec 24, 2015 at 1:09 PM, Tom Sommer  wrote:

> On 2015-12-16 14:41, Tom Sommer wrote:
>
>> Hi
>>
>> I realise 7.0.1 is already out in RC1, but there is a bug in the
>> Litespeed 6.8 sapi which breaks php_flag and php_value. It's causing
>> our customers a lot of headaches.
>>
>> I see Litespeed 6.9 is already in master, but would it be possible to
>> get backported into 7.0.1?
>>
>> The fix is here:
>>
>> https://github.com/php/php-src/commit/5bcb7a7019a49c2f80eda7d2aa947efebeee0034#diff-e8087496f5a642ce83e5d655c08c6b3a
>> (I believe)
>>
>
> So noone is going to do anything about this? It's not in 7.0.2 either?


Hi Tom,

Please contact the original committer to understand why was it done in
master only.

George Wang 

He is the de-facto maintainer for the lightspeed sapi.

Kaplan

Re: [PHP-DEV] Push Litespeed SAPI 6.9 to PHP 7.0.1

[Lior Kaplan]

George,

Can you take a look at Tom's comment about this problem.

Thanks,

Kaplan

On Wed, Dec 16, 2015 at 3:51 PM, Lior Kaplan <lio...@zend.com> wrote:

> Hi Tom,
>
> The patch isn't even committed to the 7.0 branch, only exists on master.
>
> And also 7.0.1 is already tagged a few hours ago.
>
> So, do the change on 7.0 branch and it will be part of 7.0.2.
>
> Kaplan
>
> On Wed, Dec 16, 2015 at 3:41 PM, Tom Sommer <m...@tomsommer.dk> wrote:
>
>> Hi
>>
>> I realise 7.0.1 is already out in RC1, but there is a bug in the
>> Litespeed 6.8 sapi which breaks php_flag and php_value. It's causing our
>> customers a lot of headaches.
>>
>> I see Litespeed 6.9 is already in master, but would it be possible to get
>> backported into 7.0.1?
>>
>> The fix is here:
>> https://github.com/php/php-src/commit/5bcb7a7019a49c2f80eda7d2aa947efebeee0034#diff-e8087496f5a642ce83e5d655c08c6b3a
>> (I believe)
>>
>> Thanks
>> --
>> Tom Sommer
>>
>> --
>> PHP Internals - PHP Runtime Development Mailing List
>> To unsubscribe, visit: http://www.php.net/unsub.php
>>
>>
>

Re: [PHP-DEV] Push Litespeed SAPI 6.9 to PHP 7.0.1

[Lior Kaplan]

Hi Tom,

The patch isn't even committed to the 7.0 branch, only exists on master.

And also 7.0.1 is already tagged a few hours ago.

So, do the change on 7.0 branch and it will be part of 7.0.2.

Kaplan

On Wed, Dec 16, 2015 at 3:41 PM, Tom Sommer  wrote:

> Hi
>
> I realise 7.0.1 is already out in RC1, but there is a bug in the Litespeed
> 6.8 sapi which breaks php_flag and php_value. It's causing our customers a
> lot of headaches.
>
> I see Litespeed 6.9 is already in master, but would it be possible to get
> backported into 7.0.1?
>
> The fix is here:
> https://github.com/php/php-src/commit/5bcb7a7019a49c2f80eda7d2aa947efebeee0034#diff-e8087496f5a642ce83e5d655c08c6b3a
> (I believe)
>
> Thanks
> --
> Tom Sommer
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>

[PHP-DEV] Travis CI is failing

[Lior Kaplan]

Hi,

Travis CI reports show quite a lot of failures with recent commits to few
of the branches.
>From a quick look it fails due to tests and not due to compilation issues.

Please check the status of the build/tests after your commits:
https://travis-ci.org/php/php-src/branches

At the moment ext/session/tests/bug32330.phpt fails for 5.6, 7.0 and master.

Thanks,

Kaplan

Re: [PHP-DEV] PHP 5.6 life cycle

[Lior Kaplan]

Well, August 2015 has already passed.

I guess 5.6 will be extended till Dec 2016 and security support till Dec
2017.
But that's for the community to decide.

Kaplan

On Sun, Dec 6, 2015 at 2:14 PM, Jan Ehrhardt  wrote:

> See http://php.net/supported-versions.php
>
> Will PHP 5.6 go into 'security fixes only' on 28 Aug 2015 with a end of
> life on 28 Aug 2016? Or will we be postponing this a couple of months?
>
> BTW: An end-of-life in Dec 2016 will be in line wih the EOL of OpenSSL
> 1.0.1: "Version 1.0.1 will be supported until 2016-12-31."
> http://openssl.org/policies/releasestrat.html
> --
> Jan
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>

Re: [PHP-DEV] 7.1 release date ?

[Lior Kaplan]

A year is the general time frame. 5.6 was August 2014. But don't forget you
need to aim for 9 months due to feature freeze and such.

Thanks for contributing.

Kaplan
On Dec 5, 2015 3:09 PM, "François Laupretre"  wrote:

> Hi,
>
> It may seem an obvious or odd question but do we have an estimated
> timeline (or just a rough estimate of a release date) for 7.1, or will it
> be decided later, depending on proposed RFCs ?
>
> I am currently working on several features potentially targeting 7.1 and
> such information will be a great help to organize my work. Even an estimate
> of 'probably not before x months/years' will be useful.
>
> Thanks
>
> François
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>

Re: [PHP-DEV] PHP 7.0.0 final RTM delay

[Lior Kaplan]

They just released:

https://mta.openssl.org/pipermail/openssl-announce/2015-December/49.html

Kaplan

On Thu, Dec 3, 2015 at 5:10 PM, Andi Gutmans  wrote:

> Is there an update on the OpenSSL front...?
> Is this release of OpenSSL going to be binary compatible or just source
> compatible?
>

Re: [PHP-DEV] Re: Pear fetch script problem on PHP 7.0

[Lior Kaplan]

Hi,

Thanks Ferenc for checking.

trying to debug this, I've added "echo var_dump($argv);" in the begining of
the script, but now it segfault.

before:
sh-3.2# /php-7.0.0RC7/sapi/cli/php -n /php-7.0.0RC7/pear/fetch.php "
http://5.77.39.20/install-pear-nozlib.phar; pear/install-pear-nozlib.phar

Fatal error: Redefinition of parameter $argv in
/php-7.0.0RC7/pear/fetch.php on line 3
sh-3.2# /php-7.0.0RC7/sapi/cli/php -n -m
[PHP Modules]
Core
date
dom
filter
hash
iconv
json
libxml
mysqlnd
openssl
pcre
PDO
pdo_mysql
pdo_pgsql
pdo_sqlite
readline
Reflection
session
SimpleXML
SPL
sqlite3
standard
xml
xmlreader
xmlwriter
zlib

[Zend Modules]

after:

(gdb) r -n /php-7.0.0RC7/pear/fetch.php "
http://5.77.39.20/install-pear-nozlib.phar; pear/install-pear-nozlib.phar
Starting program: /php-7.0.0RC7/sapi/cli/php -n
/php-7.0.0RC7/pear/fetch.php "http://5.77.39.20/install-pear-nozlib.phar;
pear/install-pear-nozlib.phar
Reading symbols for shared libraries
++ done
Reading symbols for shared libraries  done

Program received signal EXC_BAD_ACCESS, Could not access memory.
Reason: KERN_INVALID_ADDRESS at address: 0x0010
zend_try_compile_cv (result=0x7fff5fbfe440, ast=0x103e6f100) at
zend_compile.c:2178
2178 if (zend_string_equals_literal(name, "this")) {
(gdb) bt
#0  zend_try_compile_cv (result=0x7fff5fbfe440, ast=0x103e6f100) at
zend_compile.c:2178
#1  0x0001002b7ff1 in zend_compile_simple_var [inlined] () at
/php-7.0.0RC7/Zend/zend_compile.c:2226
#2  0x0001002b7ff1 in zend_compile_var (result=0x7fff5fbfe440,
ast=0x103e6f100, type=0) at zend_compile.c:7219
#3  0x0001002bb46d in zend_compile_args (ast=0xf2f5,
fbc=0x103e6f100) at zend_compile.c:2722
#4  0x0001002b7e62 in zend_compile_call_common (result=0x7fff5fbfe648,
args_ast=0xf2f5, fbc=0x10232e050) at zend_compile.c:2810
#5  0x0001002ba8e5 in zend_compile_call (result=0x7fff5fbfe648,
ast=0x103e6f100, type=65523712) at zend_compile.c:3245
#6  0x0001002b7366 in zend_compile_expr (result=0x7fff5fbfe648,
ast=0x103e6f100) at zend_compile.c:7111
#7  0x0001002b428f in zend_compile_echo [inlined] () at
/php-7.0.0RC7/Zend/zend_compile.c:3616
#8  0x0001002b428f in zend_compile_stmt (ast=0x103e750d0) at
zend_compile.c:7007
#9  0x0001002b7990 in zend_compile_top_stmt (ast=0x103e750d0) at
zend_compile.c:6966
#10 0x0001002b797d in zend_compile_top_stmt (ast=0x103e750e0) at
zend_compile.c:6961
#11 0x0001002b797d in zend_compile_top_stmt (ast=0x103e770a8) at
zend_compile.c:6961
#12 0x00010029e6f2 in compile_file (file_handle=0x7fff5fbfe728,
type=65523712) at zend_language_scanner.l:607
#13 0x0001002cc4dc in zend_execute_scripts (type=8,
retval=0x7fff5fbfe990, file_count=1606412688) at zend.c:1422
#14 0x00010026a1a9 in php_execute_script (primary_file=0x7fff5fbff6d8)
at main.c:2471
#15 0x00010035dad4 in do_cli [inlined] () at
/php-7.0.0RC7/sapi/cli/php_cli.c:974
#16 0x00010035dad4 in main (argc=1606416352, argv=0x7fff5fbff7e0) at
php_cli.c:1345

(again, works fine on Linux)




Kaplan



On Sun, Nov 22, 2015 at 10:51 PM, Andrea Faulds <a...@ajf.me> wrote:

> Hi Lior,
>
> Lior Kaplan wrote:
>
>> Fatal error: Redefinition of parameter $argv in
>> /php-7.0.0RC7/pear/fetch.php on line 3
>> make: *** [install-pear] Error 255
>>
>
> This is a strange and rather concerning error message. If I look at the
> source code of /pear/fetch.php in php-src, line three looks like this:
>
> function usage($argv) {
>
> $argv here is only specified once in the parameter list, yet it produces
> an error. Now, presumably this is some sort of conflict with the global
> variable $argv. But that's a global, not a superglobal, so it really
> shouldn't cause an error here.
>
> This looks like it might be a serious PHP 7 bug.
>
> And yet I can't reproduce it by running pear/fetch.php. Is something weird
> going on here?
>
> Thanks.
>
> --
> Andrea Faulds
> http://ajf.me/
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>

[PHP-DEV] Pear fetch script problem on PHP 7.0

[Lior Kaplan]

Hi,

Trying to build PHP 7 RC7 on Darwin I get:

[activating module `php7' in /usr/local/zend/apache2/conf/httpd.conf]
Installing PHP CLI binary:/usr/local/zend/bin/
Installing PHP CLI man page:  /usr/local/zend/share/man/man1/
Installing phpdbg binary: /usr/local/zend/bin/
Installing phpdbg man page:   /usr/local/zend/share/man/man1/
Installing PHP CGI binary:/usr/local/zend/bin/
Installing PHP CGI man page:  /usr/local/zend/share/man/man1/
Installing build environment: /usr/local/zend/lib/php/build/
Installing header files:  /usr/local/zend/include/php/
Installing helper programs:   /usr/local/zend/bin/
  program: phpize
  program: php-config
Installing man pages: /usr/local/zend/share/man/man1/
  page: phpize.1
  page: php-config.1
Installing PEAR environment:  /usr/local/zend/share/pear/

Fatal error: Redefinition of parameter $argv in
/php-7.0.0RC7/pear/fetch.php on line 3
make: *** [install-pear] Error 255

Has anyone encounter this from pear/fetch.php ? I could build PHP 5.6.15 in
the same environment without a problem (and the file is the same in
5.6/7.0).

Kaplan

p.s.
Most Linux environments have wget/curl so they are used before that script
(part of the "make pear-install" target).

Re: [PHP-DEV] SQLite 3.9.X in PHP 7.0.0RC6?

[Lior Kaplan]

I think it's too soon to update to the 3.9 branch (let it get a little more
stable).

But if the RM ask for this change I'll be happy to do that.

Kaplan



On Wed, Oct 21, 2015 at 12:13 PM, Mark Tomlin  wrote:

> Will we see the bundled SQLite updated to the 3.9.x released in PHP
> 7.0.0RC6?
>
> --
> Thank you for your time,
> Mark 'Dygear' Tomlin;
>

Re: [PHP-DEV] mysqli_get_cache_stats() has vanished

[Lior Kaplan]

This might help:

https://github.com/php/php-src/commit/f9ad56eab9e0010231643d51a0e0038f99f2f94b

Kaplan

On Tue, Aug 25, 2015 at 2:25 PM, Christoph Becker cmbecke...@gmx.de wrote:

 Hi!

 Does anybody know what happened to mysqli_get_cache_stats()?
 Apparently, its implementation has vanished between two consecutive
 commits:
 
 https://github.com/php/php-src/blob/40fabf68edd5524b9ce0cda925d6c7888d8441c3/ext/mysqli/mysqli_nonapi.c
 ,
 
 https://github.com/php/php-src/blob/b6898195674a26bf6588c284a6a2616bbaaa908f/ext/mysqli/mysqli_nonapi.c
 .

 It seems that happened accidentally, as the respective forward
 declaration in mysqli_fe.h is still there, and the removal doesn't seem
 to be documented (neither in NEWS nor UPGRADING).

 I wonder what to do now, as the function never had a useful
 implementation.  Shall it be officially removed?

 See also the related bug reports https://bugs.php.net/bug.php?id=61838
 and https://bugs.php.net/bug.php?id=70352.

 --
 Christoph M. Becker

 --
 PHP Internals - PHP Runtime Development Mailing List
 To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-DEV] Introducing ChangeLog-7.php to the website

[Lior Kaplan]

Hi,

With the release of 7.0.0 beta 1 I think it's time we
introduce ChangeLog-7.php to the website.

Both ChangeLog-4.php and ChangeLog-5.php have started with the first Beta
of the major releases.

Any objections ?

Kaplan

Re: [PHP-DEV] Re: [PHP-CVS] com php-src: Remove T1Lib support (see #69698): NEWS UPGRADING ext/gd/config.m4 ext/gd/config.w32 ext/gd/gd.c ext/gd/php_gd.h

[Lior Kaplan]

Just my two cent for background: Debian / Ubuntu has decided to drop this
due to dead upstream and lack of maintenance.
So this seem also reasonable for us.

Kaplan

[PHP-DEV] Re: PHP-7.0.0 branch

[Lior Kaplan]

On Tue, Jun 9, 2015 at 4:29 PM, Ferenc Kovacs tyr...@php.net wrote:


 On Tue, Jun 9, 2015 at 3:23 PM, Lior Kaplan kaplanl...@gmail.com wrote:

 Hi Guys,

 A quick question - I saw PHP-7.0.0 branch, should it be PHP-7.0 branch
 (while master continues to 7.1).

 The PHP-7.0.0 should probably be for the RCs (while cherry picking from
 PHP-7.0 as needed). If we have this branch too soon, you'll have a lot of
 cherry picking to later later on.

 Kaplan


 hi,
 cc-ing the internals list for visibility:

 the current plan is to not create a PHP-7.0 branch is until PHP-5.4 is
 EOLed, so we don't burden the average contributors yet another branch to
 merge upwards when pushing a change.
 PHP-7.0.0 will be only used by the RMs to tag the alpha/beta/RC versions
 from.
 yes, this means that until 5.4 is eoled and the PHP-7.0 branch is created
 changes targeting 7.1 have to sit in a clone or in a pull request.


Thanks.

The 7.1 changes are less of a concern, I just thought of the RM need to
merge from master to PHP-7.0.0 for each release instead of just working on
master directly.
Just my 2 cents. Of course, it's your decision...

Kaplan

Re: [PHP-DEV] error git push - You have insufficient Karma for gtk-src.git!

[Lior Kaplan]

What about sending pull requests against https://github.com/php/php-gtk-src
 ?

Kaplan

On Sun, Jun 7, 2015 at 3:20 PM, Alexandre Pereira Bühler 
alexan...@simaoebuhler.com.br wrote:

 Desire to develop and update the source code of php-gtk
 (http://git.php.net/?p=php/gtk-src.git;a=summary0 but I can not perform
 a push. My karma only allows cloning.
 git returns error:
 remote: Welcome buhlerax
 remote: You have insufficient Karma!
 remote: I'm sorry, I cannot allow you to write to
 remote: php/gtk-src.git/README
 remote: Have a nice day.
 to g...@git.php.net:/php/gtk-src.git
 How do I have a karma in http://git.php.net/?p=php/gtk-src.git;a=summary
 allowing the creation of branch and perform push?
 My profile: https://people.php.net/user.php?username=buhlerax
 Tank you

 --
 Alexandre Pereira Bühler
 Linux User: 397.546

 Simão   Bühler Ltda (Infobrindes)
 http://www.simaoebuhler.com.br
 alexan...@simaoebuhler.com.br
 Telefone: (41) 3039-5428

 Infobrindes (Simão   Bühler Ltda)
 Brindes e material promocional.
 http://www.infobrindes.com.br
 ka...@infobrindes.com.br
 Telefone: (41) 3082-8667






 --
 PHP Internals - PHP Runtime Development Mailing List
 To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] libpcre 8.37 requires extra flags (at least on AIX)

[Lior Kaplan]

Hi,

It seems to be AIX only thing, as it builds fine for me for Linux/Darwin.

Any hints ?

Kaplan

On Wed, May 20, 2015 at 9:28 PM, Stanislav Malyshev smalys...@gmail.com
wrote:

 Hi!

  While building the PHP 5.6.9 (which has libpcre 8.37) it seems we're
  missing -lpthreads build flag (for cli SAPI), as this library upgrade
 added
  this requirement.
 
  The files requiring is pcrelib/sljit/sljitUtils.c
 
  5.5.25, which doesn't have this file, works fine without the flag.
 
  I think this requirement should be reflected in ext/pcre/config0.m4 (or
 is
  there something more relevant?)

 Hmm... I wonder why it needs pthreads or does it depend on some config.
 Is it on AIX only? Because for me it builds fine on both Linux and Darwin.
 I think if it's 8.37 missing sljitUtils.c is a bug.

 --
 Stas Malyshev
 smalys...@gmail.com

Re: [PHP-DEV] About merging Pull Request workflow

[Lior Kaplan]

Yep, is a real problem. We should keep the credit / commit info.

I think we should remove --no-ff so it would just add the relevant
commits instead of actually merging them
without history (or even rebase the pull request to recent branch before
merging).

Kaplan



On Thu, May 21, 2015 at 10:16 AM, Remi Collet r...@fedoraproject.org
wrote:

 -BEGIN PGP SIGNED MESSAGE-
 Hash: SHA1

 Hi,


 Current workflow described in
 https://wiki.php.net/vcs/gitworkflow#merge_a_pull_request

 Problem, git history only give info about a merge

 Ex, after merging 1278:


 http://git.php.net/?p=php-src.git;a=commit;h=eef762d576e7744d6e0c8d6a3f997fe911b2dc34

 Another simple workflow could be

 1/ Download the patch
 https://github.com/php/php-src/pull/1278.patch

 2/ apply it
 git am 1278.patch

 3/ close the PR from
 https://qa.php.net/pulls

 This preserve credits to the authors and give a better history.

 What do you think ?


 Remi
 -BEGIN PGP SIGNATURE-
 Version: GnuPG v2
 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

 iEYEARECAAYFAlVdhk8ACgkQYUppBSnxahhKuACfbXzDxPsZJTyfwLtyoTALPVhs
 dbUAn2kk9vlD//ZQvea5Me1KU2JMgjdQ
 =1Xi5
 -END PGP SIGNATURE-

 --
 PHP Internals - PHP Runtime Development Mailing List
 To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-DEV] pcrelib version differs between 5.5.25 / 5.6.9

[Lior Kaplan]

Hi,

1. Just noticed that 5.5.25 has pcrelib 8.36 while 5.6.9 has 8.37.
That's probably because of a slight difference between the branch points.

I'll update the news / changelog

2. It seems that changes to 8.37 doesn't include all files
(e.g. ext/pcre/pcrelib/pcre.h which still states 8.36).

(compare revision 23917b45 with 95fa7279 )

Kaplan

Re: [PHP-DEV] pcrelib version differs between 5.5.25 / 5.6.9

[Lior Kaplan]

On Wed, May 20, 2015 at 11:44 AM, Stanislav Malyshev smalys...@gmail.com
wrote:

 Hi!

  1. Just noticed that 5.5.25 has pcrelib 8.36 while 5.6.9 has 8.37.
  That's probably because of a slight difference between the branch points.
 
  I'll update the news / changelog

 8.37 contains some important fixes. I thought I merged it up for all
 branches, but maybe I messed something up. Is 5.5 branch OK?


You missed the PHP-5.5.25 branch...

The PHP-5.5, PHP-5.6 branches are fine, so we'll align on the next release.

But please take a look at #2 on the original mail.

Kaplan

[PHP-DEV] libpcre 8.37 requires extra flags (at least on AIX)

[Lior Kaplan]

Hi,

While building the PHP 5.6.9 (which has libpcre 8.37) it seems we're
missing -lpthreads build flag (for cli SAPI), as this library upgrade added
this requirement.

The files requiring is pcrelib/sljit/sljitUtils.c

5.5.25, which doesn't have this file, works fine without the flag.

I think this requirement should be reflected in ext/pcre/config0.m4 (or is
there something more relevant?)


Thanks,

Kaplan

Re: [PHP-DEV] pcrelib version differs between 5.5.25 / 5.6.9

[Lior Kaplan]

Hi,

I'm not looking to place blame, we all miss staff here and there.

Just wanted to make sure everyone knows there's a difference and it will be
aligned later on.
( I noticed the difference due to a build problem on AIX, which I'm
checking)

kaplan

On Wed, May 20, 2015 at 1:07 PM, Ferenc Kovacs tyr...@gmail.com wrote:



 On Wed, May 20, 2015 at 10:56 AM, Lior Kaplan lio...@zend.com wrote:

 On Wed, May 20, 2015 at 11:44 AM, Stanislav Malyshev smalys...@gmail.com
 
 wrote:

  Hi!
 
   1. Just noticed that 5.5.25 has pcrelib 8.36 while 5.6.9 has 8.37.
   That's probably because of a slight difference between the branch
 points.
  
   I'll update the news / changelog
 
  8.37 contains some important fixes. I thought I merged it up for all
  branches, but maybe I messed something up. Is 5.5 branch OK?
 

 You missed the PHP-5.5.25 branch...

 The PHP-5.5, PHP-5.6 branches are fine, so we'll align on the next
 release.

 But please take a look at #2 on the original mail.

 Kaplan


 merging it into PHP-5.5.25 was Julien's job, Stas merges stuff into
 PHP-5.4 and upward to PHP-5.5/PHP-5.6 and master, and then the RMs merge
 from the development branch into their release branch, for PHP-5.4.X that
 is Stas, for PHP-5.5.X is Julien and I'm doing it for PHP-5.6.X


 --
 Ferenc Kovács
 @Tyr43l - http://tyrael.hu

Re: [PHP-DEV] pcrelib version differs between 5.5.25 / 5.6.9

[Lior Kaplan]

On Wed, May 20, 2015 at 2:31 PM, Anatol Belski anatol@belski.net
wrote:

 Hi,

 -Original Message-
 From: Stanislav Malyshev [mailto:smalys...@gmail.com]
 Sent: Wednesday, May 20, 2015 10:45 AM
 To: Lior Kaplan; PHP internals list
 Subject: Re: [PHP-DEV] pcrelib version differs between 5.5.25 / 5.6.9

 Hi!

  1. Just noticed that 5.5.25 has pcrelib 8.36 while 5.6.9 has 8.37.
  That's probably because of a slight difference between the branch points.
 
  I'll update the news / changelog

 8.37 contains some important fixes. I thought I merged it up for all
 branches, but maybe I messed something up. Is 5.5 branch OK?

 Hi,

 today's master reports 8.36 as well (at least pcre.h), so some more might
 have been missed.


Indeed.

It seems that due to thread replays people are missing my second point in
the original mail.

2. It seems that changes to 8.37 doesn't include all files
 (e.g. ext/pcre/pcrelib/pcre.h which still states 8.36).
 (compare file lists between revision 23917b45 with 95fa7279 )


Kaplan

[PHP-DEV] odbc extension build issues (shared vs. standalone)

[Lior Kaplan]

Hi,

Following Remi's revert of my commit [1] I'd like to suggest a better
solution for master which would be introducing --enable-odbc and having the
ODBC drivers default to no (similar to DBA).

Current problem is fixing build as a standalone (phpize...) breaks support
with builds as ./configure ...  -with-unixODBC=shared,/usr

For 5.5/5.6 - I'm not sure whether to play with parsing the options to
handle shared or shared,[path] (see example bellow) or just leave the
issue to reduce noise for now (we have this for years), although we already
did some changes about --with-odbcver .

Any thoughts / ideas / objections ?

Kaplan

p.s.
Before playing with these options I'd like to also turn ODBC builds on
travis...

---
diff --git a/ext/odbc/config.m4 b/ext/odbc/config.m4
index 4caf567..7a1c98e 100644
--- a/ext/odbc/config.m4
+++ b/ext/odbc/config.m4
@@ -452,8 +452,10 @@ PHP_ARG_WITH(unixODBC,,

   AC_MSG_CHECKING(for unixODBC support)
   if test $PHP_UNIXODBC != no; then
-if test $PHP_UNIXODBC = yes; then
+if test $PHP_UNIXODBC = yes || test $PHP_UNIXODBC = shared;
then
   PHP_UNIXODBC=/usr/local
+else
+  PHP_UNIXODBC=`echo $PHP_UNIXODBC|$SED 's/^shared,//'`
 fi
 ODBC_INCDIR=$PHP_UNIXODBC/include
 ODBC_LIBDIR=$PHP_UNIXODBC/$PHP_LIBDIR
---

[1]
http://git.php.net/?p=php-src.git;a=commitdiff;h=1174b399ad325b630ba202abc6671d8055160b99

Re: [PHP-DEV] 7.0 Release Management

[Lior Kaplan]

On Sun, Mar 22, 2015 at 3:38 AM, Leigh lei...@gmail.com wrote:

 Hi all,

 With 7.0 feature freeze in effect, and proposals and RFCs still coming in
 that are going to target 7.1, I think it's time we branched master and
 selected a release manager (or two) for 7.0.


I would branch only in time for the first beta... Similar to what
LibreOffice do:
https://wiki.documentfoundation.org/ReleasePlan/4.5#4.5.0_release

Rushing to push more features for 7.1 will come a t a cost of testing /
stabilizing 7.0.
It should be fine to ask people to delay feature suggestions for a little
later.

Kaplan

Re: [PHP-DEV] Can we remove NEWS tag ?

[Lior Kaplan]

Renamed to NEWS-cvs2svn

Kaplan
On Feb 11, 2015 5:11 PM, Andrea Faulds a...@ajf.me wrote:

 Hi,

  On 11 Feb 2015, at 09:52, Lior Kaplan lio...@zend.com wrote:
 
  Hi,
 
  I've been doing some editing to the NEWS files, and keep getting this
  problem
 
  $ git diff NEWS
  fatal: ambiguous argument 'NEWS': both revision and filename
  Use '--' to separate filenames from revisions
 
  Although I can do as it suggests, I would prefer to remove the NEWS tag
 we
  have since 2008 as part  of the move from CVS to SVN.
 
  Any objections ?
 
  Kaplan

 I swear this has come up before. Please, remove or rename it, I don't see
 anyone objecting.

 --
 Andrea Faulds
 http://ajf.me/

[PHP-DEV] Can we remove NEWS tag ?

[Lior Kaplan]

Hi,

I've been doing some editing to the NEWS files, and keep getting this
problem

$ git diff NEWS
fatal: ambiguous argument 'NEWS': both revision and filename
Use '--' to separate filenames from revisions

Although I can do as it suggests, I would prefer to remove the NEWS tag we
have since 2008 as part  of the move from CVS to SVN.

Any objections ?

Kaplan

Re: [PHP-DEV] Enable opcache by default in PHP7?

[Lior Kaplan]

On Feb 3, 2015 7:59 AM, Pierre Joye pierre@gmail.com wrote:

 On Feb 3, 2015 11:26 AM, Xinchen Hui larue...@php.net wrote:
 
  Hey:
 
opcache is disabled by default configure, I am plan to enable it
  by default
 
and also add zend_extension=opcache.so in
 php.ini-product/developmement
 
is there any objections or concerns?
 
  thanks

 No problem here for production. I am however not sure about Dev, it can
 still be disable using ini setting but I am not sure it works well with
any
 debugging extension out there. Does it?

Do we have any loading order between opcache and the debugging extensions
(e.g. xdebug) ?

If we do, it's best to keep opcache disabled for dev.

Kaplan

Re: [PHP-DEV] Delete PHPNG branch from repo?

[Lior Kaplan]

+1
On Jan 30, 2015 4:15 PM, Ferenc Kovacs tyr...@gmail.com wrote:

 On Fri, Jan 30, 2015 at 3:04 PM, Xinchen Hui larue...@php.net wrote:

  Hey:
 
 there already are more than 2 people tell me they are trying to
  play with PHP7, but turns out they are playing with PHPNG branch(since
  we used to call it phpng).
 
 as it already be merged into master. and there is also no tags against
  it.
 
 maybe we should delete it?
 
 any objections?
 
  thanks
 
  --
  Xinchen Hui
  @Laruence
  http://www.laruence.com/
 
  --
  PHP Internals - PHP Runtime Development Mailing List
  To unsubscribe, visit: http://www.php.net/unsub.php
 
 
 no, please go ahead.
 we even have tags of PRE_PHPNG_MERGE and POST_PHPNG_MERGE, so there is
 absolutely no reason to keep it around.


 --
 Ferenc Kovács
 @Tyr43l - http://tyrael.hu

Re: [PHP-DEV] Question about patch for bug 61285 - SSL connections do not timeout

[Lior Kaplan]

Hi Brad,

The fix should go to the lowest relevant branch, in this case probably the
5.5 branch.
From there it will be merged to 5.6 and master (future 7.0)/

I took a quick look at the build, and which it compiles successfully,
it seems to be a diff in the test. I suspect it comes from changes in master
than your patch alone (but didn't check this thoroughly).

If someone else wants to look, we're talking about:
https://github.com/php/php-src/pull/971
https://travis-ci.org/php/php-src/jobs/45566082

Kaplan

On Fri, Jan 2, 2015 at 4:46 PM, Brad Broerman bbroer...@bbroerman.net
wrote:

 Hi,

I have a pull request for issue 61285 - SSL connections do not
 timeout, and have a question about it's status

I created a pull request for this years ago, back in PHP 5.5.20 and
 it was never merged into the master. I recently updated my clone of the
 repo to the latest and re-wrote my patch against the newly updated
 master and re-created the pull request.

Is there a possibility of this being pulled? If not, why?  I have
 tested this code both in the original 5.5.20, in the new 5.6.4, and
 briefly with master. I believe it works pretty well.  In the pull
 request itself, I added a comment about the travis ci build failing, but
 I don't see where the failure has anything to do with this extension.
 Would this block acceptance of this patch?


  Thanks
Brad Broerman

 --
 PHP Internals - PHP Runtime Development Mailing List
 To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] CVE-2014-8142 is not mentioned in 5.6.4 changelog

[Lior Kaplan]

Fixed.

http://git.php.net/?p=web/php.git;a=commitdiff;h=52cb11fca4c343f0529ceecfdc5372b49b966435

(should be refreshed on the website soon enough)

On Wed, Dec 24, 2014 at 6:58 AM, Yasuo Ohgaki yohg...@ohgaki.net wrote:

 Hi,

 http://php.net/ChangeLog-5.php#5.4.36
 does not mention CVE-2014-8142.

 Fixed bug #68594 (Use after free vulnerability in unserialize()).
 should be
 Fixed bug #68594 (Use after free vulnerability in
 unserialize())(CVE-2014-8142).
 like 5.5/5.4's changelog.

 Regards,

 --
 Yasuo Ohgaki
 yohg...@ohgaki.net

[PHP-DEV] Re: PHPT curl tests - PHP 5.3.4 branch misses the skipif.inc file

[Lior Kaplan]

Hi,

Can someone please do this minor change in the PHP 5.4 tests ?

Kaplan

On Wed, Dec 3, 2014 at 6:08 PM, Lior Kaplan lio...@zend.com wrote:

 Hi Stas,

 I don't have permissions to fix this myself as the 5.4 branch is closed
 for security only.

 You've added ext/curl/tests/bug68089.phpt which includes skipif.inc in the
 same directory.

 Could you either copy the file from 5.5 branch or put its contents instead
 of the include ?


 $ git show PHP-5.5:ext/curl/tests/skipif.inc
 ?php
 if (!extension_loaded(curl)) exit(skip curl extension not loaded);
 if(false === getenv('PHP_CURL_HTTP_REMOTE_SERVER')) {
 if (php_sapi_name() != cli) {
 die(skip PHP_CURL_HTTP_REMOTE_SERVER env variable is not
 defined);
 }


 Thanks,

 Kaplan


 -- Forwarded message --
 From: Eyal Teutsch eya...@zend.com
 Date: Thu, Oct 30, 2014 at 9:21 AM
 Subject: PHPT curl tests - PHP 5.3.4 branch misses the skipif.inc file
 To: Lior Kaplan lio...@zend.com
 Cc: Gadi Goldbarg g...@zend.com


 Kaplan,

 We noticed here that the 5.4.34 branch 9
 https://github.com/php/php-src/tree/PHP-5.4.34/ext/curl/tests) misses the
 skipif.inc file which is required by some of the tests, and which exists in
 the master (https://github.com/php/php-src/tree/master/ext/curl/tests) .

 As our PHP ambassador, could you please fix that?

 thx
 T

[PHP-DEV] Re: PHPT curl tests - PHP 5.3.4 branch misses the skipif.inc file

[Lior Kaplan]

Ignore this, already fixed by Stas... didn't notice.

http://git.php.net/?p=php-src.git;a=commitdiff;h=b75867fff0d141bf2f81646dd5fae991e85b26ca

Kaplan

On Wed, Dec 17, 2014 at 4:05 PM, Lior Kaplan lio...@zend.com wrote:

 Hi,

 Can someone please do this minor change in the PHP 5.4 tests ?

 Kaplan

 On Wed, Dec 3, 2014 at 6:08 PM, Lior Kaplan lio...@zend.com wrote:

 Hi Stas,

 I don't have permissions to fix this myself as the 5.4 branch is closed
 for security only.

 You've added ext/curl/tests/bug68089.phpt which includes skipif.inc in
 the same directory.

 Could you either copy the file from 5.5 branch or put its contents
 instead of the include ?


 $ git show PHP-5.5:ext/curl/tests/skipif.inc
 ?php
 if (!extension_loaded(curl)) exit(skip curl extension not loaded);
 if(false === getenv('PHP_CURL_HTTP_REMOTE_SERVER')) {
 if (php_sapi_name() != cli) {
 die(skip PHP_CURL_HTTP_REMOTE_SERVER env variable is not
 defined);
 }


 Thanks,

 Kaplan


 -- Forwarded message --
 From: Eyal Teutsch eya...@zend.com
 Date: Thu, Oct 30, 2014 at 9:21 AM
 Subject: PHPT curl tests - PHP 5.3.4 branch misses the skipif.inc file
 To: Lior Kaplan lio...@zend.com
 Cc: Gadi Goldbarg g...@zend.com


 Kaplan,

 We noticed here that the 5.4.34 branch 9
 https://github.com/php/php-src/tree/PHP-5.4.34/ext/curl/tests) misses
 the skipif.inc file which is required by some of the tests, and which
 exists in the master (
 https://github.com/php/php-src/tree/master/ext/curl/tests) .

 As our PHP ambassador, could you please fix that?

 thx
 T

Re: [PHP-DEV] bison 3.0

[Lior Kaplan]

AFAIK, PHP builds fine with bison 3. At least with the common scenarios on
UNIX like systems.

TS builds might be the problem if my memory serves me right.

Kaplan

On Thu, Dec 11, 2014 at 9:36 AM, Ferenc Kovacs tyr...@gmail.com wrote:

 On Thu, Dec 11, 2014 at 8:52 AM, Sebastian Bergmann sebast...@php.net
 wrote:

   Hi!
 
   I just updated my notebook to Fedora 21 and am no longer able to
   build PHP on it since I now have bison 3.0.2 instead of bison 2.7.
 
   bison 3.0 is blacklisted in Zend/acinclude.m4. Is bison 3.0
   incompatible with our parser specification? If so, will it be
   upgraded? It's not really a good situation to be incompatible
   with current versions of essential tools such as bison.
 
   Best,
  Sebastian
 
  --
  PHP Internals - PHP Runtime Development Mailing List
  To unsubscribe, visit: http://www.php.net/unsub.php
 
 
 CCing Mike as he was the author who originally added 3.0 to the exclude
 list.
 I have a vague memory of building master successfully with bison 3.0.2
 (from homebrew) on Mac Mavericks via removing 3.0 from
 bison_version_exclude in Zend/acinclude.m4 so I think that not all versions
 of bison 3.0 are affected, but currently I'm using the bison27
 alternative(as XCode/Command Line Tools comes with bison 2.3 by default and
 master requires =2.4).

 --
 Ferenc Kovács
 @Tyr43l - http://tyrael.hu

Re: [PHP-DEV] PHP 5.4.35's ChangLog is misplaced

[Lior Kaplan]

Fixed.

(allow a few minutes for the change to take affect).

Kaplan

On Mon, Nov 17, 2014 at 6:44 AM, Yasuo Ohgaki yohg...@ohgaki.net wrote:

 Hi webmasters and/or RMs,

 PHP 5.4.35's ChangLog is misplaced.

 http://php.net/ChangeLog-5.php#5.4.35

 It should be after 5.5.19, not after 5.6.2.

 Regards,

 --
 Yasuo Ohgaki
 yohg...@ohgaki.net

Re: [PHP-DEV] PHP 5.4.35's ChangLog is misplaced

[Lior Kaplan]

The change was to make sure it's ordered by date first, than by version
number.

Before the change a version released in October appears higher than one
released in November.

Kaplan

On Wed, Dec 3, 2014 at 3:25 PM, Ferenc Kovacs tyr...@gmail.com wrote:



 On Wed, Dec 3, 2014 at 2:44 PM, Lior Kaplan lio...@zend.com wrote:

 Fixed.

 (allow a few minutes for the change to take affect).


 Hi,

 I did not fix it, because I'm not sure it is a policy that when multiple
 php versions are released then we should order them by the version and not
 by the time of the release.

 --
 Ferenc Kovács
 @Tyr43l - http://tyrael.hu

Re: [PHP-DEV] Re: PowerPC64 patchs

[Lior Kaplan]

Remi,

Any chance to have these fixes for 5.5/5.6 as well?

Kaplan

On Mon, Dec 1, 2014 at 11:09 AM, Remi Collet r...@fedoraproject.org wrote:

 -BEGIN PGP SIGNED MESSAGE-
 Hash: SHA1

 Le 27/11/2014 13:39, Gustavo Frederico Temple Pedrosa a écrit :
  Hi, internals!
 
  There are some PRs for supports of PowerPC64
 
  https://github.com/php/php-src/pull/737
  https://github.com/php/php-src/pull/919
  https://github.com/php/php-src/pull/920
  https://github.com/php/php-src/pull/921
  https://github.com/php/php-src/pull/922

 I have run a build of master with each PR.

 Comments added on all.

 922 merged.


 Notice: master on ppc64 seems in quite bad shape, we currently have
 111 failed tests (with ./configure --disable-all).

 I will try to keep the ppc64 machine to run a few more tests.


 Remi.

 -BEGIN PGP SIGNATURE-
 Version: GnuPG v2
 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

 iEYEARECAAYFAlR8PkUACgkQYUppBSnxahjBkQCg5MWGUVT/K/0XPogocxM8vTGA
 AOkAoNhnlvM0es5opW7Nh7Gu27Cbzi+9
 =CkYT
 -END PGP SIGNATURE-

 --
 PHP Internals - PHP Runtime Development Mailing List
 To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Bug 55700 fix

[Lior Kaplan]

On Sep 2, 2014 8:55 AM, Michael Wallner m...@php.net wrote:

 On 2 Sep 2014 00:13, Chris Wright c...@daverandom.com wrote:
 
  If no-one has any objections to this, I would like to merge it into
  5.6 and master.
 

 +1

Why not 5.5 ?

Kaplan

Re: [PHP-DEV] master is broken on Travis

[Lior Kaplan]

On Thu, Aug 21, 2014 at 12:29 AM, Stas Malyshev smalys...@sugarcrm.com
wrote:

 Hi!

  Removed phpdbg build from configure, and master builds fine.
 
  Removed its tests as well to have travis finish green.

 Did you commit it? I see Travis CI build is still broken.


Committed and it works, the build done at travis finished OK.

But some of the tests fail:

The command ./sapi/cli/php run-tests.php -p `pwd`/sapi/cli/php -g
FAIL,XFAIL,BORK,WARN,LEAK,SKIP --show-diff --set-timeout 120 exited with
1.

Still didn't check it.

Kaplan

Re: [PHP-DEV] master is broken on Travis

[Lior Kaplan]

On Tue, Aug 19, 2014 at 1:46 AM, Bob Weinand bobw...@hotmail.com wrote:

 Am 19.8.2014 um 00:09 schrieb Stas Malyshev smalys...@sugarcrm.com:
  Hi!
 
  Since we've had phpng branch merged to master the build on Travis CI is
  broken for master (as in, doesn't even build). Could it be fixed? It's
  not a good thing that we have master branch that CI can not even run on.
  I suspect it has to do with phpdbg but didn't look into it in depth.
  --
  Stanislav Malyshev, Software Architect
  SugarCRM: http://www.sugarcrm.com/

 Hi,

 yes, phpdbg is not ported yet to phpng. I planned to port it when I have
 time, that'll be in first week of September.

 Until then, feel free to remove phpdbg from travis build. (I'll add it
 then again)


Removed phpdbg build from configure, and master builds fine.

Removed its tests as well to have travis finish green.

Kaplan

Re: [PHP-DEV] Re: 5.6.0 final is near

[Lior Kaplan]

Please make sure these security fixes are included:

fileinfo:
Fixed bug #67716 (Segfault in cdf.c). (CVE-2014-3587)

gd:
Fixed bug #67730 (Null byte injection possible with imagexxx functions).
(CVE-2014-5120)

Thanks,

Kaplan


On Mon, Aug 18, 2014 at 5:46 PM, Ferenc Kovacs tyr...@gmail.com wrote:

 On Sun, Aug 17, 2014 at 11:25 AM, Ferenc Kovacs tyr...@gmail.com wrote:

  Hi,
 
  I'm planning to release 5.6.0 from RC4 if nothing serious comes up, so
  this is just a heads-up: if you think that there is some fix, which
 should
  make into the 5.6.0 final (which isn't in RC4) or if you think that there
  is some blocker issue which should be solved before the 5.6.0 final
  release, please drop me an email just to be sure.
 
  Thanks!
 
  --
  Ferenc Kovács
  @Tyr43l - http://tyrael.hu
 

 Hi,

 just to clarify:
 if no blocker issue is reported from php-5.6.0RC4, then we won't have
 another RC, but php-5.6.0 (final) will be tagged using PHP-5.6.0RC4 as it
 base, and maybe some commits cherry-picked (security fixes for example, or
 changes with low impact like NEWS/UPGRADING/test fixes) on top of it.
 so commits in the PHP-5.6 branch after the RC4 tagging won't be in the
 final by default, only if you can convince me that we need that.

 --
 Ferenc Kovács
 @Tyr43l - http://tyrael.hu

Re: [PHP-DEV] FW: PowerPC64 support

[Lior Kaplan]

On Thu, Jul 24, 2014 at 5:23 PM, Andrea Faulds a...@ajf.me wrote:


 On 24 Jul 2014, at 12:17, Gustavo Frederico Temple Pedrosa 
 gustavo.pedr...@eldorado.org.br wrote:

  I and my team are involved in changes for architecture-specific
 implementations,
  specifically PowerPC64, in favor of expand the support and performance
 in the PHP.

 How widely used is the PowerPC64 architecture? Is it really worth adding
 yet another set of inline asm that will have to be updated if we changed
 these operators?


For the first question - you'll probably will see an increase due to the
OpenPower and IBM's POWER8.

Kaplan

[PHP-DEV] Pull requests report (28/10/2013)

[Lior Kaplan]

Hi,

Following the git problems in the last few days, merges weren't possible.

New:
#503 https://github.com/php/php-src/pull/503 Rename pcre_printint.src to
pcre_printint.c and update from upstream
#504 https://github.com/php/php-src/pull/504 curl_seek bug #47204
#505 https://github.com/php/php-src/pull/505 Binsafe log
#506 https://github.com/php/php-src/pull/506 expectations
#507 https://github.com/php/php-src/pull/507 bug #54276 inconsistent
ini_get/get_cfg_var

Merged:
#293 https://github.com/php/php-src/pull/293 Exif crash on unknown
encoding was fixed

Still open (21 days):
#479 https://github.com/php/php-src/pull/479 Replace invalid code with a
proper #error
#486 https://github.com/php/php-src/pull/486 Client-Initiated
Renegotiation DoS Vulnerability
#487 https://github.com/php/php-src/pull/487 Changed proc_open() zpp
argument to separate the environment array
#493 https://github.com/php/php-src/pull/493 Honor cipher order
#494 https://github.com/php/php-src/pull/494 Verify SSL/TLS Peers by
Default
#496 https://github.com/php/php-src/pull/496 Implemented FR #65917
(getallheaders() is not supported by the built-in web server)
#500 https://github.com/php/php-src/pull/500 Fixed bug #50333 Improving
multi-threaded scalability by using emalloc/efree/estrdup
#501 https://github.com/php/php-src/pull/501 fixed compiler warning
#502  https://github.com/php/php-src/pull/502Allow unlimited line length
in fpm config files

Kaplan

On Mon, Oct 21, 2013 at 1:36 PM, Lior Kaplan lio...@zend.com wrote:

 Hi,

 This week we've reached to PR #500 after 2 years of getting PRs
 officially.
 The more steady stream of PRs started in March 2012... so it's around a PR
 a day in average.

 New:
 #493 https://github.com/php/php-src/pull/493 Honor cipher order
 #494 https://github.com/php/php-src/pull/494 Verify SSL/TLS Peers by
 Default
 #496 https://github.com/php/php-src/pull/496 Implemented FR #65917
 (getallheaders() is not supported by the built-in web server)
 #500 https://github.com/php/php-src/pull/500 Fixed bug #50333 Improving
 multi-threaded scalability by using emalloc/efree/estrdup
 #501 https://github.com/php/php-src/pull/501 fixed compiler warning
 #502  https://github.com/php/php-src/pull/502Allow unlimited line
 length in fpm config files

 Still open (21 days):
 #472 https://github.com/php/php-src/pull/472 Bug 49898
 #474 https://github.com/php/php-src/pull/474 Implement automatic
 property initialization
 #475 https://github.com/php/php-src/pull/475 Fix #61094 Wrong WSDL
 cache file name
 #477 https://github.com/php/php-src/pull/477 Argument unpacking
 #479 https://github.com/php/php-src/pull/479 Replace invalid code with
 a proper #error
 #486 https://github.com/php/php-src/pull/486 Client-Initiated
 Renegotiation DoS Vulnerability
 #487 https://github.com/php/php-src/pull/487 Changed proc_open() zpp
 argument to separate the environment array

 Merged:
 #236 https://github.com/php/php-src/pull/236 slow requests resets FPM
 stats
 #434 https://github.com/php/php-src/pull/434 Call php_module_shutdown()
 for php-fpm child processes
 #458 https://github.com/php/php-src/pull/458 Add ldap_escape()
 #483 https://github.com/php/php-src/pull/483 Add TLSv1.1 and TLSv1.2
 support
 #484 https://github.com/php/php-src/pull/484 Assume the free space is
 correct on Travis CI
 #491 https://github.com/php/php-src/pull/491 Fix compiler warnings in
 openssl.c
 #495 https://github.com/php/php-src/pull/495 Fixes bug #65911
 #497 https://github.com/php/php-src/pull/497 Respect the $YACC
 environment variable
 #498 https://github.com/php/php-src/pull/498 fixed typo and few grammar
 mistakes
 #499 https://github.com/php/php-src/pull/499 Fix RFC 6598 IPv4 Reserved
 Range Checks

 Closed (without merge):
 #295 https://github.com/php/php-src/pull/295 Call
 zend_throw_exception_hook before no stack frame check
 #490 https://github.com/php/php-src/pull/490 Add honor_server_ciphers
 ssl context option to mitigate BEAST
 #492 https://github.com/php/php-src/pull/492 fix
 set_magic_quotes_runtime inconsistency with documentation

 Kaplan

[PHP-DEV] PR #479

[Lior Kaplan]

Can someone with Zend karma take a look at this ?

https://github.com/php/php-src/pull/479/files

Replace invalid code with a proper #error
 This code creates a nasty error as mentioned in bugs #31131, #37062
 Patch taken from Debian's PHP package: 044-strtod_arm_fix


I would have merged myself, but don't have the karma for it.

Thanks,

Kaplan

[PHP-DEV] Pull requests report (21/10/2013)

[Lior Kaplan]

Hi,

This week we've reached to PR #500 after 2 years of getting PRs officially.
The more steady stream of PRs started in March 2012... so it's around a PR
a day in average.

New:
#493 https://github.com/php/php-src/pull/493 Honor cipher order
#494 https://github.com/php/php-src/pull/494 Verify SSL/TLS Peers by
Default
#496 https://github.com/php/php-src/pull/496 Implemented FR #65917
(getallheaders() is not supported by the built-in web server)
#500 https://github.com/php/php-src/pull/500 Fixed bug #50333 Improving
multi-threaded scalability by using emalloc/efree/estrdup
#501 https://github.com/php/php-src/pull/501 fixed compiler warning
#502  https://github.com/php/php-src/pull/502Allow unlimited line length
in fpm config files

Still open (21 days):
#472 https://github.com/php/php-src/pull/472 Bug 49898
#474 https://github.com/php/php-src/pull/474 Implement automatic property
initialization
#475 https://github.com/php/php-src/pull/475 Fix #61094 Wrong WSDL cache
file name
#477 https://github.com/php/php-src/pull/477 Argument unpacking
#479 https://github.com/php/php-src/pull/479 Replace invalid code with a
proper #error
#486 https://github.com/php/php-src/pull/486 Client-Initiated
Renegotiation DoS Vulnerability
#487 https://github.com/php/php-src/pull/487 Changed proc_open() zpp
argument to separate the environment array

Merged:
#236 https://github.com/php/php-src/pull/236 slow requests resets FPM
stats
#434 https://github.com/php/php-src/pull/434 Call php_module_shutdown()
for php-fpm child processes
#458 https://github.com/php/php-src/pull/458 Add ldap_escape()
#483 https://github.com/php/php-src/pull/483 Add TLSv1.1 and TLSv1.2
support
#484 https://github.com/php/php-src/pull/484 Assume the free space is
correct on Travis CI
#491 https://github.com/php/php-src/pull/491 Fix compiler warnings in
openssl.c
#495 https://github.com/php/php-src/pull/495 Fixes bug #65911
#497 https://github.com/php/php-src/pull/497 Respect the $YACC
environment variable
#498 https://github.com/php/php-src/pull/498 fixed typo and few grammar
mistakes
#499 https://github.com/php/php-src/pull/499 Fix RFC 6598 IPv4 Reserved
Range Checks

Closed (without merge):
#295 https://github.com/php/php-src/pull/295 Call
zend_throw_exception_hook before no stack frame check
#490 https://github.com/php/php-src/pull/490 Add honor_server_ciphers
ssl context option to mitigate BEAST
#492 https://github.com/php/php-src/pull/492 fix set_magic_quotes_runtime
inconsistency with documentation

Kaplan

On Mon, Oct 14, 2013 at 10:53 AM, Lior Kaplan lio...@zend.com wrote:

 Hi,

 Technical note: Please add a few words except the bug ID, so the PR title
 will be more meaningful.

 Thanks Lars Strojny for the merges this week...

 Total open: 75

 New:
 #486 https://github.com/php/php-src/pull/486 Client-Initiated
 Renegotiation DoS Vulnerability
 #487 https://github.com/php/php-src/pull/487 Changed proc_open() zpp
 argument to separate the environment array
 #491 https://github.com/php/php-src/pull/491 Fix compiler warnings in
 openssl.c

 Merged:
 #328 https://github.com/php/php-src/pull/328 bug #64441 fixed
 #482 https://github.com/php/php-src/pull/482 Utilize SAN extension
 matching during SSL/TLS peer verification
 #485 https://github.com/php/php-src/pull/485 Fix ZTS build breakage
 from recent openssl PRs
 #488 https://github.com/php/php-src/pull/488 Fixed assumption that the
 temporary directory is located in /tmp
 #489 https://github.com/php/php-src/pull/489 #60760 Converting
 zend_parse_parameters() to zend_parse_parameters_none() in the SPL

 Closed (without merge):
 #470 https://github.com/php/php-src/pull/470 anon class objects

 Still open (21 days):
 #460 https://github.com/php/php-src/pull/460 json_encode(): added
 option to turn only empty arrays into object
 #461 https://github.com/php/php-src/pull/461 use log2() / log10()
 within basic log function
 #462 https://github.com/php/php-src/pull/462 Bug 64744
 #463 https://github.com/php/php-src/pull/463 fix bug #53432 (Assignment
 via string index access on an empty string converts to array)
 #466 https://github.com/php/php-src/pull/466 Allow ini files to have a
 [SAPI=] section in exactly the same manner as [PATH=] and [HOST=]
 #471 https://github.com/php/php-src/pull/471 Bug 64560
 #472 https://github.com/php/php-src/pull/472 Bug 49898
 #474 https://github.com/php/php-src/pull/474 Implement automatic
 property initialization
 #475 https://github.com/php/php-src/pull/475 Fix #61094 Wrong WSDL
 cache file name
 #477 https://github.com/php/php-src/pull/477 Argument unpacking
 #479 https://github.com/php/php-src/pull/479 Replace invalid code with
 a proper #error
 #483 https://github.com/php/php-src/pull/483 Add TLSv1.1 and TLSv1.2
 support
 #484 https://github.com/php/php-src/pull/484 Assume the free space is
 correct on Travis CI

 Kaplan

Re: [PHP-DEV] Gnu/Hurd support

[Lior Kaplan]

On Sat, Sep 28, 2013 at 3:44 PM, Lior Kaplan lio...@zend.com wrote:

 On Sat, Sep 28, 2013 at 12:57 PM, Derick Rethans der...@php.net wrote:

 And bug 31347 is that was a fix for a specific issue on Windows:
 https://bugs.php.net/bug.php?id=31347


 The patch originates in Debian, and I can assure you that they don't build
 for Windows (:
 So that's a good point, thanks.

 We could probably test for ZEND_WIN32, or at least that's what I see at
 ext/opcache/ZendAccelerator.h which just got a similar patch for GNU/Hurd
 support (commit f90483001236c863abe1070d05ee2214db5a0a97).

 If that sounds OK, I'll try to do the change (although I'm not a
 developer).


Ping ?

I need this feedback to try and suggest a fixed patch.

(sorry, not a developer, just practicing general knowledge and what I see
in other commits).

Kaplan

[PHP-DEV] Pull requests report (30/9/2013)

[Lior Kaplan]

Hi,

Total requests: 81

New:
#471 https://github.com/php/php-src/pull/471 Bug 64560
#472 https://github.com/php/php-src/pull/472 Bug 49898
#474 https://github.com/php/php-src/pull/474 Implement automatic property
initialization
#475 https://github.com/php/php-src/pull/475 Fix #61094 Wrong WSDL cache
file name
#476 https://github.com/php/php-src/pull/476 Bug #48389: Correct non
posix code (fixing FTBFS on GNU/Hurd)

Merged:
#473 https://github.com/php/php-src/pull/473 fix many parallel test issues

Closed (without merge):
#431 https://github.com/php/php-src/pull/431 New function:
stream_socket_listen()

Still open (21 days):
#430 https://github.com/php/php-src/pull/430 Add support for CryptoPro
S-box for GOST
#431 https://github.com/php/php-src/pull/431 New function:
stream_socket_listen()
#432 https://github.com/php/php-src/pull/432 Addition of DATE_SQL and
DATE_SQLTIMESTAMP constants
#434 https://github.com/php/php-src/pull/434 Call php_module_shutdown()
for php-fpm child processes
#435 https://github.com/php/php-src/pull/435 Cast to resource
#437 https://github.com/php/php-src/pull/437 changes default value of
mbstring.substitute_character
#438 https://github.com/php/php-src/pull/438 Added support for keywords
where (easily) possible
#441 https://github.com/php/php-src/pull/441 Fixed bug #44889
#442 https://github.com/php/php-src/pull/442 Make the type hinting error
message slightly clearer when a class is expected
#446 https://github.com/php/php-src/pull/446 FreeTDS doesn't seem to be
returning the general error number any more
#447 https://github.com/php/php-src/pull/447 Bug 52124
#448 https://github.com/php/php-src/pull/448 Bug 45543
#449 https://github.com/php/php-src/pull/449 Bug 48225
#451 https://github.com/php/php-src/pull/451 Bug 65672
#453 https://github.com/php/php-src/pull/453 New internal API for
serialization and unserialization
#455 https://github.com/php/php-src/pull/455 Fix missing symbol linking
error on (ancient) systems without atoll, e.g. AIX5.1
#456 https://github.com/php/php-src/pull/456 Fixed whitespace part of bug
#64874 (json_decode handles whitespace and case-sensitivity incorrectly)
#457 https://github.com/php/php-src/pull/457 Fixed part of bug #64874
(json_decode handles whitespace and case-sensitivity incorrectly)
#458 https://github.com/php/php-src/pull/458 Add ldap_escape()
#459 https://github.com/php/php-src/pull/459 Bug 65701
#460 https://github.com/php/php-src/pull/460 json_encode(): added option
to turn only empty arrays into object
#461 https://github.com/php/php-src/pull/461 use log2() / log10() within
basic log function
#462 https://github.com/php/php-src/pull/462 Bug 64744
#463 https://github.com/php/php-src/pull/463 fix bug #53432 (Assignment
via string index access on an empty string converts to array)
#464 https://github.com/php/php-src/pull/464 openssl: certificate
fingerprinting support
#465 https://github.com/php/php-src/pull/465 Better wildcard matching for
CN
#466 https://github.com/php/php-src/pull/466 Allow ini files to have a
[SAPI=] section in exactly the same manner as [PATH=] and [HOST=]
#467 https://github.com/php/php-src/pull/467 Allow ini files to have a
[SAPI=] section in exactly the same manner as [PATH=] and [HOST=]
#468 https://github.com/php/php-src/pull/468 Allow ini files to have a
[SAPI=] section in exactly the same manner as [PATH=] and [HOST=]
#469 https://github.com/php/php-src/pull/469 Streams: Configure crypto
method for ssl:// transports
#470 https://github.com/php/php-src/pull/470 anon class objects

Kaplan


On Mon, Sep 23, 2013 at 9:39 AM, Lior Kaplan lio...@zend.com wrote:

 Hi,

 2nd week in a row that we get a lot of new pull requests. Any thoughts
 about how can we process them faster (especially bug fixes)? Other projects
 use 2 reviewers before commit or similar methods.

 Total requests: 77

 New:
 #455 https://github.com/php/php-src/pull/455 Fix missing symbol linking
 error on (ancient) systems without atoll, e.g. AIX5.1
 #456 https://github.com/php/php-src/pull/456 Fixed whitespace part of
 bug #64874 (json_decode handles whitespace and case-sensitivity
 incorrectly)
 #457 https://github.com/php/php-src/pull/457 Fixed part of bug #64874
 (json_decode handles whitespace and case-sensitivity incorrectly)
 #458 https://github.com/php/php-src/pull/458 Add ldap_escape()
 #459 https://github.com/php/php-src/pull/459 Bug 65701
 #460 https://github.com/php/php-src/pull/460 json_encode(): added
 option to turn only empty arrays into object
 #461 https://github.com/php/php-src/pull/461 use log2() / log10()
 within basic log function
 #462 https://github.com/php/php-src/pull/462 Bug 64744
 #463 https://github.com/php/php-src/pull/463 fix bug #53432 (Assignment
 via string index access on an empty string converts to array)
 #464 https://github.com/php/php-src/pull/464 openssl: certificate
 fingerprinting support
 #465 https://github.com/php/php-src/pull/465 Better wildcard matching
 for CN
 #466 https://github.com/php/php-src/pull

Re: [PHP-DEV] Gnu/Hurd support

[Lior Kaplan]

On Fri, Sep 27, 2013 at 3:02 PM, Derick Rethans der...@php.net wrote:

 On Thu, 26 Sep 2013, Lior Kaplan wrote:

  Hi,
 
  In Debian we build PHP for GNU/Hurd system, which need some minor fixes
  available here:
 
 
 http://anonscm.debian.org/gitweb/?p=pkg-php/php.git;a=blob;f=debian/patches/116-posixness_fix.patch

   46 --- php5.orig/main/php.h
   47 +++ php5/main/php.h
   48 @@ -244,6 +244,10 @@ END_EXTERN_C()
   49  /* macros */
   50  #define STR_PRINT(str) ((str)?(str):)
   51
   52 +#ifndef PATH_MAX
   53 +#define PATH_MAX 4096
   54 +#endif
   55 +
   56  #ifndef MAXPATHLEN
   57  # ifdef PATH_MAX
   58  #  define MAXPATHLEN PATH_MAX

 That looks wrong. You're unconditionally defining PATH_MAX, but there is
 logic in line 57 that deals with this too...


That whole section is about defining MAXPATHLEN, not PATH_MAX.

Kaplan

Re: [PHP-DEV] Gnu/Hurd support

[Lior Kaplan]

On Sat, Sep 28, 2013 at 12:57 PM, Derick Rethans der...@php.net wrote:

 And bug 31347 is that was a fix for a specific issue on Windows:
 https://bugs.php.net/bug.php?id=31347


The patch originates in Debian, and I can assure you that they don't build
for Windows (:
So that's a good point, thanks.

We could probably test for ZEND_WIN32, or at least that's what I see at
ext/opcache/ZendAccelerator.h which just got a similar patch for GNU/Hurd
support (commit f90483001236c863abe1070d05ee2214db5a0a97).

If that sounds OK, I'll try to do the change (although I'm not a developer).

Kaplan

Re: [PHP-DEV] Gnu/Hurd support

[Lior Kaplan]

On Thu, Sep 26, 2013 at 5:04 PM, Christopher Jones 
christopher.jo...@oracle.com wrote:


 Can you create a PR on github for them?


Of course.

https://github.com/php/php-src/pull/476

Kaplan

[PHP-DEV] Gnu/Hurd support

[Lior Kaplan]

Hi,

In Debian we build PHP for GNU/Hurd system, which need some minor fixes
available here:

http://anonscm.debian.org/gitweb/?p=pkg-php/php.git;a=blob;f=debian/patches/116-posixness_fix.patch

(per the guidelines here:
http://www.gnu.org/software/hurd/hurd/porting/guidelines.html#PATH_MAX_tt_MAX_PATH_tt_MAXPATHL
)

There's another few bits here for the opcache extension in 5.5:
http://anonscm.debian.org/gitweb/?p=pkg-php/php.git;a=blob;f=debian/patches/Zend_OpCache_GNUHurd_fix.patch;hb=HEAD

Kaplan

[PHP-DEV] Pull requests report (23/9/2013)

[Lior Kaplan]

Hi,

2nd week in a row that we get a lot of new pull requests. Any thoughts
about how can we process them faster (especially bug fixes)? Other projects
use 2 reviewers before commit or similar methods.

Total requests: 77

New:
#455 https://github.com/php/php-src/pull/455 Fix missing symbol linking
error on (ancient) systems without atoll, e.g. AIX5.1
#456 https://github.com/php/php-src/pull/456 Fixed whitespace part of bug
#64874 (json_decode handles whitespace and case-sensitivity incorrectly)
#457 https://github.com/php/php-src/pull/457 Fixed part of bug #64874
(json_decode handles whitespace and case-sensitivity incorrectly)
#458 https://github.com/php/php-src/pull/458 Add ldap_escape()
#459 https://github.com/php/php-src/pull/459 Bug 65701
#460 https://github.com/php/php-src/pull/460 json_encode(): added option
to turn only empty arrays into object
#461 https://github.com/php/php-src/pull/461 use log2() / log10() within
basic log function
#462 https://github.com/php/php-src/pull/462 Bug 64744
#463 https://github.com/php/php-src/pull/463 fix bug #53432 (Assignment
via string index access on an empty string converts to array)
#464 https://github.com/php/php-src/pull/464 openssl: certificate
fingerprinting support
#465 https://github.com/php/php-src/pull/465 Better wildcard matching for
CN
#466 https://github.com/php/php-src/pull/466 Allow ini files to have a
[SAPI=] section in exactly the same manner as [PATH=] and [HOST=]
#467 https://github.com/php/php-src/pull/467 Allow ini files to have a
[SAPI=] section in exactly the same manner as [PATH=] and [HOST=]
#468 https://github.com/php/php-src/pull/468 Allow ini files to have a
[SAPI=] section in exactly the same manner as [PATH=] and [HOST=]
#469 https://github.com/php/php-src/pull/469 Streams: Configure crypto
method for ssl:// transports
#470 https://github.com/php/php-src/pull/470 anon class objects

Merged:
#372 https://github.com/php/php-src/pull/372 Allow uploading files  2G
(bug 44522)
#452 https://github.com/php/php-src/pull/452 Add RFC 6598 IPs to reserved
addresses

Closed (without merge):
#397 https://github.com/php/php-src/pull/397 New handler for retrieving
properties when object is serialized
#406 https://github.com/php/php-src/pull/406 OnEnable INI MH for opcache
causing strangeness
#436 https://github.com/php/php-src/pull/436 Fixed bug #64874
(json_decode handles whitespace and case-sensitivity incorrectly)
#454 https://github.com/php/php-src/pull/454 json_encode(): option to
only encode empty arrays as objects

Still open (21 days):
#426 https://github.com/php/php-src/pull/426 Parameter skipping in
function calls
#427 https://github.com/php/php-src/pull/427 run-tests.php: Added
EXPECT_EXTERNAL, EXPECTF_EXTERNAL, EXPECTREGEX_EXTERNAL #55736
#428 https://github.com/php/php-src/pull/428 Fixed bug #48770: when
call_user_func() fails to call parent from inheriting class (2)
#429 https://github.com/php/php-src/pull/429 Segfault fix for more than
one modules
#430 https://github.com/php/php-src/pull/430 Add support for CryptoPro
S-box for GOST
#431 https://github.com/php/php-src/pull/431 New function:
stream_socket_listen()
#432 https://github.com/php/php-src/pull/432 Addition of DATE_SQL and
DATE_SQLTIMESTAMP constants
#434 https://github.com/php/php-src/pull/434 Call php_module_shutdown()
for php-fpm child processes
#435 https://github.com/php/php-src/pull/435 Cast to resource
#437 https://github.com/php/php-src/pull/437 changes default value of
mbstring.substitute_character
#438 https://github.com/php/php-src/pull/438 Added support for keywords
where (easily) possible
#441 https://github.com/php/php-src/pull/441 Fixed bug #44889
#442 https://github.com/php/php-src/pull/442 Make the type hinting error
message slightly clearer when a class is expected
#446 https://github.com/php/php-src/pull/446 FreeTDS doesn't seem to be
returning the general error number any more
#447 https://github.com/php/php-src/pull/447 Bug 52124
#448 https://github.com/php/php-src/pull/448 Bug 45543
#449 https://github.com/php/php-src/pull/449 Bug 48225
#451 https://github.com/php/php-src/pull/451 Bug 65672
#453 https://github.com/php/php-src/pull/453 New internal API for
serialization and unserialization

Kaplan

On Mon, Sep 16, 2013 at 11:26 AM, Lior Kaplan lio...@zend.com wrote:

 In the past week we've been hammered with 18 new pull requests, which
 I'm happy with (especially with the other internals discussions). But now
 the hard reviewing work begins, any help would be welcomed.

 Thank you David Soria Parra for the merges and cleanup, and thank you
 Nikita Popov for the merges this week.

 New:
 #435 https://github.com/php/php-src/pull/435 Cast to resource
 #436 https://github.com/php/php-src/pull/436 Fixed bug #64874
 (json_decode handles whitespace and case-sensitivity incorrectly)
 #437 https://github.com/php/php-src/pull/437 changes default value of
 mbstring.substitute_character
 #438 https://github.com/php/php-src/pull/438 Added support for keywords

[PHP-DEV] Pull requests report (16/9/2013)

[Lior Kaplan]

In the past week we've been hammered with 18 new pull requests, which I'm
happy with (especially with the other internals discussions). But now the
hard reviewing work begins, any help would be welcomed.

Thank you David Soria Parra for the merges and cleanup, and thank you
Nikita Popov for the merges this week.

New:
#435 https://github.com/php/php-src/pull/435 Cast to resource
#436 https://github.com/php/php-src/pull/436 Fixed bug #64874
(json_decode handles whitespace and case-sensitivity incorrectly)
#437 https://github.com/php/php-src/pull/437 changes default value of
mbstring.substitute_character
#438 https://github.com/php/php-src/pull/438 Added support for keywords
where (easily) possible
#441 https://github.com/php/php-src/pull/441 Fixed bug #44889
#442 https://github.com/php/php-src/pull/442 Make the type hinting error
message slightly clearer when a class is expected
#446 https://github.com/php/php-src/pull/446 FreeTDS doesn't seem to be
returning the general error number any more
#447 https://github.com/php/php-src/pull/447 Bug 52124
#448 https://github.com/php/php-src/pull/448 Bug 45543
#449 https://github.com/php/php-src/pull/449 Bug 48225
#451 https://github.com/php/php-src/pull/451 Bug 65672
#452 https://github.com/php/php-src/pull/452 Add RFC 6598 IPs to reserved
addresses
#453 https://github.com/php/php-src/pull/453 New internal API for
serialization and unserialization

Merged:
#439 https://github.com/php/php-src/pull/439 Bug 65548
#440 https://github.com/php/php-src/pull/440 Bug 65502
#443 https://github.com/php/php-src/pull/443 Fixed minor bug in SPL test
#444 https://github.com/php/php-src/pull/444 EmptyIterator now implements
Countable; fixes bug 60577
#445 https://github.com/php/php-src/pull/445 Bug 64157

Closed (without merge):
#290 https://github.com/php/php-src/pull/290 Fixed bug #64280
#324 https://github.com/php/php-src/pull/324 Fixed memory leak in
strtotime
#337 https://github.com/php/php-src/pull/337 Feature/log2
#338 https://github.com/php/php-src/pull/338 Adding a new
mysqli::bind_value method
#353 https://github.com/php/php-src/pull/353 Add new function
string_is_ascii
#367 https://github.com/php/php-src/pull/367 Php 5.4 strict session
collision detection
#422 https://github.com/php/php-src/pull/422 Add test for bug #60598
#450 https://github.com/php/php-src/pull/450 disable unsafe optimization

Still open (21 days):
#416 https://github.com/php/php-src/pull/416 New function:
pcntl_daemonize  pcntl_setaffinity
 #421 https://github.com/php/php-src/pull/421 Dedicated syntax for
variadic parameters
#424 https://github.com/php/php-src/pull/424 Signature is valid if there
are less args
#426 https://github.com/php/php-src/pull/426 Parameter skipping in
function calls

Kaplan

On Mon, Sep 9, 2013 at 10:37 AM, Lior Kaplan lio...@zend.com wrote:

 Hi,

 The last week brought quite a few new pull requests. I hope we'll keep see
 new people getting involved.

 New:
 #427 https://github.com/php/php-src/pull/427 run-tests.php: Added
 EXPECT_EXTERNAL, EXPECTF_EXTERNAL, EXPECTREGEX_EXTERNAL #55736
 #428 https://github.com/php/php-src/pull/428 Fixed bug #48770: when
 call_user_func() fails to call parent from inheriting class (2)
 #429 https://github.com/php/php-src/pull/429 Segfault fix for more than
 one modules
 #430 https://github.com/php/php-src/pull/430 Add support for CryptoPro
 S-box for GOST
  #431 https://github.com/php/php-src/pull/431 New function:
 stream_socket_listen()
 #432 https://github.com/php/php-src/pull/432 Addition of DATE_SQL and
 DATE_SQLTIMESTAMP constants
 #434 https://github.com/php/php-src/pull/434 Call php_module_shutdown()
 for php-fpm child processes

 Merged:
 (none)

 Closed (without merge):
 #433 https://github.com/php/php-src/pull/433 undefine user constants at
 runtime

 Still open (21 days):
 #413 https://github.com/php/php-src/pull/413 Make exception messages
 and error output binary safe
 #416 https://github.com/php/php-src/pull/416 New function:
 pcntl_daemonize  pcntl_setaffinity
 #421 https://github.com/php/php-src/pull/421 Dedicated syntax for
 variadic parameters
 #422 https://github.com/php/php-src/pull/422 Add test for bug #60598
 #424 https://github.com/php/php-src/pull/424 Signature is valid if
 there are less args
 #426 https://github.com/php/php-src/pull/426 Parameter skipping in
 function calls

 Kaplan

[PHP-DEV] Pull requests report (9/9/2013)

[Lior Kaplan]

Hi,

The last week brought quite a few new pull requests. I hope we'll keep see
new people getting involved.

New:
#427 https://github.com/php/php-src/pull/427 run-tests.php: Added
EXPECT_EXTERNAL, EXPECTF_EXTERNAL, EXPECTREGEX_EXTERNAL #55736
#428 https://github.com/php/php-src/pull/428 Fixed bug #48770: when
call_user_func() fails to call parent from inheriting class (2)
#429 https://github.com/php/php-src/pull/429 Segfault fix for more than
one modules
#430 https://github.com/php/php-src/pull/430 Add support for CryptoPro
S-box for GOST
#431 https://github.com/php/php-src/pull/431 New function:
stream_socket_listen()
#432 https://github.com/php/php-src/pull/432 Addition of DATE_SQL and
DATE_SQLTIMESTAMP constants
#434 https://github.com/php/php-src/pull/434 Call php_module_shutdown()
for php-fpm child processes

Merged:
(none)

Closed (without merge):
#433 https://github.com/php/php-src/pull/433 undefine user constants at
runtime

Still open (21 days):
#413 https://github.com/php/php-src/pull/413 Make exception messages and
error output binary safe
#416 https://github.com/php/php-src/pull/416 New function:
pcntl_daemonize  pcntl_setaffinity
#421 https://github.com/php/php-src/pull/421 Dedicated syntax for
variadic parameters
#422 https://github.com/php/php-src/pull/422 Add test for bug #60598
#424 https://github.com/php/php-src/pull/424 Signature is valid if there
are less args
#426 https://github.com/php/php-src/pull/426 Parameter skipping in
function calls

Kaplan

On Tue, Sep 3, 2013 at 9:31 AM, Lior Kaplan lio...@zend.com wrote:

 New:
 #422 https://github.com/php/php-src/pull/422 Add test for bug #60598
 #424 https://github.com/php/php-src/pull/424 Signature is valid if
 there are less args
 #426 https://github.com/php/php-src/pull/426 Parameter skipping in
 function calls

 Merged:
 #420 https://github.com/php/php-src/pull/420 Always provide retval ptr
 #423 https://github.com/php/php-src/pull/423 Fix bug #65579 (Using
 traits with get_class_methods causes segfault).

 Closed (without merge):
 #425 https://github.com/php/php-src/pull/425 Function autoloading

 Still open (21 days):
 #406 https://github.com/php/php-src/pull/406 OnEnable INI MH for
 opcache causing strangeness
 #413 https://github.com/php/php-src/pull/413 Make exception messages
 and error output binary safe
 #416 https://github.com/php/php-src/pull/416 New function:
 pcntl_daemonize  pcntl_setaffinity
 #421 https://github.com/php/php-src/pull/421 Dedicated syntax for
 variadic parameters

 Kaplan

[PHP-DEV] Pull requests report (3/9/2013)

[Lior Kaplan]

New:
#422 https://github.com/php/php-src/pull/422 Add test for bug #60598
#424 https://github.com/php/php-src/pull/424 Signature is valid if there
are less args
#426 https://github.com/php/php-src/pull/426 Parameter skipping in
function calls

Merged:
#420 https://github.com/php/php-src/pull/420 Always provide retval ptr
#423 https://github.com/php/php-src/pull/423 Fix bug #65579 (Using traits
with get_class_methods causes segfault).

Closed (without merge):
#425 https://github.com/php/php-src/pull/425 Function autoloading

Still open (21 days):
#406 https://github.com/php/php-src/pull/406 OnEnable INI MH for opcache
causing strangeness
#413 https://github.com/php/php-src/pull/413 Make exception messages and
error output binary safe
#416 https://github.com/php/php-src/pull/416 New function:
pcntl_daemonize  pcntl_setaffinity
#421 https://github.com/php/php-src/pull/421 Dedicated syntax for
variadic parameters

Kaplan

On Tue, Aug 27, 2013 at 9:00 PM, Lior Kaplan lio...@zend.com wrote:

 Hi,

 I'm please to say that we keep processing the requests faster and faster,
 leaving only few not handled in their first week. Thanks for everyone who
 helped.

 New:
 #420 https://github.com/php/php-src/pull/420 Always provide retval ptr
 #421 https://github.com/php/php-src/pull/421 Dedicated syntax for
 variadic parameters

 Merged requests:
 #197 https://github.com/php/php-src/pull/197 fputcsv improvements to
 allow RFC 4180 compliance
 #237 https://github.com/php/php-src/pull/237 Fix DateTime, when use it
 with D/l in format and textual day have dot at the end
 #322 https://github.com/php/php-src/pull/322 Fix DateInterval-days
 value
 #414 https://github.com/php/php-src/pull/414 Fix #65483:
 quoted-printable encode stream filter incorrectly encoding
  #415 https://github.com/php/php-src/pull/415 Remove duplicate calls to
 set filename  lineno for the DTRACE_FUNCTION_ENTRY/RETURN cases
 #417 https://github.com/php/php-src/pull/417 Stricter libc-client
 symlink check
 #419 https://github.com/php/php-src/pull/419 Test extension xmlrpc
 encode type double and string decode type string and int

 Closed requests (without merge):
 #418 https://github.com/php/php-src/pull/418 Add test for #65499 (not a
 PHP bug)

 Still open (21 days):
 #406 https://github.com/php/php-src/pull/406 OnEnable INI MH for
 opcache causing strangeness
 #413 https://github.com/php/php-src/pull/413 Make exception messages
 and error output binary safe
 #416 https://github.com/php/php-src/pull/416 New function:
 pcntl_daemonize  pcntl_setaffinity

 Kaplan

Re: [PHP-DEV] Attitude against distributions... (Was: JSON non-free license)

[Lior Kaplan]

On Wed, Aug 28, 2013 at 9:50 PM, Stas Malyshev smalys...@sugarcrm.comwrote:

 Hi!

  I would like to react on Stat's it's-not-our-problem comment in
  https://bugs.php.net/bug.php?id=63520

 However, given all that, I think the matter would be handled better if,
 before taking decisions that can influence many users of PHP that chose
 to trust Debian to deliver their PHP builds, Debian would consult with
 PHP community on how to handle that. I do not remember this question
 being raised on PHP list and discussed there.


http://marc.info/?l=php-internalsm=136768085009866w=2

Kaplan

Re: [PHP-DEV] Attitude against distributions... (Was: JSON non-free license)

[Lior Kaplan]

On Wed, Aug 28, 2013 at 10:45 PM, Stas Malyshev smalys...@sugarcrm.comwrote:

 Hi!

  http://marc.info/?l=php-internalsm=136768085009866w=2

 This is great but this is not exactly what I'm talking about. There's a
 big difference between having an extension that does JSON in PECL and
 replacing part of PHP core (and very commonly used part) by something
 else.


Well, having the new implementation in PECL is a logical step to publish
the code and let people test it.

His mail offers (my emphasis):

1/ update existing pecl/json extension
 - on pecl for older PHP 5.3 - 5.5
 * - on php-src in master / 5.6 *


And while the issue was first reported by Debian, the other distributions
share the same concerns. This is why PHP should consider this - because the
other parts of the eco-system are already going forward with this.

I agree to what you said about a bug not being a discussion. But it was the
first try to communicate with the community. Today, I would raise the issue
differently, but Remi's mail with the subject of Proposal: new
implementation of JSON extension should have been a good start.

Kaplan

[PHP-DEV] Pull requests report (27/8/2013)

[Lior Kaplan]

Hi,

I'm please to say that we keep processing the requests faster and faster,
leaving only few not handled in their first week. Thanks for everyone who
helped.

New:
#420 https://github.com/php/php-src/pull/420 Always provide retval ptr
#421 https://github.com/php/php-src/pull/421 Dedicated syntax for
variadic parameters

Merged requests:
#197 https://github.com/php/php-src/pull/197 fputcsv improvements to
allow RFC 4180 compliance
#237 https://github.com/php/php-src/pull/237 Fix DateTime, when use it
with D/l in format and textual day have dot at the end
#322 https://github.com/php/php-src/pull/322 Fix DateInterval-days value
#414 https://github.com/php/php-src/pull/414 Fix #65483: quoted-printable
encode stream filter incorrectly encoding
 #415 https://github.com/php/php-src/pull/415 Remove duplicate calls to
set filename  lineno for the DTRACE_FUNCTION_ENTRY/RETURN cases
#417 https://github.com/php/php-src/pull/417 Stricter libc-client symlink
check
#419 https://github.com/php/php-src/pull/419 Test extension xmlrpc encode
type double and string decode type string and int

Closed requests (without merge):
#418 https://github.com/php/php-src/pull/418 Add test for #65499 (not a
PHP bug)

Still open (21 days):
#406 https://github.com/php/php-src/pull/406 OnEnable INI MH for opcache
causing strangeness
#413 https://github.com/php/php-src/pull/413 Make exception messages and
error output binary safe
#416 https://github.com/php/php-src/pull/416 New function:
pcntl_daemonize  pcntl_setaffinity

Kaplan

On Thu, Aug 22, 2013 at 2:24 AM, Lior Kaplan lio...@zend.com wrote:

 (reporting about two weeks)

 Merged requests (past 7 days):
 #359 https://github.com/php/php-src/issues/359 PHPTests for the
 DOMDocument::load and DOMDocument::loadXML
 #360 https://github.com/php/php-src/pull/360 Bug44168
 #381 https://github.com/php/php-src/issues/381 Fixed #65225: PHP_BINARY
 incorrectly set
 #395 https://github.com/php/php-src/issues/395 typofixes - code related
 #402 https://github.com/php/php-src/issues/402 make the bison version
 check a blacklist
 #403 https://github.com/php/php-src/issues/403 Fix #61345: fix install
 of CGI binary
 #404 https://github.com/php/php-src/issues/404 
 php.ini-development/production:
 remove php_zip.dll
 #405 https://github.com/php/php-src/issues/405 Fixbug: phpize --clean
 will delete include/*.h
 #410 https://github.com/php/php-src/pull/410 Fix for php bug #64802
 #411 https://github.com/php/php-src/issues/411 Use pkg-config to detect
 iodbc
 #412 https://github.com/php/php-src/issues/412 Create test to the
 extension xmlrpc, encode array and int.

 Closed requests (without merge):
 #325 https://github.com/php/php-src/issues/325 Add schema default/fixed
 value support in DOM (merged in April, closed now).
 #329 https://github.com/php/php-src/issues/329 Allow major versions of
 bison (done as part of #402).

 New:
 #406 https://github.com/php/php-src/pull/406 OnEnable INI MH for
 opcache causing strangeness
 #413 https://github.com/php/php-src/pull/413 Make exception messages
 and error output binary safe
 #414 https://github.com/php/php-src/pull/414 Fix #65483:
 quoted-printable encode stream filter incorrectly encoding
 #415 https://github.com/php/php-src/pull/415 Remove duplicate calls to
 set filename  lineno for the DTRACE_FUNCTION_ENTRY/RETURN cases
 #416 https://github.com/php/php-src/pull/416 New function:
 pcntl_daemonize  pcntl_setaffinity

 Kaplan

[PHP-DEV] Pull requests report (21/8/2013)

[Lior Kaplan]

(reporting about two weeks)

Merged requests (past 7 days):
#359 https://github.com/php/php-src/issues/359 PHPTests for the
DOMDocument::load and DOMDocument::loadXML
#360 https://github.com/php/php-src/pull/360 Bug44168
#381 https://github.com/php/php-src/issues/381 Fixed #65225: PHP_BINARY
incorrectly set
#395 https://github.com/php/php-src/issues/395 typofixes - code related
#402 https://github.com/php/php-src/issues/402 make the bison version
check a blacklist
#403 https://github.com/php/php-src/issues/403 Fix #61345: fix install of
CGI binary
#404 https://github.com/php/php-src/issues/404
php.ini-development/production:
remove php_zip.dll
#405 https://github.com/php/php-src/issues/405 Fixbug: phpize --clean
will delete include/*.h
#410 https://github.com/php/php-src/pull/410 Fix for php bug #64802
#411 https://github.com/php/php-src/issues/411 Use pkg-config to detect
iodbc
#412 https://github.com/php/php-src/issues/412 Create test to the
extension xmlrpc, encode array and int.

Closed requests (without merge):
#325 https://github.com/php/php-src/issues/325 Add schema default/fixed
value support in DOM (merged in April, closed now).
#329 https://github.com/php/php-src/issues/329 Allow major versions of
bison (done as part of #402).

New:
#406 https://github.com/php/php-src/pull/406 OnEnable INI MH for opcache
causing strangeness
#413 https://github.com/php/php-src/pull/413 Make exception messages and
error output binary safe
#414 https://github.com/php/php-src/pull/414 Fix #65483: quoted-printable
encode stream filter incorrectly encoding
#415 https://github.com/php/php-src/pull/415 Remove duplicate calls to
set filename  lineno for the DTRACE_FUNCTION_ENTRY/RETURN cases
#416 https://github.com/php/php-src/pull/416 New function:
pcntl_daemonize  pcntl_setaffinity

Kaplan

p.s.
For those of you who want some perspective on merges done in the last
month:
http://liorkaplan.wordpress.com/2013/08/11/getting-patches-into-php-take-two/

On Wed, Aug 7, 2013 at 10:15 AM, Lior Kaplan lio...@zend.com wrote:

 Merged requests (past 7 days):
 #214 https://github.com/php/php-src/pull/214 First fixes for a 64bit
 compatible ftp extension
 #394 https://github.com/php/php-src/issues/394 typofixes - non living
 code related typo fixes
 #399 https://github.com/php/php-src/pull/399 Constify streams API and a
 few other calls down the rabbit hole.
 #401 https://github.com/php/php-src/pull/401 Php 5.5 strict session
 collision detection

 Thanks Stas (:

 Closed requests (without merge):
 #199 https://github.com/php/php-src/pull/199 Bug #62479 Fix bug where
 spaces in passwords would fail
 #368 https://github.com/php/php-src/issues/368 Php 5.5 strict session
 collision detection (in favor of #401)
 #400 https://github.com/php/php-src/pull/400 Bug44164

 New and still open requests (past 7 days):
 None  - everything from this week was either merged or closed - well done
 (:

 existing requests (7-21 days):
 #388 https://github.com/php/php-src/pull/388 Add new 'use function'
 sequence for importing namespaced functions
 #390 https://github.com/php/php-src/pull/390 Add DateInterval::add
 method
 #393 https://github.com/php/php-src/pull/393 Fix #60873: Add
 read_property handler for DateTime object
 #395 https://github.com/php/php-src/pull/395 typofixes - code related
 #397 https://github.com/php/php-src/pull/397 New handler for retrieving
 properties when object is serialized
 #398 https://github.com/php/php-src/pull/398 Fix #65069: GlobIterator
 fails to access files inside an open_basedir restricted dir

 Kaplan

[PHP-DEV] Pull requests report (7/8/2013)

[Lior Kaplan]

Merged requests (past 7 days):
#214 https://github.com/php/php-src/pull/214 First fixes for a 64bit
compatible ftp extension
#394 https://github.com/php/php-src/issues/394 typofixes - non living
code related typo fixes
#399 https://github.com/php/php-src/pull/399 Constify streams API and a
few other calls down the rabbit hole.
#401 https://github.com/php/php-src/pull/401 Php 5.5 strict session
collision detection

Thanks Stas (:

Closed requests (without merge):
#199 https://github.com/php/php-src/pull/199 Bug #62479 Fix bug where
spaces in passwords would fail
#368 https://github.com/php/php-src/issues/368 Php 5.5 strict session
collision detection (in favor of #401)
#400 https://github.com/php/php-src/pull/400 Bug44164

New and still open requests (past 7 days):
None  - everything from this week was either merged or closed - well done (:

existing requests (7-21 days):
#388 https://github.com/php/php-src/pull/388 Add new 'use function'
sequence for importing namespaced functions
#390 https://github.com/php/php-src/pull/390 Add DateInterval::add method
#393 https://github.com/php/php-src/pull/393 Fix #60873: Add
read_property handler for DateTime object
#395 https://github.com/php/php-src/pull/395 typofixes - code related
#397 https://github.com/php/php-src/pull/397 New handler for retrieving
properties when object is serialized
#398 https://github.com/php/php-src/pull/398 Fix #65069: GlobIterator
fails to access files inside an open_basedir restricted dir

Kaplan

On Tue, Jul 30, 2013 at 11:56 AM, Lior Kaplan lio...@zend.com wrote:

 The last week was characterized with less merges but more comments
 on the open and new pull requests (thanks Anatol Belski). I think this is
 equally important.

 Merged requests (past 7 days):
 #371 https://github.com/php/php-src/pull/371 Added test-case for bug
 #65028 (part of #392)
 #392 https://github.com/php/php-src/pull/392 Fix bug #65028 (also
 includes PR #371)

 Closed requests (without merge):
 #145 https://github.com/php/php-src/pull/145 Enable extension loading
 from .user.ini when run as CGI.
 #396 https://github.com/php/php-src/pull/396 Clean formatting fetch.php

 New and still open requests (past 7 days):
 #394 https://github.com/php/php-src/pull/394 typofixes - non living
 code related typo fixes
 #395 https://github.com/php/php-src/pull/395 typofixes - code related
 #397 https://github.com/php/php-src/pull/397 New handler for retrieving
 properties when object is serialized
 #398 https://github.com/php/php-src/pull/398 Fix #65069: GlobIterator
 fails to access files inside an open_basedir restricted dir

 existing requests (7-21 days):
 #381 https://github.com/php/php-src/pull/381 Fixed 
 #65225https://bugs.php.net/bug.php?id=65225:
 PHP_BINARY incorrectly set
 #382 https://github.com/php/php-src/pull/382 Added support for not
 canonicalizing the SASL realm on sasl_binds for LDAP
 #388 https://github.com/php/php-src/pull/388 Add new 'use function'
 sequence for importing namespaced functions
 #390 https://github.com/php/php-src/pull/390 Add DateInterval::add
 method
 #393 https://github.com/php/php-src/pull/393 Fix #60873: Add
 read_property handler for DateTime object

 Kaplan

[PHP-DEV] Pull requests report (30/7/2013)

[Lior Kaplan]

The last week was characterized with less merges but more comments
on the open and new pull requests (thanks Anatol Belski). I think this is
equally important.

Merged requests (past 7 days):
#371 https://github.com/php/php-src/pull/371 Added test-case for bug
#65028 (part of #392)
#392 https://github.com/php/php-src/pull/392 Fix bug #65028 (also
includes PR #371)

Closed requests (without merge):
#145 https://github.com/php/php-src/pull/145 Enable extension loading
from .user.ini when run as CGI.
#396 https://github.com/php/php-src/pull/396 Clean formatting fetch.php

New and still open requests (past 7 days):
#394 https://github.com/php/php-src/pull/394 typofixes - non living code
related typo fixes
#395 https://github.com/php/php-src/pull/395 typofixes - code related
#397 https://github.com/php/php-src/pull/397 New handler for retrieving
properties when object is serialized
#398 https://github.com/php/php-src/pull/398 Fix #65069: GlobIterator
fails to access files inside an open_basedir restricted dir

existing requests (7-21 days):
#381 https://github.com/php/php-src/pull/381 Fixed
#65225https://bugs.php.net/bug.php?id=65225:
PHP_BINARY incorrectly set
#382 https://github.com/php/php-src/pull/382 Added support for not
canonicalizing the SASL realm on sasl_binds for LDAP
#388 https://github.com/php/php-src/pull/388 Add new 'use function'
sequence for importing namespaced functions
#390 https://github.com/php/php-src/pull/390 Add DateInterval::add method
#393 https://github.com/php/php-src/pull/393 Fix #60873: Add
read_property handler for DateTime object

Kaplan

On Tue, Jul 23, 2013 at 10:41 AM, Lior Kaplan lio...@zend.com wrote:

 This is the 3rd report, and I'm glad to see more people reviewing 
 commenting the requests. Thanks.

 Merged requests (past 7 days):
 #99 https://github.com/php/php-src/issues/99 Added
 recursivetreeiterator::setPostfix() method
 #231 https://github.com/php/php-src/issues/231 Bringing CSS up to this
 decade's standards
 #267 https://github.com/php/php-src/pull/267 Bug #38917 - Native SPKAC
 support request (merged two months ago)
 #317 https://github.com/php/php-src/pull/317 Fix saving of -1 index
 from keys column in array_column function
 #326 https://github.com/php/php-src/issues/326 zend_register_bool_constant
 patch
 #351 https://github.com/php/php-src/pull/351 working example of session
 garbage collection in sub-directories
 #384 https://github.com/php/php-src/pull/384 HASH_KEY_NON_EXISTANT typo
 fix
 #385 https://github.com/php/php-src/pull/385 mssql.compatability_mode
 typo fix
 #387 https://github.com/php/php-src/pull/387 Wrong value for
 FILTER_SANITIZE_FULL_SPECIAL_CHARS
 #389 https://github.com/php/php-src/pull/389 Fixed bug #65291 -
 get_defined_constants() crash with __CLASS__ in trait
 #391 https://github.com/php/php-src/issues/391 addressed bug #65159,
 Misleading configure help text for --with-mysql-sock

 Thanks Stas for your work on this, and to Yasuo who helped as well.

 Closed requests (without merge):
 #52 https://github.com/php/php-src/issues/52 Imap send (*abandoned patch
 *)
 #72 https://github.com/php/php-src/issues/72 Implemented
 posix_getspnam() function (*abandoned patch*)
 #167 https://github.com/php/php-src/pull/167 Add PDO::quoteName() method
 #213 https://github.com/php/php-src/issues/213 Copied reproduction code
 from bugs.php.net to phpt
 #265 https://github.com/php/php-src/pull/265 ext/session/mod_files.sh
 fix (*conflicts with fix at 5f0656b89ddb42d17a70f767060a08226809421a*)
 #366 https://github.com/php/php-src/pull/366 PHP 5.3 strict session (*no
 new features for 5.3*)
 #375 https://github.com/php/php-src/issues/375 Fixed bug #48770: when
 call_user_func() fails to call parent from inheriting class (*BC break*)

 New (and still open) requests (past 7 days):
 #388 https://github.com/php/php-src/pull/388 Add new 'use function'
 sequence for importing namespaced functions
 #390 https://github.com/php/php-src/pull/390 Add DateInterval::add
 method
 #392 https://github.com/php/php-src/pull/392 Fix bug #65028
 #393 https://github.com/php/php-src/pull/393 Fix #60873: Add
 read_property handler for DateTime object

 existing requests (7-21 days):
 #373 https://github.com/php/php-src/pull/373 Add apparmor change hat
 functionality to fpm
 #374 https://github.com/php/php-src/pull/374 PostgreSQL's
 PDOStatement::getColumnMeta() fills in table's name.
 #381 https://github.com/php/php-src/pull/381 Fixed 
 #65225https://bugs.php.net/bug.php?id=65225:
 PHP_BINARY incorrectly set
 #382 https://github.com/php/php-src/pull/382 Added support for not
 canonicalizing the SASL realm on sasl_binds for LDAP

 Kaplan

[PHP-DEV] Pull requests report (23/7/2013)

[Lior Kaplan]

This is the 3rd report, and I'm glad to see more people reviewing 
commenting the requests. Thanks.

Merged requests (past 7 days):
#99 https://github.com/php/php-src/issues/99 Added
recursivetreeiterator::setPostfix() method
#231 https://github.com/php/php-src/issues/231 Bringing CSS up to this
decade's standards
#267 https://github.com/php/php-src/pull/267 Bug #38917 - Native SPKAC
support request (merged two months ago)
#317 https://github.com/php/php-src/pull/317 Fix saving of -1 index from
keys column in array_column function
#326 https://github.com/php/php-src/issues/326 zend_register_bool_constant
patch
#351 https://github.com/php/php-src/pull/351 working example of session
garbage collection in sub-directories
#384 https://github.com/php/php-src/pull/384 HASH_KEY_NON_EXISTANT typo
fix
#385 https://github.com/php/php-src/pull/385 mssql.compatability_mode
typo fix
#387 https://github.com/php/php-src/pull/387 Wrong value for
FILTER_SANITIZE_FULL_SPECIAL_CHARS
#389 https://github.com/php/php-src/pull/389 Fixed bug #65291 -
get_defined_constants() crash with __CLASS__ in trait
#391 https://github.com/php/php-src/issues/391 addressed bug #65159,
Misleading configure help text for --with-mysql-sock

Thanks Stas for your work on this, and to Yasuo who helped as well.

Closed requests (without merge):
#52 https://github.com/php/php-src/issues/52 Imap send (*abandoned patch*)
#72 https://github.com/php/php-src/issues/72 Implemented posix_getspnam()
function (*abandoned patch*)
#167 https://github.com/php/php-src/pull/167 Add PDO::quoteName() method
#213 https://github.com/php/php-src/issues/213 Copied reproduction code
from bugs.php.net to phpt
#265 https://github.com/php/php-src/pull/265 ext/session/mod_files.sh fix
(*conflicts with fix at 5f0656b89ddb42d17a70f767060a08226809421a*)
#366 https://github.com/php/php-src/pull/366 PHP 5.3 strict session (*no
new features for 5.3*)
#375 https://github.com/php/php-src/issues/375 Fixed bug #48770: when
call_user_func() fails to call parent from inheriting class (*BC break*)

New (and still open) requests (past 7 days):
#388 https://github.com/php/php-src/pull/388 Add new 'use function'
sequence for importing namespaced functions
#390 https://github.com/php/php-src/pull/390 Add DateInterval::add method
#392 https://github.com/php/php-src/pull/392 Fix bug #65028
#393 https://github.com/php/php-src/pull/393 Fix #60873: Add
read_property handler for DateTime object

existing requests (7-21 days):
#373 https://github.com/php/php-src/pull/373 Add apparmor change hat
functionality to fpm
#374 https://github.com/php/php-src/pull/374 PostgreSQL's
PDOStatement::getColumnMeta() fills in table's name.
#381 https://github.com/php/php-src/pull/381 Fixed
#65225https://bugs.php.net/bug.php?id=65225:
PHP_BINARY incorrectly set
#382 https://github.com/php/php-src/pull/382 Added support for not
canonicalizing the SASL realm on sasl_binds for LDAP

Kaplan

Re: [PHP-DEV] Pull requests report (17/7/2013)

[Lior Kaplan]

On Thu, Jul 18, 2013 at 4:21 AM, Sherif Ramadan theanomaly...@gmail.comwrote:

 On Wed, Jul 17, 2013 at 6:47 PM, Lior Kaplan lio...@zend.com wrote:

 What do you think about closing older PR (  28 days) ?


 First off, thanks for all the hard work. PRs aren't getting as much
 attention as they should, and I'd like to say that I certainly haven't been
 helping as much as I should with them. What I am noticing though, is that a
 lot of these newer PRs, or the ones that are getting more attention, seem
 to be fairly cosmetic changes. I mean, spelling mistakes are all great
 fixes, and no disrespect to any contribution small or big, but there are
 certainly a lot of PRs which people have spent a great deal of time working
 on, clearly, that seem to be getting ignored. If we start closing these
 strictly because of how long they've been open it would be such a
 discouragement to everyone who contributed. I sincerely hope this doesn't
 happen. I'd much rather see people spending more time on reviewing some of
 the older PRs and seeing if they're worthy of merging or not based on
 substance rather than just dismiss them based on how long they've been open.

 I've tried to get in contact with some of the original authors of at least
 a couple of PRs in the past weeks to see if they were interested in working
 on an RFC to get their PRs merged as they necessitated some more
 discussion, but so far have come up empty. So I'll try to help out as much
 as I can with the ones that can get immediate attention.


I'm glad to see that question got everyone's attension (:

Indeed we started with the easy ones... there isn't any reason simple
patches
won't get merged very quickly.

We have some PR which the disscussion about them is stuck, the question is
who
and when do we cut it off and send the author to rework his patch. After
some
feedback was given, if the author isn't responsive, and no one else wants to
handle the patch instead, we can reject and ask them to come back when
ready.

Also, we have more than a few PR which the patch is OK, but are stuck due
to a
missing test. This is fair enough, but should also have some rule of thumb
for
these cases.

Seeing a long list of PR waiting for a year isn't much encouraging, I would
prefer to see people quickly either have their changes accepted,  sent to
improve
the PR or completly rejected. Don't forget the PR can always be resent and
the
work isn't lost.

Kaplan

Re: [PHP-DEV] Pull requests report (17/7/2013)

[Lior Kaplan]

On Thu, Jul 18, 2013 at 10:00 PM, Stas Malyshev smalys...@sugarcrm.comwrote:

  Also, we have more than a few PR which the patch is OK, but are stuck due
  to a
  missing test. This is fair enough, but should also have some rule of
 thumb
  for
  these cases.

 Again, it would not be hard to add tests for many of them, the problem
 is again - time. For myself, I'd rather spend time on merging properly
 done patches or fixing bugs than finishing up patches that the original
 author could finish up. But if some people decide that this is a good
 way for them to contribute - that'd be great. Otherwise, removing these
 pulls from public view would only mean they'd never get taken care at all.


Maybe offer the list of needed tests as an easy task/hack so even people
not into
the internals could contribute. e.g.
https://wiki.documentfoundation.org/Easy_Hacks

Might be a win win for everybody ? (although some help might still be
needed)

Kaplan

[PHP-DEV] Pull requests report (17/7/2013)

[Lior Kaplan]

Merged requests (past 7 days):
#364 https://github.com/php/php-src/pull/364 fix invalid variable name at
ext/spl/internal/multipleiterator.inc
#370 https://github.com/php/php-src/pull/370 Remove PWS (Personal Web
Server) references
#377 https://github.com/php/php-src/pull/377 Add built-in web server to
cli usage, and align terminology in cli manpage
#378 https://github.com/php/php-src/pull/378 Fix bug
#62665https://bugs.php.net/bug.php?id=62665:
add curl.cainfo to php.ini
#386 https://github.com/php/php-src/pull/386 Typo fixes

Thanks Stas for helping these merges happen.

New (last 7 days):
#384 https://github.com/php/php-src/pull/384 HASH_KEY_NON_EXISTANT typo
fix
#385 https://github.com/php/php-src/pull/385 mssql.compatability_mode
typo fix
#387 https://github.com/php/php-src/pull/387 Wrong value for
FILTER_SANITIZE_FULL_SPECIAL_CHARS

existing (7-14 days):
#375 https://github.com/php/php-src/pull/375 Fixed bug
#48770https://bugs.php.net/bug.php?id=48770:
when call_user_func() fails to call parent from inheriting class
#381 https://github.com/php/php-src/pull/381 Fixed
#65225https://bugs.php.net/bug.php?id=65225:
PHP_BINARY incorrectly set
#382 https://github.com/php/php-src/pull/382 Added support for not
canonicalizing the SASL realm on sasl_binds for LDAP

What do you think about closing older PR (  28 days) ?

Kaplan

On Wed, Jul 10, 2013 at 3:36 PM, Lior Kaplan lio...@zend.com wrote:

 Hi,

 Following my suggestion to help with pull requests, I'm going to send a
 report about new  ongoing pull requests.
 I hope it will help us to handle them more efficiently and lower the
 response time for patches.

 Feedback is much appriciated.

 New (last 7 days):
 #375 https://github.com/php/php-src/pull/375 Fixed bug 
 #48770https://bugs.php.net/bug.php?id=48770:
 when call_user_func() fails to call parent from inheriting class
 #377 https://github.com/php/php-src/pull/377 Add built-in web server to
 cli usage, and align terminology in cli manpage
 #378 https://github.com/php/php-src/pull/378 Fix bug 
 #62665https://bugs.php.net/bug.php?id=62665:
 add curl.cainfo to php.ini
 #381 https://github.com/php/php-src/pull/381 Fixed 
 #65225https://bugs.php.net/bug.php?id=65225:
 PHP_BINARY incorrectly set
 #382 https://github.com/php/php-src/pull/382 Added support for not
 canonicalizing the SASL realm on sasl_binds for LDAP

 Older (but seems trivial):
 #360 https://github.com/php/php-src/pull/360 Use in
 preg_replace_callback() using variables by reference and test for bug #
 64979 https://bugs.php.net/bug.php?id=64979
 #364 https://github.com/php/php-src/pull/364 fix invalid variable name
 at ext/spl/internal/multipleiterator.inc
 #370 https://github.com/php/php-src/pull/370 Remove PWS (Personal Web
 Server) references

 Kaplan

 p.s.
 Feel free to just approve the merge after reviewing the code, and I'll do
 merge myself later.

[PHP-DEV] Pull requests report (10/7/2013)

[Lior Kaplan]

Hi,

Following my suggestion to help with pull requests, I'm going to send a
report about new  ongoing pull requests.
I hope it will help us to handle them more efficiently and lower the
response time for patches.

Feedback is much appriciated.

New (last 7 days):
#375 https://github.com/php/php-src/pull/375 Fixed bug
#48770https://bugs.php.net/bug.php?id=48770:
when call_user_func() fails to call parent from inheriting class
#377 https://github.com/php/php-src/pull/377 Add built-in web server to
cli usage, and align terminology in cli manpage
#378 https://github.com/php/php-src/pull/378 Fix bug
#62665https://bugs.php.net/bug.php?id=62665:
add curl.cainfo to php.ini
#381 https://github.com/php/php-src/pull/381 Fixed
#65225https://bugs.php.net/bug.php?id=65225:
PHP_BINARY incorrectly set
#382 https://github.com/php/php-src/pull/382 Added support for not
canonicalizing the SASL realm on sasl_binds for LDAP

Older (but seems trivial):
#360 https://github.com/php/php-src/pull/360 Use in
preg_replace_callback() using variables by reference and test for bug
#64979https://bugs.php.net/bug.php?id=64979
#364 https://github.com/php/php-src/pull/364 fix invalid variable name at
ext/spl/internal/multipleiterator.inc
#370 https://github.com/php/php-src/pull/370 Remove PWS (Personal Web
Server) references

Kaplan

p.s.
Feel free to just approve the merge after reviewing the code, and I'll do
merge myself later.

Re: [PHP-DEV] VCS Account Request: kaplan

[Lior Kaplan]

Ping ?

On Thu, Jun 27, 2013 at 2:01 PM, Lior Kaplan kaplanl...@gmail.com wrote:

 Helping with merging patches and pull requests


 --
 PHP Internals - PHP Runtime Development Mailing List
 To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] VCS Account Request: kaplan

[Lior Kaplan]

Thanks for the tip. I do work for Zend, but ask for the accont to
contribute privately.
I don't want access only because of corporate affiliation.

I asked for the accont after a short discussion about pull requests, and
was invited to help...

Kaplan

On Tue, Jul 9, 2013 at 11:02 AM, Yasuo Ohgaki yohg...@ohgaki.net wrote:

 If you are people from Zend, it's faster to ask Zeev or anyone else who
 already have karma.

 --
 Yasuo Ohgaki
 yohg...@ohgaki.net


 2013/7/9 Lior Kaplan lio...@zend.com

 Ping ?

 On Thu, Jun 27, 2013 at 2:01 PM, Lior Kaplan kaplanl...@gmail.com
 wrote:

  Helping with merging patches and pull requests
 
 
  --
  PHP Internals - PHP Runtime Development Mailing List
  To unsubscribe, visit: http://www.php.net/unsub.php
 
 

Re: [PHP-DEV] Cherry picking #60560 for php 5.4

[Lior Kaplan]

On Fri, Jun 28, 2013 at 11:47 PM, Stas Malyshev smalys...@sugarcrm.comwrote:

 Hi!

  Bug #60560 was fixed in trunk while PHP 5.4 was in its RC phases. The fix
  was never merged back to the 5.4 branch, meaning it's only avaailable on
  the 5.5 release.
 
  Could we cherry pick it for the 5.4 branch ?
 
  The relevant commit is
 
 http://git.php.net/?p=php-src.git;a=commit;h=37272e46def5673492ed926e9631a4e01568e42e

 I think we could.


Saw it's already in, thanks.

Kaplan

[PHP-DEV] VCS Account Request: kaplan

[Lior Kaplan]

Helping with merging patches and pull requests


-- 
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-DEV] Cherry picking #60560 for php 5.4

[Lior Kaplan]

Hi,

Bug #60560 was fixed in trunk while PHP 5.4 was in its RC phases. The fix
was never merged back to the 5.4 branch, meaning it's only avaailable on
the 5.5 release.

Could we cherry pick it for the 5.4 branch ?

The relevant commit is
http://git.php.net/?p=php-src.git;a=commit;h=37272e46def5673492ed926e9631a4e01568e42e

Kaplan

[PHP-DEV] Who's incharge of github pull requests?

[Lior Kaplan]

Hi,

It seems the list of pull requests on github is getting bigger, who's
inchange to review it?
https://github.com/php/php-src/pulls

I must say that my experience so far in trying to push patches through the
bug system
or pull request is quite deprsing (comparing to other open source projects):
https://liorkaplan.wordpress.com/2013/06/05/getting-patches-into-php/

Kaplan

Re: [PHP-DEV] PHP 5.3 - end of live schedule

[Lior Kaplan]

On Tue, Dec 11, 2012 at 12:48 PM, Pierre Joye pierre@gmail.com wrote:

 what's about:

 - announce 5.3 EOL plan with 5.5 final release

 then:

 - EOL by release of php-next (a year later)

 or

 - EOL by release of php-next+1 (two years later)

 depending on which option got accepted.


In all these cases we are going to support 3 branches in parallel, is that
really what we want ?

I would be happy to see 5.3 in security mode only before the realase of 5.5.

Also, I wouldn't make a connection between release of the next version with
the EOL,
as the next version can always be delayed and we want to limit the support
time of old
versions to focus on stable and php-next development.

Kaplan

[PHP-DEV] Non ASCII char in php.ini [patch]

[Lior Kaplan]

Hi,

We've noticed that the php.ini-development and php.ini-production
include a UTF-8 character which looks weird under ASCII (or other
simple locales).

It was added with this commit to the PHP-5.3 branch:
http://git.php.net/?p=php-src.git;a=patch;h=c9b5d92821db7335632f8578871e2b75ac018f2a

(It doesn't exist in PHP-5.4/master branches)

diff --git a/php.ini-development b/php.ini-development
index 1375516..d1fa7a3 100644
--- a/php.ini-development
+++ b/php.ini-development
@@ -1909,7 +1909,7 @@ ldap.max_links = -1
 
 [xsl]
 ; Write operations from within XSLT are disabled by default.
-; XSL_SECPREF_CREATE_DIRECTORY | XSL_SECPREF_WRITE_NETWORK
|C2A0XSL_SECPREF_WRITE_FILE = 44
+; XSL_SECPREF_CREATE_DIRECTORY | XSL_SECPREF_WRITE_NETWORK |
XSL_SECPREF_WRITE_FILE = 44
 ; Set it to 0 to allow all operations
 ;xsl.security_prefs = 44
 
diff --git a/php.ini-production b/php.ini-production
index 495fb01..9d5861d 100644
--- a/php.ini-production
+++ b/php.ini-production
@@ -1909,7 +1909,7 @@ ldap.max_links = -1
 
 [xsl]
 ; Write operations from within XSLT are disabled by default.
-; XSL_SECPREF_CREATE_DIRECTORY | XSL_SECPREF_WRITE_NETWORK
|C2A0XSL_SECPREF_WRITE_FILE = 44
+; XSL_SECPREF_CREATE_DIRECTORY | XSL_SECPREF_WRITE_NETWORK |
XSL_SECPREF_WRITE_FILE = 44
 ; Set it to 0 to allow all operations
 ;xsl.security_prefs = 44
 
(this is the diff with LC_ALL=c, notice the C2A0 removal. The
change isn't visible with UTF-8 locales)

Thanks,

Lior Kaplan
Zend Technologies Ltd.


-- 
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-DEV] 5.4.0 RC7

[Lior Kaplan]

Hi,

RC7 is already tagged but misses
http://svn.php.net/viewvc?view=revisionrevision=323013 for earlier
today.

Guessing we try to avoid another RC, shouldn't we re-tag to include this
fix? It might delay the upcoming release tomorrow of RC7, but might help
to have a better final version based on RC7.

Kaplan


-- 
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Re: One more critical problem in 5.4

[Lior Kaplan]

On Tue, 2012-01-31 at 03:58 -0500, Michael Wallner wrote:
 On Tue, 31 Jan 2012 10:04:34 +0200, yoram bar haim wrote:
 
  Sorry, problem is not solved yet.
 
 I committed a possible fix to trunk.  It's pretty much along
 the patch from you, I just hat to fix crashes in the cli server
 and need to do some more testing before merging into PHP_5_4.

Hi Mike,

According to my testing revision 322931 and 322964 fix the issue on the
5.4 branch. I also tested that display_startup_errors=1 doesn't make
apache to crash (as this was the original report).

Thanks for the fixes (:

Kaplan



-- 
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Uploading 5.4 RC to unstable (Was: Upcoming transition of php5 to 5.4)

[Lior Kaplan]

Hi Ondřej,

I'd wait for RC7 in any case, and with some luck it will be the final RC
for 5.4.0.

With my Debian hat on, I would wait for the official release, as to
minimize the noise we'll get in Debian from testing RCs. The recent RCs
all had some major issues fixed/changed in them (which is better to test
with dedicated people than the general users of Debian).

Kaplan

On Wed, 2012-02-01 at 11:11 +0100, Ondřej Surý wrote:
 Hi,
 
 I was thinking that it could be a good idea (after current version migrates
 to testing) to upload 5.4RCx to unstable to begin work on transition as soon
 as possible. RC releases should have stable API(?), so application wise
 there's no problem. I'll fill a release critical bug in our BTS, so
 the 5.4 version
 don't migrate to testing and close it with stable 5.4.0 release.
 
 Ccing PHP internals to let them know and ask if it is a good idea (the 5.4RC
 will be probably used by more people when uploaded to Debian unstable, i.e.
 it means more testing, but also more bugreports).
 
 O.
 
 -- Forwarded message --
 From: Ondřej Surý ond...@sury.org
 Date: Wed, Feb 1, 2012 at 08:40
 Subject: Upcoming transition of php5 to 5.4
 To: Debian Release debian-rele...@lists.debian.org
 
 
 Hi,
 
 this is just a heads up that we would like to ship wheezy with php5 5.4
 which is in upstream RC phase now (and in debian-experimental).
 
 It introduce a couple of incompatible changes (for a full list see attached
 UPGRADING file), most notably (not listing minor changes and added features):
 - default charset is now utf-8
 - magic_quotes are deprecated (with warning)
 - safe_mode and register_globals was removed
 - three new reserved words: callable, insteadof and trait
 - multibyte support is now default
 - removed syntax (break $var, continue $var)
 - sqlite(1) extension was removed (already done in php5.3 in Debian)
 
 I am inclined to let the current php5 in unstable to transition to testing
 and then upload next 5.4.0 RC to unstable with transition blocking bug,
 so we can start testing existing software as soon as possible.
 
 I also plan to provide official backports for Debian squeeze, so people
 can come and test new php5.4 before they upgrade to wheezy.
 
 Final note: We already had similar transitions in php (4-5, 5.2-5.3, etc.),
 so it's not really a big deal, but it will require some amount of work hence
 this email.
 
 Ondrej
 P.S.: Please Cc: me as I am not subscribed to the list (but I do check
 the web archives).
 --
 Ondřej Surý ond...@sury.org
 
 
 -- 
 Ondřej Surý ond...@sury.org
 



--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-DEV] Re: One more critical problem in 5.4

[Lior Kaplan]

 On Wed, 25 Jan 2012 09:13:43 -0800, Stas Malyshev wrote:
 
  Hi!
  
  We've just found one more critical problem in 5.4.
 
  Apache/PHP crashes in case of error on startup, when
  display_startup_errors=1. It's probably related to new output API.
 
  I afraid it may affect many php users.
  
  OK, thanks. Looks like we'd be needing another RC then. Let's fix this
  one and the __FILE__ crash in that case.
 
 Fix committed.

The fix does work (thanks), but introduces another problem with scripts
without output in FastCGI. The problem is that the headers aren't sent
when there's no output from the script. If the script does produce an
output then the headers are sent.

should be reproducible with this simple script:

?php
header(Location: http://www.google.com;);

Kaplan
Zend Technologies Ltd.


-- 
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php