[PHP-DEV] [PATCH][HEAD] Upload progress in sessions
Hi, I have written a patch to implement upload progress feedback in session data. The file upload feature in PHP allows extensions to be called back on some events. A few extensions use this to implement some sort of upload progress feedback, but none of them are released with PHP, which makes this feature unusable in many environments. The patch allows to store upload progress informations in session variables. These informations can be retrieved by an other script while the upload is still in progress, allowing to provide feedback to the user. Implementing this in the sessions extension makes this feature available to every one. Using the session extension for this purpose also allows to use the different storage backends available. I have written a RFC/documentation here: http://wiki.php.net/rfc/session_upload_progress Any objection on committing this to HEAD ? Regards, Arnaud -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] [PATCH][HEAD] Upload progress in sessions
On Mon, Sep 8, 2008 at 12:18 PM, Arnaud Le Blanc [EMAIL PROTECTED] wrote: Hi, I have written a patch to implement upload progress feedback in session data. The file upload feature in PHP allows extensions to be called back on some events. A few extensions use this to implement some sort of upload progress feedback, but none of them are released with PHP, which makes this feature unusable in many environments. The patch allows to store upload progress informations in session variables. These informations can be retrieved by an other script while the upload is still in progress, allowing to provide feedback to the user. Implementing this in the sessions extension makes this feature available to every one. Using the session extension for this purpose also allows to use the different storage backends available. I have written a RFC/documentation here: http://wiki.php.net/rfc/session_upload_progress Any objection on committing this to HEAD ? It is indeed nice to have this feature without relying on an extension, however do you know that APC will be bundled in php6? As APC provides this feature. Cheers, -- Pierre http://blog.thepimp.net | http://www.libgd.org -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] [PATCH][HEAD] Upload progress in sessions
On Mon, Sep 8, 2008 at 12:18 PM, Arnaud Le Blanc [EMAIL PROTECTED] wrote: The patch allows to store upload progress informations in session variables. These informations can be retrieved by an other script while the upload is still in progress, allowing to provide feedback to the user. Implementing this in the sessions extension makes this feature available to every one. Using the session extension for this purpose also allows to use the different storage backends available. I have written a RFC/documentation here: http://wiki.php.net/rfc/session_upload_progress Would it be possible to use something like $_SESSION['foo']['upload_progress_123'] instead of storing the information in the top-level session space? I can imagine there being frameworks and such that put their session stuff in some special container like $_SESSION['foo'] so that their session data does not interfere with the data of other components or the application that makes use of the framework. Martin -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] [PATCH][HEAD] Upload progress in sessions
Hi, On Monday 08 September 2008 13:03:11 Pierre Joye wrote: On Mon, Sep 8, 2008 at 12:18 PM, Arnaud Le Blanc [EMAIL PROTECTED] wrote: Hi, I have written a patch to implement upload progress feedback in session data. The file upload feature in PHP allows extensions to be called back on some events. A few extensions use this to implement some sort of upload progress feedback, but none of them are released with PHP, which makes this feature unusable in many environments. The patch allows to store upload progress informations in session variables. These informations can be retrieved by an other script while the upload is still in progress, allowing to provide feedback to the user. Implementing this in the sessions extension makes this feature available to every one. Using the session extension for this purpose also allows to use the different storage backends available. I have written a RFC/documentation here: http://wiki.php.net/rfc/session_upload_progress Any objection on committing this to HEAD ? It is indeed nice to have this feature without relying on an extension, however do you know that APC will be bundled in php6? As APC provides this feature. Yes, but I don't think it will be enabled on shared hosting, for instance. Also, while session data can be shared across multiple servers, APC's storage can't. Cheers, -- Pierre http://blog.thepimp.net | http://www.libgd.org Regards, Arnaud -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] [PATCH][HEAD] Upload progress in sessions
Hi, On Monday 08 September 2008 13:06:50 Martin Jansen wrote: On Mon, Sep 8, 2008 at 12:18 PM, Arnaud Le Blanc [EMAIL PROTECTED] wrote: The patch allows to store upload progress informations in session variables. These informations can be retrieved by an other script while the upload is still in progress, allowing to provide feedback to the user. Implementing this in the sessions extension makes this feature available to every one. Using the session extension for this purpose also allows to use the different storage backends available. I have written a RFC/documentation here: http://wiki.php.net/rfc/session_upload_progress Would it be possible to use something like $_SESSION['foo']['upload_progress_123'] instead of storing the information in the top-level session space? I can imagine there being frameworks and such that put their session stuff in some special container like $_SESSION['foo'] so that their session data does not interfere with the data of other components or the application that makes use of the framework. Yes, this can be done. The prefix setting (upload_progress_ by default) was added for that purpose, but it may be possible to use $_SESSION[prefix][name]. Martin Regards, Arnaud -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] [PATCH][HEAD] Upload progress in sessions
2008/9/8 Arnaud Le Blanc [EMAIL PROTECTED]: Hi, On Monday 08 September 2008 13:06:50 Martin Jansen wrote: On Mon, Sep 8, 2008 at 12:18 PM, Arnaud Le Blanc [EMAIL PROTECTED] wrote: The patch allows to store upload progress informations in session variables. These informations can be retrieved by an other script while the upload is still in progress, allowing to provide feedback to the user. Implementing this in the sessions extension makes this feature available to every one. Using the session extension for this purpose also allows to use the different storage backends available. I have written a RFC/documentation here: http://wiki.php.net/rfc/session_upload_progress Would it be possible to use something like $_SESSION['foo']['upload_progress_123'] instead of storing the information in the top-level session space? I can imagine there being frameworks and such that put their session stuff in some special container like $_SESSION['foo'] so that their session data does not interfere with the data of other components or the application that makes use of the framework. Yes, this can be done. The prefix setting (upload_progress_ by default) was added for that purpose, but it may be possible to use $_SESSION[prefix][name]. Martin Regards, Arnaud -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php Would maybe having $_SESSION['_Files'] == $_FILES for multiple uploads and have the current size uploaded as a new entry in $_FILES be easier? That way no additional configuration option. -- - Richard Quadling Zend Certified Engineer : http://zend.com/zce.php?c=ZEND002498r=213474731 Standing on the shoulders of some very clever giants! -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] [PATCH][HEAD] Upload progress in sessions
Hi, On Monday 08 September 2008 15:19:07 Richard Quadling wrote: 2008/9/8 Arnaud Le Blanc [EMAIL PROTECTED]: Hi, On Monday 08 September 2008 13:06:50 Martin Jansen wrote: On Mon, Sep 8, 2008 at 12:18 PM, Arnaud Le Blanc [EMAIL PROTECTED] wrote: The patch allows to store upload progress informations in session variables. These informations can be retrieved by an other script while the upload is still in progress, allowing to provide feedback to the user. Implementing this in the sessions extension makes this feature available to every one. Using the session extension for this purpose also allows to use the different storage backends available. I have written a RFC/documentation here: http://wiki.php.net/rfc/session_upload_progress Would it be possible to use something like $_SESSION['foo']['upload_progress_123'] instead of storing the information in the top-level session space? I can imagine there being frameworks and such that put their session stuff in some special container like $_SESSION['foo'] so that their session data does not interfere with the data of other components or the application that makes use of the framework. Yes, this can be done. The prefix setting (upload_progress_ by default) was added for that purpose, but it may be possible to use $_SESSION[prefix] [name]. Martin Regards, Arnaud -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php Would maybe having $_SESSION['_Files'] == $_FILES for multiple uploads and have the current size uploaded as a new entry in $_FILES be easier? That way no additional configuration option. This will not work if the user sends a request while a previous one is not terminated. Also, this may break some applications that use _Files as a key in $_SESSION if this is not configurable. And the entries outside of files (content_length, etc) needs to be added somewhere ;) The files array in the current patch is just like $_FILES. -- - Richard Quadling Zend Certified Engineer : http://zend.com/zce.php?c=ZEND002498r=213474731 Standing on the shoulders of some very clever giants! -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php Regards, Arnaud -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
