Re: [PHP-DEV] [RFC] [VOTE] Change the edge case of round()
Hi all, Voting is now closed. As a result of the vote, this RFC was rejected. (7 in favor, 8 against) Therefore, as stated in the RFC, the following pull request will be adopted to fix the bug in `round()`. https://github.com/php/php-src/pull/12268 Thank you for all your votes. Regards. Saki -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: https://www.php.net/unsub.php
Re: [PHP-DEV] [RFC] [VOTE] Change the edge case of round()
Hi! I've voted no, but only because I think that because this is technically a documented (through RFC) BC break, it should wait for PHP 9, and not for any 8.*. I think so too, it's a frequently used function, and while the argument for the change look convincing, changing it an advanced point version still sounds like not a good idea. -- Stas Malyshev smalys...@gmail.com -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: https://www.php.net/unsub.php
Re: [PHP-DEV] [RFC] [VOTE] Change the edge case of round()
On 24 November 2023 00:31:16 GMT, Saki Takamachi wrote: >Hi internals, > >I started voting on my RFC "Change the edge case of round()”. > >Voting will end December 8th, 00:00 GMT. > >https://wiki.php.net/rfc/change_the_edge_case_of_round > >Regards. > >Saki >-- >PHP Internals - PHP Runtime Development Mailing List >To unsubscribe, visit: https://www.php.net/unsub.php I've voted no, but only because I think that because this is technically a documented (through RFC) BC break, it should wait for PHP 9, and not for any 8.*. cheers Derick -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: https://www.php.net/unsub.php
Re: [PHP-DEV] [RFC] [VOTE] Change the edge case of round()
On Fri, Nov 24, 2023 at 12:31 AM Saki Takamachi wrote: > Hi internals, > > I started voting on my RFC "Change the edge case of round()”. > > Voting will end December 8th, 00:00 GMT. > > https://wiki.php.net/rfc/change_the_edge_case_of_round > > I have been thinking about this one for a bit and I voted no at the end. I would probably pick the new behaviour if designing a new function like this but considering that it's been around for long time in this form, I don't think it's worth to be changed as it introduces slight BC break that might difficult to figure out. Also the old behaviour might be more intuitive for users so it does not seem completely wrong to me to keep it. Cheers Jakub
[PHP-DEV] [RFC] [VOTE] Change the edge case of round()
Hi internals, I started voting on my RFC "Change the edge case of round()”. Voting will end December 8th, 00:00 GMT. https://wiki.php.net/rfc/change_the_edge_case_of_round Regards. Saki -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: https://www.php.net/unsub.php
