Re: [PHP-DEV] Bug 61272

2012-12-06 Thread Yasuo Ohgaki
2012/11/29 Michael Wallner m...@php.net:
 On 29 November 2012 08:00, Yasuo Ohgaki yohg...@ohgaki.net wrote:
 However, new code encapsulate output globals. (I mean internally)
 It would be nice for my extension if output globals are exposed.

 This was changed intentionally, why would you need OG what the API
 does not provide?

 Exposing output global is not mandatory, though.

Encapsulation is great for ordinary use, but I have extension that
records PHP internal activities. It also records and override some
contents of output global.

I haven't thought what API would be needed, I'll look into current code
later and what API is needed.

Regards,

--
Yasuo Ohgaki
yohg...@ohgaki.net

-- 
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-DEV] Bug 61272

2012-11-29 Thread Michael Wallner
On 29 November 2012 08:00, Yasuo Ohgaki yohg...@ohgaki.net wrote:

 I recently looked into new output code in PHP 5.4.
 It's MUCH nicer than older code. Good job!

Appreciated!

 However, new code encapsulate output globals. (I mean internally)
 It would be nice for my extension if output globals are exposed.

This was changed intentionally, why would you need OG what the API
does not provide?

 Exposing output global is not mandatory, though.



-- 
Regards,
Mike

-- 
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-DEV] Bug 61272

2012-11-28 Thread Yasuo Ohgaki
Hi,

Slightly related topic.

I recently looked into new output code in PHP 5.4.
It's MUCH nicer than older code. Good job!
However, new code encapsulate output globals. (I mean internally)
It would be nice for my extension if output globals are exposed.
Exposing output global is not mandatory, though.

Regards,

--
Yasuo Ohgaki
yohg...@ohgaki.net

-- 
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php



[PHP-DEV] Bug 61272

2012-11-25 Thread Casper Langemeijer

Hi all,

Somewhere in May this year I discovered that our software would not run 
on PHP 5.4 because of changed behaviour of ob_start(). I discovered a 
bugreport that was marked 'Not a bug', but valuable info was already 
added to it. I contacted Michael Wallner (mike) directly because he 
marked the bug 'not a bug'. No response.


I decided that this bug was worth my time and invested a few hours into 
it. I have found that the test that tested it was broken too. I wrote a 
patch for the bug and the test and added this onto the bug report on 
June 8th.


June 18th I re-opened the bugreport. I just got my php.net account. I 
thought re-opening the bug would mean it would get noticed by someone.


Since then the bugreport gathered some me-too's and one 
thanks-for-the-patch. (At least my work has made one other person happy 
so far.)


Two weeks ago I emailed Michael Wallner again. No response.

I noticed Xinchen Hui (laruence) assigned the bug to mike two days ago. 
Based on my experiences so far, I don't think he will look into this 
issue though.


Mike, please note that I do not blame you. I understand that free time 
is very sparse and valuable and for most of us doing any work on an open 
source project is done in free time.


Can someone please look into this? I've written all I know in 
https://bugs.php.net/bug.php?id=61272 but I'm available to discuss the 
patch by email or in #php.pecl


Greetings, Casper